104550 2012-12-10 06:40:11 -0800 [Qt] MediaPlayerQTKit broken after switching QPainter to raster engine. 2012-12-19 04:35:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zeno zeno abecsi eric.carlson feature-media-reviews hausmann kbalazs rgabor webkit.review.bot oldest_to_newest 787270 0 zeno 2012-12-10 06:40:11 -0800 [Qt] MediaPlayerQTKit broken after switching QPainter to raster engine. 787279 1 178539 zeno 2012-12-10 06:45:45 -0800 Created attachment 178539 Patch 787309 2 178539 hausmann 2012-12-10 07:23:45 -0800 Comment on attachment 178539 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178539&action=review r=me with comments/changes. Looking forward to this code path disappearing altogether hopefully in the near future ;-) > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1374 > + NSBitmapImageRep *imageRep = [[NSBitmapImageRep alloc] initWithBitmapDataPlanes: NULL I think you're going to need to call [imageRep release] later on after painting to release the memory again, no? 787324 3 zeno 2012-12-10 07:39:04 -0800 (In reply to comment #2) > Looking forward to this code path disappearing altogether hopefully in the near future ;-) Me too. > > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1374 > > + NSBitmapImageRep *imageRep = [[NSBitmapImageRep alloc] initWithBitmapDataPlanes: NULL > > I think you're going to need to call [imageRep release] later on after painting to release the memory again, no? Yes. 787349 4 zeno 2012-12-10 08:12:11 -0800 Committed r137159: <http://trac.webkit.org/changeset/137159> 794480 5 kbalazs 2012-12-19 02:50:53 -0800 Just a quick note on this patch: probably we want to introduce a global (WTF) helper for bgr <-> rgb conversion, since it is subject of SIMD and I believe Gabor Rapcsányi already implemented it in NEON at some other place :) 794511 6 hausmann 2012-12-19 04:30:46 -0800 (In reply to comment #5) > Just a quick note on this patch: probably we want to introduce a global (WTF) helper for bgr <-> rgb conversion, since it is subject of SIMD and I believe Gabor Rapcsányi already implemented it in NEON at some other place :) Maybe yes, but we're going to stop using the code here very soon, so that's going to be one user less. 794514 7 rgabor 2012-12-19 04:35:28 -0800 (In reply to comment #5) > Just a quick note on this patch: probably we want to introduce a global (WTF) helper for bgr <-> rgb conversion, since it is subject of SIMD and I believe Gabor Rapcsányi already implemented it in NEON at some other place :) I had a patch to speed up a little bit this conversion: https://bugs.webkit.org/show_bug.cgi?id=103630 With NEON SIMD it could be twice as fast as now, if you are interested in I can make a bug for it. 178539 2012-12-10 06:45:45 -0800 2012-12-10 07:23:45 -0800 Patch bug-104550-20121210154306.patch text/plain 4673 zeno U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2E3ODllNzdiNjRiYWE0 ZWZhZTM1NzAyNmM1MmM1ZjllNGEzNDc0NS4uZDgwYmI4OTY1MGQyMzdhYmY4MDRkZmE2OTA0OTU3 OTBkMTI4MDAyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTEyLTEwICBaZW5v IEFsYmlzc2VyICA8emVub0B3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF0gTWVkaWFQbGF5ZXJR VEtpdCBicm9rZW4gYWZ0ZXIgc3dpdGNoaW5nIFFQYWludGVyIHRvIHJhc3RlciBlbmdpbmUuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ1NTAKKwor ICAgICAgICBXaXRoIFF0NSBRUGFpbnRlciBjaGFuZ2VkIHRvIHVzaW5nIHRoZSByYXN0ZXIgZW5n aW5lLgorICAgICAgICBUaGVyZWZvcmUgd2Ugbm8gbG9uZ2VyIGhhdmUgYW4gTlNHcmFwaGljc0Nv bnRleHQgdGhhdCB3ZSBjYW4KKyAgICAgICAgdXNlIGZvciBkcmF3aW5nIHZpZGVvIGZyYW1lcy4K KyAgICAgICAgV2l0aCB0aGlzIHBhdGNoIHdlIGFyZSByZW5kZXJpbmcgdGhlIHZpZGVvIGZyYW1l IGludG8gYW4gaW1hZ2UgYnVmZmVyCisgICAgICAgIGFuZCB0aGVuIHBhaW50IGl0IG1hbnVhbGx5 IHVzaW5nIFFQYWludGVyLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0 Lm1tOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpzd2FwQmdyVG9SZ2Ip OgorICAgICAgICAgICAgU3dhcCB0aGUgY29sb3IgZm9ybWF0IGZyb20gQkdSIHRvIFJHQiwKKyAg ICAgICAgICAgIHNpbmNlIEJHUiBpcyBub3Qgc3VwcG9ydGVkIGJ5IFFJbWFnZS4KKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZVFUS2l0OjpwYWludCk6CisKIDIwMTItMTItMTAg IEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlZmFjdG9yaW5n OiBJbnRyb2R1Y2UgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6aXNEaXNhYmxlZE9yUmVhZE9ubHkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBs YXllclByaXZhdGVRVEtpdC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21h Yy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5tbQppbmRleCA0MjgxYjdlYjYxMmIxZDU5MTc3YTkx NmExMjkwMzQ3MjA5NmUwMTcxLi5mNDkyNjcwNDJlNzliMmJkNTJlNmVlMTQ0Y2Y2Y2VmZjFhNjM4 OWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVk aWFQbGF5ZXJQcml2YXRlUVRLaXQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvbWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0Lm1tCkBAIC0xMzQzLDYgKzEzNDMsMTgg QEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVRVEtpdDo6cGFpbnRDdXJyZW50RnJhbWVJbkNvbnRl eHQoR3JhcGhpY3NDb250ZXh0KiBjb250ZXgKICAgICBwYWludChjb250ZXh0LCByKTsKIH0KIAor I2lmIFBMQVRGT1JNKFFUKSAmJiBVU0UoUVRLSVQpCitzdGF0aWMgaW5saW5lIHZvaWQgc3dhcEJn clRvUmdiKHVpbnQzMl90KiBwaXhlbCwgdWludDMyX3Qgd2lkdGgsIHVpbnQzMl90IGhlaWdodCkK K3sKKyAgICB1aW50MzJfdCogZW5kID0gcGl4ZWwgKyAod2lkdGggKiBoZWlnaHQpOworCisgICAg d2hpbGUgKHBpeGVsIDwgZW5kKSB7CisgICAgICAgICpwaXhlbCA9ICgoKnBpeGVsIDw8IDE2KSAm IDB4ZmYwMDAwKSB8ICgoKnBpeGVsID4+IDE2KSAmIDB4ZmYpIHwgKCpwaXhlbCAmIDB4ZmYwMGZm MDApOworICAgICAgICArK3BpeGVsOworICAgIH0KK30KKyNlbmRpZgorCiB2b2lkIE1lZGlhUGxh eWVyUHJpdmF0ZVFUS2l0OjpwYWludChHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IElu dFJlY3QmIHIpCiB7CiAgICAgaWYgKGNvbnRleHQtPnBhaW50aW5nRGlzYWJsZWQoKSB8fCBtX2hh c1Vuc3VwcG9ydGVkVHJhY2tzKQpAQCAtMTM1OSwxNSArMTM3MSwxNyBAQCB2b2lkIE1lZGlhUGxh eWVyUHJpdmF0ZVFUS2l0OjpwYWludChHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IElu dFJlY3QmIHIpCiAgICAgSW50UmVjdCBwYWludFJlY3QoSW50UG9pbnQoMCwgMCksIEludFNpemUo ci53aWR0aCgpLCByLmhlaWdodCgpKSk7CiAKICNpZiBQTEFURk9STShRVCkgJiYgVVNFKFFUS0lU KQotICAgIC8vIEluIFF0LCBHcmFwaGljc0NvbnRleHQgaXMgYSBRUGFpbnRlciBzbyBldmVyeSB0 cmFuc2Zvcm1hdGlvbnMgYXBwbGllZCBvbiBpdCB3b24ndCBtYXR0ZXIgYmVjYXVzZSBoZXJlCi0g ICAgLy8gdGhlIHZpZGVvIGlzIHJlbmRlcmVkIGJ5IFF1aWNrVGltZSBub3QgYnkgUXQuCi0gICAg Q0dDb250ZXh0UmVmIGNnQ29udGV4dCA9IHN0YXRpY19jYXN0PENHQ29udGV4dFJlZj4oW1tOU0dy YXBoaWNzQ29udGV4dCBjdXJyZW50Q29udGV4dF0gZ3JhcGhpY3NQb3J0XSk7Ci0gICAgQ0dDb250 ZXh0U2F2ZUdTdGF0ZShjZ0NvbnRleHQpOwotICAgIENHQ29udGV4dFNldEludGVycG9sYXRpb25R dWFsaXR5KGNnQ29udGV4dCwga0NHSW50ZXJwb2xhdGlvbkxvdyk7Ci0gICAgQ0dDb250ZXh0VHJh bnNsYXRlQ1RNKGNnQ29udGV4dCwgci54KCksIHIueSgpICsgci5oZWlnaHQoKSk7Ci0gICAgQ0dD b250ZXh0U2NhbGVDVE0oY2dDb250ZXh0LCBzY2FsZUZhY3Rvci53aWR0aCgpLCBzY2FsZUZhY3Rv ci5oZWlnaHQoKSk7Ci0KLSAgICBuZXdDb250ZXh0ID0gW05TR3JhcGhpY3NDb250ZXh0IGN1cnJl bnRDb250ZXh0XTsKKyAgICBOU0JpdG1hcEltYWdlUmVwICppbWFnZVJlcCA9IFtbTlNCaXRtYXBJ bWFnZVJlcCBhbGxvY10gaW5pdFdpdGhCaXRtYXBEYXRhUGxhbmVzOiBOVUxMCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwaXhlbHNX aWRlOiBwYWludFJlY3Qud2lkdGgoKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcGl4ZWxzSGlnaDogcGFpbnRSZWN0LmhlaWdodCgp CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBiaXRzUGVyU2FtcGxlOiA4CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBzYW1wbGVzUGVyUGl4ZWw6IDQKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhhc0FscGhh OiBZRVMKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGlzUGxhbmFyOiBOTworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29sb3JTcGFjZU5hbWU6IE5TQ2FsaWJyYXRlZFJH QkNvbG9yU3BhY2UKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGJ5dGVzUGVyUm93OiA0ICogcGFpbnRSZWN0LndpZHRoKCkgLy8gMzIg Yml0IHBlciBwaXhlbC4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGJpdHNQZXJQaXhlbDogMzJdOworICAgIG5ld0NvbnRleHQgPSBb TlNHcmFwaGljc0NvbnRleHQgZ3JhcGhpY3NDb250ZXh0V2l0aEJpdG1hcEltYWdlUmVwOiBpbWFn ZVJlcF07CiAjZWxzZQogICAgIEdyYXBoaWNzQ29udGV4dFN0YXRlU2F2ZXIgc3RhdGVTYXZlcigq Y29udGV4dCk7CiAgICAgY29udGV4dC0+dHJhbnNsYXRlKHIueCgpLCByLnkoKSArIHIuaGVpZ2h0 KCkpOwpAQCAtMTQzMCw3ICsxNDQ0LDExIEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQ6 OnBhaW50KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgSW50UmVjdCYgcikKICAgICB9 CiAjZW5kaWYKICNpZiBQTEFURk9STShRVCkgJiYgVVNFKFFUS0lUKQotICAgIENHQ29udGV4dFJl c3RvcmVHU3RhdGUoY2dDb250ZXh0KTsKKyAgICB1bnNpZ25lZCBjaGFyKiBiaXRtYXAgPSBbaW1h Z2VSZXAgYml0bWFwRGF0YV07CisgICAgc3dhcEJnclRvUmdiKHJlaW50ZXJwcmV0X2Nhc3Q8dWlu dDMyX3QqPihiaXRtYXApLCBwYWludFJlY3Qud2lkdGgoKSwgcGFpbnRSZWN0LmhlaWdodCgpKTsK KyAgICBRSW1hZ2UgdmlkZW9GcmFtZShiaXRtYXAsIHBhaW50UmVjdC53aWR0aCgpLCBwYWludFJl Y3QuaGVpZ2h0KCksIFFJbWFnZTo6Rm9ybWF0X0FSR0IzMik7CisgICAgUVBhaW50ZXIqIHBhaW50 ZXIgPSBjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKTsKKyAgICBwYWludGVyLT5kcmF3SW1hZ2Uo UVJlY3QociksIHZpZGVvRnJhbWUpOwogI2VuZGlmCiAgICAgRU5EX0JMT0NLX09CSkNfRVhDRVBU SU9OUzsKICAgICBbbV9vYmpjT2JzZXJ2ZXIuZ2V0KCkgc2V0RGVsYXlDYWxsYmFja3M6Tk9dOwo=