104544 2012-12-10 06:07:39 -0800 [WK2] TiledBackingStore: remove unneeded 'treatAsInitialValue' parameter from PageViewportControllerClient::setContentsScale 2012-12-10 06:59:55 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov abecsi cmarcelo gyuyoung.kim jturcotte kenneth menard rakuco webkit.review.bot oldest_to_newest 787243 0 mikhail.pozdnyakov 2012-12-10 06:07:39 -0800 The 'treatAsInitialValue' parameter in PageViewportControllerClient::setContentsScale() is not used by anyone. Can be dropped to make the code cleaner. 787245 1 178530 mikhail.pozdnyakov 2012-12-10 06:13:02 -0800 Created attachment 178530 patch 787253 2 abecsi 2012-12-10 06:23:33 -0800 Note that on Qt we might actually need to pass that flag through the delayed setting of the scale, since this information is lost which resulted in bugs in the double-tap-to-zoom logic: see https://bugs.webkit.org/show_bug.cgi?id=103889. But we can also add a separate function to clean the scale stack if needed, so I'm not opposing this clean-up. 787292 3 178530 webkit.review.bot 2012-12-10 06:59:50 -0800 Comment on attachment 178530 patch Clearing flags on attachment: 178530 Committed r137149: <http://trac.webkit.org/changeset/137149> 787293 4 webkit.review.bot 2012-12-10 06:59:55 -0800 All reviewed patches have been landed. Closing bug. 178530 2012-12-10 06:13:02 -0800 2012-12-10 06:59:50 -0800 patch bug104544 text/plain 6120 mikhail.pozdnyakov Y29tbWl0IDNiNGRlM2M2ODQ3OWVlMDcwY2VjZDA0MjUzOTlmZTk4YzY5NjQ2ZDgKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg TW9uIERlYyAxMCAxNjowOTowMCAyMDEyICswMjAwCgogICAgYnVnMTA0NTQ0CgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmlu ZGV4IGUwMTM3ZTUuLjcxMmFmNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMi0x Mi0xMCAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4K KworICAgICAgICBbV0syXSBUaWxlZEJhY2tpbmdTdG9yZTogcmVtb3ZlIHVubmVlZGVkICd0cmVh dEFzSW5pdGlhbFZhbHVlJyBwYXJhbWV0ZXIgZnJvbSBQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xp ZW50OjpzZXRDb250ZW50c1NjYWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDQ1NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW1vdmVkICd0cmVhdEFzSW5pdGlhbFZhbHVlJyBwYXJhbWV0ZXIgZnJv bSBQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50OjpzZXRDb250ZW50c1NjYWxlKCkKKyAgICAg ICAgYXMgaXQgd2FzIG5vdCB1c2VkIGJ5IGFueW9uZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Q YWdlVmlld3BvcnRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGFnZVZpZXdwb3J0 Q29udHJvbGxlcjo6ZGlkUmVuZGVyRnJhbWUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9QYWdlVmll d3BvcnRDb250cm9sbGVyQ2xpZW50Lmg6CisgICAgICAgIChQYWdlVmlld3BvcnRDb250cm9sbGVy Q2xpZW50KToKKyAgICAgICAgKiBVSVByb2Nlc3MvZWZsL1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJD bGllbnRFZmwuY3BwOgorICAgICAgICAoV2ViS2l0OjpQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xp ZW50RWZsOjpzZXRDb250ZW50c1NjYWxlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvZWZsL1BhZ2VW aWV3cG9ydENvbnRyb2xsZXJDbGllbnRFZmwuaDoKKyAgICAgICAgKFBhZ2VWaWV3cG9ydENvbnRy b2xsZXJDbGllbnRFZmwpOgorICAgICAgICAqIFVJUHJvY2Vzcy9xdC9QYWdlVmlld3BvcnRDb250 cm9sbGVyQ2xpZW50UXQuY3BwOgorICAgICAgICAoV2ViS2l0OjpQYWdlVmlld3BvcnRDb250cm9s bGVyQ2xpZW50UXQ6OnNldENvbnRlbnRzU2NhbGUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9xdC9Q YWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50UXQuaDoKKyAgICAgICAgKFBhZ2VWaWV3cG9ydENv bnRyb2xsZXJDbGllbnRRdCk6CisKIDIwMTItMTItMTAgIEh1YW5nIERvbmdzdW5nICA8bHV4dGVs bGFAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgQ29vcmRpbmF0ZWQgR3JhcGhpY3M6IEFkZCBD b29yZGluYXRlZFN1cmZhY2UgdG8gcmVtb3ZlIHRoZSBkZXBlbmRlbmN5IG9mIFNoYXJlYWJsZVN1 cmZhY2UgZnJvbSBDb29yZGluYXRlZCBHcmFwaGljcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9QYWdlVmlld3BvcnRDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9QYWdlVmlld3BvcnRDb250cm9sbGVyLmNwcAppbmRleCAwNGIzYjlhLi5kYWQx MDk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZVZpZXdwb3J0Q29u dHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VWaWV3cG9ydENv bnRyb2xsZXIuY3BwCkBAIC0xODQsNyArMTg0LDcgQEAgdm9pZCBQYWdlVmlld3BvcnRDb250cm9s bGVyOjpkaWRSZW5kZXJGcmFtZShjb25zdCBJbnRTaXplJiBjb250ZW50c1NpemUsIGNvbnN0IEkK ICAgICAvLyBnbyB0aHJvdWdoIGhlcmUgdG8gYmUgYXBwbGllZCBvbiB0aGUgdmlld3BvcnQgdG8g YXZvaWQgc2hvd2luZyBpbmNvbXBsZXRlCiAgICAgLy8gdGlsZXMgdG8gdGhlIHVzZXIgZHVyaW5n IGEgZmV3IG1pbGxpc2Vjb25kcy4KICAgICBpZiAobV9lZmZlY3RpdmVTY2FsZUlzTG9ja2VkKSB7 Ci0gICAgICAgIG1fY2xpZW50LT5zZXRDb250ZW50c1NjYWxlKG1fZWZmZWN0aXZlU2NhbGUsIGZh bHNlKTsKKyAgICAgICAgbV9jbGllbnQtPnNldENvbnRlbnRzU2NhbGUobV9lZmZlY3RpdmVTY2Fs ZSk7CiAgICAgICAgIG1fZWZmZWN0aXZlU2NhbGVJc0xvY2tlZCA9IGZhbHNlOwogICAgIH0KICAg ICBpZiAobV9jb250ZW50c1Bvc2l0aW9uSXNMb2NrZWQpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9QYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50LmggYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudC5oCmluZGV4IDdi MDVlYTguLjExMmYwZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdl Vmlld3BvcnRDb250cm9sbGVyQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnQuaApAQCAtMzksNyArMzksNyBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCB+UGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudCgpIHsgfQogCiAgICAg dmlydHVhbCB2b2lkIHNldFZpZXdwb3J0UG9zaXRpb24oY29uc3QgV2ViQ29yZTo6RmxvYXRQb2lu dCYgY29udGVudHNQb2ludCkgPSAwOwotICAgIHZpcnR1YWwgdm9pZCBzZXRDb250ZW50c1NjYWxl KGZsb2F0LCBib29sIHRyZWF0QXNJbml0aWFsVmFsdWUpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQg c2V0Q29udGVudHNTY2FsZShmbG9hdCkgPSAwOwogCiAgICAgdmlydHVhbCB2b2lkIGRpZFJlc3Vt ZUNvbnRlbnQoKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGRpZENoYW5nZUNvbnRlbnRzU2l6ZShj b25zdCBXZWJDb3JlOjpJbnRTaXplJikgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2VmbC9QYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50RWZsLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudEVmbC5j cHAKaW5kZXggNTQ5MDUyMy4uMDc0NmY2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2VmbC9QYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50RWZsLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRFZmwu Y3BwCkBAIC04NCwxMSArODQsOCBAQCB2b2lkIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRF Zmw6OnNldFZpZXdwb3J0UG9zaXRpb24oY29uc3QgV2ViQ29yZTo6RmxvYXRQbwogICAgIG1fY29u dHJvbGxlci0+ZGlkQ2hhbmdlQ29udGVudHNWaXNpYmlsaXR5KG1fY29udGVudFBvc2l0aW9uLCBz Y2FsZUZhY3RvcigpKTsKIH0KIAotdm9pZCBQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50RWZs OjpzZXRDb250ZW50c1NjYWxlKGZsb2F0IG5ld1NjYWxlLCBib29sIHRyZWF0QXNJbml0aWFsVmFs dWUpCit2b2lkIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRFZmw6OnNldENvbnRlbnRzU2Nh bGUoZmxvYXQgbmV3U2NhbGUpCiB7Ci0gICAgaWYgKHRyZWF0QXNJbml0aWFsVmFsdWUpCi0gICAg ICAgIHNldFZpZXdwb3J0UG9zaXRpb24oRmxvYXRQb2ludCgwLCAwKSk7Ci0KICAgICBtX3ZpZXdJ bXBsLT5zZXRTY2FsZUZhY3RvcihuZXdTY2FsZSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9lZmwvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudEVmbC5oIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9QYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50 RWZsLmgKaW5kZXggMzRmNjEwYi4uOTkxMTkxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2VmbC9QYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50RWZsLmgKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9QYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50RWZs LmgKQEAgLTUyLDcgKzUyLDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0UmVuZGVyZXJBY3RpdmUo Ym9vbCk7CiAKICAgICB2aXJ0dWFsIHZvaWQgc2V0Vmlld3BvcnRQb3NpdGlvbihjb25zdCBXZWJD b3JlOjpGbG9hdFBvaW50JiBjb250ZW50c1BvaW50KTsKLSAgICB2aXJ0dWFsIHZvaWQgc2V0Q29u dGVudHNTY2FsZShmbG9hdCwgYm9vbCB0cmVhdEFzSW5pdGlhbFZhbHVlKTsKKyAgICB2aXJ0dWFs IHZvaWQgc2V0Q29udGVudHNTY2FsZShmbG9hdCk7CiAKICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVz dW1lQ29udGVudCgpOwogICAgIHZpcnR1YWwgdm9pZCBkaWRDaGFuZ2VDb250ZW50c1NpemUoY29u c3QgV2ViQ29yZTo6SW50U2l6ZSYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL3F0L1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvcXQvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudFF0LmNwcAppbmRleCAx YjZkOTJlLi5jOWUyMWFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQv UGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvcXQvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudFF0LmNwcApAQCAtMzIyLDEz ICszMjIsOSBAQCB2b2lkIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRRdDo6c2V0Vmlld3Bv cnRQb3NpdGlvbihjb25zdCBGbG9hdFBvaW50JiBjb250ZQogICAgIHVwZGF0ZVZpZXdwb3J0Q29u dHJvbGxlcigpOwogfQogCi12b2lkIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRRdDo6c2V0 Q29udGVudHNTY2FsZShmbG9hdCBsb2NhbFNjYWxlLCBib29sIHRyZWF0QXNJbml0aWFsVmFsdWUp Cit2b2lkIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRRdDo6c2V0Q29udGVudHNTY2FsZShm bG9hdCBsb2NhbFNjYWxlKQogewotICAgIGlmICh0cmVhdEFzSW5pdGlhbFZhbHVlKSB7Ci0gICAg ICAgIGNsZWFyUmVsYXRpdmVab29tU3RhdGUoKTsKLSAgICAgICAgc2V0Q29udGVudFJlY3RWaXNp YmxlUG9zaXRpb25BdFNjYWxlKFFQb2ludEYoKSwgbG9jYWxTY2FsZSk7Ci0gICAgfSBlbHNlCi0g ICAgICAgIHNjYWxlQ29udGVudChsb2NhbFNjYWxlKTsKKyAgICBzY2FsZUNvbnRlbnQobG9jYWxT Y2FsZSk7CiB9CiAKIHZvaWQgUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudFF0OjpzZXRDb250 ZW50c1JlY3RUb05lYXJlc3RWYWxpZEJvdW5kcygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvcXQvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudFF0LmggYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvcXQvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudFF0LmgKaW5k ZXggNjg3ZjI5MS4uZjViYjFkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L3F0L1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRRdC5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9xdC9QYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50UXQuaApAQCAtNDgsNyAr NDgsNyBAQCBwdWJsaWM6CiAgICAgflBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRRdCgpOwog CiAgICAgdmlydHVhbCB2b2lkIHNldFZpZXdwb3J0UG9zaXRpb24oY29uc3QgV2ViQ29yZTo6Rmxv YXRQb2ludCYgY29udGVudHNQb2ludCk7Ci0gICAgdmlydHVhbCB2b2lkIHNldENvbnRlbnRzU2Nh bGUoZmxvYXQgc2NhbGUsIGJvb2wgdHJlYXRBc0luaXRpYWxWYWx1ZSk7CisgICAgdmlydHVhbCB2 b2lkIHNldENvbnRlbnRzU2NhbGUoZmxvYXQpOwogCiAgICAgdmlydHVhbCB2b2lkIGRpZFJlc3Vt ZUNvbnRlbnQoKTsKICAgICB2aXJ0dWFsIHZvaWQgZGlkQ2hhbmdlQ29udGVudHNTaXplKGNvbnN0 IFdlYkNvcmU6OkludFNpemUmKTsK