104529 2012-12-10 02:42:12 -0800 [Qt] Builds for Mac are tied to the OS system instead of the SDK version. 2013-06-06 02:03:13 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 michael.bruning michael.bruning hausmann thiago vestbo zeno oldest_to_newest 787132 0 michael.bruning 2012-12-10 02:42:12 -0800 SSIA, it's not possible to build for another SDK as the WebKitSystemInterface library version is chosen based on the OS version, not on the SDK that the build is made with. 787141 1 178500 michael.bruning 2012-12-10 02:55:34 -0800 Created attachment 178500 Patch 787150 2 178500 zeno 2012-12-10 03:13:43 -0800 Comment on attachment 178500 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178500&action=review > Source/WebCore/WebCore.pri:183 > + equals(DARWIN_MAJOR_VERSION, "9") | contains(QMAKE_MAC_SDK, ".*MacOSX10.5.sdk.*") { Isn't this going to cause trouble, when somebody tries to build for target MacOSX10.8, on a machine running MacOSX10.7 ? (Building for a newer version than running on the build-system). Now obviously we currently do not support a different target than the one building on. So this would probably still be an improvement. But I am not sure if it is the correct solution. 787156 3 michael.bruning 2012-12-10 03:26:14 -0800 (In reply to comment #2) > Isn't this going to cause trouble, when somebody tries to build for target MacOSX10.8, on a machine running MacOSX10.7 ? (Building for a newer version than running on the build-system). True, that would not work afaics. The question is whether we want the complete solution now or improve gradually... 787179 4 178509 michael.bruning 2012-12-10 03:58:33 -0800 Created attachment 178509 Patch 787196 5 zeno 2012-12-10 04:30:42 -0800 (In reply to comment #4) LGTM :) 787201 6 178509 hausmann 2012-12-10 04:40:11 -0800 Comment on attachment 178509 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178509&action=review > Source/WebCore/WebCore.pri:188 > + SYSTEM_LIBRARY_PATH = $${ROOT_WEBKIT_DIR}/WebKitLibraries/libWebKitSystemInterfaceLeopard.a > + } else:contains(QMAKE_MAC_SDK, ".*MacOSX10.6.sdk.*") { > + SYSTEM_LIBRARY_PATH = $${ROOT_WEBKIT_DIR}/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a > + } else:contains(QMAKE_MAC_SDK, ".*MacOSX10.7.sdk.*") { I think references to Leopard and SnowLeopard can be removed before landing. These libraries do not exist anymore (see WebKitLibraries/). Only Lion and MountainLion are supported in trunk. 787216 7 michael.bruning 2012-12-10 05:15:15 -0800 Committed r137139: <http://trac.webkit.org/changeset/137139> 897603 8 thiago 2013-06-05 16:43:31 -0700 The commit is missing an explanation of why the two libraries for Lion and Mountain Lion are no longer being added. With no explanation, it sounds like an oversight / mistake. Can someone bring them back? 897687 9 michael.bruning 2013-06-06 02:03:13 -0700 (In reply to comment #8) > The commit is missing an explanation of why the two libraries for Lion and Mountain Lion are no longer being added. > > With no explanation, it sounds like an oversight / mistake. Can someone bring them back? The libraries were removed since Apple no longer supports the WebKitSystemInterfaces for these on trunk and the libraries that were checked in here had not been updated in a while and were most likely not usable anymore. I do not see a big chance to bring them back to be honest. 178500 2012-12-10 02:55:34 -0800 2012-12-10 03:58:28 -0800 Patch bug-104529-20121210115256.patch text/plain 2692 michael.bruning U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmIzOGFkZmU5MWExMDYz ZDE1YWE3Yjk2ZTczMjljYjAyYmUzMWJjMS4uZjc3OGZmYjNiOGQyYTI3MjE4OTZhNWE2NjJmMWIw MTkwZmQxMDViMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTEwICBNaWNo YWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRd IEJ1aWxkcyBmb3IgTWFjIGFyZSB0aWVkIHRvIHRoZSBPUyBzeXN0ZW0gaW5zdGVhZCBvZiB0aGUg U0RLIHZlcnNpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDQ1MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBCYXNlZCBvbiB3b3JrIGJ5IEVpa2UgWmlsbGVyIDxlaWtlLnppbGxlckBkaWdpYS5jb20+ LgorICAgICAgICBBZGRlZCBjaGVja3MgZm9yIHRoZSBTREsgdmVyc2lvbiB3aGVuIGNob3Npbmcg V2ViS2l0IFN5c3RlbSBMaWJyYXJpZXMgZm9yCisgICAgICAgIE1hYyBidWlsZHMuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzIChub3QgYXBwbGljYWJsZSkuCisKKyAgICAgICAgKiBXZWJDb3JlLnBy aToKKwogMjAxMi0xMi0wNSAgQW50b25pbyBHb21lcyAgPGExLmdvbWVzQHNpc2Euc2Ftc3VuZy5j b20+CiAKICAgICAgICAgUmV3b3JrIGJ1ZyA5NzkyNyB0byBub3QgZGVwZW5kIG9uIFJlbmRlckxh eWVyOjphbGxvd3NTY3JvbGxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUu cHJpIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcmkKaW5kZXggOTRmNmU2NWVmMjAzZDAzZmNh NzNjMjIxNDkxZmFhMDkyNmE2YmNjZi4uYzQ5MDQxZTdhZTE0MjQ3NjdhZTFkMDBiNjlmNTkzNzll YTkzZGE5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcmkKKysrIGIvU291 cmNlL1dlYkNvcmUvV2ViQ29yZS5wcmkKQEAgLTE4MCwxNCArMTgwLDE0IEBAIGVuYWJsZT8oVklE RU8pIHsKICAgICAgICAgIyBXZSBjYW4ga25vdyB0aGUgTWFjIE9TIHZlcnNpb24gYnkgdXNpbmcg dGhlIERhcndpbiBtYWpvciB2ZXJzaW9uCiAgICAgICAgIERBUldJTl9WRVJTSU9OID0gJCRzcGxp dChRTUFLRV9IT1NULnZlcnNpb24sICIuIikKICAgICAgICAgREFSV0lOX01BSk9SX1ZFUlNJT04g PSAkJGZpcnN0KERBUldJTl9WRVJTSU9OKQotICAgICAgICBlcXVhbHMoREFSV0lOX01BSk9SX1ZF UlNJT04sICIxMiIpIHsKLSAgICAgICAgICAgIExJQlMgKz0gJCR7Uk9PVF9XRUJLSVRfRElSfS9X ZWJLaXRMaWJyYXJpZXMvbGliV2ViS2l0U3lzdGVtSW50ZXJmYWNlTW91bnRhaW5MaW9uLmEKLSAg ICAgICAgfSBlbHNlOmVxdWFscyhEQVJXSU5fTUFKT1JfVkVSU0lPTiwgIjExIikgewotICAgICAg ICAgICAgTElCUyArPSAkJHtST09UX1dFQktJVF9ESVJ9L1dlYktpdExpYnJhcmllcy9saWJXZWJL aXRTeXN0ZW1JbnRlcmZhY2VMaW9uLmEKLSAgICAgICAgfSBlbHNlOmVxdWFscyhEQVJXSU5fTUFK T1JfVkVSU0lPTiwgIjEwIikgewotICAgICAgICAgICAgTElCUyArPSAkJHtST09UX1dFQktJVF9E SVJ9L1dlYktpdExpYnJhcmllcy9saWJXZWJLaXRTeXN0ZW1JbnRlcmZhY2VTbm93TGVvcGFyZC5h Ci0gICAgICAgIH0gZWxzZTplcXVhbHMoREFSV0lOX01BSk9SX1ZFUlNJT04sICI5IikgeworICAg ICAgICBlcXVhbHMoREFSV0lOX01BSk9SX1ZFUlNJT04sICI5IikgfCBjb250YWlucyhRTUFLRV9N QUNfU0RLLCAiLipNYWNPU1gxMC41LnNkay4qIikgewogICAgICAgICAgICAgTElCUyArPSAkJHtS T09UX1dFQktJVF9ESVJ9L1dlYktpdExpYnJhcmllcy9saWJXZWJLaXRTeXN0ZW1JbnRlcmZhY2VM ZW9wYXJkLmEKKyAgICAgICAgfSBlbHNlOmVxdWFscyhEQVJXSU5fTUFKT1JfVkVSU0lPTiwgIjEw IikgfCBjb250YWlucyhRTUFLRV9NQUNfU0RLLCAiLipNYWNPU1gxMC42LnNkay4qIikgeworICAg ICAgICAgICAgTElCUyArPSAkJHtST09UX1dFQktJVF9ESVJ9L1dlYktpdExpYnJhcmllcy9saWJX ZWJLaXRTeXN0ZW1JbnRlcmZhY2VTbm93TGVvcGFyZC5hCisgICAgICAgIH0gZWxzZTplcXVhbHMo REFSV0lOX01BSk9SX1ZFUlNJT04sICIxMSIpIHwgY29udGFpbnMoUU1BS0VfTUFDX1NESywgIi4q TWFjT1NYMTAuNy5zZGsuKiIpIHsKKyAgICAgICAgICAgIExJQlMgKz0gJCR7Uk9PVF9XRUJLSVRf RElSfS9XZWJLaXRMaWJyYXJpZXMvbGliV2ViS2l0U3lzdGVtSW50ZXJmYWNlTGlvbi5hCisgICAg ICAgIH0gZWxzZTplcXVhbHMoREFSV0lOX01BSk9SX1ZFUlNJT04sICIxMiIpIHwgY29udGFpbnMo UU1BS0VfTUFDX1NESywgIi4qTWFjT1NYMTAuOC5zZGsuKiIpIHsKKyAgICAgICAgICAgIExJQlMg Kz0gJCR7Uk9PVF9XRUJLSVRfRElSfS9XZWJLaXRMaWJyYXJpZXMvbGliV2ViS2l0U3lzdGVtSW50 ZXJmYWNlTW91bnRhaW5MaW9uLmEKICAgICAgICAgfQogICAgIH0gZWxzZTp1c2U/KEdTVFJFQU1F UikgewogICAgICAgICBJTkNMVURFUEFUSCArPSAkJFNPVVJDRV9ESVIvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyCg== 178509 2012-12-10 03:58:33 -0800 2012-12-10 04:40:11 -0800 Patch bug-104529-20121210125554.patch text/plain 3931 michael.bruning U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmIzOGFkZmU5MWExMDYz ZDE1YWE3Yjk2ZTczMjljYjAyYmUzMWJjMS4uZmEwMjA3MThhOWYwZTkzNGYyN2FlZjc2NDhjMWVj MGYzODljOTI2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTEwICBNaWNo YWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRd IEJ1aWxkcyBmb3IgTWFjIGFyZSB0aWVkIHRvIHRoZSBPUyBzeXN0ZW0gaW5zdGVhZCBvZiB0aGUg U0RLIHZlcnNpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDQ1MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBVc2luZyB3b3JrIGJ5IEVpa2UgWmlsbGVyIDxlaWtlLnppbGxlckBkaWdpYS5jb20+Lgor CisgICAgICAgIFRoZSBidWlsZCBzeXN0ZW0gbm93IGZpcnN0IHRyaWVzIHRvIGFzc2lnbiB0aGUg Y29ycmVjdCBzeXN0ZW0gbGlicmFyaWVzCisgICAgICAgIGZvciB0aGUgU0RLIGJlaW5nIHVzZWQg Zm9yIE1hYyBidWlsZHMuIElmIHRoaXMgZG9lcyBub3QgeWllbGQgYW55CisgICAgICAgIHJlc3Vs dCwgaXQgZmFsbHMgYmFjayB0byB1c2luZyB0aGUgTWFjIE9TIHZlcnNpb24gdG8gZGV0ZXJtaW5l IHRoZQorICAgICAgICBjb3JyZWN0IGxpYnJhcnkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChu b3QgYXBwbGljYWJsZSkuCisKKyAgICAgICAgKiBXZWJDb3JlLnByaToKKwogMjAxMi0xMi0wNSAg QW50b25pbyBHb21lcyAgPGExLmdvbWVzQHNpc2Euc2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmV3 b3JrIGJ1ZyA5NzkyNyB0byBub3QgZGVwZW5kIG9uIFJlbmRlckxheWVyOjphbGxvd3NTY3JvbGxp bmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJpIGIvU291cmNlL1dlYkNv cmUvV2ViQ29yZS5wcmkKaW5kZXggOTRmNmU2NWVmMjAzZDAzZmNhNzNjMjIxNDkxZmFhMDkyNmE2 YmNjZi4uOWZhZWNkYmU4NWNjNGVkMDU5ZDgwMmY3YzIxZDU3Mjg2ZGEzMDI4ZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcmkKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29y ZS5wcmkKQEAgLTE3NywxOCArMTc3LDMzIEBAIGVuYWJsZT8oVklERU8pIHsKICAgICAgICAgICAg ICAgICAtZnJhbWV3b3JrIFF1YXJ0ekNvcmUgLWZyYW1ld29yayBRVEtpdCBcCiAgICAgICAgICAg ICAgICAgLWZyYW1ld29yayBTZWN1cml0eSAtZnJhbWV3b3JrIElPS2l0CiAKLSAgICAgICAgIyBX ZSBjYW4ga25vdyB0aGUgTWFjIE9TIHZlcnNpb24gYnkgdXNpbmcgdGhlIERhcndpbiBtYWpvciB2 ZXJzaW9uCiAgICAgICAgIERBUldJTl9WRVJTSU9OID0gJCRzcGxpdChRTUFLRV9IT1NULnZlcnNp b24sICIuIikKICAgICAgICAgREFSV0lOX01BSk9SX1ZFUlNJT04gPSAkJGZpcnN0KERBUldJTl9W RVJTSU9OKQotICAgICAgICBlcXVhbHMoREFSV0lOX01BSk9SX1ZFUlNJT04sICIxMiIpIHsKLSAg ICAgICAgICAgIExJQlMgKz0gJCR7Uk9PVF9XRUJLSVRfRElSfS9XZWJLaXRMaWJyYXJpZXMvbGli V2ViS2l0U3lzdGVtSW50ZXJmYWNlTW91bnRhaW5MaW9uLmEKLSAgICAgICAgfSBlbHNlOmVxdWFs cyhEQVJXSU5fTUFKT1JfVkVSU0lPTiwgIjExIikgewotICAgICAgICAgICAgTElCUyArPSAkJHtS T09UX1dFQktJVF9ESVJ9L1dlYktpdExpYnJhcmllcy9saWJXZWJLaXRTeXN0ZW1JbnRlcmZhY2VM aW9uLmEKLSAgICAgICAgfSBlbHNlOmVxdWFscyhEQVJXSU5fTUFKT1JfVkVSU0lPTiwgIjEwIikg ewotICAgICAgICAgICAgTElCUyArPSAkJHtST09UX1dFQktJVF9ESVJ9L1dlYktpdExpYnJhcmll cy9saWJXZWJLaXRTeXN0ZW1JbnRlcmZhY2VTbm93TGVvcGFyZC5hCi0gICAgICAgIH0gZWxzZTpl cXVhbHMoREFSV0lOX01BSk9SX1ZFUlNJT04sICI5IikgewotICAgICAgICAgICAgTElCUyArPSAk JHtST09UX1dFQktJVF9ESVJ9L1dlYktpdExpYnJhcmllcy9saWJXZWJLaXRTeXN0ZW1JbnRlcmZh Y2VMZW9wYXJkLmEKKworICAgICAgICAjIFdlIGZpcnN0IGNoZWNrIGlmIGEgc3BlY2lmaWMgU0RL IGlzIHNldCB0byBiZSB1c2VkIGZvciB0aGUgYnVpbGQuCisgICAgICAgIGNvbnRhaW5zKFFNQUtF X01BQ19TREssICIuKk1hY09TWDEwLjUuc2RrLioiKSB7CisgICAgICAgICAgICBTWVNURU1fTElC UkFSWV9QQVRIID0gJCR7Uk9PVF9XRUJLSVRfRElSfS9XZWJLaXRMaWJyYXJpZXMvbGliV2ViS2l0 U3lzdGVtSW50ZXJmYWNlTGVvcGFyZC5hCisgICAgICAgIH0gZWxzZTpjb250YWlucyhRTUFLRV9N QUNfU0RLLCAiLipNYWNPU1gxMC42LnNkay4qIikgeworICAgICAgICAgICAgU1lTVEVNX0xJQlJB UllfUEFUSCA9ICQke1JPT1RfV0VCS0lUX0RJUn0vV2ViS2l0TGlicmFyaWVzL2xpYldlYktpdFN5 c3RlbUludGVyZmFjZVNub3dMZW9wYXJkLmEKKyAgICAgICAgfSBlbHNlOmNvbnRhaW5zKFFNQUtF X01BQ19TREssICIuKk1hY09TWDEwLjcuc2RrLioiKSB7CisgICAgICAgICAgICBTWVNURU1fTElC UkFSWV9QQVRIID0gJCR7Uk9PVF9XRUJLSVRfRElSfS9XZWJLaXRMaWJyYXJpZXMvbGliV2ViS2l0 U3lzdGVtSW50ZXJmYWNlTGlvbi5hCisgICAgICAgIH0gZWxzZTpjb250YWlucyhRTUFLRV9NQUNf U0RLLCAiLipNYWNPU1gxMC44LnNkay4qIikgeworICAgICAgICAgICAgU1lTVEVNX0xJQlJBUllf UEFUSCA9ICQke1JPT1RfV0VCS0lUX0RJUn0vV2ViS2l0TGlicmFyaWVzL2xpYldlYktpdFN5c3Rl bUludGVyZmFjZU1vdW50YWluTGlvbi5hCisgICAgICAgIH0KKworICAgICAgICAjIElmIHRoZSBw cmV2aW91cyBjaGVjayBkaWQgbm90IHlpZWxkIGEgcmVzdWx0LCB3ZSByZXNvcnQgdG8gdGhlIERh cndpbiB2ZXJzaW9uLgorICAgICAgICBpc0VtcHR5KFNZU1RFTV9MSUJSQVJZX1BBVEgpIHsKKyAg ICAgICAgICAgIGVxdWFscyhEQVJXSU5fTUFKT1JfVkVSU0lPTiwgIjkiKSB7CisgICAgICAgICAg ICAgICAgU1lTVEVNX0xJQlJBUllfUEFUSCA9ICQke1JPT1RfV0VCS0lUX0RJUn0vV2ViS2l0TGli cmFyaWVzL2xpYldlYktpdFN5c3RlbUludGVyZmFjZUxlb3BhcmQuYQorICAgICAgICAgICAgfSBl bHNlOmVxdWFscyhEQVJXSU5fTUFKT1JfVkVSU0lPTiwgIjEwIikgeworICAgICAgICAgICAgICAg IFNZU1RFTV9MSUJSQVJZX1BBVEggPSAkJHtST09UX1dFQktJVF9ESVJ9L1dlYktpdExpYnJhcmll cy9saWJXZWJLaXRTeXN0ZW1JbnRlcmZhY2VTbm93TGVvcGFyZC5hCisgICAgICAgICAgICB9IGVs c2U6ZXF1YWxzKERBUldJTl9NQUpPUl9WRVJTSU9OLCAiMTEiKSB7CisgICAgICAgICAgICAgICAg U1lTVEVNX0xJQlJBUllfUEFUSCA9ICQke1JPT1RfV0VCS0lUX0RJUn0vV2ViS2l0TGlicmFyaWVz L2xpYldlYktpdFN5c3RlbUludGVyZmFjZUxpb24uYQorICAgICAgICAgICAgfSBlbHNlOmVxdWFs cyhEQVJXSU5fTUFKT1JfVkVSU0lPTiwgIjEyIikgeworICAgICAgICAgICAgICAgIFNZU1RFTV9M SUJSQVJZX1BBVEggPSAkJHtST09UX1dFQktJVF9ESVJ9L1dlYktpdExpYnJhcmllcy9saWJXZWJL aXRTeXN0ZW1JbnRlcmZhY2VNb3VudGFpbkxpb24uYQorICAgICAgICAgICAgfQogICAgICAgICB9 CisgICAgICAgIExJQlMgKz0gJCRTWVNURU1fTElCUkFSWV9QQVRICiAgICAgfSBlbHNlOnVzZT8o R1NUUkVBTUVSKSB7CiAgICAgICAgIElOQ0xVREVQQVRIICs9ICQkU09VUkNFX0RJUi9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIKICAgICB9IGVsc2U6dXNlPyhRVF9NVUxUSU1FRElBKSB7Cg==