104504 2012-12-09 20:05:51 -0800 [BlackBerry] Webkit crashes sometimes (even though very rarely) when deleting a webview 2012-12-10 05:35:47 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Major --- 1 charles.wei charles.wei anilsson logingx mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 786942 0 charles.wei 2012-12-09 20:05:51 -0800 Internal tracking number: 261567 When deleting a webview, the webkit thread will send a sync message to userInterfaceThread to delete handlers, including the viewport accessor. But the UserInterfaceThread could be doing a blit after it has deleted the viewport accessor and before the webkit thread gets the time slot to resume it's operation to clean up the webview, which leaves a very short time that viewport accessor of a webpage has been deleted while the webpage is still in the process of deleting, and the viewport accessor is referenced in the UserInterfaceThread when blitting contents. So we need to check if the viewport accessor is NULL before using it in the BackingStore code. 786944 1 178461 charles.wei 2012-12-09 20:11:02 -0800 Created attachment 178461 Patch 786945 2 178461 charles.wei 2012-12-09 20:12:05 -0800 Comment on attachment 178461 Patch Already reviewed and approved by George Staikos offline. Commit it. 786965 3 anilsson 2012-12-09 21:25:24 -0800 This patch is not quite right, see comment in PR #261257 786966 4 anilsson 2012-12-09 21:25:42 -0800 (In reply to comment #3) > This patch is not quite right, see comment in PR #261257 Uh, 261567 786969 5 charles.wei 2012-12-09 21:27:22 -0800 Ok, stopped committing. will fix . 787021 6 178478 charles.wei 2012-12-09 23:09:22 -0800 Created attachment 178478 Patch 787027 7 charles.wei 2012-12-09 23:23:00 -0800 With the internal bug fix for 261671, this seems less likely to happen. But it doesn't hurt to have this fix just in case there's other code path that might reach here. 787207 8 anilsson 2012-12-10 04:51:45 -0800 (In reply to comment #7) > With the internal bug fix for 261671, this seems less likely to happen. But it doesn't hurt to have this fix just in case there's other code path that might reach here. I agree, checking for null when something can be null is good. 787208 9 178478 rwlbuis 2012-12-10 05:01:40 -0800 Comment on attachment 178478 Patch LGTM. 787218 10 178478 charles.wei 2012-12-10 05:26:14 -0800 Comment on attachment 178478 Patch Commit. 787219 11 178478 webkit.review.bot 2012-12-10 05:35:43 -0800 Comment on attachment 178478 Patch Clearing flags on attachment: 178478 Committed r137140: <http://trac.webkit.org/changeset/137140> 787220 12 webkit.review.bot 2012-12-10 05:35:47 -0800 All reviewed patches have been landed. Closing bug. 178461 2012-12-09 20:11:02 -0800 2012-12-09 23:09:12 -0800 Patch bug-104504-20121210120823.patch text/plain 2991 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyNDQxZjllOWRjMjBkNmJlNDk5ZjdkYzcwOTY4ZjMwMzcxNTVlNDZmLi44Zjg4MTg5NzVk NWY2M2MwODllYzhmNmY0MTA2NTliZDFmZTE4NDUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMi0xMi0wOSAgQ2hhcmxlcyBXZWkgIDxjaGFybGVz LndlaUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFdlYmtpdCBj cmFzaGVzIHNvbWV0aW1lcyAoZXZlbiB0aG91Z2ggdmVyeSByYXJlbHkpIHdoZW4gZGVsZXRpbmcg YSB3ZWJ2aWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDQ1MDQKKworICAgICAgICBSZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KKworICAgICAg ICBXaGVuIGRlbGV0aW5nIGEgd2VidmlldywgdGhlIHdlYmtpdCB0aHJlYWQgd2lsbCBzZW5kIGEg c3luYyBtZXNzYWdlIHRvIHVzZXJJbnRlcmZhY2VUaHJlYWQKKyAgICAgICAgdG8gZGVsZXRlIGhh bmRsZXJzLCBpbmNsdWRpbmcgdGhlIHZpZXdwb3J0IGFjY2Vzc29yLiBCdXQgdGhlIFVzZXJJbnRl cmZhY2VUaHJlYWQgY291bGQgYmUKKyAgICAgICAgZG9pbmcgYSBibGl0IGFmdGVyIGl0IGhhcyBk ZWxldGVkIHRoZSB2aWV3cG9ydCBhY2Nlc3NvciBhbmQgYmVmb3JlIHRoZSB3ZWJraXQgdGhyZWFk IGdldHMKKyAgICAgICAgdGhlIHRpbWUgc2xvdCB0byByZXN1bWUgaXQncyBvcGVyYXRpb24gdG8g Y2xlYW4gdXAgdGhlIHdlYnZpZXcsIHdoaWNoIGxlYXZlcyBhIHZlcnkgc2hvcnQKKyAgICAgICAg dGltZSB0aGF0IHZpZXdwb3J0IGFjY2Vzc29yIG9mIGEgd2VicGFnZSBoYXMgYmVlbiBkZWxldGVk IHdoaWxlIHRoZSB3ZWJwYWdlIGlzIHN0aWxsIGluCisgICAgICAgIHRoZSBwcm9jZXNzIG9mIGRl bGV0aW5nLCBhbmQgdGhlIHZpZXdwb3J0IGFjY2Vzc29yIGlzIHJlZmVyZW5jZWQgaW4gdGhlIFVz ZXJJbnRlcmZhY2VUaHJlYWQuCisKKyAgICAgICAgU28gd2UgbmVlZCB0byBjaGVjayBpZiB0aGUg dmlld3BvcnQgYWNjZXNzb3IgaXMgTlVMTCBiZWZvcmUgdXNpbmcgaXQgaW4gdGhlIGJhY2tpbmdz dG9yZSBjb2RlLgorCisgICAgICAgICogQXBpL0JhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChC bGFja0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZVByaXZhdGU6OmJsaXRWaXNpYmxlQ29udGVu dHMpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVQcml2YXRlOjpp bnZhbGlkYXRlV2luZG93KToKKwogMjAxMi0xMi0wOCAgSmFja3kgSmlhbmcgIDx6aGFqaWFuZ0By aW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBHb29nbGUgcmVzdWx0cyBwYWdlIHJlbmRl cmluZyBpc3N1ZSB3aXRoIFJUTCBsYW5ndWFnZXMgbGlrZSBhcmFiaWMvaGVicmV3CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAKaW5kZXggOWRkZjFjMGEy NDIwNzM0MmRjOWM3YjE0ZjJhNjRjZGRjYWE2YjE4NS4uNWU3MzVmNTMzMGQzNTEwZjAxMWQyNjJl NGYxMTA0NzRjNjI4NjAzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9CYWNraW5nU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFj a2luZ1N0b3JlLmNwcApAQCAtMTI4NSw2ICsxMjg1LDggQEAgdm9pZCBCYWNraW5nU3RvcmVQcml2 YXRlOjpibGl0VmlzaWJsZUNvbnRlbnRzKGJvb2wgZm9yY2UpCiAgICAgbV9oYXNCbGl0Sm9icyA9 IGZhbHNlOwogCiAgICAgUGxhdGZvcm06OlZpZXdwb3J0QWNjZXNzb3IqIHZpZXdwb3J0QWNjZXNz b3IgPSBtX3dlYlBhZ2UtPmNsaWVudCgpLT51c2VySW50ZXJmYWNlVmlld3BvcnRBY2Nlc3Nvcigp OworICAgIGlmICghdmlld3BvcnRBY2Nlc3NvcikKKyAgICAgICAgcmV0dXJuOwogICAgIGNvbnN0 IFBsYXRmb3JtOjpJbnRSZWN0IGRzdFJlY3QgPSB2aWV3cG9ydEFjY2Vzc29yLT5kZXN0aW5hdGlv blN1cmZhY2VSZWN0KCk7CiAKICAgICBjb25zdCBQbGF0Zm9ybTo6SW50UmVjdCBwaXhlbFZpZXdw b3J0UmVjdCA9IHZpZXdwb3J0QWNjZXNzb3ItPnBpeGVsVmlld3BvcnRSZWN0KCk7CkBAIC0yMjg0 LDcgKzIyODYsNyBAQCB2b2lkIEJhY2tpbmdTdG9yZVByaXZhdGU6OnNldFdlYlBhZ2VCYWNrZ3Jv dW5kQ29sb3IoY29uc3QgV2ViQ29yZTo6Q29sb3ImIGNvbG9yKQogdm9pZCBCYWNraW5nU3RvcmVQ cml2YXRlOjppbnZhbGlkYXRlV2luZG93KCkKIHsKICAgICAvLyBHcmFiIGEgcmVjdCBhcHByb3By aWF0ZSBmb3IgdGhlIGN1cnJlbnQgdGhyZWFkLgotICAgIGlmIChCbGFja0JlcnJ5OjpQbGF0Zm9y bTo6dXNlckludGVyZmFjZVRocmVhZE1lc3NhZ2VDbGllbnQoKS0+aXNDdXJyZW50VGhyZWFkKCkp CisgICAgaWYgKEJsYWNrQmVycnk6OlBsYXRmb3JtOjp1c2VySW50ZXJmYWNlVGhyZWFkTWVzc2Fn ZUNsaWVudCgpLT5pc0N1cnJlbnRUaHJlYWQoKSAmJiBtX3dlYlBhZ2UtPmNsaWVudCgpLT51c2Vy SW50ZXJmYWNlVmlld3BvcnRBY2Nlc3NvcigpKQogICAgICAgICBpbnZhbGlkYXRlV2luZG93KG1f d2ViUGFnZS0+Y2xpZW50KCktPnVzZXJJbnRlcmZhY2VWaWV3cG9ydEFjY2Vzc29yKCktPmRlc3Rp bmF0aW9uU3VyZmFjZVJlY3QoKSk7CiAgICAgZWxzZQogICAgICAgICBpbnZhbGlkYXRlV2luZG93 KFBsYXRmb3JtOjpJbnRSZWN0KFBsYXRmb3JtOjpJbnRQb2ludCgwLCAwKSwgbV9jbGllbnQtPnRy YW5zZm9ybWVkVmlld3BvcnRTaXplKCkpKTsK 178478 2012-12-09 23:09:22 -0800 2012-12-10 05:35:43 -0800 Patch bug-104504-20121210150640.patch text/plain 3133 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyNDQxZjllOWRjMjBkNmJlNDk5ZjdkYzcwOTY4ZjMwMzcxNTVlNDZmLi44Zjg4MTg5NzVk NWY2M2MwODllYzhmNmY0MTA2NTliZDFmZTE4NDUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMi0xMi0wOSAgQ2hhcmxlcyBXZWkgIDxjaGFybGVz LndlaUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFdlYmtpdCBj cmFzaGVzIHNvbWV0aW1lcyAoZXZlbiB0aG91Z2ggdmVyeSByYXJlbHkpIHdoZW4gZGVsZXRpbmcg YSB3ZWJ2aWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDQ1MDQKKworICAgICAgICBSZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KKworICAgICAg ICBXaGVuIGRlbGV0aW5nIGEgd2VidmlldywgdGhlIHdlYmtpdCB0aHJlYWQgd2lsbCBzZW5kIGEg c3luYyBtZXNzYWdlIHRvIHVzZXJJbnRlcmZhY2VUaHJlYWQKKyAgICAgICAgdG8gZGVsZXRlIGhh bmRsZXJzLCBpbmNsdWRpbmcgdGhlIHZpZXdwb3J0IGFjY2Vzc29yLiBCdXQgdGhlIFVzZXJJbnRl cmZhY2VUaHJlYWQgY291bGQgYmUKKyAgICAgICAgZG9pbmcgYSBibGl0IGFmdGVyIGl0IGhhcyBk ZWxldGVkIHRoZSB2aWV3cG9ydCBhY2Nlc3NvciBhbmQgYmVmb3JlIHRoZSB3ZWJraXQgdGhyZWFk IGdldHMKKyAgICAgICAgdGhlIHRpbWUgc2xvdCB0byByZXN1bWUgaXQncyBvcGVyYXRpb24gdG8g Y2xlYW4gdXAgdGhlIHdlYnZpZXcsIHdoaWNoIGxlYXZlcyBhIHZlcnkgc2hvcnQKKyAgICAgICAg dGltZSB0aGF0IHZpZXdwb3J0IGFjY2Vzc29yIG9mIGEgd2VicGFnZSBoYXMgYmVlbiBkZWxldGVk IHdoaWxlIHRoZSB3ZWJwYWdlIGlzIHN0aWxsIGluCisgICAgICAgIHRoZSBwcm9jZXNzIG9mIGRl bGV0aW5nLCBhbmQgdGhlIHZpZXdwb3J0IGFjY2Vzc29yIGlzIHJlZmVyZW5jZWQgaW4gdGhlIFVz ZXJJbnRlcmZhY2VUaHJlYWQuCisKKyAgICAgICAgU28gd2UgbmVlZCB0byBjaGVjayBpZiB0aGUg dmlld3BvcnQgYWNjZXNzb3IgaXMgTlVMTCBiZWZvcmUgdXNpbmcgaXQgaW4gdGhlIGJhY2tpbmdz dG9yZSBjb2RlLgorCisgICAgICAgICogQXBpL0JhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChC bGFja0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZVByaXZhdGU6OmJsaXRWaXNpYmxlQ29udGVu dHMpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVQcml2YXRlOjpp bnZhbGlkYXRlV2luZG93KToKKwogMjAxMi0xMi0wOCAgSmFja3kgSmlhbmcgIDx6aGFqaWFuZ0By aW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBHb29nbGUgcmVzdWx0cyBwYWdlIHJlbmRl cmluZyBpc3N1ZSB3aXRoIFJUTCBsYW5ndWFnZXMgbGlrZSBhcmFiaWMvaGVicmV3CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAKaW5kZXggOWRkZjFjMGEy NDIwNzM0MmRjOWM3YjE0ZjJhNjRjZGRjYWE2YjE4NS4uYzkxYTJhZDgxMmM5NjVhZmJkYmJkZmM0 ZjZkMjczOThmZGRjNTAwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9CYWNraW5nU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFj a2luZ1N0b3JlLmNwcApAQCAtMTI4NSw2ICsxMjg1LDggQEAgdm9pZCBCYWNraW5nU3RvcmVQcml2 YXRlOjpibGl0VmlzaWJsZUNvbnRlbnRzKGJvb2wgZm9yY2UpCiAgICAgbV9oYXNCbGl0Sm9icyA9 IGZhbHNlOwogCiAgICAgUGxhdGZvcm06OlZpZXdwb3J0QWNjZXNzb3IqIHZpZXdwb3J0QWNjZXNz b3IgPSBtX3dlYlBhZ2UtPmNsaWVudCgpLT51c2VySW50ZXJmYWNlVmlld3BvcnRBY2Nlc3Nvcigp OworICAgIGlmICghdmlld3BvcnRBY2Nlc3NvcikKKyAgICAgICAgcmV0dXJuOwogICAgIGNvbnN0 IFBsYXRmb3JtOjpJbnRSZWN0IGRzdFJlY3QgPSB2aWV3cG9ydEFjY2Vzc29yLT5kZXN0aW5hdGlv blN1cmZhY2VSZWN0KCk7CiAKICAgICBjb25zdCBQbGF0Zm9ybTo6SW50UmVjdCBwaXhlbFZpZXdw b3J0UmVjdCA9IHZpZXdwb3J0QWNjZXNzb3ItPnBpeGVsVmlld3BvcnRSZWN0KCk7CkBAIC0yMjg0 LDkgKzIyODYsMTAgQEAgdm9pZCBCYWNraW5nU3RvcmVQcml2YXRlOjpzZXRXZWJQYWdlQmFja2dy b3VuZENvbG9yKGNvbnN0IFdlYkNvcmU6OkNvbG9yJiBjb2xvcikKIHZvaWQgQmFja2luZ1N0b3Jl UHJpdmF0ZTo6aW52YWxpZGF0ZVdpbmRvdygpCiB7CiAgICAgLy8gR3JhYiBhIHJlY3QgYXBwcm9w cmlhdGUgZm9yIHRoZSBjdXJyZW50IHRocmVhZC4KLSAgICBpZiAoQmxhY2tCZXJyeTo6UGxhdGZv cm06OnVzZXJJbnRlcmZhY2VUaHJlYWRNZXNzYWdlQ2xpZW50KCktPmlzQ3VycmVudFRocmVhZCgp KQotICAgICAgICBpbnZhbGlkYXRlV2luZG93KG1fd2ViUGFnZS0+Y2xpZW50KCktPnVzZXJJbnRl cmZhY2VWaWV3cG9ydEFjY2Vzc29yKCktPmRlc3RpbmF0aW9uU3VyZmFjZVJlY3QoKSk7Ci0gICAg ZWxzZQorICAgIGlmIChCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6dXNlckludGVyZmFjZVRocmVhZE1l c3NhZ2VDbGllbnQoKS0+aXNDdXJyZW50VGhyZWFkKCkpIHsKKyAgICAgICAgaWYgKG1fd2ViUGFn ZS0+Y2xpZW50KCktPnVzZXJJbnRlcmZhY2VWaWV3cG9ydEFjY2Vzc29yKCkpCisgICAgICAgICAg ICBpbnZhbGlkYXRlV2luZG93KG1fd2ViUGFnZS0+Y2xpZW50KCktPnVzZXJJbnRlcmZhY2VWaWV3 cG9ydEFjY2Vzc29yKCktPmRlc3RpbmF0aW9uU3VyZmFjZVJlY3QoKSk7CisgICAgfSBlbHNlCiAg ICAgICAgIGludmFsaWRhdGVXaW5kb3coUGxhdGZvcm06OkludFJlY3QoUGxhdGZvcm06OkludFBv aW50KDAsIDApLCBtX2NsaWVudC0+dHJhbnNmb3JtZWRWaWV3cG9ydFNpemUoKSkpOwogfQogCg==