104490 2012-12-09 10:52:47 -0800 Remove unused code in GObject DOM bindings generator 2012-12-09 11:02:10 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned abarth haraken japhet webkit.review.bot xan.lopez oldest_to_newest 786818 0 cgarcia 2012-12-09 10:52:47 -0800 We don't install signals nor even listeners anymore. 786819 1 178428 cgarcia 2012-12-09 10:55:13 -0800 Created attachment 178428 Patch 786822 2 cgarcia 2012-12-09 11:02:10 -0800 Committed r137089: <http://trac.webkit.org/changeset/137089> 178428 2012-12-09 10:55:13 -0800 2012-12-09 10:58:05 -0800 Patch wk-dom-unused-code.diff text/plain 3392 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1Yzk0MzBlLi4xNzYxYTA2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTEyLTA5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KKworICAgICAgICBSZW1vdmUgdW51c2VkIGNvZGUgaW4gR09iamVjdCBET00gYmluZGluZ3Mg Z2VuZXJhdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDQ0OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG06CisgICAgICAgIChH ZW5lcmF0ZVByb3BlcnRpZXMpOiBSZW1vdmUgY29kZSB0byBpbnN0YWxsIGV2ZW50IGxpc3RlbmVy cyBhbmQKKyAgICAgICAgc2lnbmFscy4KKwogMjAxMi0xMi0wOSAgWmFuIERvYmVyc2VrICA8emFu ZG9iZXJzZWtAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdXBkYXRlIGZvciB0aGUg R09iamVjdCBiaW5kaW5ncyBhZnRlciByMTM3MDc0IGFuZCByMTM3MDc4LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbSBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0K aW5kZXggZTMxMzk2MS4uMGE3NGExYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCkBAIC0zMSw4ICszMSw2IEBA IG15ICVoZHJJbmNsdWRlcyA9ICgpOwogbXkgJGRlZmluZVR5cGVNYWNybyA9ICJHX0RFRklORV9U WVBFIjsKIG15ICRkZWZpbmVUeXBlSW50ZXJmYWNlSW1wbGVtZW50YXRpb24gPSAiKSI7CiBteSBA dHh0RXZlbnRMaXN0ZW5lcnMgPSAoKTsKLW15IEB0eHRJbnN0YWxsRXZlbnRMaXN0ZW5lcnMgPSAo KTsKLW15IEB0eHRJbnN0YWxsU2lnbmFscyA9ICgpOwogbXkgQHR4dEluc3RhbGxQcm9wcyA9ICgp OwogbXkgQHR4dFNldFByb3BzID0gKCk7CiBteSBAdHh0R2V0UHJvcHMgPSAoKTsKQEAgLTY3MSwy MyArNjY5LDYgQEAgRU9GCiAgICAgICAgIHB1c2goQGNCb2R5UHJvcGVydGllcywgIlxuIik7CiAg ICAgfQogCi0gICAgaWYgKHNjYWxhciBAdHh0SW5zdGFsbEV2ZW50TGlzdGVuZXJzID4gMCkgewot ICAgICAgICAkaW1wbENvbnRlbnQgPSA8PCAiRU9GIjsKLXN0YXRpYyB2b2lkICR7bG93ZXJDYXNl SWZhY2VOYW1lfV9jb25zdHJ1Y3RlZChHT2JqZWN0KiBvYmplY3QpCi17Ci0gICAgR19PQkpFQ1Rf Q0xBU1MoJHtsb3dlckNhc2VJZmFjZU5hbWV9X3BhcmVudF9jbGFzcyktPmNvbnN0cnVjdGVkKG9i amVjdCk7Ci1FT0YKLSAgICAgICAgcHVzaChAY0JvZHlQcm9wZXJ0aWVzLCAkaW1wbENvbnRlbnQp OwotICAgICAgICBwdXNoKEBjQm9keVByb3BlcnRpZXMsICJcbiIpOwotICAgICAgICBwdXNoKEBj Qm9keVByb3BlcnRpZXMsIEB0eHRJbnN0YWxsRXZlbnRMaXN0ZW5lcnMpOwotCi0gICAgICAgICRp bXBsQ29udGVudCA9IDw8ICJFT0YiOwotfQotCi1FT0YKLSAgICAgICAgcHVzaChAY0JvZHlQcm9w ZXJ0aWVzLCAkaW1wbENvbnRlbnQpOwotICAgIH0KLQogICAgICMgQWRkIGEgY29uc3RydWN0b3Ig aW1wbGVtZW50YXRpb24gb25seSBmb3IgZGlyZWN0IHN1YmNsYXNzZXMgb2YgT2JqZWN0IHRvIG1h a2Ugc3VyZQogICAgICMgdGhhdCB0aGUgV2ViQ29yZSB3cmFwcGVkIG9iamVjdCBpcyBhZGRlZCBv bmx5IG9uY2UgdG8gdGhlIERPTSBjYWNoZS4gVGhlIERPTSBnYXJiYWdlCiAgICAgIyBjb2xsZWN0 b3Igd29ya3MgYmVjYXVzZSBOb2RlIGlzIGEgZGlyZWN0IHN1YmNsYXNzIG9mIE9iamVjdCBhbmQg dGhlIHZlcnNpb24gb2YKQEAgLTcxNiw3ICs2OTcsNyBAQCBzdGF0aWMgdm9pZCAke2xvd2VyQ2Fz ZUlmYWNlTmFtZX1fY2xhc3NfaW5pdCgke2NsYXNzTmFtZX1DbGFzcyogcmVxdWVzdENsYXNzKQog RU9GCiAgICAgcHVzaChAY0JvZHlQcm9wZXJ0aWVzLCAkaW1wbENvbnRlbnQpOwogCi0gICAgaWYg KCRwYXJlbnRJbXBsQ2xhc3NOYW1lIGVxICJPYmplY3QiIHx8IHNjYWxhciBAdHh0SW5zdGFsbEV2 ZW50TGlzdGVuZXJzID4gMCB8fCAkbnVtUHJvcGVydGllcyA+IDApIHsKKyAgICBpZiAoJHBhcmVu dEltcGxDbGFzc05hbWUgZXEgIk9iamVjdCIgfHwgJG51bVByb3BlcnRpZXMgPiAwKSB7CiAgICAg ICAgIHB1c2goQGNCb2R5UHJvcGVydGllcywgIiAgICBHT2JqZWN0Q2xhc3MqIGdvYmplY3RDbGFz cyA9IEdfT0JKRUNUX0NMQVNTKHJlcXVlc3RDbGFzcyk7XG4iKTsKIAogICAgICAgICBpZiAoJHBh cmVudEltcGxDbGFzc05hbWUgZXEgIk9iamVjdCIpIHsKQEAgLTcyNSwxMCArNzA2LDYgQEAgRU9G CiAgICAgICAgICAgICBwdXNoKEBjQm9keVByb3BlcnRpZXMsICIgICAgZ29iamVjdENsYXNzLT5m aW5hbGl6ZSA9ICR7bG93ZXJDYXNlSWZhY2VOYW1lfV9maW5hbGl6ZTtcbiIpOwogICAgICAgICB9 CiAKLSAgICAgICAgaWYgKHNjYWxhciBAdHh0SW5zdGFsbEV2ZW50TGlzdGVuZXJzID4gMCkgewot ICAgICAgICAgICAgcHVzaChAY0JvZHlQcm9wZXJ0aWVzLCAiICAgIGdvYmplY3RDbGFzcy0+Y29u c3RydWN0ZWQgPSAke2xvd2VyQ2FzZUlmYWNlTmFtZX1fY29uc3RydWN0ZWQ7XG4iKTsKLSAgICAg ICAgfQotCiAgICAgICAgIGlmICgkbnVtUHJvcGVydGllcyA+IDApIHsKICAgICAgICAgICAgIGlm IChzY2FsYXIgQHdyaXRlYWJsZVByb3BlcnRpZXMgPiAwKSB7CiAgICAgICAgICAgICAgICAgcHVz aChAY0JvZHlQcm9wZXJ0aWVzLCAiICAgIGdvYmplY3RDbGFzcy0+c2V0X3Byb3BlcnR5ID0gJHts b3dlckNhc2VJZmFjZU5hbWV9X3NldF9wcm9wZXJ0eTtcbiIpOwpAQCAtNzM3LDExICs3MTQsNiBA QCBFT0YKICAgICAgICAgICAgIHB1c2goQGNCb2R5UHJvcGVydGllcywgIlxuIik7CiAgICAgICAg ICAgICBwdXNoKEBjQm9keVByb3BlcnRpZXMsIEB0eHRJbnN0YWxsUHJvcHMpOwogICAgICAgICB9 Ci0KLSAgICAgICAgaWYgKHNjYWxhciBAdHh0SW5zdGFsbFNpZ25hbHMgPiAwKSB7Ci0gICAgICAg ICAgICBwdXNoKEBjQm9keVByb3BlcnRpZXMsICJcbiIpOwotICAgICAgICAgICAgcHVzaChAY0Jv ZHlQcm9wZXJ0aWVzLCBAdHh0SW5zdGFsbFNpZ25hbHMpOwotICAgICAgICB9CiAgICAgfQogICAg ICRpbXBsQ29udGVudCA9IDw8ICJFT0YiOwogfQo=