104483 2012-12-09 05:55:38 -0800 AX: wrong Enabled states on a ListBox 2012-12-10 09:31:26 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 apinheiro webkit-unassigned cfleizach dmazzoni jdiggs webkit.review.bot oldest_to_newest 786775 0 178416 apinheiro 2012-12-09 05:55:38 -0800 Created attachment 178416 A layout test that should pass but it isn't If a ListBox has a disabled item it should be exposed as disabled. I found this problem while working on the bug 98376 I found a new problem. The bug is about getting the gtk port passing a existing test. On that test the last item is not selectable. But in the same way, it shouldn't be enabled, but it is. I'm attaching a modified test, with the expected outcome. Right now this is failing. Note: I'm reporting this bug to the GTK port, as it is the one I'm working on, but this test should also pass in any port, and I think that this would be failing on any other port. 786780 1 178417 apinheiro 2012-12-09 07:36:52 -0800 Created attachment 178417 Fixes the bug The error was at AccessibilityListBoxOption, as it redefined isEnabled, and didn't take into account the DISABLED attribute. So this patch takes that into account, and for completeness sake, I also added a check for aria-disabled. I renamed the test, as this is a listbox specif thing, and also added aria-atribute checks. As you could have noticed, I also removed the [GTK] prefix at the summary and moved it to the Accessibility component. This is because taking into account the solution, this problem would be affecting any port. 786797 2 apinheiro 2012-12-09 08:39:14 -0800 Chris, could you please review this? As I said is a really easy patch. 787033 3 178417 cfleizach 2012-12-09 23:35:57 -0800 Comment on attachment 178417 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=178417&action=review It bugs me a bit that we're checking for aria_disabledAttr in two methods, but I see a bunch of different implementations that would make a common implementation a bit tricky and less glamorous to get right. I think if we continue to provide custom isEnabled implementations we should think about refactoring a bit, but I think this is OK in current form just a minor comment about the layout tests > LayoutTests/accessibility/listbox-enabled-states.html:35 > + shouldBeTrue('accessibilityController.focusedElement.childAtIndex(4).isEnabled'); you should also include the js-post test scripts so that we get the successfullyParsed messages > Source/WebCore/ChangeLog:3 > + Wrong Enabled states on a ListBox We should probably prefix the bug title with AX: * so that others know what this refers to 787148 4 178504 apinheiro 2012-12-10 03:08:52 -0800 Created attachment 178504 Fixes the bug (In reply to comment #3) > (From update of attachment 178417 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178417&action=review > > It bugs me a bit that we're checking for aria_disabledAttr in two methods, but I see a bunch of different implementations that would make a common implementation a bit tricky and less glamorous to get right. > I think if we continue to provide custom isEnabled implementations we should think about refactoring a bit, but I think this is OK in current form I agree. > just a minor comment about the layout tests > > > LayoutTests/accessibility/listbox-enabled-states.html:35 > > + shouldBeTrue('accessibilityController.focusedElement.childAtIndex(4).isEnabled'); > > you should also include the js-post test scripts so that we get the successfullyParsed messages Done. Note: I based this tests on a existing one, so the reasons I didn't notice this. Right now there are several tests that lack the js-post. Anyway not sure if a "cleaning task" it is worth or not. > > > Source/WebCore/ChangeLog:3 > > + Wrong Enabled states on a ListBox > > We should probably prefix the bug title with AX: * > so that others know what this refers to Done 787407 5 178504 webkit.review.bot 2012-12-10 09:31:23 -0800 Comment on attachment 178504 Fixes the bug Clearing flags on attachment: 178504 Committed r137168: <http://trac.webkit.org/changeset/137168> 787408 6 webkit.review.bot 2012-12-10 09:31:26 -0800 All reviewed patches have been landed. Closing bug. 178416 2012-12-09 05:55:38 -0800 2012-12-09 07:36:52 -0800 A layout test that should pass but it isn't 0001-This-test-should-pass.patch text/plain 2523 apinheiro RnJvbSA4N2JiODkyZWIwNTU1OTJkOTdjMDFhNmYyMzNlYWJkMDY2NzJhNGQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/QWxlamFuZHJvPTIwUGk9QzM9QjFlaXJvPz0g PGFwaW5oZWlyb0BpZ2FsaWEuY29tPgpEYXRlOiBTdW4sIDkgRGVjIDIwMTIgMTQ6MzM6MzMgKzAx MDAKU3ViamVjdDogW1BBVENIXSBUaGlzIHRlc3Qgc2hvdWxkIHBhc3MKCi0tLQogLi4uL2FjY2Vz c2liaWxpdHkvZW5hYmxlZC1zdGF0ZXMtZXhwZWN0ZWQudHh0ICAgICAgfCAgICA5ICsrKysrCiBM YXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2VuYWJsZWQtc3RhdGVzLmh0bWwgICAgICB8ICAgMzUg KysrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKQog Y3JlYXRlIG1vZGUgMTAwNjQ0IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZW5hYmxlZC1zdGF0 ZXMtZXhwZWN0ZWQudHh0CiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS9lbmFibGVkLXN0YXRlcy5odG1sCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYWNjZXNz aWJpbGl0eS9lbmFibGVkLXN0YXRlcy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9hY2Nlc3Np YmlsaXR5L2VuYWJsZWQtc3RhdGVzLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwLi42OTNkZjUzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvYWNj ZXNzaWJpbGl0eS9lbmFibGVkLXN0YXRlcy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw5IEBACisK K1RoaXMgdGVzdHMgdGhhdCB3ZSByZXBvcnQgdGhlIGNvcnJlY3QgZW5hYmxlZCBzdGF0ZSBvbiBh IGxpc3Rib3guCisKKworUEFTUyBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVu dC5pc0VuYWJsZWQgaXMgdHJ1ZQorUEFTUyBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2Vk RWxlbWVudC5jaGlsZEF0SW5kZXgoMCkuaXNFbmFibGVkIGlzIHRydWUKK1BBU1MgYWNjZXNzaWJp bGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQuY2hpbGRBdEluZGV4KDEpLmlzRW5hYmxlZCBp cyB0cnVlCitQQVNTIGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50LmNoaWxk QXRJbmRleCgyKS5pc0VuYWJsZWQgaXMgZmFsc2UKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv YWNjZXNzaWJpbGl0eS9lbmFibGVkLXN0YXRlcy5odG1sIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS9lbmFibGVkLXN0YXRlcy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAuLjhkZjhlOWYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5 L2VuYWJsZWQtc3RhdGVzLmh0bWwKQEAgLTAsMCArMSwzNSBAQAorPGh0bWw+Cis8aGVhZD4KKyAg ICA8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2Ny aXB0PgorPC9oZWFkPgorCis8Ym9keSBpZD0iYm9keSI+CisKKzxzZWxlY3QgaWQ9InNlbGVjdEVs ZW1lbnQiIG11bHRpcGxlIHRpdGxlPSJzZWxlY3RFbGVtZW50Ij4KKyAgICA8b3B0aW9uIFNFTEVD VEVEPk9wdGlvbiAxPC9vcHRpb24+CisgICAgPG9wdGlvbj5PcHRpb24gMjwvb3B0aW9uPgorICAg IDxvcHRpb24gRElTQUJMRUQ+T3B0aW9uIDM8L29wdGlvbj4KKzwvc2VsZWN0PgorCis8cD5UaGlz IHRlc3RzIHRoYXQgd2UgcmVwb3J0IHRoZSBjb3JyZWN0IGVuYWJsZWQgc3RhdGUgb24gYSBsaXN0 Ym94LjwvcD4KKworPHAgaWQ9Im5vdERSVCI+VGhpcyB0ZXN0IHNob3VsZCBvbmx5IGJlIHJ1biBp bnNpZGUgb2YgRHVtcFJlbmRlclRyZWUuPC9wPgorCis8cCBpZD0iY29uc29sZSI+PC9wPgorCis8 c2NyaXB0PgorICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lciAmJiB3aW5kb3cuYWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIpIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm5vdERSVCIp LnN0eWxlLnZpc2liaWxpdHkgPSAiaGlkZGVuIjsKKworICAgICAgICB0ZXN0UnVubmVyLmR1bXBB c1RleHQoKTsKKworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic2VsZWN0RWxlbWVu dCIpLmZvY3VzKCk7CisKKyAgICAgICAgc2hvdWxkQmVUcnVlKCdhY2Nlc3NpYmlsaXR5Q29udHJv bGxlci5mb2N1c2VkRWxlbWVudC5pc0VuYWJsZWQnKTsKKyAgICAgICAgc2hvdWxkQmVUcnVlKCdh Y2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudC5jaGlsZEF0SW5kZXgoMCkuaXNF bmFibGVkJyk7CisgICAgICAgIHNob3VsZEJlVHJ1ZSgnYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIu Zm9jdXNlZEVsZW1lbnQuY2hpbGRBdEluZGV4KDEpLmlzRW5hYmxlZCcpOworICAgICAgICBzaG91 bGRCZUZhbHNlKCdhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudC5jaGlsZEF0 SW5kZXgoMikuaXNFbmFibGVkJyk7CisgICAgfQorPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ Ci0tIAoxLjcuMTAuNAoK 178417 2012-12-09 07:36:52 -0800 2012-12-10 03:08:52 -0800 Fixes the bug 0001-Bug-104483.patch text/plain 5312 apinheiro RnJvbSAyY2E3NzYwZjc0MjZjZjM3NGFjYzRiODkzYzE2NDJlYzFmNGZiYzEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/QWxlamFuZHJvPTIwUGk9QzM9QjFlaXJvPz0g PGFwaW5oZWlyb0BpZ2FsaWEuY29tPgpEYXRlOiBTdW4sIDkgRGVjIDIwMTIgMTQ6MzM6MzMgKzAx MDAKU3ViamVjdDogW1BBVENIXSBCdWcgMTA0NDgzCgotLS0KIExheW91dFRlc3RzL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMCArKysrKwogLi4uL2xpc3Rib3gt ZW5hYmxlZC1zdGF0ZXMtZXhwZWN0ZWQudHh0ICAgICAgICAgICAgfCAgIDExICsrKysrKwogLi4u L2FjY2Vzc2liaWxpdHkvbGlzdGJveC1lbmFibGVkLXN0YXRlcy5odG1sICAgICAgfCAgIDM5ICsr KysrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKwogLi4uL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJp bGl0eUxpc3RCb3hPcHRpb24uY3BwICAgfCAgICA2ICsrKwogNSBmaWxlcyBjaGFuZ2VkLCA4MCBp bnNlcnRpb25zKCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0 eS9saXN0Ym94LWVuYWJsZWQtc3RhdGVzLWV4cGVjdGVkLnR4dAogY3JlYXRlIG1vZGUgMTAwNjQ0 IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbGlzdGJveC1lbmFibGVkLXN0YXRlcy5odG1sCgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IDk4ZmQwYmUuLmI5MjQwM2QgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0xMi0w OSAgQWxlamFuZHJvIFBpw7FlaXJvICA8YXBpbmhlaXJvQGlnYWxpYS5jb20+CisKKyAgICAgICAg V3JvbmcgRW5hYmxlZCBzdGF0ZXMgb24gYSBMaXN0Qm94CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ0ODMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbGlzdGJveC1lbmFibGVk LXN0YXRlcy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbGlz dGJveC1lbmFibGVkLXN0YXRlcy5odG1sOiBBZGRlZC4KKwogMjAxMi0xMi0wOCAgQWRhbSBLbGVp biAgPGFkYW1rQGNocm9taXVtLm9yZz4KIAogICAgICAgICBIVE1MVGVtcGxhdGVFbGVtZW50Lmlu bmVySFRNTCBzaG91bGQgYmUgcGFyc2VkIGludG8gdGhlIHRlbXBsYXRlIGNvbnRlbnRzIG93bmVy IGRvY3VtZW50CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2xpc3Rib3gt ZW5hYmxlZC1zdGF0ZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9s aXN0Ym94LWVuYWJsZWQtc3RhdGVzLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwLi5lZjI3NDg1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvYWNj ZXNzaWJpbGl0eS9saXN0Ym94LWVuYWJsZWQtc3RhdGVzLWV4cGVjdGVkLnR4dApAQCAtMCwwICsx LDExIEBACisKK1RoaXMgdGVzdHMgdGhhdCB3ZSByZXBvcnQgdGhlIGNvcnJlY3QgZW5hYmxlZCBz dGF0ZSBvbiBhIGxpc3Rib3guCisKKworUEFTUyBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1 c2VkRWxlbWVudC5pc0VuYWJsZWQgaXMgdHJ1ZQorUEFTUyBhY2Nlc3NpYmlsaXR5Q29udHJvbGxl ci5mb2N1c2VkRWxlbWVudC5jaGlsZEF0SW5kZXgoMCkuaXNFbmFibGVkIGlzIHRydWUKK1BBU1Mg YWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQuY2hpbGRBdEluZGV4KDEpLmlz RW5hYmxlZCBpcyB0cnVlCitQQVNTIGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVt ZW50LmNoaWxkQXRJbmRleCgyKS5pc0VuYWJsZWQgaXMgZmFsc2UKK1BBU1MgYWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQuY2hpbGRBdEluZGV4KDMpLmlzRW5hYmxlZCBpcyBm YWxzZQorUEFTUyBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudC5jaGlsZEF0 SW5kZXgoNCkuaXNFbmFibGVkIGlzIHRydWUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYWNj ZXNzaWJpbGl0eS9saXN0Ym94LWVuYWJsZWQtc3RhdGVzLmh0bWwgYi9MYXlvdXRUZXN0cy9hY2Nl c3NpYmlsaXR5L2xpc3Rib3gtZW5hYmxlZC1zdGF0ZXMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwLi5jNDIxYmNkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv YWNjZXNzaWJpbGl0eS9saXN0Ym94LWVuYWJsZWQtc3RhdGVzLmh0bWwKQEAgLTAsMCArMSwzOSBA QAorPGh0bWw+Cis8aGVhZD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJjZXMv anMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorCis8Ym9keSBpZD0iYm9keSI+CisK KzxzZWxlY3QgaWQ9InNlbGVjdEVsZW1lbnQiIG11bHRpcGxlIHRpdGxlPSJzZWxlY3RFbGVtZW50 Ij4KKyAgICA8b3B0aW9uIFNFTEVDVEVEPk9wdGlvbiAxPC9vcHRpb24+CisgICAgPG9wdGlvbj5P cHRpb24gMjwvb3B0aW9uPgorICAgIDxvcHRpb24gRElTQUJMRUQ+T3B0aW9uIDM8L29wdGlvbj4K KyAgICA8b3B0aW9uIGFyaWEtZGlzYWJsZWQ9InRydWUiPk9wdGlvbiA0PC9vcHRpb24+CisgICAg PG9wdGlvbiBhcmlhLWRpc2FibGVkPSJmYWxzZSI+T3B0aW9uIDU8L29wdGlvbj4KKzwvc2VsZWN0 PgorCis8cD5UaGlzIHRlc3RzIHRoYXQgd2UgcmVwb3J0IHRoZSBjb3JyZWN0IGVuYWJsZWQgc3Rh dGUgb24gYSBsaXN0Ym94LjwvcD4KKworPHAgaWQ9Im5vdERSVCI+VGhpcyB0ZXN0IHNob3VsZCBv bmx5IGJlIHJ1biBpbnNpZGUgb2YgRHVtcFJlbmRlclRyZWUuPC9wPgorCis8cCBpZD0iY29uc29s ZSI+PC9wPgorCis8c2NyaXB0PgorICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lciAmJiB3aW5kb3cu YWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoIm5vdERSVCIpLnN0eWxlLnZpc2liaWxpdHkgPSAiaGlkZGVuIjsKKworICAgICAgICB0ZXN0 UnVubmVyLmR1bXBBc1RleHQoKTsKKworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi c2VsZWN0RWxlbWVudCIpLmZvY3VzKCk7CisKKyAgICAgICAgc2hvdWxkQmVUcnVlKCdhY2Nlc3Np YmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudC5pc0VuYWJsZWQnKTsKKyAgICAgICAgc2hv dWxkQmVUcnVlKCdhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudC5jaGlsZEF0 SW5kZXgoMCkuaXNFbmFibGVkJyk7CisgICAgICAgIHNob3VsZEJlVHJ1ZSgnYWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQuY2hpbGRBdEluZGV4KDEpLmlzRW5hYmxlZCcpOwor ICAgICAgICBzaG91bGRCZUZhbHNlKCdhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxl bWVudC5jaGlsZEF0SW5kZXgoMikuaXNFbmFibGVkJyk7CisgICAgICAgIHNob3VsZEJlRmFsc2Uo J2FjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50LmNoaWxkQXRJbmRleCgzKS5p c0VuYWJsZWQnKTsKKyAgICAgICAgc2hvdWxkQmVUcnVlKCdhY2Nlc3NpYmlsaXR5Q29udHJvbGxl ci5mb2N1c2VkRWxlbWVudC5jaGlsZEF0SW5kZXgoNCkuaXNFbmFibGVkJyk7CisgICAgfQorPC9z Y3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGU0YTkwZi4uMTk1Mzc2ZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTA5ICBBbGVqYW5kcm8gUGnDsWVp cm8gIDxhcGluaGVpcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBXcm9uZyBFbmFibGVkIHN0YXRl cyBvbiBhIExpc3RCb3gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNDQ4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRlc3Q6IGFjY2Vzc2liaWxpdHkvbGlzdGJveC1lbmFibGVkLXN0YXRlcy5odG1sCisK KyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlMaXN0Qm94T3B0aW9uLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlMaXN0Qm94T3B0aW9uOjppc0VuYWJsZWQp OiB0YWtpbmcgaW50bworICAgICAgICBhY2NvdW50IHRoZSBESVNBQkxFRCBhdHRyaWJ1dGUgYW5k IHRoZSBhcmlhLWRpc2FibGVkIGF0dHJpYnV0ZSB0bworICAgICAgICBkZWNpZGUgaWYgdGhlIGl0 ZW0gaXMgZW5hYmxlZCBvciBub3QuCisKIDIwMTItMTItMDggIFBhdHJpY2sgR2Fuc3RlcmVyICA8 cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQnVpbGQgZml4IGZvciBFTkFCTEUoU1ZHKSAm JiAhRU5BQkxFKEZJTFRFUlMpIGFmdGVyIHIxMzY5NzUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlMaXN0Qm94T3B0aW9uLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eUxpc3RCb3hPcHRpb24uY3BwCmlu ZGV4IGU2NjY0OWEuLjNjNTYyNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eUxpc3RCb3hPcHRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eUxpc3RCb3hPcHRpb24uY3BwCkBAIC02OCw2ICs2 OCwxMiBAQCBib29sIEFjY2Vzc2liaWxpdHlMaXN0Qm94T3B0aW9uOjppc0VuYWJsZWQoKSBjb25z dAogICAgIAogICAgIGlmIChtX29wdGlvbkVsZW1lbnQtPmhhc1RhZ05hbWUob3B0Z3JvdXBUYWcp KQogICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoZXF1YWxJZ25vcmluZ0Nhc2UoZ2V0 QXR0cmlidXRlKGFyaWFfZGlzYWJsZWRBdHRyKSwgInRydWUiKSkKKyAgICAgICAgcmV0dXJuIGZh bHNlOworCisgICAgaWYgKG1fb3B0aW9uRWxlbWVudC0+aGFzQXR0cmlidXRlKGRpc2FibGVkQXR0 cikpCisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAKICAgICByZXR1cm4gdHJ1ZTsKIH0KLS0g CjEuNy4xMC40Cgo= 178504 2012-12-10 03:08:52 -0800 2012-12-10 09:31:23 -0800 Fixes the bug 0001-Bug-104483.patch text/plain 5435 apinheiro RnJvbSAwYjc1NThlNmQyMGJhMDMyYTI4NmJjMjdhMzIyYjgyMTA5ZGFhZDVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/QWxlamFuZHJvPTIwUGk9QzM9QjFlaXJvPz0g PGFwaW5oZWlyb0BpZ2FsaWEuY29tPgpEYXRlOiBTdW4sIDkgRGVjIDIwMTIgMTQ6MzM6MzMgKzAx MDAKU3ViamVjdDogW1BBVENIXSBCdWcgMTA0NDgzCgotLS0KIExheW91dFRlc3RzL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMCArKysrKwogLi4uL2xpc3Rib3gt ZW5hYmxlZC1zdGF0ZXMtZXhwZWN0ZWQudHh0ICAgICAgICAgICAgfCAgIDE0ICsrKysrKysKIC4u Li9hY2Nlc3NpYmlsaXR5L2xpc3Rib3gtZW5hYmxlZC1zdGF0ZXMuaHRtbCAgICAgIHwgICA0MSAr KysrKysrKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysKIC4uLi9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlMaXN0Qm94T3B0aW9uLmNwcCAgIHwgICAgNiArKysKIDUgZmlsZXMgY2hhbmdlZCwgODUg aW5zZXJ0aW9ucygrKQogY3JlYXRlIG1vZGUgMTAwNjQ0IExheW91dFRlc3RzL2FjY2Vzc2liaWxp dHkvbGlzdGJveC1lbmFibGVkLXN0YXRlcy1leHBlY3RlZC50eHQKIGNyZWF0ZSBtb2RlIDEwMDY0 NCBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2xpc3Rib3gtZW5hYmxlZC1zdGF0ZXMuaHRtbAoK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5OGZkMGJlLi41YTE3YmM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMTIt MDkgIEFsZWphbmRybyBQacOxZWlybyAgPGFwaW5oZWlyb0BpZ2FsaWEuY29tPgorCisgICAgICAg IEFYOiB3cm9uZyBFbmFibGVkIHN0YXRlcyBvbiBhIExpc3RCb3gKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDQ4MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9saXN0Ym94LWVu YWJsZWQtc3RhdGVzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogYWNjZXNzaWJpbGl0 eS9saXN0Ym94LWVuYWJsZWQtc3RhdGVzLmh0bWw6IEFkZGVkLgorCiAyMDEyLTEyLTA4ICBBZGFt IEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEhUTUxUZW1wbGF0ZUVsZW1l bnQuaW5uZXJIVE1MIHNob3VsZCBiZSBwYXJzZWQgaW50byB0aGUgdGVtcGxhdGUgY29udGVudHMg b3duZXIgZG9jdW1lbnQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbGlz dGJveC1lbmFibGVkLXN0YXRlcy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmls aXR5L2xpc3Rib3gtZW5hYmxlZC1zdGF0ZXMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAuLjRjYzZhZDgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9hY2Nlc3NpYmlsaXR5L2xpc3Rib3gtZW5hYmxlZC1zdGF0ZXMtZXhwZWN0ZWQudHh0CkBAIC0w LDAgKzEsMTQgQEAKKworVGhpcyB0ZXN0cyB0aGF0IHdlIHJlcG9ydCB0aGUgY29ycmVjdCBlbmFi bGVkIHN0YXRlIG9uIGEgbGlzdGJveC4KKworCitQQVNTIGFjY2Vzc2liaWxpdHlDb250cm9sbGVy LmZvY3VzZWRFbGVtZW50LmlzRW5hYmxlZCBpcyB0cnVlCitQQVNTIGFjY2Vzc2liaWxpdHlDb250 cm9sbGVyLmZvY3VzZWRFbGVtZW50LmNoaWxkQXRJbmRleCgwKS5pc0VuYWJsZWQgaXMgdHJ1ZQor UEFTUyBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudC5jaGlsZEF0SW5kZXgo MSkuaXNFbmFibGVkIGlzIHRydWUKK1BBU1MgYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNl ZEVsZW1lbnQuY2hpbGRBdEluZGV4KDIpLmlzRW5hYmxlZCBpcyBmYWxzZQorUEFTUyBhY2Nlc3Np YmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudC5jaGlsZEF0SW5kZXgoMykuaXNFbmFibGVk IGlzIGZhbHNlCitQQVNTIGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50LmNo aWxkQXRJbmRleCg0KS5pc0VuYWJsZWQgaXMgdHJ1ZQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQg aXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2FjY2Vz c2liaWxpdHkvbGlzdGJveC1lbmFibGVkLXN0YXRlcy5odG1sIGIvTGF5b3V0VGVzdHMvYWNjZXNz aWJpbGl0eS9saXN0Ym94LWVuYWJsZWQtc3RhdGVzLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMC4uY2E2NjRmMwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Fj Y2Vzc2liaWxpdHkvbGlzdGJveC1lbmFibGVkLXN0YXRlcy5odG1sCkBAIC0wLDAgKzEsNDEgQEAK KzxodG1sPgorPGhlYWQ+CisgICAgPHNjcmlwdCBzcmM9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pz LXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHkgaWQ9ImJvZHkiPgorCis8 c2VsZWN0IGlkPSJzZWxlY3RFbGVtZW50IiBtdWx0aXBsZSB0aXRsZT0ic2VsZWN0RWxlbWVudCI+ CisgICAgPG9wdGlvbiBTRUxFQ1RFRD5PcHRpb24gMTwvb3B0aW9uPgorICAgIDxvcHRpb24+T3B0 aW9uIDI8L29wdGlvbj4KKyAgICA8b3B0aW9uIERJU0FCTEVEPk9wdGlvbiAzPC9vcHRpb24+Cisg ICAgPG9wdGlvbiBhcmlhLWRpc2FibGVkPSJ0cnVlIj5PcHRpb24gNDwvb3B0aW9uPgorICAgIDxv cHRpb24gYXJpYS1kaXNhYmxlZD0iZmFsc2UiPk9wdGlvbiA1PC9vcHRpb24+Cis8L3NlbGVjdD4K KworPHA+VGhpcyB0ZXN0cyB0aGF0IHdlIHJlcG9ydCB0aGUgY29ycmVjdCBlbmFibGVkIHN0YXRl IG9uIGEgbGlzdGJveC48L3A+CisKKzxwIGlkPSJub3REUlQiPlRoaXMgdGVzdCBzaG91bGQgb25s eSBiZSBydW4gaW5zaWRlIG9mIER1bXBSZW5kZXJUcmVlLjwvcD4KKworPHAgaWQ9ImNvbnNvbGUi PjwvcD4KKworPHNjcmlwdD4KKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIgJiYgd2luZG93LmFj Y2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJub3REUlQiKS5zdHlsZS52aXNpYmlsaXR5ID0gImhpZGRlbiI7CisKKyAgICAgICAgdGVzdFJ1 bm5lci5kdW1wQXNUZXh0KCk7CisKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNl bGVjdEVsZW1lbnQiKS5mb2N1cygpOworCisgICAgICAgIHNob3VsZEJlVHJ1ZSgnYWNjZXNzaWJp bGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQuaXNFbmFibGVkJyk7CisgICAgICAgIHNob3Vs ZEJlVHJ1ZSgnYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQuY2hpbGRBdElu ZGV4KDApLmlzRW5hYmxlZCcpOworICAgICAgICBzaG91bGRCZVRydWUoJ2FjY2Vzc2liaWxpdHlD b250cm9sbGVyLmZvY3VzZWRFbGVtZW50LmNoaWxkQXRJbmRleCgxKS5pc0VuYWJsZWQnKTsKKyAg ICAgICAgc2hvdWxkQmVGYWxzZSgnYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1l bnQuY2hpbGRBdEluZGV4KDIpLmlzRW5hYmxlZCcpOworICAgICAgICBzaG91bGRCZUZhbHNlKCdh Y2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudC5jaGlsZEF0SW5kZXgoMykuaXNF bmFibGVkJyk7CisgICAgICAgIHNob3VsZEJlVHJ1ZSgnYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIu Zm9jdXNlZEVsZW1lbnQuY2hpbGRBdEluZGV4KDQpLmlzRW5hYmxlZCcpOworICAgIH0KKzwvc2Ny aXB0PgorCis8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0Lmpz Ij48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZTRhOTBmLi4xZDIz ZDRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTItMDkgIEFsZWphbmRybyBQ acOxZWlybyAgPGFwaW5oZWlyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIEFYOiB3cm9uZyBFbmFi bGVkIHN0YXRlcyBvbiBhIExpc3RCb3gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNDQ4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRlc3Q6IGFjY2Vzc2liaWxpdHkvbGlzdGJveC1lbmFibGVkLXN0YXRl cy5odG1sCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlMaXN0Qm94T3B0 aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlMaXN0Qm94T3B0aW9uOjpp c0VuYWJsZWQpOiB0YWtpbmcgaW50bworICAgICAgICBhY2NvdW50IHRoZSBESVNBQkxFRCBhdHRy aWJ1dGUgYW5kIHRoZSBhcmlhLWRpc2FibGVkIGF0dHJpYnV0ZSB0bworICAgICAgICBkZWNpZGUg aWYgdGhlIGl0ZW0gaXMgZW5hYmxlZCBvciBub3QuCisKIDIwMTItMTItMDggIFBhdHJpY2sgR2Fu c3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQnVpbGQgZml4IGZvciBFTkFC TEUoU1ZHKSAmJiAhRU5BQkxFKEZJTFRFUlMpIGFmdGVyIHIxMzY5NzUuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlMaXN0Qm94T3B0aW9uLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eUxpc3RCb3hPcHRp b24uY3BwCmluZGV4IGU2NjY0OWEuLjNjNTYyNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eUxpc3RCb3hPcHRpb24uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eUxpc3RCb3hPcHRpb24uY3BwCkBA IC02OCw2ICs2OCwxMiBAQCBib29sIEFjY2Vzc2liaWxpdHlMaXN0Qm94T3B0aW9uOjppc0VuYWJs ZWQoKSBjb25zdAogICAgIAogICAgIGlmIChtX29wdGlvbkVsZW1lbnQtPmhhc1RhZ05hbWUob3B0 Z3JvdXBUYWcpKQogICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoZXF1YWxJZ25vcmlu Z0Nhc2UoZ2V0QXR0cmlidXRlKGFyaWFfZGlzYWJsZWRBdHRyKSwgInRydWUiKSkKKyAgICAgICAg cmV0dXJuIGZhbHNlOworCisgICAgaWYgKG1fb3B0aW9uRWxlbWVudC0+aGFzQXR0cmlidXRlKGRp c2FibGVkQXR0cikpCisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAKICAgICByZXR1cm4gdHJ1 ZTsKIH0KLS0gCjEuNy4xMC40Cgo=