104447 2012-12-08 10:48:40 -0800 [BlackBerry] Enforce selection of last work when triggering caret based selection 2012-12-08 12:35:53 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 786555 0 mifenton 2012-12-08 10:48:40 -0800 When the next node is selectable but none text, triggering a selection at the end will match the selectable adjacent node rather than the previous text. Since we want the previous text, adjust the caret accordingly. 786559 1 178367 mifenton 2012-12-08 11:12:53 -0800 Created attachment 178367 Patch 786565 2 178367 rwlbuis 2012-12-08 11:39:13 -0800 Comment on attachment 178367 Patch LGTM. 786580 3 178367 webkit.review.bot 2012-12-08 12:35:50 -0800 Comment on attachment 178367 Patch Clearing flags on attachment: 178367 Committed r137046: <http://trac.webkit.org/changeset/137046> 786581 4 webkit.review.bot 2012-12-08 12:35:53 -0800 All reviewed patches have been landed. Closing bug. 178367 2012-12-08 11:12:53 -0800 2012-12-08 12:35:50 -0800 Patch 0001-2012-12-08-Mike-Fenton-mifenton-rim.com.patch text/plain 4479 mifenton RnJvbSA2OWRkNzA2M2FjOTg1NTk1NDhkYjNhMDQ1MjA0OTk1OTAxYTY3YmZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog U2F0LCA4IERlYyAyMDEyIDEzOjM2OjQ5IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMi0xMi0w OCAgTWlrZSBGZW50b24gIDxtaWZlbnRvbkByaW0uY29tPgoKICAgICAgICBQUiAyNDkyMjUuCgog ICAgICAgIFdoZW4gdGhlIHNlbGVjdGlvbiBoYXMgcmVhY2hlZCB0aGUgZW5kIG9mIGFuIGlucHV0 IGZpZWxkLAogICAgICAgIGVuc3VyZSB0aGUgbGFzdCB3b3JkIGlzIHNlbGVjdGVkIGJ5IGFkanVz dGluZyB0aGUgY2FyZXQuCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAg ICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKICAgICAgICAoQmxhY2tCZXJy eTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6OnNldEJhdGNoRWRpdGluZ0FjdGl2ZSk6CiAgICAgICAg KiBXZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5oOgogICAgICAgIChJbnB1dEhhbmRsZXIpOgog ICAgICAgICogV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcDoKICAgICAgICAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVyOjpzZWxlY3RPYmplY3QpOgotLS0KIFNv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAyMiAr KysrKysrKysrKysrKysrKysrKwogLi4uL2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhh bmRsZXIuY3BwICAgICAgfCAgICA1ICsrKysrCiAuLi4vV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9JbnB1dEhhbmRsZXIuaCB8ICAgIDIgKysKIC4uLi9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAgIHwgICAxMSArKysrKysrKy0tCiA0IGZpbGVzIGNo YW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9DaGFuZ2VMb2cKaW5kZXggMzk1ZjVhYS4uM2UwNGI0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTItMTItMDggIE1pa2UgRmVudG9uICA8bWlm ZW50b25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRW5mb3JjZSBzZWxlY3Rpb24g b2YgbGFzdCB3b3JrIHdoZW4gdHJpZ2dlcmluZyBjYXJldCBiYXNlZCBzZWxlY3Rpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDQ0NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBSIDI0OTIyNS4KKwor ICAgICAgICBXaGVuIHRoZSBzZWxlY3Rpb24gaGFzIHJlYWNoZWQgdGhlIGVuZCBvZiBhbiBpbnB1 dCBmaWVsZCwKKyAgICAgICAgZW5zdXJlIHRoZSBsYXN0IHdvcmQgaXMgc2VsZWN0ZWQgYnkgYWRq dXN0aW5nIHRoZSBjYXJldC4KKworICAgICAgICBSZXZpZXdlZCBJbnRlcm5hbGx5IGJ5IEdlbiBN YWsuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHA6CisgICAgICAg IChCbGFja0JlcnJ5OjpXZWJLaXQ6OklucHV0SGFuZGxlcjo6aXNDYXJldEF0RW5kT2ZUZXh0KToK KyAgICAgICAgKFdlYktpdCk6CisgICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIu aDoKKyAgICAgICAgKElucHV0SGFuZGxlcik6CisgICAgICAgICogV2ViS2l0U3VwcG9ydC9TZWxl Y3Rpb25IYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6U2VsZWN0aW9u SGFuZGxlcjo6c2VsZWN0T2JqZWN0KToKKwogMjAxMi0xMi0wOCAgQ2hyaXMgSHV0dGVuLUN6YXBz a2kgIDxjaHV0dGVuQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFJlbW92ZSBhYm91 dDpjcmVkaXRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3Vw cG9ydC9JbnB1dEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAppbmRleCAyYmFiYTNiLi4yNmE5YzkwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxl ci5jcHAKQEAgLTE4NjQsNiArMTg2NCwxMSBAQCBib29sIElucHV0SGFuZGxlcjo6c2V0QmF0Y2hF ZGl0aW5nQWN0aXZlKGJvb2wgYWN0aXZlKQogICAgIHJldHVybiB0cnVlOwogfQogCitib29sIElu cHV0SGFuZGxlcjo6aXNDYXJldEF0RW5kT2ZUZXh0KCkKK3sKKyAgICByZXR1cm4gY2FyZXRQb3Np dGlvbigpID09IGVsZW1lbnRUZXh0KCkubGVuZ3RoKCk7Cit9CisKIGludCBJbnB1dEhhbmRsZXI6 OmNhcmV0UG9zaXRpb24oKSBjb25zdAogewogICAgIGlmICghaXNBY3RpdmVUZXh0RWRpdCgpKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRI YW5kbGVyLmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhh bmRsZXIuaAppbmRleCAyOTAzOGJlLi4zZDhkMGEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuaApAQCAtMTIxLDYgKzEy MSw4IEBAIHB1YmxpYzoKIAogICAgIFdlYkNvcmU6OkludFJlY3QgYm91bmRpbmdCb3hGb3JJbnB1 dEZpZWxkKCk7CiAKKyAgICBib29sIGlzQ2FyZXRBdEVuZE9mVGV4dCgpOworCiAgICAgLy8gSU1G IGRyaXZlbiBjYWxscy4KICAgICBib29sIHNldEJhdGNoRWRpdGluZ0FjdGl2ZShib29sKTsKICAg ICBib29sIHNldFNlbGVjdGlvbihpbnQgc3RhcnQsIGludCBlbmQsIGJvb2wgY2hhbmdlSXNQYXJ0 T2ZDb21wb3NpdGlvbiA9IGZhbHNlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKaW5kZXggYmIwMGVm Yy4uYWFiZGE3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKQEAgLTY1NCw5ICs2NTQsMTYgQEAg dm9pZCBTZWxlY3Rpb25IYW5kbGVyOjpzZWxlY3RPYmplY3QoVGV4dEdyYW51bGFyaXR5IGdyYW51 bGFyaXR5KQogCiAgICAgU2VsZWN0aW9uTG9nKExvZ0xldmVsSW5mbywgIlNlbGVjdGlvbkhhbmRs ZXI6OnNlbGVjdE9iamVjdCB1c2luZyBjdXJyZW50IHNlbGVjdGlvbiIpOwogCi0gICAgLy8gVXNl IHRoZSBjdXJyZW50IHNlbGVjdGlvbiBhcyB0aGUgc2VsZWN0aW9uIHBvaW50LgogICAgIEFTU0VS VChmb2N1c2VkRnJhbWUtPnNlbGVjdGlvbigpLT5zZWxlY3Rpb25UeXBlKCkgIT0gVmlzaWJsZVNl bGVjdGlvbjo6Tm9TZWxlY3Rpb24pOwotICAgIG1fc2VsZWN0aW9uQWN0aXZlID0gZXhwYW5kU2Vs ZWN0aW9uVG9HcmFudWxhcml0eShmb2N1c2VkRnJhbWUsIGZvY3VzZWRGcmFtZS0+c2VsZWN0aW9u KCktPnNlbGVjdGlvbigpLCBncmFudWxhcml0eSwgdHJ1ZSAvKiBpc0lucHV0TW9kZSAqLyk7CisK KyAgICAvLyBVc2UgdGhlIGN1cnJlbnQgc2VsZWN0aW9uIGFzIHRoZSBzZWxlY3Rpb24gcG9pbnQu CisgICAgVmlzaWJsZVNlbGVjdGlvbiBzZWxlY3Rpb25PcmlnaW4gPSBmb2N1c2VkRnJhbWUtPnNl bGVjdGlvbigpLT5zZWxlY3Rpb24oKTsKKworICAgIC8vIElmIHRoaXMgaXMgdGhlIGVuZCBvZiB0 aGUgaW5wdXQgZmllbGQsIG1ha2Ugc3VyZSB3ZSBzZWxlY3QgdGhlIGxhc3Qgd29yZC4KKyAgICBp ZiAobV93ZWJQYWdlLT5tX2lucHV0SGFuZGxlci0+aXNDYXJldEF0RW5kT2ZUZXh0KCkpCisgICAg ICAgIHNlbGVjdGlvbk9yaWdpbiA9IHByZXZpb3VzV29yZFBvc2l0aW9uKHNlbGVjdGlvbk9yaWdp bi5zdGFydCgpKTsKKworICAgIG1fc2VsZWN0aW9uQWN0aXZlID0gZXhwYW5kU2VsZWN0aW9uVG9H cmFudWxhcml0eShmb2N1c2VkRnJhbWUsIHNlbGVjdGlvbk9yaWdpbiwgZ3JhbnVsYXJpdHksIHRy dWUgLyogaXNJbnB1dE1vZGUgKi8pOwogfQogCiB2b2lkIFNlbGVjdGlvbkhhbmRsZXI6OnNlbGVj dE9iamVjdChOb2RlKiBub2RlKQotLSAKMS43LjkuNQoK