104440 2012-12-08 08:12:19 -0800 Web Inspector: follow up to r136974: do not process shortcuts while editing 2012-12-11 04:46:17 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 786510 0 pfeldman 2012-12-08 08:12:19 -0800 Currently, typing H while editing node results in corresponding shortcut processing. 786511 1 178356 pfeldman 2012-12-08 08:13:59 -0800 Created attachment 178356 Patch 788326 2 178356 webkit.review.bot 2012-12-11 04:46:13 -0800 Comment on attachment 178356 Patch Clearing flags on attachment: 178356 Committed r137292: <http://trac.webkit.org/changeset/137292> 788327 3 webkit.review.bot 2012-12-11 04:46:17 -0800 All reviewed patches have been landed. Closing bug. 178356 2012-12-08 08:13:59 -0800 2012-12-11 04:46:13 -0800 Patch bug-104440-20121208201122.patch text/plain 4645 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmZlODA5Yzk4OTIyNzAy Y2U2MjQyMjAyZjZhYWI0ZDg0MmZhMzkyYy4uODE2NmJkOWU4ZmM3MGE3MDdkZGRjMjgxYmYwZjZl MzU4ZTVmNjdmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTA4ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGZvbGxvdyB1cCB0byByMTM2OTc0OiBkbyBub3QgcHJvY2VzcyBzaG9ydGN1dHMgd2hpbGUg ZWRpdGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA0NDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q3VycmVudGx5LCB0eXBpbmcgSCB3aGlsZSBlZGl0aW5nIG5vZGUgcmVzdWx0cyBpbiBjb3JyZXNw b25kaW5nIHNob3J0Y3V0IHByb2Nlc3NpbmcuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQt ZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVu dHNUcmVlT3V0bGluZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlT3V0bGlu ZS5wcm90b3R5cGUuaGFuZGxlU2hvcnRjdXQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1l bnRzVHJlZUVsZW1lbnQucHJvdG90eXBlLm9uZW50ZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlLl9zdGFydEVkaXRpbmdBdHRyaWJ1dGUpOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlLmRpc3Bv c2UpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBl Ll9zdGFydEVkaXRpbmdBc0hUTUwpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJl ZUVsZW1lbnQucHJvdG90eXBlLl9lZGl0aW5nQ2FuY2VsbGVkKToKKwogMjAxMi0xMi0wNyAgU3Rl cGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDU1MgdXJs KCkgZmlsdGVycyB3aXRoIGZvcndhcmQgcmVmZXJlbmNlcyBkb24ndCB3b3JrCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUu anMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxp bmUuanMKaW5kZXggZmU3MTU5MDlmOWJiODI4OTViNWJiZmI4OWZhMjhmZjY1NTYwMGZjNC4uOTA5 ZDA5ZDRlYzg4NTE0ZTExZTI5ZjMzMmRjOWU0ZjUyY2VkODFmOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCisrKyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5q cwpAQCAtNTcsNyArNTcsNiBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlT3V0bGluZSA9IGZ1 bmN0aW9uKG9taXRSb290RE9NTm9kZSwgc2VsZWN0RW5hYmxlZCwgc2hvdwogICAgIHRoaXMuX3Jv b3RET01Ob2RlID0gbnVsbDsKICAgICB0aGlzLl9zZWxlY3RET01Ob2RlID0gbnVsbDsKICAgICB0 aGlzLl9ldmVudFN1cHBvcnQgPSBuZXcgV2ViSW5zcGVjdG9yLk9iamVjdCgpOwotICAgIHRoaXMu X2VkaXRpbmcgPSBmYWxzZTsKIAogICAgIHRoaXMuX3Zpc2libGUgPSBmYWxzZTsKIApAQCAtMTY2 LDExICsxNjUsNiBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlT3V0bGluZS5wcm90b3R5cGUg PSB7CiAgICAgICAgICAgICB0aGlzLl9zZWxlY3RlZE5vZGVDaGFuZ2VkKCk7CiAgICAgfSwKIAot ICAgIGdldCBlZGl0aW5nKCkKLSAgICB7Ci0gICAgICAgIHJldHVybiB0aGlzLl9lZGl0aW5nOwot ICAgIH0sCi0KICAgICB1cGRhdGU6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIHZhciBzZWxl Y3RlZE5vZGUgPSB0aGlzLnNlbGVjdGVkVHJlZUVsZW1lbnQgPyB0aGlzLnNlbGVjdGVkVHJlZUVs ZW1lbnQucmVwcmVzZW50ZWRPYmplY3QgOiBudWxsOwpAQCAtNTU5LDcgKzU1Myw3IEBAIFdlYklu c3BlY3Rvci5FbGVtZW50c1RyZWVPdXRsaW5lLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIH0K ICAgICAgICAgfQogCi0gICAgICAgIGlmIChldmVudC5rZXlDb2RlID09PSBXZWJJbnNwZWN0b3Iu S2V5Ym9hcmRTaG9ydGN1dC5LZXlzLkguY29kZSkgeworICAgICAgICBpZiAoIXRyZWVFbGVtZW50 Ll9lZGl0aW5nICYmIGV2ZW50LmtleUNvZGUgPT09IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0 Y3V0LktleXMuSC5jb2RlKSB7CiAgICAgICAgICAgICBXZWJJbnNwZWN0b3IuY3NzTW9kZWwudG9n Z2xlSW5saW5lVmlzaWJpbGl0eShub2RlLmlkKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgfQpAQCAtMTA4OCw3ICsxMDgyLDcgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1l bnQucHJvdG90eXBlID0gewogICAgIHsKICAgICAgICAgLy8gT24gRW50ZXIgb3IgUmV0dXJuIHN0 YXJ0IGVkaXRpbmcgdGhlIGZpcnN0IGF0dHJpYnV0ZQogICAgICAgICAvLyBvciBjcmVhdGUgYSBu ZXcgYXR0cmlidXRlIG9uIHRoZSBzZWxlY3RlZCBlbGVtZW50LgotICAgICAgICBpZiAodGhpcy50 cmVlT3V0bGluZS5lZGl0aW5nKQorICAgICAgICBpZiAodGhpcy5fZWRpdGluZykKICAgICAgICAg ICAgIHJldHVybiBmYWxzZTsKIAogICAgICAgICB0aGlzLl9zdGFydEVkaXRpbmcoKTsKQEAgLTEz MTksNyArMTMxMyw3IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50LnByb3RvdHlw ZSA9IHsKICAgICAgICAgfQogCiAgICAgICAgIGNvbmZpZy5jdXN0b21GaW5pc2hIYW5kbGVyID0g aGFuZGxlS2V5RG93bkV2ZW50cy5iaW5kKHRoaXMpOwotICAgICAgICAKKwogICAgICAgICB0aGlz Ll9lZGl0aW5nID0gV2ViSW5zcGVjdG9yLnN0YXJ0RWRpdGluZyhhdHRyaWJ1dGUsIGNvbmZpZyk7 CiAKICAgICAgICAgd2luZG93LmdldFNlbGVjdGlvbigpLnNldEJhc2VBbmRFeHRlbnQoZWxlbWVu dEZvclNlbGVjdGlvbiwgMCwgZWxlbWVudEZvclNlbGVjdGlvbiwgMSk7CkBAIC0xNDM5LDcgKzE0 MzMsNyBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAK ICAgICAgICAgZnVuY3Rpb24gZGlzcG9zZSgpCiAgICAgICAgIHsKLSAgICAgICAgICAgIHRoaXMu X2VkaXRpbmcgPSBmYWxzZTsKKyAgICAgICAgICAgIGRlbGV0ZSB0aGlzLl9lZGl0aW5nOwogCiAg ICAgICAgICAgICAvLyBSZW1vdmUgZWRpdG9yLgogICAgICAgICAgICAgdGhpcy5saXN0SXRlbUVs ZW1lbnQucmVtb3ZlQ2hpbGQodGhpcy5faHRtbEVkaXRFbGVtZW50KTsKQEAgLTE0NjUsNyArMTQ1 OSw3IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKIAog ICAgIF9hdHRyaWJ1dGVFZGl0aW5nQ29tbWl0dGVkOiBmdW5jdGlvbihlbGVtZW50LCBuZXdUZXh0 LCBvbGRUZXh0LCBhdHRyaWJ1dGVOYW1lLCBtb3ZlRGlyZWN0aW9uKQogICAgIHsKLSAgICAgICAg dGhpcy5fZWRpdGluZyA9IGZhbHNlOworICAgICAgICBkZWxldGUgdGhpcy5fZWRpdGluZzsKIAog ICAgICAgICB2YXIgdHJlZU91dGxpbmUgPSB0aGlzLnRyZWVPdXRsaW5lOwogICAgICAgICAvKioK QEAgLTE1MjgsNyArMTUyMiw3IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50LnBy b3RvdHlwZSA9IHsKIAogICAgIF90YWdOYW1lRWRpdGluZ0NvbW1pdHRlZDogZnVuY3Rpb24oZWxl bWVudCwgbmV3VGV4dCwgb2xkVGV4dCwgdGFnTmFtZSwgbW92ZURpcmVjdGlvbikKICAgICB7Ci0g ICAgICAgIHRoaXMuX2VkaXRpbmcgPSBmYWxzZTsKKyAgICAgICAgZGVsZXRlIHRoaXMuX2VkaXRp bmc7CiAgICAgICAgIHZhciBzZWxmID0gdGhpczsKIAogICAgICAgICBmdW5jdGlvbiBjYW5jZWwo KQpAQCAtMTU4NCw3ICsxNTc4LDcgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQu cHJvdG90eXBlID0gewogICAgICAqLwogICAgIF90ZXh0Tm9kZUVkaXRpbmdDb21taXR0ZWQ6IGZ1 bmN0aW9uKHRleHROb2RlLCBlbGVtZW50LCBuZXdUZXh0KQogICAgIHsKLSAgICAgICAgdGhpcy5f ZWRpdGluZyA9IGZhbHNlOworICAgICAgICBkZWxldGUgdGhpcy5fZWRpdGluZzsKIAogICAgICAg ICBmdW5jdGlvbiBjYWxsYmFjaygpCiAgICAgICAgIHsKQEAgLTE1OTksNyArMTU5Myw3IEBAIFdl Ykluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgKi8KICAg ICBfZWRpdGluZ0NhbmNlbGxlZDogZnVuY3Rpb24oZWxlbWVudCwgY29udGV4dCkKICAgICB7Ci0g ICAgICAgIHRoaXMuX2VkaXRpbmcgPSBmYWxzZTsKKyAgICAgICAgZGVsZXRlIHRoaXMuX2VkaXRp bmc7CiAKICAgICAgICAgLy8gTmVlZCB0byByZXN0b3JlIGF0dHJpYnV0ZXMgc3RydWN0dXJlLgog ICAgICAgICB0aGlzLnVwZGF0ZVRpdGxlKCk7Cg==