104426 2012-12-07 18:45:49 -0800 GC3Dintptr and GC3Dsizeiptr typedefs incorrect for Win64 2012-12-10 03:30:49 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 net147 webkit-unassigned dglazkov hausmann peter+ews webkit.review.bot oldest_to_newest 786356 0 net147 2012-12-07 18:45:49 -0800 The GC3Dintptr and GC3Dsizeiptr typedefs in Source/WebCore/platform/graphics/GraphicsTypes3D.h are incorrect for Win64 as LLP64 is used there. This would result in compile error due to narrowing conversion of 64-bit pointer to signed long int which is 32-bit. 786358 1 178323 net147 2012-12-07 18:50:19 -0800 Created attachment 178323 Patch 786369 2 178323 buildbot 2012-12-07 19:07:51 -0800 Comment on attachment 178323 Patch Attachment 178323 did not pass win-ews (win): Output: http://queues.webkit.org/results/15189527 786373 3 178323 peter+ews 2012-12-07 19:22:59 -0800 Comment on attachment 178323 Patch Attachment 178323 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15189528 786376 4 178326 net147 2012-12-07 19:29:05 -0800 Created attachment 178326 Patch 786387 5 178329 net147 2012-12-07 19:51:39 -0800 Created attachment 178329 Patch 787152 6 hausmann 2012-12-10 03:18:03 -0800 For reference, this is a bug in the Khronos headers, where this definition comes from. The bug is also tracked upstream at https://www.khronos.org/bugzilla/show_bug.cgi?id=525 787158 7 178329 webkit.review.bot 2012-12-10 03:30:45 -0800 Comment on attachment 178329 Patch Clearing flags on attachment: 178329 Committed r137129: <http://trac.webkit.org/changeset/137129> 787159 8 webkit.review.bot 2012-12-10 03:30:49 -0800 All reviewed patches have been landed. Closing bug. 178323 2012-12-07 18:50:19 -0800 2012-12-07 19:29:05 -0800 Patch bug-104426.patch text/plain 1405 net147 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzAwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTA3ICBKb25hdGhh biBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAgICAgIEZpeCBHQzNEaW50cHRyIGFuZCBH QzNEc2l6ZWlwdHIgdHlwZWRlZnMgZm9yIFdpbjY0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ0MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgR0MzRGludHB0ciBhbmQgR0MzRHNpemVpcHRyIHR5 cGVkZWZzIGFyZSBpbmNvcnJlY3QgZm9yIFdpbjY0IGFzCisgICAgICAgIExMUDY0IGlzIHVzZWQg dGhlcmUuIFRoaXMgd291bGQgcmVzdWx0IGluIGNvbXBpbGUgZXJyb3IgZHVlIHRvCisgICAgICAg IG5hcnJvd2luZyBjb252ZXJzaW9uIG9mIDY0LWJpdCBwb2ludGVyIHRvIHNpZ25lZCBsb25nIGlu dCB3aGljaCBpcworICAgICAgICAzMi1iaXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9HcmFwaGljc1R5cGVzM0QuaDoKKwogMjAxMi0xMi0wNyAgQWxleGlzIE1lbmFyZCAgPGFsZXhp c0B3ZWJraXQub3JnPgogCiAgICAgICAgIEVuYWJsZSBDU1MzIHBvc2l0aW9uIG9mZnNldCBmb3Ig Q1NTIE1hc2tpbmcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFw aGljc1R5cGVzM0QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9HcmFwaGljc1R5cGVzM0QuaAkocmV2aXNpb24gMTM2OTQ4KQorKysgU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NUeXBlczNELmgJKHdvcmtpbmcgY29weSkKQEAg LTQyLDggKzQyLDggQEAgdHlwZWRlZiBpbnQgR0MzRHNpemVpOwogdHlwZWRlZiB1bnNpZ25lZCBp bnQgR0MzRHVpbnQ7CiB0eXBlZGVmIGZsb2F0IEdDM0RmbG9hdDsKIHR5cGVkZWYgZmxvYXQgR0Mz RGNsYW1wZjsKLXR5cGVkZWYgc2lnbmVkIGxvbmcgaW50IEdDM0RpbnRwdHI7Ci10eXBlZGVmIHNp Z25lZCBsb25nIGludCBHQzNEc2l6ZWlwdHI7Cit0eXBlZGVmIGludHB0cl90IEdDM0RpbnRwdHI7 Cit0eXBlZGVmIHNzaXplX3QgR0MzRHNpemVpcHRyOwogdHlwZWRlZiBjaGFyIEdDM0RjaGFyOwog CiB0eXBlZGVmIEdDM0R1aW50IFBsYXRmb3JtM0RPYmplY3Q7Cg== 178326 2012-12-07 19:29:05 -0800 2012-12-07 19:51:39 -0800 Patch bug-104426.patch text/plain 1460 net147 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzAwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTA3ICBKb25hdGhh biBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAgICAgIEZpeCBHQzNEaW50cHRyIGFuZCBH QzNEc2l6ZWlwdHIgdHlwZWRlZnMgZm9yIFdpbjY0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ0MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgR0MzRGludHB0ciBhbmQgR0MzRHNpemVpcHRyIHR5 cGVkZWZzIGFyZSBpbmNvcnJlY3QgZm9yIFdpbjY0IGFzCisgICAgICAgIExMUDY0IGlzIHVzZWQg dGhlcmUuIFRoaXMgd291bGQgcmVzdWx0IGluIGNvbXBpbGUgZXJyb3IgZHVlIHRvCisgICAgICAg IG5hcnJvd2luZyBjb252ZXJzaW9uIG9mIDY0LWJpdCBwb2ludGVyIHRvIHNpZ25lZCBsb25nIGlu dCB3aGljaCBpcworICAgICAgICAzMi1iaXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9HcmFwaGljc1R5cGVzM0QuaDoKKwogMjAxMi0xMi0wNyAgQWxleGlzIE1lbmFyZCAgPGFsZXhp c0B3ZWJraXQub3JnPgogCiAgICAgICAgIEVuYWJsZSBDU1MzIHBvc2l0aW9uIG9mZnNldCBmb3Ig Q1NTIE1hc2tpbmcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFw aGljc1R5cGVzM0QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9HcmFwaGljc1R5cGVzM0QuaAkocmV2aXNpb24gMTM2OTQ4KQorKysgU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NUeXBlczNELmgJKHdvcmtpbmcgY29weSkKQEAg LTQyLDggKzQyLDEzIEBAIHR5cGVkZWYgaW50IEdDM0RzaXplaTsKIHR5cGVkZWYgdW5zaWduZWQg aW50IEdDM0R1aW50OwogdHlwZWRlZiBmbG9hdCBHQzNEZmxvYXQ7CiB0eXBlZGVmIGZsb2F0IEdD M0RjbGFtcGY7CisjaWZkZWYgV0lONjQKK3R5cGVkZWYgc2lnbmVkIGxvbmcgbG9uZyBpbnQgR0Mz RGludHB0cjsKK3R5cGVkZWYgc2lnbmVkIGxvbmcgbG9uZyBpbnQgR0MzRHNpemVpcHRyOworI2Vs c2UKIHR5cGVkZWYgc2lnbmVkIGxvbmcgaW50IEdDM0RpbnRwdHI7CiB0eXBlZGVmIHNpZ25lZCBs b25nIGludCBHQzNEc2l6ZWlwdHI7CisjZW5kaWYKIHR5cGVkZWYgY2hhciBHQzNEY2hhcjsKIAog dHlwZWRlZiBHQzNEdWludCBQbGF0Zm9ybTNET2JqZWN0Owo= 178329 2012-12-07 19:51:39 -0800 2012-12-10 03:30:45 -0800 Patch bug-104426.patch text/plain 1406 net147 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzAwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTA3ICBKb25hdGhh biBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAgICAgIEZpeCBHQzNEaW50cHRyIGFuZCBH QzNEc2l6ZWlwdHIgdHlwZWRlZnMgZm9yIFdpbjY0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ0MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgR0MzRGludHB0ciBhbmQgR0MzRHNpemVpcHRyIHR5 cGVkZWZzIGFyZSBpbmNvcnJlY3QgZm9yIFdpbjY0IGFzCisgICAgICAgIExMUDY0IGlzIHVzZWQg dGhlcmUuIFRoaXMgd291bGQgcmVzdWx0IGluIGNvbXBpbGUgZXJyb3IgZHVlIHRvCisgICAgICAg IG5hcnJvd2luZyBjb252ZXJzaW9uIG9mIDY0LWJpdCBwb2ludGVyIHRvIHNpZ25lZCBsb25nIGlu dCB3aGljaCBpcworICAgICAgICAzMi1iaXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9HcmFwaGljc1R5cGVzM0QuaDoKKwogMjAxMi0xMi0wNyAgQWxleGlzIE1lbmFyZCAgPGFsZXhp c0B3ZWJraXQub3JnPgogCiAgICAgICAgIEVuYWJsZSBDU1MzIHBvc2l0aW9uIG9mZnNldCBmb3Ig Q1NTIE1hc2tpbmcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFw aGljc1R5cGVzM0QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9HcmFwaGljc1R5cGVzM0QuaAkocmV2aXNpb24gMTM2OTQ4KQorKysgU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NUeXBlczNELmgJKHdvcmtpbmcgY29weSkKQEAg LTQyLDggKzQyLDggQEAgdHlwZWRlZiBpbnQgR0MzRHNpemVpOwogdHlwZWRlZiB1bnNpZ25lZCBp bnQgR0MzRHVpbnQ7CiB0eXBlZGVmIGZsb2F0IEdDM0RmbG9hdDsKIHR5cGVkZWYgZmxvYXQgR0Mz RGNsYW1wZjsKLXR5cGVkZWYgc2lnbmVkIGxvbmcgaW50IEdDM0RpbnRwdHI7Ci10eXBlZGVmIHNp Z25lZCBsb25nIGludCBHQzNEc2l6ZWlwdHI7Cit0eXBlZGVmIGludHB0cl90IEdDM0RpbnRwdHI7 Cit0eXBlZGVmIGludHB0cl90IEdDM0RzaXplaXB0cjsKIHR5cGVkZWYgY2hhciBHQzNEY2hhcjsK IAogdHlwZWRlZiBHQzNEdWludCBQbGF0Zm9ybTNET2JqZWN0Owo=