104424 2012-12-07 18:26:06 -0800 JSC::CodeBlock::getJITType() missing const qualifier when JIT disabled 2012-12-07 19:55:54 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 net147 webkit-unassigned hausmann webkit.review.bot oldest_to_newest 786342 0 net147 2012-12-07 18:26:06 -0800 If JIT is enabled, JSC::CodeBlock::getJITType() has the const qualifier. If JIT is disabled, JSC::CodeBlock::getJITType() does not have the const qualifier. JSC::CodeBlock::getJITType() should have the const qualifier in both cases. 786347 1 178320 net147 2012-12-07 18:31:41 -0800 Created attachment 178320 Patch 786357 2 178320 laszlo.gombos 2012-12-07 18:48:14 -0800 Comment on attachment 178320 Patch lgtm. 786389 3 178320 webkit.review.bot 2012-12-07 19:55:51 -0800 Comment on attachment 178320 Patch Clearing flags on attachment: 178320 Committed r137010: <http://trac.webkit.org/changeset/137010> 786390 4 webkit.review.bot 2012-12-07 19:55:54 -0800 All reviewed patches have been landed. Closing bug. 178320 2012-12-07 18:31:41 -0800 2012-12-07 19:55:51 -0800 Patch bug-104424.patch text/plain 1359 net147 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM3MDA1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTEyLTA3ICBKb25hdGhhbiBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAgICAg IEFkZCBtaXNzaW5nIGNvbnN0IHF1YWxpZmllciB0byBKU0M6OkNvZGVCbG9jazo6Z2V0SklUVHlw ZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ0 MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKU0M6 OkNvZGVCbG9jazo6Z2V0SklUVHlwZSgpIGhhcyB0aGUgY29uc3QgcXVhbGlmaWVyIHdoZW4gSklU IGlzCisgICAgICAgIGVuYWJsZWQgYnV0IGlzIG1pc3NpbmcgdGhlIGNvbnN0IHF1YWxpZmllciB3 aGVuIEpJVCBpcyBkaXNhYmxlZC4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5oOgor ICAgICAgICAoSlNDOjpDb2RlQmxvY2s6OmdldEpJVFR5cGUpOgorCiAyMDEyLTEyLTA3ICBPbGl2 ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBmdW5jdGlvbiBjb2Rl IGNhY2hlIHByb3BvcnRpb25hbCB0byBtYWluIGNvZGVibG9jayBjYWNoZQpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAkocmV2aXNpb24gMTM2OTQ4KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCSh3b3JraW5nIGNv cHkpCkBAIC01MjgsNyArNTI4LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgICAgICByZXR1 cm4gcmVzdWx0OwogICAgICAgICB9CiAjZWxzZQotICAgICAgICBKSVRDb2RlOjpKSVRUeXBlIGdl dEpJVFR5cGUoKSB7IHJldHVybiBKSVRDb2RlOjpCYXNlbGluZUpJVDsgfQorICAgICAgICBKSVRD b2RlOjpKSVRUeXBlIGdldEpJVFR5cGUoKSBjb25zdCB7IHJldHVybiBKSVRDb2RlOjpCYXNlbGlu ZUpJVDsgfQogI2VuZGlmCiAKICAgICAgICAgU2NyaXB0RXhlY3V0YWJsZSogb3duZXJFeGVjdXRh YmxlKCkgY29uc3QgeyByZXR1cm4gbV9vd25lckV4ZWN1dGFibGUuZ2V0KCk7IH0K