104410 2012-12-07 16:12:18 -0800 [Chromium-Android] Use harfbuzz-ng instead of harfbuzz-old on Android 2012-12-21 16:22:43 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 wangxianzhu wangxianzhu abarth bashi behdad eric glenn jshin laszlo.gombos leviw peter phajdan.jr tony webkit.review.bot oldest_to_newest 786269 0 wangxianzhu 2012-12-07 16:12:18 -0800 It's really critical to switch to harfbuzz-ng because so many bugs are resolved with the switch. 787681 1 178624 wangxianzhu 2012-12-10 13:39:59 -0800 Created attachment 178624 Patch 787684 2 wangxianzhu 2012-12-10 13:43:41 -0800 Just enabled harfbuzz-ng in gyp without any C++ code change. The original Android-specific code in ComplexTextControllerHarfBuzz.cpp (depending on harfbuzz-old) is not needed in the new code path because we already have proper font fallback mechanism on in Skia for Android and used it in WebKit. Perhaps we should cleanup the obsolete code if no one uses harfbuzz-old. 789436 3 peter 2012-12-12 04:01:36 -0800 Do we want this before the M25 branch point? It seems like a risky change to do on such short notice.. 789615 4 wangxianzhu 2012-12-12 09:05:51 -0800 (In reply to comment #3) > Do we want this before the M25 branch point? It seems like a risky change to do on such short notice.. This is not urgent. I think we can land it after M25 branch point. 789677 5 eric 2012-12-12 10:30:20 -0800 I doubt its particularly risky, given that linux has been on ng for several months iirc. But there is also no hurry in my view. 789680 6 178624 eric 2012-12-12 10:32:10 -0800 Comment on attachment 178624 Patch Lgtm, but be sure to coordinate with peter wrt when this should be landed. 789732 7 tony 2012-12-12 11:24:29 -0800 Is anyone still on old harfbuzz after this change? Can we delete the old harfbuzz code (there was some extra abstraction to handle both). 790550 8 peter 2012-12-13 06:28:55 -0800 (In reply to comment #5) > I doubt its particularly risky, given that linux has been on ng for several months iirc. But there is also no hurry in my view. We used to have a few modifications in harfbuzz in regards to memory usage, switching Android to harfbuzz-ng just before the branch point can have unexpected side-effects unless it's really thoroughly tested. While it's not a particularly risky change, it's safer to do it in the M26 period. The amount of issues we have with M25 is rather high as it is. Landing this on Tuesday morning (assuming branch occurs on Monday) is perfectly fine with me. Thanks for doing this, Xianzhu! 796507 9 178624 webkit.review.bot 2012-12-21 15:28:57 -0800 Comment on attachment 178624 Patch Clearing flags on attachment: 178624 Committed r138401: <http://trac.webkit.org/changeset/138401> 796508 10 webkit.review.bot 2012-12-21 15:29:01 -0800 All reviewed patches have been landed. Closing bug. 796534 11 behdad 2012-12-21 16:22:43 -0800 Awesome! Thanks everyone. 178624 2012-12-10 13:39:59 -0800 2012-12-21 15:28:57 -0800 Patch bug-104410-20121210213721.patch text/plain 5358 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDc0NjY2ODRkMjBkZTNm ZTAwMTdlYWYxZmNjYThmOWIyMGQ2Y2ZmMS4uZGJjZjM0NTZiNzVjNzJmNmI5N2U4MjA2NTRhYjQ3 MzQyNGQwMmVkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTEwICBYaWFu emh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVt LUFuZHJvaWRdIFVzZSBoYXJmYnV6ei1uZyBpbnN0ZWFkIG9mIGhhcmZidXp6LW9sZCBvbiBBbmRy b2lkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ0 MTAKKworICAgICAgICBVc2luZyBoYXJmYnV6ei1uZyB3ZSBjYW4gYXZvaWQgbWFueSBidWdzIG9m IHRoZSBvYnNvbGV0ZSBoYXJmYnV6ei1vbGQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2Ugb2YgZnVuY3Rpb25h bGl0eS4gRXhpc3RpbmcgdGVzdHMgc2hvdWxkIHBhc3MuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5 cC9XZWJDb3JlLmd5cDogVXNlIGhhcmZidXp6LW5nIG9uIEFuZHJvaWQuCisKIDIwMTItMTItMTAg IEFkYW0gS2xlaW4gIDxhZGFta0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgY3Itd2luIGJ1aWxk IGZpeCBhZnRlciByMTM3MTYxLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCA2ZmYzODIx NGEyMDJkY2QxY2U0MmRjMjZhNjU4NmY0ODUxMzU3NTliLi40ZWI3ZjcxYzAxNTAzOTI2NmFmYWIy NDJjYWU3M2Q2YzBlNzg5OTU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEyIEBACisyMDEyLTEyLTEwICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgW0Nocm9taXVtLUFuZHJvaWRdIFVzZSBoYXJmYnV6ei1uZyBpbnN0ZWFk IG9mIGhhcmZidXp6LW9sZCBvbiBBbmRyb2lkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ0MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGZlYXR1cmVzLmd5cGk6IEVuYWJsZSBoYXJmYnV6ei1uZyBv biBBbmRyb2lkLgorCiAyMDEyLTEyLTEwICBBbGV4aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5v cmc+CiAKICAgICAgICAgW0NTUzMgQmFja2dyb3VuZHMgYW5kIEJvcmRlcnNdIFJlbW92ZSBDU1Mz X0JBQ0tHUk9VTkQgZmVhdHVyZSBmbGFnLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2Vi Q29yZS5neXAvV2ViQ29yZS5neXAgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3Jl Lmd5cAppbmRleCA2ZGU4Zjc2Y2M3ZmZiY2I4Y2JmZTVkMTU2NjE5YmIxYjMyYjdhNzYxLi5iMTEw MjhkYjBhZDdlM2Y5MGMyYjM0MjNlM2IzOWI3NWNhZDA2ZTFkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJD b3JlLmd5cC9XZWJDb3JlLmd5cApAQCAtMjQ3LDEwICsyNDcsNiBAQAogICAgICAgWyd1c2VfeDEx PT0xIG9yIE9TPT0iYW5kcm9pZCInLCB7CiAgICAgICAgICd3ZWJjb3JlX2luY2x1ZGVfZGlycyc6 IFsKICAgICAgICAgICAnLi4vcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enonLAotICAgICAgICBd LAotICAgICAgfV0sCi0gICAgICBbJ3VzZV94MTE9PTEnLCB7Ci0gICAgICAgICd3ZWJjb3JlX2lu Y2x1ZGVfZGlycyc6IFsKICAgICAgICAgICAnLi4vcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enov bmcnLAogICAgICAgICBdLAogICAgICAgfV0sCkBAIC0xNzA5LDcgKzE3MDUsNyBAQAogICAgICAg ICAgICAgWydleGNsdWRlJywgJ3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21p dW1EZWZhdWx0LmgnXSwKICAgICAgICAgICBdLAogICAgICAgICB9XSwKLSAgICAgICAgWyd1c2Vf eDExID09IDEnLCB7CisgICAgICAgIFsndXNlX3gxMT09MSBvciBPUz09ImFuZHJvaWQiJywgewog ICAgICAgICAgICdzb3VyY2VzLyc6IFsKICAgICAgICAgICAgICMgQ2hlcnJ5LXBpY2sgZmlsZXMg ZXhjbHVkZWQgYnkgdGhlIGJyb2FkZXIgcmVndWxhciBleHByZXNzaW9ucyBhYm92ZS4KICAgICAg ICAgICAgIFsnaW5jbHVkZScsICdwbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Gb250SGFyZkJ1 enpcXC5jcHAkJ10sCkBAIC0xNzIyLDEyICsxNzE4LDE5IEBACiAgICAgICAgICAgICBbJ2luY2x1 ZGUnLCAncGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnR5cGUvT3BlblR5cGVWZXJ0aWNhbERhdGFcXC4o Y3BwfGgpJCddLAogICAgICAgICAgICAgWydpbmNsdWRlJywgJ3BsYXRmb3JtL2dyYXBoaWNzL3Nr aWEvU2ltcGxlRm9udERhdGFTa2lhXFwuY3BwJCddLAogICAgICAgICAgIF0sCi0gICAgICAgIH0s IHsgIyB1c2VfeDExPT0wCisgICAgICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKKyAgICAgICAgICAg ICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L2hhcmZidXp6LW5nL2hhcmZidXp6Lmd5 cDpoYXJmYnV6ei1uZycsCisgICAgICAgICAgXSwKKyAgICAgICAgfSwgeyAjIHVzZV94MTE9PTAg YW5kIE9TIT0iYW5kcm9pZCIKICAgICAgICAgICAnc291cmNlcy8nOiBbCi0gICAgICAgICAgICBb J2V4Y2x1ZGUnLCAnTGludXhcXC5jcHAkJ10sCiAgICAgICAgICAgICBbJ2V4Y2x1ZGUnLCAnSGFy ZmJ1enpbXi9dK1xcLihjcHB8aCkkJ10sCiAgICAgICAgICAgXSwKICAgICAgICAgfV0sCisgICAg ICAgIFsndXNlX3gxMSE9MScsIHsKKyAgICAgICAgICAnc291cmNlcy8nOiBbCisgICAgICAgICAg ICBbJ2V4Y2x1ZGUnLCAnTGludXhcXC5jcHAkJ10sCisgICAgICAgICAgXSwKKyAgICAgICAgfV0s CiAgICAgICAgIFsndG9vbGtpdF91c2VzX2d0ayA9PSAxJywgewogICAgICAgICAgICdzb3VyY2Vz Lyc6IFsKICAgICAgICAgICAgICMgQ2hlcnJ5LXBpY2sgZmlsZXMgZXhjbHVkZWQgYnkgdGhlIGJy b2FkZXIgcmVndWxhciBleHByZXNzaW9ucyBhYm92ZS4KQEAgLTE3MzgsMTYgKzE3NDEsNiBAQAog ICAgICAgICAgICAgWydleGNsdWRlJywgJ0d0a1xcLmNwcCQnXSwKICAgICAgICAgICBdLAogICAg ICAgICB9XSwKLSAgICAgICAgWyd1c2VfeDExPT0xJywgewotICAgICAgICAgICdkZXBlbmRlbmNp ZXMnOiBbCi0gICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9oYXJm YnV6ei1uZy9oYXJmYnV6ei5neXA6aGFyZmJ1enotbmcnLAotICAgICAgICAgIF0sCi0gICAgICAg IH1dLAotICAgICAgICBbJ09TPT0iYW5kcm9pZCInLCB7Ci0gICAgICAgICAgJ2RlcGVuZGVuY2ll cyc6IFsKLSAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L2hhcmZi dXp6L2hhcmZidXp6Lmd5cDpoYXJmYnV6eicsCi0gICAgICAgICAgXSwKLSAgICAgICAgfV0sCiAg ICAgICAgIFsnT1M9PSJtYWMiJywgewogICAgICAgICAgICMgTmVjZXNzYXJ5IGZvciBNYWMgLm1t IHN0dWZmLgogICAgICAgICAgICdpbmNsdWRlX2RpcnMnOiBbCkBAIC0xOTE4LDE1ICsxOTExLDcg QEAKICAgICAgICAgICAgIFsnaW5jbHVkZScsICdwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9H bHlwaFBhZ2VUcmVlTm9kZUxpbnV4XFwuY3BwJCddLAogICAgICAgICAgICAgWydleGNsdWRlJywg J3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ljb25DaHJvbWl1bVxcLmNwcCQnXSwKICAgICAg ICAgICAgIFsnaW5jbHVkZScsICdwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9WRE1YUGFyc2Vy XFwuY3BwJCddLAotICAgICAgICAgICAgWydpbmNsdWRlJywgJ3BsYXRmb3JtL2dyYXBoaWNzL2hh cmZidXp6L0NvbXBsZXhUZXh0Q29udHJvbGxlckhhcmZCdXp6XFwuY3BwJCddLAotICAgICAgICAg ICAgWydpbmNsdWRlJywgJ3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0ZvbnRIYXJmQnV6elxc LmNwcCQnXSwKLSAgICAgICAgICAgIFsnaW5jbHVkZScsICdwbGF0Zm9ybS9ncmFwaGljcy9oYXJm YnV6ei9Gb250UGxhdGZvcm1EYXRhSGFyZkJ1enpcXC5jcHAkJ10sCi0gICAgICAgICAgICBbJ2lu Y2x1ZGUnLCAncGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovSGFyZkJ1enpTa2lhXFwuY3BwJCdd LAotICAgICAgICAgICAgWydpbmNsdWRlJywgJ3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0hh cmZCdXp6U2hhcGVyQmFzZVxcLmNwcCQnXSwKLSAgICAgICAgICAgIFsnaW5jbHVkZScsICdwbGF0 Zm9ybS9ncmFwaGljcy9vcGVudHlwZS9PcGVuVHlwZVR5cGVzXFwuaCQnXSwKLSAgICAgICAgICAg IFsnaW5jbHVkZScsICdwbGF0Zm9ybS9ncmFwaGljcy9vcGVudHlwZS9PcGVuVHlwZVZlcnRpY2Fs RGF0YVxcLihjcHB8aCkkJ10sCiAgICAgICAgICAgICBbJ2V4Y2x1ZGUnLCAncGxhdGZvcm0vZ3Jh cGhpY3Mvc2tpYS9Gb250Q2FjaGVTa2lhXFwuY3BwJCddLAotICAgICAgICAgICAgWydpbmNsdWRl JywgJ3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvU2ltcGxlRm9udERhdGFTa2lhXFwuY3BwJCddLAog ICAgICAgICAgIF0sCiAgICAgICAgIH0sIHsgIyBPUyE9ImFuZHJvaWQiCiAgICAgICAgICAgJ3Nv dXJjZXMvJzogWwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5n eXBpIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCmluZGV4IDcyMTM0MDVj YzI5MjFjNDAwYmQxOWY4ZWZhYWU4ZWY1YTgzODI2ZDYuLmQxNDdkZjBjZDIwOTk4MjE5YzdlMzI0 NDNhM2NlZDJhYTJjZmY0ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVh dHVyZXMuZ3lwaQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKQEAg LTIzNCw3ICsyMzQsNyBAQAogICAgICAgICAgICdXVEZfVVNFX1NLSUFfT05fTUFDX0NIUk9NSVVN PTEnLAogICAgICAgICBdLAogICAgICAgfV0sCi0gICAgICBbJ3VzZV94MTE9PTEnLCB7CisgICAg ICBbJ3VzZV94MTE9PTEgb3IgT1M9PSJhbmRyb2lkIicsIHsKICAgICAgICAgJ2ZlYXR1cmVfZGVm aW5lcyc6IFsKICAgICAgICAgICAnV1RGX1VTRV9IQVJGQlVaWl9ORz0xJywKICAgICAgICAgXSwK