104405 2012-12-07 14:56:19 -0800 webkit-patch print-expectations doesn't work right for platforms w/ shared expectations 2012-12-10 11:06:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric ojan rniwa webkit.review.bot oldest_to_newest 786195 0 dpranke 2012-12-07 14:56:19 -0800 webkit-patch print-expectations doesn't work right for platforms w/ shared expectations 786199 1 178287 dpranke 2012-12-07 14:57:57 -0800 Created attachment 178287 Patch 786220 2 178287 eric 2012-12-07 15:19:15 -0800 Comment on attachment 178287 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178287&action=review Rs=me > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:70 > + # FIXME: This won't work if multiple ports share a TestExpectations file but support different modifiers in the file. Should we be asserting? 786255 3 dpranke 2012-12-07 15:57:09 -0800 (In reply to comment #2) > (From update of attachment 178287 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178287&action=review > > Rs=me > > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:70 > > + # FIXME: This won't work if multiple ports share a TestExpectations file but support different modifiers in the file. > > Should we be asserting? No, because there's no good way to detect that at the moment. 787551 4 dpranke 2012-12-10 11:06:00 -0800 Committed r137184: <http://trac.webkit.org/changeset/137184> 178287 2012-12-07 14:57:57 -0800 2012-12-07 15:19:15 -0800 Patch bug-104405-20121207145520.patch text/plain 5163 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODQ4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDBjZTVlMTQ1NzU0OTZhZjc2ODM2NWI1YTZlOWQzMTRi NDRkNTQ0ZC4uMjQzNDRkNGRlYzM3YzAxMzY4MGE1YzQxNmJhOWJiMzZjMzIwNTAzZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI5 IEBACiAyMDEyLTEyLTA3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIHdlYmtpdC1wYXRjaCBwcmludC1leHBlY3RhdGlvbnMgZG9lc24ndCB3b3JrIHJpZ2h0 IGZvciBwbGF0Zm9ybXMgdy8gc2hhcmVkIGV4cGVjdGF0aW9ucworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0NDA1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgbXVsdGlwbGUgcG9ydHMgc2hhcmVkIGEg VGVzdEV4cGVjdGF0aW9ucyBmaWxlLCB3ZWJraXQtcGF0Y2gKKyAgICAgICAgcHJpbnQtZXhwZWN0 YXRpb25zIHdvdWxkIHVzZSB0aGUgZXhwZWN0YXRpb24gZm9yIHRoZSBmaXJzdCBwb3J0CisgICAg ICAgIHVzaW5nIHRoYXQgZmlsZSBhbmQgcHJpbnQgdGhlIHJlc3VsdCBmb3IgYWxsIHBvcnRzLCBy YXRoZXIgdGhhbgorICAgICAgICByZS1wYXJzZSBhbmQgcHJpbnQgZWFjaCBwb3J0IHNlcGFyYXRl bHkgKGUuZy4sIHdlIG1pZ2h0IHByaW50CisgICAgICAgIHRoZSBjaHJvbWl1bS1saW51eCBleHBl Y3RhdGlvbiBmb3IgYSBmaWxlIGZvciBib3RoIGNocm9taXVtLWxpbnV4CisgICAgICAgIGFuZCBj aHJvbWl1bS1tYWMpLiBEaXNjb3ZlcmVkIHdoaWxlIHRlc3RpbmcvZGVidWdnaW5nIHRoZSBmaXgK KyAgICAgICAgZm9yIGJ1ZyAxMDQ0MDMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L3Rlc3QucHk6CisgICAgICAgIChUZXN0UG9ydC5fc2tpcHBlZF90ZXN0 c19mb3JfdW5zdXBwb3J0ZWRfZmVhdHVyZXMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisgICAgICAgIChsaW50KToKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVlcmllcy5weToKKyAgICAgICAg KFByaW50RXhwZWN0YXRpb25zLl9tb2RlbCk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL3F1ZXJpZXNfdW5pdHRlc3QucHk6CisgICAgICAgIChQcmludEV4cGVjdGF0 aW9uc1Rlc3QudGVzdF9wbGF0Zm9ybSk6CisKKzIwMTItMTItMDcgIERpcmsgUHJhbmtlICA8ZHBy YW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgbnJ3dDogdXNlIHRoZSBkZWZhdWx0IGxvZ2lj IGZvciBza2lwcGluZyBwbGF0Zm9ybS1zcGVjaWZpYyB0ZXN0cyBmb3IgY2hyb21pdW0KICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDQwMwogCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3Rlc3QucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3Rlc3QucHkKaW5kZXgg OTYyNmZlNjJjZWMxOWUxMmU2ZGIzYzQ4MmE0YzNlNDcxZGFmZjJmYi4uODA0ZmYyNWQ1Yzc0OTAx Y2MyYTYxMTM3ODhmYmY0ZTNhOWI3NmRjMiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC90ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvdGVzdC5weQpAQCAtNDMzLDkgKzQzMyw3IEBAIGNsYXNzIFRl c3RQb3J0KFBvcnQpOgogICAgIGRlZiB3ZWJraXRfYmFzZShzZWxmKToKICAgICAgICAgcmV0dXJu ICcvdGVzdC5jaGVja291dCcKIAotICAgIGRlZiBza2lwcGVkX2xheW91dF90ZXN0cyhzZWxmLCB0 ZXN0X2xpc3QpOgotICAgICAgICAjIFRoaXMgYWxsb3dzIHVzIHRvIHRlc3QgdGhlIGhhbmRsaW5n IFNraXBwZWQgZmlsZXMsIGJvdGggd2l0aCBhIHRlc3QKLSAgICAgICAgIyB0aGF0IGFjdHVhbGx5 IHBhc3NlcywgYW5kIGEgdGVzdCB0aGF0IGRvZXMgZmFpbC4KKyAgICBkZWYgX3NraXBwZWRfdGVz dHNfZm9yX3Vuc3VwcG9ydGVkX2ZlYXR1cmVzKHNlbGYsIHRlc3RfbGlzdCk6CiAgICAgICAgIHJl dHVybiBzZXQoWydmYWlsdXJlcy9leHBlY3RlZC9za2lwX3RleHQuaHRtbCcsCiAgICAgICAgICAg ICAgICAgICAgICdmYWlsdXJlcy91bmV4cGVjdGVkL3NraXBfcGFzcy5odG1sJywKICAgICAgICAg ICAgICAgICAgICAgJ3ZpcnR1YWwvc2tpcHBlZCddKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKaW5kZXggMzlmNmYy YTIxMWFjNTI0Yzk5ODk5MDJmMDJjYjBkNTc2NmJjYzdjZS4uMDdlODhjYWM2MDg3YTg3YmY5NWNm Njk3M2M5MGNhZmJmODZkMjYxOSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CkBAIC02Niw2ICs2Niw4IEBAIGRl ZiBsaW50KHBvcnQsIG9wdGlvbnMpOgogCiAgICAgZm9yIHBvcnRfdG9fbGludCBpbiBwb3J0c190 b19saW50OgogICAgICAgICBleHBlY3RhdGlvbnNfZGljdCA9IHBvcnRfdG9fbGludC5leHBlY3Rh dGlvbnNfZGljdCgpCisKKyAgICAgICAgIyBGSVhNRTogVGhpcyB3b24ndCB3b3JrIGlmIG11bHRp cGxlIHBvcnRzIHNoYXJlIGEgVGVzdEV4cGVjdGF0aW9ucyBmaWxlIGJ1dCBzdXBwb3J0IGRpZmZl cmVudCBtb2RpZmllcnMgaW4gdGhlIGZpbGUuCiAgICAgICAgIGZvciBleHBlY3RhdGlvbnNfZmls ZSBpbiBleHBlY3RhdGlvbnNfZGljdC5rZXlzKCk6CiAgICAgICAgICAgICBpZiBleHBlY3RhdGlv bnNfZmlsZSBpbiBmaWxlc19saW50ZWQ6CiAgICAgICAgICAgICAgICAgY29udGludWUKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWVyaWVzLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXJpZXMucHkKaW5kZXggN2Nj ODQ2NzE1NGRiMjM1NGE1ZmE1NzQ3M2VlMjQ0OWEzYjMzM2ZiOC4uNzlmZmE5YmQ4ZGRjZDdjNTE4 NDdkYzc4MWYxNzVkOWZjZGQ0YTZhZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL2NvbW1hbmRzL3F1ZXJpZXMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL3F1ZXJpZXMucHkKQEAgLTUxNCwxMCArNTE0LDcgQEAgY2xhc3MgUHJpbnRF eHBlY3RhdGlvbnMoQWJzdHJhY3REZWNsYXJhdGl2ZUNvbW1hbmQpOgogCiAgICAgZGVmIF9tb2Rl bChzZWxmLCBvcHRpb25zLCBwb3J0X25hbWUsIHRlc3RzKToKICAgICAgICAgcG9ydCA9IHNlbGYu X3Rvb2wucG9ydF9mYWN0b3J5LmdldChwb3J0X25hbWUsIG9wdGlvbnMpCi0gICAgICAgIGV4cGVj dGF0aW9uc19wYXRoID0gcG9ydC5wYXRoX3RvX3Rlc3RfZXhwZWN0YXRpb25zX2ZpbGUoKQotICAg ICAgICBpZiBub3QgZXhwZWN0YXRpb25zX3BhdGggaW4gc2VsZi5fZXhwZWN0YXRpb25fbW9kZWxz OgotICAgICAgICAgICAgc2VsZi5fZXhwZWN0YXRpb25fbW9kZWxzW2V4cGVjdGF0aW9uc19wYXRo XSA9IFRlc3RFeHBlY3RhdGlvbnMocG9ydCwgdGVzdHMpLm1vZGVsKCkKLSAgICAgICAgcmV0dXJu IHNlbGYuX2V4cGVjdGF0aW9uX21vZGVsc1tleHBlY3RhdGlvbnNfcGF0aF0KKyAgICAgICAgcmV0 dXJuIFRlc3RFeHBlY3RhdGlvbnMocG9ydCwgdGVzdHMpLm1vZGVsKCkKIAogCiBjbGFzcyBQcmlu dEJhc2VsaW5lcyhBYnN0cmFjdERlY2xhcmF0aXZlQ29tbWFuZCk6CmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVlcmllc191bml0dGVzdC5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWVyaWVzX3VuaXR0ZXN0LnB5Cmlu ZGV4IGIyNTJjMGIwZTU4ZDQ0Nzk3NDAxNjlkMjQ4NmUzZDRiZTQ4NzRlNzIuLjAyZmEwMzA3OWRm MjYzZTUwNThiMjAwZTQ1Njk2ZjE0ZTc2ZTU1YmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWVyaWVzX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWVyaWVzX3VuaXR0ZXN0LnB5CkBAIC0yMjcs NiArMjI3LDE0IEBAIGNsYXNzIFByaW50RXhwZWN0YXRpb25zVGVzdCh1bml0dGVzdC5UZXN0Q2Fz ZSk6CiAgICAgICAgICAgICAgICAgICAgICAgICdMYXlvdXRUZXN0cy9wbGF0Zm9ybS90ZXN0LXdp bi14cC9UZXN0RXhwZWN0YXRpb25zXG4nKSwKICAgICAgICAgICAgICAgICAgICAgICBwYXRocz1U cnVlKQogCisgICAgZGVmIHRlc3RfcGxhdGZvcm0oc2VsZik6CisgICAgICAgIHNlbGYucnVuX3Rl c3QoWydwbGF0Zm9ybS90ZXN0LW1hYy1sZW9wYXJkL2h0dHAvdGVzdC5odG1sJ10sCisgICAgICAg ICAgICAgICAgICAgICAgKCcvLyBGb3IgdGVzdC1tYWMtc25vd2xlb3BhcmRcbicKKyAgICAgICAg ICAgICAgICAgICAgICAgJ3BsYXRmb3JtL3Rlc3QtbWFjLWxlb3BhcmQgWyBQYXNzIFNraXAgV29u dEZpeCBdXG4nICAjIE5vdGUgdGhhdCB0aGlzIGlzIHRoZSBleHBlY3RhdGlvbiAoZnJvbSBiZWlu ZyBza2lwcGVkIGludGVybmFsbHkpLCBub3QgdGhlIHRlc3QgbmFtZQorICAgICAgICAgICAgICAg ICAgICAgICAnXG4nCisgICAgICAgICAgICAgICAgICAgICAgICcvLyBGb3IgdGVzdC1tYWMtbGVv cGFyZFxuJworICAgICAgICAgICAgICAgICAgICAgICAncGxhdGZvcm0vdGVzdC1tYWMtbGVvcGFy ZC9odHRwL3Rlc3QuaHRtbCBbIFBhc3MgXVxuJyksCisgICAgICAgICAgICAgICAgICAgICAgcGxh dGZvcm09J3Rlc3QtbWFjLSonKQogCiBjbGFzcyBQcmludEJhc2VsaW5lc1Rlc3QodW5pdHRlc3Qu VGVzdENhc2UpOgogICAgIGRlZiBzZXRVcChzZWxmKToK