104404 2012-12-07 14:44:13 -0800 Allow embedder to observe changes to frame names 2012-12-14 14:56:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fsamuel fsamuel abarth ap dglazkov fishd jamesr japhet tkent+wkapi webkit.review.bot oldest_to_newest 786185 0 fsamuel 2012-12-07 14:44:13 -0800 [NOT FOR REVIEW] Allow embedder to observe changes to frame names 786186 1 178283 fsamuel 2012-12-07 14:44:35 -0800 Created attachment 178283 Patch 786188 2 webkit.review.bot 2012-12-07 14:47:15 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 786268 3 ap 2012-12-07 16:07:45 -0800 Could you please elaborate on what a NOT FOR REVIEW bug with a patch marked for review means? I don't understand how it's helpful to have "NOT FOR REVIEW" in bug title in any circumstances, but having a patch for review makes it even stranger. 786298 4 jamesr 2012-12-07 16:43:01 -0800 @Fady - if you're using "webkit-patch upload" use the "--no-review" flag to upload 787265 5 fsamuel 2012-12-10 06:31:51 -0800 (In reply to comment #4) > @Fady - if you're using "webkit-patch upload" use the "--no-review" flag to upload Yup, I remembered that after I posted the patch :-) Sorry for the confusion. Thanks. This change is still in discussion. If we decide this is useful, I request a review. Thanks. 787919 6 fsamuel 2012-12-10 18:13:06 -0800 (In reply to comment #5) > (In reply to comment #4) > > @Fady - if you're using "webkit-patch upload" use the "--no-review" flag to upload > > Yup, I remembered that after I posted the patch :-) Sorry for the confusion. Thanks. This change is still in discussion. If we decide this is useful, I request a review. Thanks. I'd like to go ahead and get a review for this, please. 788984 7 178283 fishd 2012-12-11 16:49:37 -0800 Comment on attachment 178283 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178283&action=review > Source/WebCore/page/ChromeClient.h:148 > + virtual void frameNameChanged(Frame*, const String&) { } this feels like something that should be plumbed through the FrameLoaderClient > Source/WebKit/chromium/public/WebViewClient.h:165 > + virtual void frameNameChanged(WebFrame*, const WebString&) { } nit: we usually go with a format more like didChangeFoo or willChangeFoo. it seems like the consistent approach would be didChangeFrameName, but how about putting this on WebFrameClient instead? Then, it can just be didChangeName as a WebFrame already has a name attribute. 789108 8 178945 fsamuel 2012-12-11 18:59:10 -0800 Created attachment 178945 Patch 789111 9 178283 fsamuel 2012-12-11 19:00:58 -0800 Comment on attachment 178283 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178283&action=review >> Source/WebCore/page/ChromeClient.h:148 >> + virtual void frameNameChanged(Frame*, const String&) { } > > this feels like something that should be plumbed through the FrameLoaderClient Done. >> Source/WebKit/chromium/public/WebViewClient.h:165 >> + virtual void frameNameChanged(WebFrame*, const WebString&) { } > > nit: we usually go with a format more like didChangeFoo or willChangeFoo. > it seems like the consistent approach would be didChangeFrameName, but how > about putting this on WebFrameClient instead? Then, it can just be didChangeName > as a WebFrame already has a name attribute. Done. 791879 10 178945 webkit.review.bot 2012-12-14 14:56:30 -0800 Comment on attachment 178945 Patch Clearing flags on attachment: 178945 Committed r137776: <http://trac.webkit.org/changeset/137776> 791880 11 webkit.review.bot 2012-12-14 14:56:34 -0800 All reviewed patches have been landed. Closing bug. 178283 2012-12-07 14:44:35 -0800 2012-12-11 19:00:58 -0800 Patch bug-104404-20121207174159.patch text/plain 6878 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTNkMDFlYzExOTcwMjQ3 MzQ5ZDA1ODMzOGJkZDg1M2U2MTAxNGQ2MC4uZTQ5NzJiNmE5ODQwNjZhMGRlMjM5N2M0MWJiNmVm YzNiNjEwMWQwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEyLTA3ICBGYWR5 IFNhbXVlbCAgPGZzYW11ZWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtOT1QgRk9SIFJFVklF V10gQWxsb3cgZW1iZWRkZXIgdG8gb2JzZXJ2ZSBjaGFuZ2VzIHRvIGZyYW1lIG5hbWVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ0MDQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvQ2hyb21l LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZTo6ZnJhbWVOYW1lQ2hhbmdlZCk6CisgICAg ICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBwYWdlL0Nocm9tZS5oOgorICAgICAgICAoQ2hyb21l KToKKyAgICAgICAgKiBwYWdlL0Nocm9tZUNsaWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6Q2hy b21lQ2xpZW50OjpmcmFtZU5hbWVDaGFuZ2VkKToKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5j cHA6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6OnNldE5hbWUpOgorCiAyMDEyLTEyLTA3 ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBUaHJvdyBhd2F5 IFN0eWxlUmVzb2x2ZXJzIHRoYXQgaGF2ZW4ndCBiZWVuIHVzZWQgZm9yIGEgbG9uZyB0aW1lLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCBmMjYwOGVjMTQwNGIyYmMzNzY0N2EwMzUxMjli MmE1N2FiNTgwYzMwLi5kNzJlNGQ1MjM1NDBjMjU5NjUyNjkxZjg3YTk2MjhlYTE5OGRlYzMzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTA3ICBG YWR5IFNhbXVlbCAgPGZzYW11ZWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtOT1QgRk9SIFJF VklFV10gQWxsb3cgZW1iZWRkZXIgdG8gb2JzZXJ2ZSBjaGFuZ2VzIHRvIGZyYW1lIG5hbWVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ0MDQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpdGlvbmFs IGluZm9ybWF0aW9uIG9mIHRoZSBjaGFuZ2Ugc3VjaCBhcyBhcHByb2FjaCwgcmF0aW9uYWxlLiBQ bGVhc2UgYWRkIHBlci1mdW5jdGlvbiBkZXNjcmlwdGlvbnMgYmVsb3cgKE9PUFMhKS4KKworICAg ICAgICAqIHB1YmxpYy9XZWJWaWV3Q2xpZW50Lmg6CisgICAgICAgIChXZWJWaWV3Q2xpZW50KToK KyAgICAgICAgKFdlYktpdDo6V2ViVmlld0NsaWVudDo6ZnJhbWVOYW1lQ2hhbmdlZCk6CisgICAg ICAgICogc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpDaHJvbWVD bGllbnRJbXBsOjpmcmFtZU5hbWVDaGFuZ2VkKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAg ICogc3JjL0Nocm9tZUNsaWVudEltcGwuaDoKKyAgICAgICAgKENocm9tZUNsaWVudEltcGwpOgor CiAyMDEyLTEyLTA3ICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBbQ2hyb21pdW1dIE1vdmUgV29ya2VyQ29udGV4dFByb3h5OjpjcmVhdGUgb3V0IG9mIFBs YXRmb3JtU3VwcG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWUuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWUuY3BwCmluZGV4IDg0ZGZjYjQyMzI3YzA4MzAw MWE1NTQ0ZWY4Yzc1MjljMmUzODM0MmMuLjA1YmU1ZjkwOWZhY2ZmMDhmMjgyODc4MWQ1OTRiODRk NjgzN2Q3ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZS5jcHAKQEAgLTM1NCw2ICszNTQsMTIgQEAgdm9p ZCBDaHJvbWU6OnNldFN0YXR1c2JhclRleHQoRnJhbWUqIGZyYW1lLCBjb25zdCBTdHJpbmcmIHN0 YXR1cykKICAgICBtX2NsaWVudC0+c2V0U3RhdHVzYmFyVGV4dChmcmFtZS0+ZGlzcGxheVN0cmlu Z01vZGlmaWVkQnlFbmNvZGluZyhzdGF0dXMpKTsKIH0KIAordm9pZCBDaHJvbWU6OmZyYW1lTmFt ZUNoYW5nZWQoRnJhbWUqIGZyYW1lLCBjb25zdCBTdHJpbmcmIG5hbWUpCit7CisgICAgQVNTRVJU KGZyYW1lKTsKKyAgICBtX2NsaWVudC0+ZnJhbWVOYW1lQ2hhbmdlZChmcmFtZSwgbmFtZSk7Cit9 CisKIGJvb2wgQ2hyb21lOjpzaG91bGRJbnRlcnJ1cHRKYXZhU2NyaXB0KCkKIHsKICAgICAvLyBE ZWZlciBsb2FkcyBpbiBjYXNlIHRoZSBjbGllbnQgbWV0aG9kIHJ1bnMgYSBuZXcgZXZlbnQgbG9v cCB0aGF0IHdvdWxkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZS5oIGIv U291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWUuaAppbmRleCBlNzhmMzg1ODFhNjRmYjBiZjhmYzc3 MWEyY2JlNzM0NGFlNmFiMjI2Li5kZWZiMDU0OTg0ZTIxYmE0ZmRhN2Y2MzdjZDI4ZGFlY2E5ZmU3 N2Y2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvQ2hyb21lLmgKQEAgLTE0MCw2ICsxNDAsNyBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAgICAgICAgIGJvb2wgcnVuSmF2YVNjcmlwdENvbmZpcm0oRnJhbWUqLCBjb25zdCBT dHJpbmcmKTsKICAgICAgICAgYm9vbCBydW5KYXZhU2NyaXB0UHJvbXB0KEZyYW1lKiwgY29uc3Qg U3RyaW5nJiBtZXNzYWdlLCBjb25zdCBTdHJpbmcmIGRlZmF1bHRWYWx1ZSwgU3RyaW5nJiByZXN1 bHQpOwogICAgICAgICB2b2lkIHNldFN0YXR1c2JhclRleHQoRnJhbWUqLCBjb25zdCBTdHJpbmcm KTsKKyAgICAgICAgdm9pZCBmcmFtZU5hbWVDaGFuZ2VkKEZyYW1lKiwgY29uc3QgU3RyaW5nJik7 CiAgICAgICAgIGJvb2wgc2hvdWxkSW50ZXJydXB0SmF2YVNjcmlwdCgpOwogCiAgICAgICAgIElu dFJlY3Qgd2luZG93UmVzaXplclJlY3QoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVu dC5oCmluZGV4IDM1YzMyMzI4YzM0M2EwZjU2OTMyOTZkNzA1NzExNzczMDhiYWFiMjkuLmYzYzFl NDM3MDI1MzlmY2Q0YWUwZDM4YmI4ZTMzNzc3NTg5NjdlMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9DaHJv bWVDbGllbnQuaApAQCAtMTQ1LDYgKzE0NSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgdmlydHVhbCBib29sIHJ1bkphdmFTY3JpcHRDb25maXJtKEZyYW1lKiwgY29uc3QgU3RyaW5n JikgPSAwOwogICAgICAgICB2aXJ0dWFsIGJvb2wgcnVuSmF2YVNjcmlwdFByb21wdChGcmFtZSos IGNvbnN0IFN0cmluZyYgbWVzc2FnZSwgY29uc3QgU3RyaW5nJiBkZWZhdWx0VmFsdWUsIFN0cmlu ZyYgcmVzdWx0KSA9IDA7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBzZXRTdGF0dXNiYXJUZXh0KGNv bnN0IFN0cmluZyYpID0gMDsKKyAgICAgICAgdmlydHVhbCB2b2lkIGZyYW1lTmFtZUNoYW5nZWQo RnJhbWUqLCBjb25zdCBTdHJpbmcmKSB7IH0KICAgICAgICAgdmlydHVhbCBib29sIHNob3VsZElu dGVycnVwdEphdmFTY3JpcHQoKSA9IDA7CiAgICAgICAgIHZpcnR1YWwgS2V5Ym9hcmRVSU1vZGUg a2V5Ym9hcmRVSU1vZGUoKSA9IDA7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RE9NV2luZG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAppbmRleCBi Nzk3NzNiMWRmMDQyZjA1YmZlODEyODRjN2Q2MjI1Mzk0MjdjNzQxLi5lNjQ4MzBlYTBjNDZkZDRm NjgxZTc2YWQ0MmI2YzFjNmUxMTFjM2RjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0RPTVdpbmRvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCkBA IC0xMjQxLDYgKzEyNDEsMTIgQEAgdm9pZCBET01XaW5kb3c6OnNldE5hbWUoY29uc3QgU3RyaW5n JiBzdHJpbmcpCiAgICAgICAgIHJldHVybjsKIAogICAgIG1fZnJhbWUtPnRyZWUoKS0+c2V0TmFt ZShzdHJpbmcpOworICAgIFBhZ2UqIHBhZ2UgPSBtX2ZyYW1lLT5wYWdlKCk7CisgICAgaWYgKCFw YWdlKQorICAgICAgICByZXR1cm47CisKKyAgICBBU1NFUlQobV9mcmFtZS0+ZG9jdW1lbnQoKSk7 IC8vIENsaWVudCBjYWxscyBzaG91bGRuJ3QgYmUgbWFkZSB3aGVuIHRoZSBmcmFtZSBpcyBpbiBp bmNvbnNpc3RlbnQgc3RhdGUuCisgICAgcGFnZS0+Y2hyb21lKCktPmZyYW1lTmFtZUNoYW5nZWQo bV9mcmFtZSwgc3RyaW5nKTsKIH0KIAogdm9pZCBET01XaW5kb3c6OnNldFN0YXR1cyhjb25zdCBT dHJpbmcmIHN0cmluZykgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJWaWV3Q2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3 Q2xpZW50LmgKaW5kZXggYzZlMTc1ZGJhZGU5YzU1YWU5NmVkNThlNDcyNzM4NTIwZGRhOTI3My4u NmNjYTg4ODliNzBlZmY5ZTUxMDNkNGQ4MTgxNDAwNjY5YzQ1YjJkYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaApAQCAtMTYxLDYgKzE2MSw4IEBA IHB1YmxpYzoKICAgICAvLyBDYWxsZWQgYnkgV2ViSGVscGVyUGx1Z2luIHRvIHByb3ZpZGUgdGhl IFdlYkZyYW1lQ2xpZW50IGludGVyZmFjZSBmb3IgdGhlIFdlYkZyYW1lLgogICAgIHZpcnR1YWwg dm9pZCBpbml0aWFsaXplSGVscGVyUGx1Z2luV2ViRnJhbWUoV2ViSGVscGVyUGx1Z2luKikgeyB9 CiAKKyAgICAvLyBDYWxsZWQgd2hlbiB0aGUgbmFtZSBvZiBhIGZyYW1lIGNoYW5nZXMuCisgICAg dmlydHVhbCB2b2lkIGZyYW1lTmFtZUNoYW5nZWQoV2ViRnJhbWUqLCBjb25zdCBXZWJTdHJpbmcm KSB7IH0KIAogICAgIC8vIE5hdmlnYXRpb25hbCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCmluZGV4IDU2ZTE3Zjc1NTQ3OWI1ZTdjZjliNDQ5 MThjNTliZWZhMDY5MThhZDIuLmZhMzVhZjRhZjNlZmYzNTYwOWRhZjkyOGFhOWNmOGU2NGE3MGEx MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudElt cGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwu Y3BwCkBAIC00NzgsNiArNDc4LDEyIEBAIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6c2V0U3RhdHVz YmFyVGV4dChjb25zdCBTdHJpbmcmIG1lc3NhZ2UpCiAgICAgICAgIG1fd2ViVmlldy0+Y2xpZW50 KCktPnNldFN0YXR1c1RleHQobWVzc2FnZSk7CiB9CiAKK3ZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6 ZnJhbWVOYW1lQ2hhbmdlZChGcmFtZSogZnJhbWUsIGNvbnN0IFN0cmluZyYgbmFtZSkKK3sKKyAg ICBpZiAobV93ZWJWaWV3LT5jbGllbnQoKSkKKyAgICAgICAgbV93ZWJWaWV3LT5jbGllbnQoKS0+ ZnJhbWVOYW1lQ2hhbmdlZChXZWJGcmFtZUltcGw6OmZyb21GcmFtZShmcmFtZSksIG5hbWUpOwor fQorCiBib29sIENocm9tZUNsaWVudEltcGw6OnNob3VsZEludGVycnVwdEphdmFTY3JpcHQoKQog ewogICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQgbWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL0Nocm9tZUNsaWVudEltcGwuaAppbmRleCA3NzA4NGY4MDEwMmY2MjM3YjY3ODJkYzhiNjBm Y2MyY2UyNjY5NTIwLi5jMzJkZjBhZjgxOWU4YjZhM2U1NDMzNGI4ZjJlMzZhYzk4YWEyYTVkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5oCkBAIC0x MTAsNiArMTEwLDcgQEAgcHVibGljOgogICAgICAgICBXZWJDb3JlOjpGcmFtZSosIGNvbnN0IFdU Rjo6U3RyaW5nJiBtZXNzYWdlLAogICAgICAgICBjb25zdCBXVEY6OlN0cmluZyYgZGVmYXVsdFZh bHVlLCBXVEY6OlN0cmluZyYgcmVzdWx0KTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0U3RhdHVzYmFy VGV4dChjb25zdCBXVEY6OlN0cmluZyYgbWVzc2FnZSk7CisgICAgdmlydHVhbCB2b2lkIGZyYW1l TmFtZUNoYW5nZWQoV2ViQ29yZTo6RnJhbWUqLCBjb25zdCBXVEY6OlN0cmluZyYpOwogICAgIHZp cnR1YWwgYm9vbCBzaG91bGRJbnRlcnJ1cHRKYXZhU2NyaXB0KCk7CiAgICAgdmlydHVhbCBXZWJD b3JlOjpLZXlib2FyZFVJTW9kZSBrZXlib2FyZFVJTW9kZSgpOwogICAgIHZpcnR1YWwgV2ViQ29y ZTo6SW50UmVjdCB3aW5kb3dSZXNpemVyUmVjdCgpIGNvbnN0Owo= 178945 2012-12-11 18:59:10 -0800 2012-12-14 14:56:29 -0800 Patch bug-104404-20121211215631.patch text/plain 5058 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRjM2MxNjRiNTlhMGYx Y2EzMmZjZThhMjI1MGZkMmE4NTQ5MjM4NC4uNDUzMDdlZGRjMTk5MDdlNDNlMjMzNGIyNjI1Njgw MDBkNjIzMTRiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTExICBGYWR5 IFNhbXVlbCAgPGZzYW11ZWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFsbG93IGVtYmVkZGVy IHRvIG9ic2VydmUgY2hhbmdlcyB0byBmcmFtZSBuYW1lcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0NDA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXJDbGllbnQuaDoK KyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50OjpkaWRDaGFuZ2VOYW1lKToKKyAg ICAgICAgKEZyYW1lTG9hZGVyQ2xpZW50KToKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6OnNldE5hbWUpOgorCiAyMDEyLTEyLTEwICBw ZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgogCiAgICAgICAgIFtXaW5DYWly b10gTGluayBmaXggaW4gSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cKaW5kZXggN2Y2ODU4ODM5Mjc0MTVhNmU1OTU2YzJjOWQ2YjAyNWJiNDg0NTVlNi4uNTM2 NmRjOWJlMGU5YzQ5ZDgzMjg0MzNkZDJiYzBmYmYxNDk4MzRmNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMi0xMSAgRmFkeSBTYW11ZWwgIDxmc2Ft dWVsQGNocm9taXVtLm9yZz4KKworICAgICAgICBBbGxvdyBlbWJlZGRlciB0byBvYnNlcnZlIGNo YW5nZXMgdG8gZnJhbWUgbmFtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwNDQwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcHVibGljL1dlYkZyYW1lQ2xpZW50Lmg6CisgICAgICAgIChXZWJGcmFt ZUNsaWVudCk6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lQ2xpZW50OjpkaWRDaGFuZ2VOYW1l KToKKyAgICAgICAgKiBzcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdl YktpdDo6RnJhbWVMb2FkZXJDbGllbnRJbXBsOjpkaWRDaGFuZ2VOYW1lKToKKyAgICAgICAgKFdl YktpdCk6CisgICAgICAgICogc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5oOgorICAgICAgICAo RnJhbWVMb2FkZXJDbGllbnRJbXBsKToKKwogMjAxMi0xMi0xMCAgTWlrZSBXZXN0ICA8bWt3c3RA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQWRkICdXZWJLaXQvY2hyb21pdW0v d2luOCcgdG8gLmdpdGlnbm9yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0Zy YW1lTG9hZGVyQ2xpZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXJDbGll bnQuaAppbmRleCBjOWVhZTY0OGM4NzdmZTIwMGU5MGVhZjY0ZDUwNjIwNDliYjE3YzA2Li5mMjg2 MDg3YTI3MDY3ZWExNzc5Y2VhNmM3ODFjMmZhNzk4N2MzNzg3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXJDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXJDbGllbnQuaApAQCAtMzQwLDYgKzM0MCw4IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKICAgICAgICAgLy8gUmV0dXJucyB0cnVlIGlmIHRoZSBlbWJlZGRlciBpbnRlcmNl cHRlZCB0aGUgcG9zdE1lc3NhZ2UgY2FsbAogICAgICAgICB2aXJ0dWFsIGJvb2wgd2lsbENoZWNr QW5kRGlzcGF0Y2hNZXNzYWdlRXZlbnQoU2VjdXJpdHlPcmlnaW4qIC8qdGFyZ2V0Ki8sIE1lc3Nh Z2VFdmVudCopIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAKKyAgICAgICAgdmlydHVhbCB2b2lk IGRpZENoYW5nZU5hbWUoY29uc3QgU3RyaW5nJikgeyB9CisKICNpZiBFTkFCTEUoV0VCX0lOVEVO VFMpCiAgICAgICAgIHZpcnR1YWwgdm9pZCBkaXNwYXRjaEludGVudChQYXNzUmVmUHRyPEludGVu dFJlcXVlc3Q+KSA9IDA7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RE9NV2luZG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAppbmRleCBi Nzk3NzNiMWRmMDQyZjA1YmZlODEyODRjN2Q2MjI1Mzk0MjdjNzQxLi4wYzY2ZDZhZjEyZWM2OGEz YzFlYWI3ZmQzODEzYjJkODM4Yzc0YThkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0RPTVdpbmRvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCkBA IC0xMjQxLDYgKzEyNDEsNyBAQCB2b2lkIERPTVdpbmRvdzo6c2V0TmFtZShjb25zdCBTdHJpbmcm IHN0cmluZykKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV9mcmFtZS0+dHJlZSgpLT5zZXROYW1l KHN0cmluZyk7CisgICAgbV9mcmFtZS0+bG9hZGVyKCktPmNsaWVudCgpLT5kaWRDaGFuZ2VOYW1l KHN0cmluZyk7CiB9CiAKIHZvaWQgRE9NV2luZG93OjpzZXRTdGF0dXMoY29uc3QgU3RyaW5nJiBz dHJpbmcpIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJh bWVDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lQ2xpZW50 LmgKaW5kZXggZTVhYWNlM2VkZTFmNzY4ZWNjNDMyMGJhNTk4YzQ0NDlkMjU1NzI5NS4uZjNmZjNk MjVmYmM5ZTkyOWU1NTI2MGQ2MjVlMGFkMjY2MzY1OTJjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWVDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZUNsaWVudC5oCkBAIC0xMjAsNiArMTIwLDkgQEAgcHVi bGljOgogICAgIC8vIHdoZW4gdGhlIGRvY3VtZW50IGlzIGJlaW5nIHVubG9hZGVkLCBkdWUgdG8g bmV3IG9uZSBjb21taXR0aW5nLgogICAgIHZpcnR1YWwgdm9pZCB3aWxsQ2xvc2UoV2ViRnJhbWUq KSB7IH0KIAorICAgIC8vIFRoaXMgZnJhbWUncyBuYW1lIGhhcyBjaGFuZ2VkLgorICAgIHZpcnR1 YWwgdm9pZCBkaWRDaGFuZ2VOYW1lKFdlYkZyYW1lKiwgY29uc3QgV2ViU3RyaW5nJikgeyB9CisK ICAgICAvLyBMb2FkIGNvbW1hbmRzIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KIAogICAgIC8vIFRoZSBjbGllbnQgc2hvdWxkIGhhbmRsZSB0 aGUgbmF2aWdhdGlvbiBleHRlcm5hbGx5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHAKaW5kZXggZjRkZjE5MmU4NmRkOGI0ZjA0 MGM4YjQ0YjM1ZDBiNTFiZGRjMjVhMC4uNjFjODdkYzU2NTlhZjU1OWNlY2U0OWI2Y2UwNThhNzYz YTEyYTEyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2Fk ZXJDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxv YWRlckNsaWVudEltcGwuY3BwCkBAIC0xNjM1LDYgKzE2MzUsMTMgQEAgYm9vbCBGcmFtZUxvYWRl ckNsaWVudEltcGw6OndpbGxDaGVja0FuZERpc3BhdGNoTWVzc2FnZUV2ZW50KAogICAgICAgICBz b3VyY2UsIG1fd2ViRnJhbWUsIFdlYlNlY3VyaXR5T3JpZ2luKHRhcmdldCksIFdlYkRPTU1lc3Nh Z2VFdmVudChldmVudCkpOwogfQogCit2b2lkIEZyYW1lTG9hZGVyQ2xpZW50SW1wbDo6ZGlkQ2hh bmdlTmFtZShjb25zdCBTdHJpbmcmIG5hbWUpCit7CisgICAgaWYgKCFtX3dlYkZyYW1lLT5jbGll bnQoKSkKKyAgICAgICAgcmV0dXJuOworICAgIG1fd2ViRnJhbWUtPmNsaWVudCgpLT5kaWRDaGFu Z2VOYW1lKG1fd2ViRnJhbWUsIG5hbWUpOworfQorCiAjaWYgRU5BQkxFKFdFQl9JTlRFTlRTX1RB RykKIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRJbXBsOjpyZWdpc3RlckludGVudFNlcnZpY2UoCiAg ICAgICAgIGNvbnN0IFN0cmluZyYgYWN0aW9uLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuaAppbmRleCBhMTlhNzgyYzA2NzZlNDhhN2Nj NDVkZDdlNGE1MDk1YmRlMTEwYTdlLi40MzAyM2VlM2Q4NWM5YzkxOWI2ZTVhZjBiYmEzMjM4NDNh OWJlNWU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRl ckNsaWVudEltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRl ckNsaWVudEltcGwuaApAQCAtMjA5LDYgKzIwOSw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwg UGFzc1JlZlB0cjxXZWJDb3JlOjpGcmFtZU5ldHdvcmtpbmdDb250ZXh0PiBjcmVhdGVOZXR3b3Jr aW5nQ29udGV4dCgpOwogICAgIHZpcnR1YWwgYm9vbCB3aWxsQ2hlY2tBbmREaXNwYXRjaE1lc3Nh Z2VFdmVudChXZWJDb3JlOjpTZWN1cml0eU9yaWdpbiogdGFyZ2V0LCBXZWJDb3JlOjpNZXNzYWdl RXZlbnQqKSBjb25zdDsKKyAgICB2aXJ0dWFsIHZvaWQgZGlkQ2hhbmdlTmFtZShjb25zdCBTdHJp bmcmKTsKIAogI2lmIEVOQUJMRShXRUJfSU5URU5UU19UQUcpCiAgICAgdmlydHVhbCB2b2lkIHJl Z2lzdGVySW50ZW50U2VydmljZShjb25zdCBTdHJpbmcmIGFjdGlvbiwK