104389 2012-12-07 12:21:38 -0800 [BlackBerry] General code cleanup and improved logging 2012-12-07 14:41:46 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nima.ghanavatian nima.ghanavatian mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 786047 0 nima.ghanavatian 2012-12-07 12:21:38 -0800 SSIA 786056 1 178254 nima.ghanavatian 2012-12-07 12:34:57 -0800 Created attachment 178254 Patch 786070 2 178254 rwlbuis 2012-12-07 12:44:46 -0800 Comment on attachment 178254 Patch LGTM. 786180 3 178254 webkit.review.bot 2012-12-07 14:41:43 -0800 Comment on attachment 178254 Patch Clearing flags on attachment: 178254 Committed r136987: <http://trac.webkit.org/changeset/136987> 786181 4 webkit.review.bot 2012-12-07 14:41:46 -0800 All reviewed patches have been landed. Closing bug. 178254 2012-12-07 12:34:57 -0800 2012-12-07 14:41:43 -0800 Patch bug-104389-20121207152651.patch text/plain 3042 nima.ghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAxMzVjNzI2Nzk1YzQ5MjBlOWZkMzBkMDRkNzdlYTIzMmQxNGE1NWNkLi41NmJjMjE4M2M1 NGUxMDMzMDk0MWU0YTE5MGZiYWE0OGZkMjBhODFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0xMi0wNCAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBHZW5lcmFsIGNvZGUg Y2xlYW51cCBhbmQgaW1wcm92ZWQgbG9nZ2luZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDM4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgTWlrZSBGZW50b24K KworICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKKyAgICAgICAgKEJs YWNrQmVycnk6OldlYktpdDo6Y29udmVydFN0cmluZ1RvV2NoYXIpOgorICAgICAgICAoQmxhY2tC ZXJyeTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6OnJlcXVlc3RDaGVja2luZ09mU3RyaW5nKToKKyAg ICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5wdXRIYW5kbGVyOjpoYW5kbGVLZXlib2FyZElu cHV0KToKKwogMjAxMi0xMi0wNyAgQW5kcmV3IExvICA8YW5sb0ByaW0uY29tPgogCiAgICAgICAg IFtCbGFja0JlcnJ5XSBEb3VibGUgem9vbSBhbmltYXRpb24gd2hlbiBmb2N1c2luZyBvbiBpbnB1 dCBmaWVsZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBw b3J0L0lucHV0SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3Vw cG9ydC9JbnB1dEhhbmRsZXIuY3BwCmluZGV4IDI5ZGJjYmE3NDc4MTAwZTEzNzE0ZTY0N2E2ODc5 MzlkOGVhZGJlMmIuLjVjMjFiNzEyNWJmNTY1YjI1ZWQ4MTk1YjQwYWE1Y2JmMTY0MWJmYWEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFu ZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5w dXRIYW5kbGVyLmNwcApAQCAtNDg2LDE0ICs0ODYsMTcgQEAgc3RhdGljIGJvb2wgY29udmVydFN0 cmluZ1RvV2NoYXIoY29uc3QgV1RGOjpTdHJpbmcmIHN0cmluZywgd2NoYXJfdCogZGVzdCwgaW50 IGQKIHsKICAgICBBU1NFUlQoZGVzdCk7CiAKLSAgICBpZiAoIXN0cmluZy5sZW5ndGgoKSkgewor ICAgIGludCBsZW5ndGggPSBzdHJpbmcubGVuZ3RoKCk7CisKKyAgICBpZiAoIWxlbmd0aCkgewog ICAgICAgICBkZXN0TGVuZ3RoID0gMDsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCiAg ICAgVUVycm9yQ29kZSBlYyA9IFVfWkVST19FUlJPUjsKKwogICAgIC8vIHdjaGFyX3Qgc3RyaW5n cyBzZW50IHRvIElNRiBhcmUgMzIgYml0IHNvIGNhc3RpbmcgdG8gVUNoYXIzMiBpcyBzYWZlLgot ICAgIHVfc3RyVG9VVEYzMihyZWludGVycHJldF9jYXN0PFVDaGFyMzIqPihkZXN0KSwgZGVzdENh cGFjaXR5LCBkZXN0TGVuZ3RoLCBzdHJpbmcuY2hhcmFjdGVycygpLCBzdHJpbmcubGVuZ3RoKCks ICZlYyk7CisgICAgdV9zdHJUb1VURjMyKHJlaW50ZXJwcmV0X2Nhc3Q8VUNoYXIzMio+KGRlc3Qp LCBkZXN0Q2FwYWNpdHksIGRlc3RMZW5ndGgsIHN0cmluZy5jaGFyYWN0ZXJzKCksIGxlbmd0aCwg JmVjKTsKICAgICBpZiAoZWMpIHsKICAgICAgICAgbG9nQWx3YXlzKExvZ0xldmVsQ3JpdGljYWws ICJJbnB1dEhhbmRsZXI6OmNvbnZlcnRTdHJpbmdUb1djaGFyIEVycm9yIGNvbnZlcnRpbmcgc3Ry aW5nIGVjICglZCkuIiwgZWMpOwogICAgICAgICBkZXN0TGVuZ3RoID0gMDsKQEAgLTU4NCw2ICs1 ODcsOCBAQCB2b2lkIElucHV0SGFuZGxlcjo6cmVxdWVzdENoZWNraW5nT2ZTdHJpbmcoUGFzc1Jl ZlB0cjxXZWJDb3JlOjpUZXh0Q2hlY2tpbmdSZXF1ZQogewogICAgIG1fcmVxdWVzdCA9IHRleHRD aGVja2luZ1JlcXVlc3Q7CiAKKyAgICBJbnB1dExvZyhMb2dMZXZlbEluZm8sICJJbnB1dEhhbmRs ZXI6OnJlcXVlc3RDaGVja2luZ09mU3RyaW5nICclcyciLCBtX3JlcXVlc3QtPnRleHQoKS5sYXRp bjEoKS5kYXRhKCkpOworCiAgICAgaWYgKCFtX3JlcXVlc3QpIHsKICAgICAgICAgU3BlbGxpbmdM b2coTG9nTGV2ZWxXYXJuLCAiSW5wdXRIYW5kbGVyOjpyZXF1ZXN0Q2hlY2tpbmdPZlN0cmluZyBk aWQgbm90IHJlY2VpdmUgYSB2YWxpZCByZXF1ZXN0LiIpOwogICAgICAgICByZXR1cm47CkBAIC0x NjE0LDcgKzE2MTksNyBAQCB2b2lkIElucHV0SGFuZGxlcjo6Y2FuY2VsU2VsZWN0aW9uKCkKIAog Ym9vbCBJbnB1dEhhbmRsZXI6OmhhbmRsZUtleWJvYXJkSW5wdXQoY29uc3QgUGxhdGZvcm06Oktl eWJvYXJkRXZlbnQmIGtleWJvYXJkRXZlbnQsIGJvb2wgY2hhbmdlSXNQYXJ0T2ZDb21wb3NpdGlv bikKIHsKLSAgICBJbnB1dExvZyhMb2dMZXZlbEluZm8sICJJbnB1dEhhbmRsZXI6OmhhbmRsZUtl eWJvYXJkSW5wdXQgcmVjZWl2ZWQgY2hhcmFjdGVyPSVsYywgdHlwZT0lZCIsIGtleWJvYXJkRXZl bnQuY2hhcmFjdGVyKCksIGtleWJvYXJkRXZlbnQudHlwZSgpKTsKKyAgICBJbnB1dExvZyhMb2dM ZXZlbEluZm8sICJJbnB1dEhhbmRsZXI6OmhhbmRsZUtleWJvYXJkSW5wdXQgcmVjZWl2ZWQgY2hh cmFjdGVyPSclYycsIHR5cGU9JWQiLCBrZXlib2FyZEV2ZW50LmNoYXJhY3RlcigpLCBrZXlib2Fy ZEV2ZW50LnR5cGUoKSk7CiAKICAgICAvLyBDbGVhcmluZyB0aGUgbV9yZWNlaXZlZEJhY2tzcGFj ZUtleURvd24gc3RhdGUgb24gYW55IEtleWJvYXJkRXZlbnQuCiAgICAgbV9yZWNlaXZlZEJhY2tz cGFjZUtleURvd24gPSBmYWxzZTsK