104387 2012-12-07 12:10:34 -0800 XMLSerializer is too aggressive in adding prefixes 2012-12-07 14:14:32 -0800 1 1 1 Unclassified WebKit XML 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 schenney schenney ap darin eric krit mifenton peterejkemp rniwa webkit.review.bot oldest_to_newest 786034 0 schenney 2012-12-07 12:10:34 -0800 Bug https://bugs.webkit.org/show_bug.cgi?id=79586 fixed an issue with SVG xlink references in cases where the "xlink:" prefix was being dropped from svg attributes. It turns out that we were too aggressive in this, at least compared to other browsers. See http://stackoverflow.com/q/12803451/209103 Patch in a moment. 786040 1 178251 schenney 2012-12-07 12:17:42 -0800 Created attachment 178251 Patch 786048 2 178251 rniwa 2012-12-07 12:22:11 -0800 Comment on attachment 178251 Patch Makes sense. 786143 3 178251 webkit.review.bot 2012-12-07 14:14:28 -0800 Comment on attachment 178251 Patch Clearing flags on attachment: 178251 Committed r136984: <http://trac.webkit.org/changeset/136984> 786144 4 webkit.review.bot 2012-12-07 14:14:32 -0800 All reviewed patches have been landed. Closing bug. 178251 2012-12-07 12:17:42 -0800 2012-12-07 14:14:28 -0800 Patch bug-104387-20121207151506.patch text/plain 5165 schenney SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNjk2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEyLTA3ICBTdGVwaGVu IENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgWE1MU2VyaWFsaXpl ciBpcyB0b28gYWdncmVzc2l2ZSBpbiBhZGRpbmcgcHJlZml4ZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDM4NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGhhdmUgYmVlbiBhZGRpbmcgInhsaW5r OiIgYW5kICJ4bWxuczoiIGFuZCAieG1sOiIgcHJlZml4ZXMgdG8gYW55CisgICAgICAgIGF0dHJp YnV0ZSB0aGF0IGlzIGluIG9uZSBvZiB0aG9zZSBuYW1lc3BhY2VzIGJ1dCB3aGljaCBkaWQgbm90 IGFscmVhZHkKKyAgICAgICAgaGF2ZSB0aGUgbWF0Y2hpbmcgcHJlZml4LiBUaGlzIGFwcGVhcnMg dG8gYmUgaW4gZXJyb3IsIGF0IGxlYXN0CisgICAgICAgIGNvbXBhcmVkIHRvIG90aGVyIGJyb3dz ZXJzLgorCisgICAgICAgIFRoZSBjb3JyZWN0IGJlaGF2aW9yIGFwcGVhcnMgdG8gYmUgdG8gYWRk IHRoZSBwcmVmaXggb25seSBpZiB0aGVyZSBpcworICAgICAgICBubyBleGlzdGluZyBwcmVmaXgu IElmIHRoZXJlIGlzIGFuIGV4aXN0aW5nIHByZWZpeCwgd2Ugbm93IGxlYXZlIGl0IGFsb25lLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cy4gRXhpc3RpbmcgdGVzdCBleHBhbmRlZC4KKworICAgICAg ICAqIGVkaXRpbmcvTWFya3VwQWNjdW11bGF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWFy a3VwQWNjdW11bGF0b3I6OmFwcGVuZEF0dHJpYnV0ZSk6IE9ubHkgcmVwbGFjZSB0aGUgcHJlZml4 CisgICAgICAgIGF0dHJpYnV0ZSBuYW1lIHByZWZpeCBpZiBpdCBpcyBlbXB0eSwgYW5kIGluIG9u ZSBvZiB0aGUgcmVjb2duaXNlZAorICAgICAgICBuYW1lc3BhY2VzLgorCiAyMDEyLTEyLTA3ICBS b2JlcnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OKHIx MjcxNjMpOiBDb250ZW50IGlzIG9mZnNldCB0byB0aGUgcmlnaHQgYXQgcmVhLnJ1CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9lZGl0aW5nL01hcmt1cEFjY3VtdWxhdG9yLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL01hcmt1cEFjY3VtdWxhdG9yLmNwcAkocmV2aXNpb24g MTM2OTU0KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9NYXJrdXBBY2N1bXVsYXRvci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQ1NSwxMyArNDU1LDEzIEBAIHZvaWQgTWFya3VwQWNjdW11bGF0 b3I6OmFwcGVuZEF0dHJpYnV0ZSgKICAgICBlbHNlIHsKICAgICAgICAgUXVhbGlmaWVkTmFtZSBw cmVmaXhlZE5hbWUgPSBhdHRyaWJ1dGUubmFtZSgpOwogICAgICAgICBpZiAoYXR0cmlidXRlLm5h bWVzcGFjZVVSSSgpID09IFhMaW5rTmFtZXM6OnhsaW5rTmFtZXNwYWNlVVJJKSB7Ci0gICAgICAg ICAgICBpZiAoYXR0cmlidXRlLnByZWZpeCgpICE9IHhsaW5rQXRvbSkKKyAgICAgICAgICAgIGlm ICghYXR0cmlidXRlLnByZWZpeCgpKQogICAgICAgICAgICAgICAgIHByZWZpeGVkTmFtZS5zZXRQ cmVmaXgoeGxpbmtBdG9tKTsKICAgICAgICAgfSBlbHNlIGlmIChhdHRyaWJ1dGUubmFtZXNwYWNl VVJJKCkgPT0gWE1MTmFtZXM6OnhtbE5hbWVzcGFjZVVSSSkgewotICAgICAgICAgICAgaWYgKGF0 dHJpYnV0ZS5wcmVmaXgoKSAhPSB4bWxBdG9tKQorICAgICAgICAgICAgaWYgKCFhdHRyaWJ1dGUu cHJlZml4KCkpCiAgICAgICAgICAgICAgICAgcHJlZml4ZWROYW1lLnNldFByZWZpeCh4bWxBdG9t KTsKICAgICAgICAgfSBlbHNlIGlmIChhdHRyaWJ1dGUubmFtZXNwYWNlVVJJKCkgPT0gWE1MTlNO YW1lczo6eG1sbnNOYW1lc3BhY2VVUkkpIHsKLSAgICAgICAgICAgIGlmIChhdHRyaWJ1dGUubmFt ZSgpICE9IFhNTE5TTmFtZXM6OnhtbG5zQXR0ciAmJiBhdHRyaWJ1dGUucHJlZml4KCkgIT0geG1s bnNBdG9tKQorICAgICAgICAgICAgaWYgKGF0dHJpYnV0ZS5uYW1lKCkgIT0gWE1MTlNOYW1lczo6 eG1sbnNBdHRyICYmICFhdHRyaWJ1dGUucHJlZml4KCkpCiAgICAgICAgICAgICAgICAgcHJlZml4 ZWROYW1lLnNldFByZWZpeCh4bWxuc0F0b20pOwogICAgICAgICB9CiAgICAgICAgIHJlc3VsdC5h cHBlbmQocHJlZml4ZWROYW1lLnRvU3RyaW5nKCkpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTM2OTY4 KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMTItMDcgIFN0ZXBoZW4gQ2hlbm5leSAgPHNjaGVubmV5QGNocm9taXVtLm9yZz4K KworICAgICAgICBYTUxTZXJpYWxpemVyIGlzIHRvbyBhZ2dyZXNzaXZlIGluIGFkZGluZyBwcmVm aXhlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0 Mzg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRk IGEgdGVzdCBjYXNlIGZvciBhIHByZWZpeCB0aGF0IGlzIGFscmVhZHkgc2V0LCBidXQgdG8gYSBk aWZmZXJlbnQgbmFtZSB0aGFuIHRoZSBkZWZhdWx0LgorCisgICAgICAgICogc3ZnL2N1c3RvbS94 bGluay1wcmVmaXgtaW4tYXR0cmlidXRlcy5odG1sOgorICAgICAgICAqIHN2Zy9jdXN0b20veGxp bmstcHJlZml4LWluLWF0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0OgorCiAyMDEyLTEyLTA3ICBKYW1l cyBTaW1vbnNlbiAgPHNpbW9uamFtQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1d IEVuYWJsZSBJbnRlbCdzIFJlc291cmNlIFRpbWluZyB0ZXN0cwpJbmRleDogTGF5b3V0VGVzdHMv c3ZnL2N1c3RvbS94bGluay1wcmVmaXgtaW4tYXR0cmlidXRlcy1leHBlY3RlZC50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS94bGluay1wcmVmaXgtaW4tYXR0cmlidXRl cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDEzNjk1NCkKKysrIExheW91dFRlc3RzL3N2Zy9jdXN0 b20veGxpbmstcHJlZml4LWluLWF0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkp CkBAIC0xLDIgKzEsMiBAQAotPGRpdiBpZD0idGFyZ2V0Ij4gPGRpdiBpZD0ic3Znb3V0cHV0Ij4g PC9kaXY+PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHN2Zz0iaHR0cDov L3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5 L3hsaW5rIiB3aWR0aD0iMjAwIiBoZWlnaHQ9IjIwMCI+PGltYWdlIHdpZHRoPSIyMCIgaGVpZ2h0 PSIyMCIgeGxpbms6aHJlZj0icmVzb3VyY2VzL2dyZWVuLWNoZWNrZXIucG5nIj48L2ltYWdlPjxp bWFnZSB4PSIwIiB5PSIzMCIgd2lkdGg9IjIwIiBoZWlnaHQ9IjIwIiB4bGluazpocmVmPSJyZXNv dXJjZXMvZ3JlZW4tY2hlY2tlci5wbmciPjwvaW1hZ2U+PC9zdmc+PC9kaXY+Cis8ZGl2IGlkPSJ0 YXJnZXQiPiA8ZGl2IGlkPSJzdmdvdXRwdXQiPiA8L2Rpdj48c3ZnIHhtbG5zPSJodHRwOi8vd3d3 LnczLm9yZy8yMDAwL3N2ZyIgc3ZnPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6 eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiIHdpZHRoPSIyMDAiIGhlaWdodD0i MjAwIj48aW1hZ2Ugd2lkdGg9IjIwIiBoZWlnaHQ9IjIwIiB4bGluazpocmVmPSJyZXNvdXJjZXMv Z3JlZW4tY2hlY2tlci5wbmciPjwvaW1hZ2U+PGltYWdlIHg9IjAiIHk9IjMwIiB3aWR0aD0iMjAi IGhlaWdodD0iMjAiIHhsaW5rOmhyZWY9InJlc291cmNlcy9ncmVlbi1jaGVja2VyLnBuZyI+PC9p bWFnZT48L3N2Zz48L2Rpdj4gPEVsIHhtbG5zOmE9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxp bmsiIGE6dGl0bGU9IkMiIGE6aHJlZj0iSCIvPgogCkluZGV4OiBMYXlvdXRUZXN0cy9zdmcvY3Vz dG9tL3hsaW5rLXByZWZpeC1pbi1hdHRyaWJ1dGVzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvc3ZnL2N1c3RvbS94bGluay1wcmVmaXgtaW4tYXR0cmlidXRlcy5odG1sCShyZXZpc2lv biAxMzY5NTQpCisrKyBMYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3hsaW5rLXByZWZpeC1pbi1hdHRy aWJ1dGVzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTQxLDggKzQxLDEyIEBACiAgICAgICAgIHZh ciBzZXJpYWxpemVyID0gbmV3IFhNTFNlcmlhbGl6ZXIoKTsKICAgICAgICAgdmFyIHhtbFN0cmlu ZyA9IHNlcmlhbGl6ZXIuc2VyaWFsaXplVG9TdHJpbmcodGFyZ2V0KTsKIAorICAgICAgICB2YXIg eGxpbmtfc3RyID0gJzxFbCBhOnRpdGxlPSJDIiBhOmhyZWY9IkgiIHhtbG5zOmE9Imh0dHA6Ly93 d3cudzMub3JnLzE5OTkveGxpbmsiIC8+JzsKKyAgICAgICAgdmFyIHhsaW5rX2RvbSA9IG5ldyBE T01QYXJzZXIoKS5wYXJzZUZyb21TdHJpbmcoeGxpbmtfc3RyLCAndGV4dC94bWwnKTsKKyAgICAg ICAgdmFyIHhsaW5rX291dHB1dCA9IHNlcmlhbGl6ZXIuc2VyaWFsaXplVG9TdHJpbmcoeGxpbmtf ZG9tKTsKKwogICAgICAgICB2YXIgc3ZnVGV4dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJz dmdvdXRwdXQiKTsKLSAgICAgICAgc3ZnVGV4dC50ZXh0Q29udGVudCA9IHhtbFN0cmluZzsKKyAg ICAgICAgc3ZnVGV4dC50ZXh0Q29udGVudCA9IHhtbFN0cmluZyArICJcbiIgKyB4bGlua19vdXRw dXQ7CiAgICAgfQogICAgIDwvc2NyaXB0PgogPC9oZWFkPgo=