104385 2012-12-07 12:03:09 -0800 [BlackBerry] Remove no-op line in WebPage.cpp 2013-01-04 02:12:48 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rwlbuis rwlbuis mifenton tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 786029 0 rwlbuis 2012-12-07 12:03:09 -0800 SSIA 786033 1 178249 rwlbuis 2012-12-07 12:05:48 -0800 Created attachment 178249 Patch 786086 2 178249 tonikitoo 2012-12-07 13:09:09 -0800 Comment on attachment 178249 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178249&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:-4096 > - tPoint.m_screenPos = tPoint.m_screenPos; is not it a typo? point.m_screenPoint? 786121 3 rwlbuis 2012-12-07 13:59:06 -0800 Hi Antonio, (In reply to comment #2) > (From update of attachment 178249 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178249&action=review > > > Source/WebKit/blackberry/Api/WebPage.cpp:-4096 > > - tPoint.m_screenPos = tPoint.m_screenPos; > > is not it a typo? point.m_screenPoint? I don't think so, anyway the "Platform::TouchPoint tPoint = point;" just above makes them equal. The only point I can see to this line is if it would have used d->mapFromTransformed in the past, but I removed that (badly :)). 800104 4 rwlbuis 2013-01-04 02:12:48 -0800 This was landed in r137031, closing. 178249 2012-12-07 12:05:48 -0800 2012-12-07 20:44:07 -0800 Patch bug-104385-20121207160327.patch text/plain 1457 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBlNDBiOTI2MDRlOTkwZmIzYjZkOTI0YzA3MzY4ZWY3ZjNhMmZmNWU3Li5kZGUzYjE2Yjgw ZGY2MzRkZDQ0ZmIwOGU3NThlZjE4ZmY0N2VjNzg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0xMi0wNyAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBSZW1vdmUgbm8tb3AgbGluZSBpbiBXZWJQYWdl LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0 Mzg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVt b3ZlIHNlbGYtYXNzaWdubWVudCBuby1vcCBsaW5lLiBNdXN0IGhhdmUgYmVlbiBsZWZ0IHdoZW4g SSByZW1vdmVkIHRoZQorICAgICAgICBtYXBGcm9tVHJhbnNmb3JtZWQgcGFydC4KKworICAgICAg ICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFn ZTo6dG91Y2hQb2ludEFzTW91c2VFdmVudCk6CisKIDIwMTItMTItMDcgIE1pa2UgTGF0dGFuemlv ICA8bWxhdHRhbnppb0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBVcGRhdGUgQmxh Y2tCZXJyeSBQb3J0IHRvIHVzZSBuZXcgR3JhcGhpY3M6OmNyZWF0ZUJ1ZmZlciBCdWZmZXJUeXBl IGVudW0gdmFsdWVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9X ZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5k ZXggZjEwZDM3NDM0ODMxMzRjYmUxMTNjNjhkZDk2NDdhNWUxYmNjMWY1OC4uNzk5ZWI1NmQ5Mzc0 NmYxNmFhOTYzOThjNzkyOGVhMzdiYjVlNjlkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL1dlYlBhZ2UuY3BwCkBAIC00MDkzLDcgKzQwOTMsNiBAQCB2b2lkIFdlYlBhZ2U6OnRvdWNo UG9pbnRBc01vdXNlRXZlbnQoY29uc3QgUGxhdGZvcm06OlRvdWNoUG9pbnQmIHBvaW50KQogCiAg ICAgUGxhdGZvcm06OlRvdWNoUG9pbnQgdFBvaW50ID0gcG9pbnQ7CiAgICAgdFBvaW50Lm1fcG9z ID0gZC0+bWFwRnJvbVRyYW5zZm9ybWVkKHRQb2ludC5tX3Bvcyk7Ci0gICAgdFBvaW50Lm1fc2Ny ZWVuUG9zID0gdFBvaW50Lm1fc2NyZWVuUG9zOwogCiAgICAgZC0+bV90b3VjaEV2ZW50SGFuZGxl ci0+aGFuZGxlVG91Y2hQb2ludCh0UG9pbnQpOwogfQo=