104383 2012-12-07 11:34:09 -0800 Web Inspector: Evaluate private browsing mode's effect on console messages. 2012-12-11 01:19:05 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 104454 1 mkwst mkwst abarth apavlov ap dglazkov japhet jochen keishi loislo mjs mrowe pfeldman pmuellr timothy vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 786013 0 mkwst 2012-12-07 11:34:09 -0800 Some console messages are gated on not being in private browsing mode (e.g. CachedResourceLoader::printAccessDeniedMessage). 1. Is this still relevant? Do console messages end up in system logs somewhere? 2. If it's relevant, how can we avoid making every call site do the check? Centralizing it somewhere (in Console?) might make sense. 3. What about the strange printf'ing we do in Console::addMessage? Is that necessary? If so, it should almost certainly be gated on private browsing. 4. More questions? 786020 1 mkwst 2012-12-07 11:46:07 -0800 Adam added this check in particular was added 4 years ago in http://trac.webkit.org/changeset/34720. :) No bug number, however. I'll dig around for other occurrences. 786027 2 mkwst 2012-12-07 11:56:52 -0800 DOMWindow::printErrorMessage used to be in the JSC bindings as printErrorMessageForFrame, added in http://trac.webkit.org/changeset/49963 No commentary for that bit, however. Monday morning, I'll dig a bit more into which messages these two methods are gating on privacy grounds. 786088 3 mkwst 2012-12-07 13:14:18 -0800 +jochen, who has opinions. 786101 4 jochen 2012-12-07 13:33:24 -0800 (In reply to comment #3) > +jochen, who has opinions. According to http://trac.webkit.org/browser/trunk/Source/WebCore/page/Settings.h#L161 we don't record any console message in private browsing mode. I agree that this should probably be enforced in the Console 786191 5 ap 2012-12-07 14:51:43 -0800 > 3. What about the strange printf'ing we do in Console::addMessage? Is that necessary? It implements WebKit1 Mac SPI, +[WebCoreStatistics setShouldPrintExceptions:]. 786196 6 timothy 2012-12-07 14:57:34 -0800 (In reply to comment #5) > > 3. What about the strange printf'ing we do in Console::addMessage? Is that necessary? > > It implements WebKit1 Mac SPI, +[WebCoreStatistics setShouldPrintExceptions:]. And it is something I plan to add to WK2. I have a local patch I use to make it work in WK2. It makes debugging the Web Inspector easier. 786446 7 mkwst 2012-12-07 23:50:11 -0800 (In reply to comment #4) > (In reply to comment #3) > > +jochen, who has opinions. > > According to http://trac.webkit.org/browser/trunk/Source/WebCore/page/Settings.h#L161 we don't record any console message in private browsing mode. Hrm. Ok. I don't understand the privacy violation of console messages. Are they potentially logged to some persistant storage? As long as they're transient, what is the risk we're protecting users against? 786448 8 timothy 2012-12-08 00:16:44 -0800 (In reply to comment #7) > (In reply to comment #4) > > (In reply to comment #3) > > > +jochen, who has opinions. > > > > According to http://trac.webkit.org/browser/trunk/Source/WebCore/page/Settings.h#L161 we don't record any console message in private browsing mode. > > Hrm. Ok. > > I don't understand the privacy violation of console messages. Are they potentially logged to some persistant storage? As long as they're transient, what is the risk we're protecting users against? They can go to the system log (seen via Console.app) if you just launch the app via double click (like a user). If you launch via the Terminal or Xcode it dumps to the TTY and not the system log. 786456 9 mkwst 2012-12-08 00:52:06 -0800 (In reply to comment #8) > They can go to the system log (seen via Console.app) if you just launch the app via double click (like a user). If you launch via the Terminal or Xcode it dumps to the TTY and not the system log. Thanks for the detail! Are you talking about the printf'd messages, or the messages sent to the console? I see three things happening in Console::addMessage: 1. The message is sent to a ChromeClient. 2. The message is sent to InspectorInstrumentation. 3. The message is (potentially) printf'd. Do all three potentially leak information to the system log? If possible, I'd like to retain #2, as I haven't seen any code in Inspector that would write information outside the context of the browsing session, but I agree that the other two should probably be gated on private browsing mode. I'll put up a patch for discussion on Monday. 786457 10 jochen 2012-12-08 00:58:38 -0800 Can't you turn private browsing mode on and off during runtime? In that case you might want to clear the console messages stored in the inspector when private browsing is disabled again. 786459 11 mkwst 2012-12-08 01:11:10 -0800 (In reply to comment #10) > Can't you turn private browsing mode on and off during runtime? In that case you might want to clear the console messages stored in the inspector when private browsing is disabled again. That makes sense. We should also clear any stored exceptions that haven't made it to the console yet (ScriptExecutionContext::PendingException). 786496 12 timothy 2012-12-08 07:40:33 -0800 (In reply to comment #9) > (In reply to comment #8) > > > They can go to the system log (seen via Console.app) if you just launch the app via double click (like a user). If you launch via the Terminal or Xcode it dumps to the TTY and not the system log. > > Thanks for the detail! Are you talking about the printf'd messages, or the messages sent to the console? > > I see three things happening in Console::addMessage: > > 1. The message is sent to a ChromeClient. > 2. The message is sent to InspectorInstrumentation. > 3. The message is (potentially) printf'd. > > Do all three potentially leak information to the system log? If possible, I'd like to retain #2, as I haven't seen any code in Inspector that would write information outside the context of the browsing session, but I agree that the other two should probably be gated on private browsing mode. > > I'll put up a patch for discussion on Monday. I was just talking about printf. 786587 13 178373 mkwst 2012-12-08 13:00:30 -0800 Created attachment 178373 Patch 786594 14 mkwst 2012-12-08 13:04:11 -0800 (In reply to comment #13) > Created an attachment (id=178373) [details] > Patch Here's a strawman that blocks ChromeClient and printf notifications, but allows InspectorInstrumentation. If there's agreement that this is what we want, I'll put some tests together. Filed bug 104454 to cover clearing console state when exiting private browsing, as it's a bit tangential to what we're focusing on here. 787273 15 178537 mkwst 2012-12-10 06:42:38 -0800 Created attachment 178537 Patch 787275 16 mkwst 2012-12-10 06:44:03 -0800 I had a quick chat with Pavel, he's happy with the change. Carrying over Pavel's r+ and throwing the updated patch to the bots. I'll wait to land this to give PST-zone folks a chance to weigh in. Thanks! 787338 17 178537 webkit.review.bot 2012-12-10 08:00:48 -0800 Comment on attachment 178537 Patch Attachment 178537 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15239483 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 788131 18 178537 mkwst 2012-12-11 00:40:31 -0800 Comment on attachment 178537 Patch I pinged ap on IRC last night; no concerns given the folks already CCd on the bug. (In reply to comment #17) > (From update of attachment 178537 [details]) > Attachment 178537 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15239483 > > New failing tests: > inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html This runs locally without crashing. Calling it flake; let's see what the CQ says. :) 788157 19 178537 webkit.review.bot 2012-12-11 01:18:59 -0800 Comment on attachment 178537 Patch Clearing flags on attachment: 178537 Committed r137267: <http://trac.webkit.org/changeset/137267> 788158 20 webkit.review.bot 2012-12-11 01:19:05 -0800 All reviewed patches have been landed. Closing bug. 178373 2012-12-08 13:00:30 -0800 2012-12-10 06:42:32 -0800 Patch bug-104383-20121208215753.patch text/plain 6604 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGRjMTljYTZlNTNkNDZm MzkzYmMyMDlmZWMyNmRkMWI1NzI1NjVkNS4uZTE1M2YzZjNkODc1MjJhZDI1NzQ2NzJkODAyZWUx ZTdmZGIwMjllNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDEyLTEyLTA4ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRXZh bHVhdGUgcHJpdmF0ZSBicm93c2luZyBtb2RlJ3MgZWZmZWN0IG9uIGNvbnNvbGUgbWVzc2FnZXMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQzODMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUd28gc2V0 cyBvZiBjb25zb2xlIG1lc3NhZ2VzIGFyZSBjdXJyZW50bHkgZ2F0ZWQgb24gcHJpdmF0ZSBicm93 c2luZworICAgICAgICBtb2RlIGJlaW5nIGluYWN0aXZlLiBUaGlzIHBhdGNoIGNlbnRyYWxpemVz IHRoZSBwcml2YXRlIGJyb3dzaW5nIGNoZWNrcworICAgICAgICBpbiBvcmRlciB0byBhcHBseSB0 aGVtIGVxdWFsbHkgdG8gYWxsIGNvbnNvbGUgbWVzc2FnZXMsIGFuZCBjaGFuZ2VzIHRoZQorICAg ICAgICBncmFudWxhcml0eSBhdCB3aGljaCB0aGV5IGFjdC4KKworICAgICAgICBUaGUgY3VycmVu dCBjaGVja3MgYmxvY2sgdGhlIGNvbnNvbGUgbWVzc2FnZXMgZW50aXJlbHkuIFRoaXMgcGF0Y2gK KyAgICAgICAgYmxvY2tzIG9ubHkgbm90aWZpY2F0aW9ucyB0byBDaHJvbWVDbGllbnQgYW5kIGVu c3VyZXMgdGhhdCBtZXNzYWdlcworICAgICAgICB3b24ndCBiZSBwYXNzZWQgdG8gcHJpbnRmIHdo ZXJlIHRoZXkgbWlnaHQgZW5kIHVwIGluIHN5c3RlbSBsb2dzLgorICAgICAgICBOb3RpZmljYXRp b25zIHRvIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbiBzZWVtIHNhZmU7IHNvIGZhciBhcyBJIGNh bgorICAgICAgICB0ZWxsLCB0aGVyZSdzIG5vIGNvbXBlbGxpbmcgcmVhc29uIHRvIHByZXZlbnQg Y29uc29sZS1iYXNlZCBkZWJ1Z2dpbmcKKyAgICAgICAgaW4gcHJpdmF0ZSBicm93c2luZyBtb2Rl LiBUaGlzIHBhdGNoIGV4Y2x1ZGVzIHRob3NlIGNhbGxzIGZyb20gdGhlCisgICAgICAgIHByaXZh dGUgYnJvd3NpbmcgY2hlY2suCisKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3Vy Y2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FjaGVkUmVzb3VyY2VMb2FkZXI6OnBy aW50QWNjZXNzRGVuaWVkTWVzc2FnZSk6CisgICAgICAgICAgICBEcm9wIHRoZSBwcml2YXRlIGJy b3dzaW5nIGNoZWNrLgorICAgICAgICAqIHBhZ2UvQ29uc29sZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpDb25zb2xlOjphZGRNZXNzYWdlKToKKyAgICAgICAgICAgIEFkZCBwcml2YXRlIGJyb3dz aW5nIGNoZWNrcyB0byB0aGUgdHdvIDo6YWRkTWVzc2FnZSB2YXJpYW50cyB0aGF0CisgICAgICAg ICAgICBkbyByZWFsIHdvcmsuIEVuc3VyZSB0aGF0IGNhbGxzIHRvIHByaW50ZiBhbmQgbm90aWZp Y2F0aW9ucyB0bworICAgICAgICAgICAgQ2hyb21lQ2xpZW50cyBhcmUgZ2F0ZWQgb24gdGhlc2Ug Y2hlY2tzLCBidXQgYWx3YXlzIGFsbG93CisgICAgICAgICAgICBub3RpZmljYXRpb25zIHRvIElu c3BlY3Rvckluc3RydW1lbnRhdGlvbi4KKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6OnByaW50RXJyb3JNZXNzYWdlKToKKyAgICAgICAg ICAgIERyb3AgdGhlIHByaXZhdGUgYnJvd3NpbmcgY2hlY2suCisKIDIwMTItMTItMDggIEd1c3Rh dm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg TWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hl L0NhY2hlZFJlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9D YWNoZWRSZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggNGZiYWY0NzdjNzUwZjEzZjhmZjY4YjEzNmJl OTcxYmFkNTkxN2Q1Ny4uMWIyYzVjZWQyNDJjZjFjNjQ3NmIwMWU5NDU2N2IwY2VlODI5ZmU0NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9h ZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VM b2FkZXIuY3BwCkBAIC02MzAsMTcgKzYzMCwxMiBAQCB2b2lkIENhY2hlZFJlc291cmNlTG9hZGVy OjpwcmludEFjY2Vzc0RlbmllZE1lc3NhZ2UoY29uc3QgS1VSTCYgdXJsKSBjb25zdAogICAgIGlm ICghZnJhbWUoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgU2V0dGluZ3MqIHNldHRpbmdzID0g ZnJhbWUoKS0+c2V0dGluZ3MoKTsKLSAgICBpZiAoIXNldHRpbmdzIHx8IHNldHRpbmdzLT5wcml2 YXRlQnJvd3NpbmdFbmFibGVkKCkpCi0gICAgICAgIHJldHVybjsKLQogICAgIFN0cmluZyBtZXNz YWdlOwogICAgIGlmICghbV9kb2N1bWVudCB8fCBtX2RvY3VtZW50LT51cmwoKS5pc051bGwoKSkK ICAgICAgICAgbWVzc2FnZSA9ICJVbnNhZmUgYXR0ZW1wdCB0byBsb2FkIFVSTCAiICsgdXJsLnN0 cmluZygpICsgJy4nOwogICAgIGVsc2UKICAgICAgICAgbWVzc2FnZSA9ICJVbnNhZmUgYXR0ZW1w dCB0byBsb2FkIFVSTCAiICsgdXJsLnN0cmluZygpICsgIiBmcm9tIGZyYW1lIHdpdGggVVJMICIg KyBtX2RvY3VtZW50LT51cmwoKS5zdHJpbmcoKSArICIuIERvbWFpbnMsIHByb3RvY29scyBhbmQg cG9ydHMgbXVzdCBtYXRjaC5cbiI7CiAKLSAgICAvLyBGSVhNRTogcHJvdmlkZSBsaW5lIG51bWJl ciBhbmQgc291cmNlIFVSTC4KICAgICBmcmFtZSgpLT5kb2N1bWVudCgpLT5hZGRDb25zb2xlTWVz c2FnZShPdGhlck1lc3NhZ2VTb3VyY2UsIExvZ01lc3NhZ2VUeXBlLCBFcnJvck1lc3NhZ2VMZXZl bCwgbWVzc2FnZSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ29uc29s ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnNvbGUuY3BwCmluZGV4IDk2YzNjZTNkZGY0 ODczMDI0ZmJjOGJlMjY3NDM3NmY5NzIwNGNkZGQuLjU3MTRkNmZiMWVkYWI5NDUyM2VjMWU2M2Y2 YThjODE5ZWM4OWE3ZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ29uc29sZS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Db25zb2xlLmNwcApAQCAtNDcsNiArNDcsNyBA QAogI2luY2x1ZGUgIlNjcmlwdFByb2ZpbGVyLmgiCiAjaW5jbHVkZSAiU2NyaXB0VmFsdWUuaCIK ICNpbmNsdWRlICJTY3JpcHRhYmxlRG9jdW1lbnRQYXJzZXIuaCIKKyNpbmNsdWRlICJTZXR0aW5n cy5oIgogI2luY2x1ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSA8d3RmL1VudXNlZFBhcmFtLmg+CiAj aW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgpAQCAtMTYzLDE0ICsxNjQsMTcgQEAgdm9pZCBD b25zb2xlOjphZGRNZXNzYWdlKE1lc3NhZ2VTb3VyY2Ugc291cmNlLCBNZXNzYWdlVHlwZSB0eXBl LCBNZXNzYWdlTGV2ZWwgbGUKICAgICBpZiAoIXBhZ2UpCiAgICAgICAgIHJldHVybjsKIAotICAg IHBhZ2UtPmNocm9tZSgpLT5jbGllbnQoKS0+YWRkTWVzc2FnZVRvQ29uc29sZShzb3VyY2UsIHR5 cGUsIGxldmVsLCBtZXNzYWdlLCBsaW5lTnVtYmVyLCB1cmwpOwotCiAgICAgaWYgKGNhbGxTdGFj aykKICAgICAgICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjphZGRNZXNzYWdlVG9Db25zb2xl KHBhZ2UsIHNvdXJjZSwgdHlwZSwgbGV2ZWwsIG1lc3NhZ2UsIGNhbGxTdGFjaywgcmVxdWVzdElk ZW50aWZpZXIpOwogICAgIGVsc2UKICAgICAgICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjph ZGRNZXNzYWdlVG9Db25zb2xlKHBhZ2UsIHNvdXJjZSwgdHlwZSwgbGV2ZWwsIG1lc3NhZ2UsIHVy bCwgbGluZU51bWJlciwgc3RhdGUsIHJlcXVlc3RJZGVudGlmaWVyKTsKIAotICAgIGlmICghQ29u c29sZTo6c2hvdWxkUHJpbnRFeGNlcHRpb25zKCkpCisgICAgaWYgKCFtX2ZyYW1lLT5zZXR0aW5n cygpIHx8IG1fZnJhbWUtPnNldHRpbmdzKCktPnByaXZhdGVCcm93c2luZ0VuYWJsZWQoKSkKKyAg ICAgICAgcmV0dXJuOworCisgICAgcGFnZS0+Y2hyb21lKCktPmNsaWVudCgpLT5hZGRNZXNzYWdl VG9Db25zb2xlKHNvdXJjZSwgdHlwZSwgbGV2ZWwsIG1lc3NhZ2UsIGxpbmVOdW1iZXIsIHVybCk7 CisKKyAgICBpZiAoIXNob3VsZFByaW50RXhjZXB0aW9ucygpKQogICAgICAgICByZXR1cm47CiAK ICAgICBwcmludFNvdXJjZVVSTEFuZExpbmUodXJsLCBsaW5lTnVtYmVyKTsKQEAgLTE5NCw2ICsx OTgsMTYgQEAgdm9pZCBDb25zb2xlOjphZGRNZXNzYWdlKE1lc3NhZ2VUeXBlIHR5cGUsIE1lc3Nh Z2VMZXZlbCBsZXZlbCwgU2NyaXB0U3RhdGUqIHN0YXQKICAgICBSZWZQdHI8U2NyaXB0Q2FsbFN0 YWNrPiBjYWxsU3RhY2soY3JlYXRlU2NyaXB0Q2FsbFN0YWNrKHN0YXRlLCBzdGFja1NpemUpKTsK ICAgICBjb25zdCBTY3JpcHRDYWxsRnJhbWUmIGxhc3RDYWxsZXIgPSBjYWxsU3RhY2stPmF0KDAp OwogCisgICAgU3RyaW5nIG1lc3NhZ2U7CisgICAgYm9vbCBnb3RNZXNzYWdlID0gYXJndW1lbnRz LT5nZXRGaXJzdEFyZ3VtZW50QXNTdHJpbmcobWVzc2FnZSk7CisgICAgSW5zcGVjdG9ySW5zdHJ1 bWVudGF0aW9uOjphZGRNZXNzYWdlVG9Db25zb2xlKHBhZ2UsIENvbnNvbGVBUElNZXNzYWdlU291 cmNlLCB0eXBlLCBsZXZlbCwgbWVzc2FnZSwgc3RhdGUsIGFyZ3VtZW50cy5yZWxlYXNlKCkpOwor CisgICAgaWYgKCFtX2ZyYW1lLT5zZXR0aW5ncygpIHx8IG1fZnJhbWUtPnNldHRpbmdzKCktPnBy aXZhdGVCcm93c2luZ0VuYWJsZWQoKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgaWYgKGdvdE1l c3NhZ2UpCisgICAgICAgIHBhZ2UtPmNocm9tZSgpLT5jbGllbnQoKS0+YWRkTWVzc2FnZVRvQ29u c29sZShDb25zb2xlQVBJTWVzc2FnZVNvdXJjZSwgdHlwZSwgbGV2ZWwsIG1lc3NhZ2UsIGxhc3RD YWxsZXIubGluZU51bWJlcigpLCBsYXN0Q2FsbGVyLnNvdXJjZVVSTCgpKTsKKwogICAgIGlmIChz aG91bGRQcmludEV4Y2VwdGlvbnMoKSkgewogICAgICAgICBwcmludFNvdXJjZVVSTEFuZExpbmUo bGFzdENhbGxlci5zb3VyY2VVUkwoKSwgMCk7CiAgICAgICAgIHByaW50TWVzc2FnZVNvdXJjZUFu ZExldmVsUHJlZml4KENvbnNvbGVBUElNZXNzYWdlU291cmNlLCBsZXZlbCk7CkBAIC0yMTMsMTIg KzIyNyw2IEBAIHZvaWQgQ29uc29sZTo6YWRkTWVzc2FnZShNZXNzYWdlVHlwZSB0eXBlLCBNZXNz YWdlTGV2ZWwgbGV2ZWwsIFNjcmlwdFN0YXRlKiBzdGF0CiAgICAgICAgICAgICBwcmludGYoIlx0 JXNcbiIsIGZ1bmN0aW9uTmFtZS51dGY4KCkuZGF0YSgpKTsKICAgICAgICAgfQogICAgIH0KLQot ICAgIFN0cmluZyBtZXNzYWdlOwotICAgIGlmIChhcmd1bWVudHMtPmdldEZpcnN0QXJndW1lbnRB c1N0cmluZyhtZXNzYWdlKSkKLSAgICAgICAgcGFnZS0+Y2hyb21lKCktPmNsaWVudCgpLT5hZGRN ZXNzYWdlVG9Db25zb2xlKENvbnNvbGVBUElNZXNzYWdlU291cmNlLCB0eXBlLCBsZXZlbCwgbWVz c2FnZSwgbGFzdENhbGxlci5saW5lTnVtYmVyKCksIGxhc3RDYWxsZXIuc291cmNlVVJMKCkpOwot Ci0gICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjphZGRNZXNzYWdlVG9Db25zb2xlKHBhZ2Us IENvbnNvbGVBUElNZXNzYWdlU291cmNlLCB0eXBlLCBsZXZlbCwgbWVzc2FnZSwgc3RhdGUsIGFy Z3VtZW50cy5yZWxlYXNlKCkpOwogfQogCiB2b2lkIENvbnNvbGU6OmRlYnVnKFNjcmlwdFN0YXRl KiBzdGF0ZSwgUGFzc1JlZlB0cjxTY3JpcHRBcmd1bWVudHM+IGFyZ3VtZW50cykKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRE9NV2luZG93LmNwcAppbmRleCBiNzk3NzNiMWRmMDQyZjA1YmZlODEyODRjN2Q2MjI1Mzk0 MjdjNzQxLi45ZWFkMTRlMmRmYzY4NGRiOTMyY2U3ZmMwMDA1ZGMwNGQwZTdhN2RlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9ET01XaW5kb3cuY3BwCkBAIC0xNzU2LDEyICsxNzU2LDYgQEAgdm9pZCBET01XaW5k b3c6OnByaW50RXJyb3JNZXNzYWdlKGNvbnN0IFN0cmluZyYgbWVzc2FnZSkKICAgICBpZiAobWVz c2FnZS5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIFNldHRpbmdzKiBzZXR0aW5n cyA9IG1fZnJhbWUtPnNldHRpbmdzKCk7Ci0gICAgaWYgKCFzZXR0aW5ncykKLSAgICAgICAgcmV0 dXJuOwotICAgIGlmIChzZXR0aW5ncy0+cHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCgpKQotICAgICAg ICByZXR1cm47Ci0KICAgICBjb25zb2xlKCktPmFkZE1lc3NhZ2UoSlNNZXNzYWdlU291cmNlLCBM b2dNZXNzYWdlVHlwZSwgRXJyb3JNZXNzYWdlTGV2ZWwsIG1lc3NhZ2UpOwogfQogCg== 178537 2012-12-10 06:42:38 -0800 2012-12-11 01:18:59 -0800 Patch bug-104383-20121210154006.patch text/plain 10277 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmU4MTFjZGMzNjQyMDE4 OGVjOTg0NTNjYThkMjNkYzNhOTM1NWM5NC4uMTQxZWVkMWNiNzcyMzFlNDZmNTdiYmYzZDQxNzJi YmFmYjIxZTdjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM4IEBACisyMDEyLTEyLTEwICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRXZh bHVhdGUgcHJpdmF0ZSBicm93c2luZyBtb2RlJ3MgZWZmZWN0IG9uIGNvbnNvbGUgbWVzc2FnZXMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQzODMK KworICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgorCisgICAgICAgIFR3byBzZXRz IG9mIGNvbnNvbGUgbWVzc2FnZXMgYXJlIGN1cnJlbnRseSBnYXRlZCBvbiBwcml2YXRlIGJyb3dz aW5nCisgICAgICAgIG1vZGUgYmVpbmcgaW5hY3RpdmUuIFRoaXMgcGF0Y2ggY2VudHJhbGl6ZXMg dGhlIHByaXZhdGUgYnJvd3NpbmcgY2hlY2tzCisgICAgICAgIGluIG9yZGVyIHRvIGFwcGx5IHRo ZW0gZXF1YWxseSB0byBhbGwgY29uc29sZSBtZXNzYWdlcywgYW5kIGNoYW5nZXMgdGhlCisgICAg ICAgIGdyYW51bGFyaXR5IGF0IHdoaWNoIHRoZXkgYWN0LgorCisgICAgICAgIFRoZSBjdXJyZW50 IGNoZWNrcyBibG9jayB0aGUgY29uc29sZSBtZXNzYWdlcyBlbnRpcmVseS4gVGhpcyBwYXRjaAor ICAgICAgICBibG9ja3Mgb25seSBub3RpZmljYXRpb25zIHRvIENocm9tZUNsaWVudCBhbmQgZW5z dXJlcyB0aGF0IG1lc3NhZ2VzCisgICAgICAgIHdvbid0IGJlIHBhc3NlZCB0byBwcmludGYgd2hl cmUgdGhleSBtaWdodCBlbmQgdXAgaW4gc3lzdGVtIGxvZ3MuCisgICAgICAgIE5vdGlmaWNhdGlv bnMgdG8gSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uIHNlZW0gc2FmZTsgc28gZmFyIGFzIEkgY2Fu CisgICAgICAgIHRlbGwsIHRoZXJlJ3Mgbm8gY29tcGVsbGluZyByZWFzb24gdG8gcHJldmVudCBj b25zb2xlLWJhc2VkIGRlYnVnZ2luZworICAgICAgICBpbiBwcml2YXRlIGJyb3dzaW5nIG1vZGUu IFRoaXMgcGF0Y2ggZXhjbHVkZXMgdGhvc2UgY2FsbHMgZnJvbSB0aGUKKyAgICAgICAgcHJpdmF0 ZSBicm93c2luZyBjaGVjay4KKworICAgICAgICBUZXN0OiBpbnNwZWN0b3IvY29uc29sZS9jbGll bnRzLWlnbm9yZWQtaW4tcHJpdmF0ZWJyb3dzaW5nLmh0bWwKKworICAgICAgICAqIGxvYWRlci9j YWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRS ZXNvdXJjZUxvYWRlcjo6cHJpbnRBY2Nlc3NEZW5pZWRNZXNzYWdlKToKKyAgICAgICAgICAgIERy b3AgdGhlIHByaXZhdGUgYnJvd3NpbmcgY2hlY2suCisgICAgICAgICogcGFnZS9Db25zb2xlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbnNvbGU6OmFkZE1lc3NhZ2UpOgorICAgICAgICAgICAg QWRkIHByaXZhdGUgYnJvd3NpbmcgY2hlY2tzIHRvIHRoZSB0d28gOjphZGRNZXNzYWdlIHZhcmlh bnRzIHRoYXQKKyAgICAgICAgICAgIGRvIHJlYWwgd29yay4gRW5zdXJlIHRoYXQgY2FsbHMgdG8g cHJpbnRmIGFuZCBub3RpZmljYXRpb25zIHRvCisgICAgICAgICAgICBDaHJvbWVDbGllbnRzIGFy ZSBnYXRlZCBvbiB0aGVzZSBjaGVja3MsIGJ1dCBhbHdheXMgYWxsb3cKKyAgICAgICAgICAgIG5v dGlmaWNhdGlvbnMgdG8gSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLgorICAgICAgICAqIHBhZ2Uv RE9NV2luZG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVdpbmRvdzo6cHJpbnRFcnJvck1l c3NhZ2UpOgorICAgICAgICAgICAgRHJvcCB0aGUgcHJpdmF0ZSBicm93c2luZyBjaGVjay4KKwog MjAxMi0xMi0xMCAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZDogdG91Y2ggUmVuZGVyaW5nQWxsSW5PbmUuY3BwIHRvIGZpeCBBcHBs ZSBXaW5kb3dzIGJ1aWxkZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2Fj aGUvQ2FjaGVkUmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hl L0NhY2hlZFJlc291cmNlTG9hZGVyLmNwcAppbmRleCA0ZmJhZjQ3N2M3NTBmMTNmOGZmNjhiMTM2 YmU5NzFiYWQ1OTE3ZDU3Li4xYjJjNWNlZDI0MmNmMWM2NDc2YjAxZTk0NTY3YjBjZWU4MjlmZTQ1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VM b2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJj ZUxvYWRlci5jcHAKQEAgLTYzMCwxNyArNjMwLDEyIEBAIHZvaWQgQ2FjaGVkUmVzb3VyY2VMb2Fk ZXI6OnByaW50QWNjZXNzRGVuaWVkTWVzc2FnZShjb25zdCBLVVJMJiB1cmwpIGNvbnN0CiAgICAg aWYgKCFmcmFtZSgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBTZXR0aW5ncyogc2V0dGluZ3Mg PSBmcmFtZSgpLT5zZXR0aW5ncygpOwotICAgIGlmICghc2V0dGluZ3MgfHwgc2V0dGluZ3MtPnBy aXZhdGVCcm93c2luZ0VuYWJsZWQoKSkKLSAgICAgICAgcmV0dXJuOwotCiAgICAgU3RyaW5nIG1l c3NhZ2U7CiAgICAgaWYgKCFtX2RvY3VtZW50IHx8IG1fZG9jdW1lbnQtPnVybCgpLmlzTnVsbCgp KQogICAgICAgICBtZXNzYWdlID0gIlVuc2FmZSBhdHRlbXB0IHRvIGxvYWQgVVJMICIgKyB1cmwu c3RyaW5nKCkgKyAnLic7CiAgICAgZWxzZQogICAgICAgICBtZXNzYWdlID0gIlVuc2FmZSBhdHRl bXB0IHRvIGxvYWQgVVJMICIgKyB1cmwuc3RyaW5nKCkgKyAiIGZyb20gZnJhbWUgd2l0aCBVUkwg IiArIG1fZG9jdW1lbnQtPnVybCgpLnN0cmluZygpICsgIi4gRG9tYWlucywgcHJvdG9jb2xzIGFu ZCBwb3J0cyBtdXN0IG1hdGNoLlxuIjsKIAotICAgIC8vIEZJWE1FOiBwcm92aWRlIGxpbmUgbnVt YmVyIGFuZCBzb3VyY2UgVVJMLgogICAgIGZyYW1lKCktPmRvY3VtZW50KCktPmFkZENvbnNvbGVN ZXNzYWdlKE90aGVyTWVzc2FnZVNvdXJjZSwgTG9nTWVzc2FnZVR5cGUsIEVycm9yTWVzc2FnZUxl dmVsLCBtZXNzYWdlKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9Db25z b2xlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ29uc29sZS5jcHAKaW5kZXggOTZjM2NlM2Rk ZjQ4NzMwMjRmYmM4YmUyNjc0Mzc2Zjk3MjA0Y2RkZC4uNTcxNGQ2ZmIxZWRhYjk0NTIzZWMxZTYz ZjZhOGM4MTllYzg5YTdmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9Db25zb2xl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnNvbGUuY3BwCkBAIC00Nyw2ICs0Nyw3 IEBACiAjaW5jbHVkZSAiU2NyaXB0UHJvZmlsZXIuaCIKICNpbmNsdWRlICJTY3JpcHRWYWx1ZS5o IgogI2luY2x1ZGUgIlNjcmlwdGFibGVEb2N1bWVudFBhcnNlci5oIgorI2luY2x1ZGUgIlNldHRp bmdzLmgiCiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNsdWRlIDx3dGYvVW51c2VkUGFyYW0uaD4K ICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CkBAIC0xNjMsMTQgKzE2NCwxNyBAQCB2b2lk IENvbnNvbGU6OmFkZE1lc3NhZ2UoTWVzc2FnZVNvdXJjZSBzb3VyY2UsIE1lc3NhZ2VUeXBlIHR5 cGUsIE1lc3NhZ2VMZXZlbCBsZQogICAgIGlmICghcGFnZSkKICAgICAgICAgcmV0dXJuOwogCi0g ICAgcGFnZS0+Y2hyb21lKCktPmNsaWVudCgpLT5hZGRNZXNzYWdlVG9Db25zb2xlKHNvdXJjZSwg dHlwZSwgbGV2ZWwsIG1lc3NhZ2UsIGxpbmVOdW1iZXIsIHVybCk7Ci0KICAgICBpZiAoY2FsbFN0 YWNrKQogICAgICAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmFkZE1lc3NhZ2VUb0NvbnNv bGUocGFnZSwgc291cmNlLCB0eXBlLCBsZXZlbCwgbWVzc2FnZSwgY2FsbFN0YWNrLCByZXF1ZXN0 SWRlbnRpZmllcik7CiAgICAgZWxzZQogICAgICAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246 OmFkZE1lc3NhZ2VUb0NvbnNvbGUocGFnZSwgc291cmNlLCB0eXBlLCBsZXZlbCwgbWVzc2FnZSwg dXJsLCBsaW5lTnVtYmVyLCBzdGF0ZSwgcmVxdWVzdElkZW50aWZpZXIpOwogCi0gICAgaWYgKCFD b25zb2xlOjpzaG91bGRQcmludEV4Y2VwdGlvbnMoKSkKKyAgICBpZiAoIW1fZnJhbWUtPnNldHRp bmdzKCkgfHwgbV9mcmFtZS0+c2V0dGluZ3MoKS0+cHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCgpKQor ICAgICAgICByZXR1cm47CisKKyAgICBwYWdlLT5jaHJvbWUoKS0+Y2xpZW50KCktPmFkZE1lc3Nh Z2VUb0NvbnNvbGUoc291cmNlLCB0eXBlLCBsZXZlbCwgbWVzc2FnZSwgbGluZU51bWJlciwgdXJs KTsKKworICAgIGlmICghc2hvdWxkUHJpbnRFeGNlcHRpb25zKCkpCiAgICAgICAgIHJldHVybjsK IAogICAgIHByaW50U291cmNlVVJMQW5kTGluZSh1cmwsIGxpbmVOdW1iZXIpOwpAQCAtMTk0LDYg KzE5OCwxNiBAQCB2b2lkIENvbnNvbGU6OmFkZE1lc3NhZ2UoTWVzc2FnZVR5cGUgdHlwZSwgTWVz c2FnZUxldmVsIGxldmVsLCBTY3JpcHRTdGF0ZSogc3RhdAogICAgIFJlZlB0cjxTY3JpcHRDYWxs U3RhY2s+IGNhbGxTdGFjayhjcmVhdGVTY3JpcHRDYWxsU3RhY2soc3RhdGUsIHN0YWNrU2l6ZSkp OwogICAgIGNvbnN0IFNjcmlwdENhbGxGcmFtZSYgbGFzdENhbGxlciA9IGNhbGxTdGFjay0+YXQo MCk7CiAKKyAgICBTdHJpbmcgbWVzc2FnZTsKKyAgICBib29sIGdvdE1lc3NhZ2UgPSBhcmd1bWVu dHMtPmdldEZpcnN0QXJndW1lbnRBc1N0cmluZyhtZXNzYWdlKTsKKyAgICBJbnNwZWN0b3JJbnN0 cnVtZW50YXRpb246OmFkZE1lc3NhZ2VUb0NvbnNvbGUocGFnZSwgQ29uc29sZUFQSU1lc3NhZ2VT b3VyY2UsIHR5cGUsIGxldmVsLCBtZXNzYWdlLCBzdGF0ZSwgYXJndW1lbnRzLnJlbGVhc2UoKSk7 CisKKyAgICBpZiAoIW1fZnJhbWUtPnNldHRpbmdzKCkgfHwgbV9mcmFtZS0+c2V0dGluZ3MoKS0+ cHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCgpKQorICAgICAgICByZXR1cm47CisKKyAgICBpZiAoZ290 TWVzc2FnZSkKKyAgICAgICAgcGFnZS0+Y2hyb21lKCktPmNsaWVudCgpLT5hZGRNZXNzYWdlVG9D b25zb2xlKENvbnNvbGVBUElNZXNzYWdlU291cmNlLCB0eXBlLCBsZXZlbCwgbWVzc2FnZSwgbGFz dENhbGxlci5saW5lTnVtYmVyKCksIGxhc3RDYWxsZXIuc291cmNlVVJMKCkpOworCiAgICAgaWYg KHNob3VsZFByaW50RXhjZXB0aW9ucygpKSB7CiAgICAgICAgIHByaW50U291cmNlVVJMQW5kTGlu ZShsYXN0Q2FsbGVyLnNvdXJjZVVSTCgpLCAwKTsKICAgICAgICAgcHJpbnRNZXNzYWdlU291cmNl QW5kTGV2ZWxQcmVmaXgoQ29uc29sZUFQSU1lc3NhZ2VTb3VyY2UsIGxldmVsKTsKQEAgLTIxMywx MiArMjI3LDYgQEAgdm9pZCBDb25zb2xlOjphZGRNZXNzYWdlKE1lc3NhZ2VUeXBlIHR5cGUsIE1l c3NhZ2VMZXZlbCBsZXZlbCwgU2NyaXB0U3RhdGUqIHN0YXQKICAgICAgICAgICAgIHByaW50Zigi XHQlc1xuIiwgZnVuY3Rpb25OYW1lLnV0ZjgoKS5kYXRhKCkpOwogICAgICAgICB9CiAgICAgfQot Ci0gICAgU3RyaW5nIG1lc3NhZ2U7Ci0gICAgaWYgKGFyZ3VtZW50cy0+Z2V0Rmlyc3RBcmd1bWVu dEFzU3RyaW5nKG1lc3NhZ2UpKQotICAgICAgICBwYWdlLT5jaHJvbWUoKS0+Y2xpZW50KCktPmFk ZE1lc3NhZ2VUb0NvbnNvbGUoQ29uc29sZUFQSU1lc3NhZ2VTb3VyY2UsIHR5cGUsIGxldmVsLCBt ZXNzYWdlLCBsYXN0Q2FsbGVyLmxpbmVOdW1iZXIoKSwgbGFzdENhbGxlci5zb3VyY2VVUkwoKSk7 Ci0KLSAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmFkZE1lc3NhZ2VUb0NvbnNvbGUocGFn ZSwgQ29uc29sZUFQSU1lc3NhZ2VTb3VyY2UsIHR5cGUsIGxldmVsLCBtZXNzYWdlLCBzdGF0ZSwg YXJndW1lbnRzLnJlbGVhc2UoKSk7CiB9CiAKIHZvaWQgQ29uc29sZTo6ZGVidWcoU2NyaXB0U3Rh dGUqIHN0YXRlLCBQYXNzUmVmUHRyPFNjcmlwdEFyZ3VtZW50cz4gYXJndW1lbnRzKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9ET01XaW5kb3cuY3BwCmluZGV4IGI3OTc3M2IxZGYwNDJmMDViZmU4MTI4NGM3ZDYyMjUz OTQyN2M3NDEuLjllYWQxNGUyZGZjNjg0ZGI5MzJjZTdmYzAwMDVkYzA0ZDBlN2E3ZGUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKQEAgLTE3NTYsMTIgKzE3NTYsNiBAQCB2b2lkIERPTVdp bmRvdzo6cHJpbnRFcnJvck1lc3NhZ2UoY29uc3QgU3RyaW5nJiBtZXNzYWdlKQogICAgIGlmICht ZXNzYWdlLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgU2V0dGluZ3MqIHNldHRp bmdzID0gbV9mcmFtZS0+c2V0dGluZ3MoKTsKLSAgICBpZiAoIXNldHRpbmdzKQotICAgICAgICBy ZXR1cm47Ci0gICAgaWYgKHNldHRpbmdzLT5wcml2YXRlQnJvd3NpbmdFbmFibGVkKCkpCi0gICAg ICAgIHJldHVybjsKLQogICAgIGNvbnNvbGUoKS0+YWRkTWVzc2FnZShKU01lc3NhZ2VTb3VyY2Us IExvZ01lc3NhZ2VUeXBlLCBFcnJvck1lc3NhZ2VMZXZlbCwgbWVzc2FnZSk7CiB9CiAKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCA5MTBlMjYwN2Q4NTgzZTQ0ZDE2OTA2MWFjNGVlYzZkYTNiMDNjMGRiLi5jN2E0ZjUzMjAyMjc2 MWRlN2NkODQ4MzE4YTdlYjNmMjNlNWMzYTI0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTIt MTItMTAgIE1pa2UgV2VzdCAgPG1rd3N0QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBFdmFsdWF0ZSBwcml2YXRlIGJyb3dzaW5nIG1vZGUncyBlZmZlY3Qgb24gY29uc29s ZSBtZXNzYWdlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNDM4MworCisgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvY29uc29sZS9jbGllbnRzLWlnbm9yZWQtaW4tcHJpdmF0ZWJyb3dzaW5n LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaW5zcGVjdG9yL2NvbnNvbGUvY2xpZW50 cy1pZ25vcmVkLWluLXByaXZhdGVicm93c2luZy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0 Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAgICAgU2tpcCB0aGlzIHRl c3Qgb24gQ2hyb21pdW0sIGFzIHRoYXQgcG9ydCBkb2Vzbid0IHVzZSBQcml2YXRlQnJvd3NpbmcK KwogMjAxMi0xMi0xMCAgWmFuIERvYmVyc2VrICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQgR1RLIGdhcmRlbmluZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2luc3BlY3Rvci9jb25zb2xlL2NsaWVudHMtaWdub3JlZC1pbi1wcml2YXRlYnJvd3NpbmctZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY2xpZW50cy1pZ25vcmVk LWluLXByaXZhdGVicm93c2luZy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uN2JlMjQxZWI3OWJl YzJlNzNkZDU4NmRkMDNjNWZiY2YxMTAwMTRmNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2luc3BlY3Rvci9jb25zb2xlL2NsaWVudHMtaWdub3JlZC1pbi1wcml2YXRlYnJvd3Npbmct ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNCBAQAorSW4gUHJpdmF0ZUJyb3dzaW5nIG1vZGUsIGNv bnNvbGUgbWVzc2FnZXMgYXJlIHZpc2libGUgaW4gdGhlIENvbnNvbGUsIGJ1dCBhcmVuJ3Qgc2Vu dCB0byBDaHJvbWVDbGllbnRzIChvciBwcmludGYnZCkgaW4gb3JkZXIgdG8gZW5zdXJlIHRoZXkg bmV2ZXIgZW5kIHVwIGluIGxvZ3MuIEJldHRlciBzYWZlIHRoYW4gc29ycnkuCisKK2xvZzogVGhp cyBzaG91bGQgc2hvdyB1cCBvbmNlIGNvbnNvbGUgbWVzc2FnZXMgYXJlIGR1bXBlZCwgYnV0IHNo b3VsZCBfbm90XyBzaG93IHVwIGFzIGEgIkNPTlNPTEUgTUVTU0FHRToiIGF0IHRoZSB0b3Agb2Yg dGhlIG91dHB1dC4KKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUv Y2xpZW50cy1pZ25vcmVkLWluLXByaXZhdGVicm93c2luZy5odG1sIGIvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL2NvbnNvbGUvY2xpZW50cy1pZ25vcmVkLWluLXByaXZhdGVicm93c2luZy5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjRjNzg0MjcwNDljN2FlZTdmNTZkY2ZmNWIxMzlmMjBhMzAwMDI0NzIKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jbGllbnRzLWlnbm9y ZWQtaW4tcHJpdmF0ZWJyb3dzaW5nLmh0bWwKQEAgLTAsMCArMSwzMCBAQAorPGh0bWw+Cis8aGVh ZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9odHRwL3Rlc3RzL2luc3BlY3Rvci9pbnNwZWN0b3ItdGVz dC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vaHR0cC90ZXN0cy9pbnNwZWN0b3Iv Y29uc29sZS10ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisKK2Z1bmN0aW9uIHRlc3QoKQor eworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5zZXRQcml2 YXRlQnJvd3NpbmdFbmFibGVkKHRydWUpOworCisgICAgY29uc29sZS5sb2coJ1RoaXMgc2hvdWxk IHNob3cgdXAgb25jZSBjb25zb2xlIG1lc3NhZ2VzIGFyZSBkdW1wZWQsIGJ1dCBzaG91bGQgX25v dF8gc2hvdyB1cCBhcyBhICJDT05TT0xFIE1FU1NBR0U6IiBhdCB0aGUgdG9wIG9mIHRoZSBvdXRw dXQuJyk7CisKKyAgICBJbnNwZWN0b3JUZXN0LmR1bXBDb25zb2xlTWVzc2FnZXMoKTsKKworICAg IGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5zZXRQcml2YXRlQnJv d3NpbmdFbmFibGVkKGZhbHNlKTsKKyAgICBJbnNwZWN0b3JUZXN0LmNvbXBsZXRlVGVzdCgpOwor fQorCis8L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorPHA+ SW4gUHJpdmF0ZUJyb3dzaW5nIG1vZGUsIGNvbnNvbGUgbWVzc2FnZXMgYXJlIHZpc2libGUgaW4g dGhlIENvbnNvbGUsIGJ1dAorYXJlbid0IHNlbnQgdG8gQ2hyb21lQ2xpZW50cyAob3IgcHJpbnRm J2QpIGluIG9yZGVyIHRvIGVuc3VyZSB0aGV5IG5ldmVyIGVuZAordXAgaW4gbG9ncy4gQmV0dGVy IHNhZmUgdGhhbiBzb3JyeS48L3A+CisKKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDA1OTQ0ZDFkMmYwMGE0 MjNmY2QzZjQ2OWU2MWI2NmI2MGY5MTk2ODEuLjEyZGViMzI4OGRiYmU0Mzg1MDc5OTk0MzI5ZGJm MDk2MjkyYTRmYzIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rl c3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4 cGVjdGF0aW9ucwpAQCAtNjU1LDYgKzY1NSw3IEBAIHBsdWdpbnMvcHJpdmF0ZS1icm93c2luZy1t b2RlLTIuaHRtbCBbIFdvbnRGaXggXQogc3RvcmFnZS9kb21zdG9yYWdlL2xvY2Fsc3RvcmFnZS9w cml2YXRlLWJyb3dzaW5nLWFmZmVjdHMtc3RvcmFnZS5odG1sIFsgV29udEZpeCBdCiBzdG9yYWdl L2RvbXN0b3JhZ2Uvc2Vzc2lvbnN0b3JhZ2UvcHJpdmF0ZS1icm93c2luZy1hZmZlY3RzLXN0b3Jh Z2UuaHRtbCBbIFdvbnRGaXggXQogc3RvcmFnZS93ZWJzcWwvcHJpdmF0ZS1icm93c2luZy1ub3Jl YWQtbm93cml0ZS5odG1sIFsgV29udEZpeCBdCitpbnNwZWN0b3IvY29uc29sZS9jbGllbnRzLWln bm9yZWQtaW4tcHJpdmF0ZWJyb3dzaW5nLmh0bWwgWyBXb250Rml4IF0KIAogIyBXZSBkb24ndCBs ZXQgYW55b25lIHNldCBzdGF0dXMgaW4gdGhlIGJyb3dzZXIuCiBwbHVnaW5zL3NldC1zdGF0dXMu aHRtbCBbIFdvbnRGaXggXQo=