104382 2012-12-07 10:50:40 -0800 REGRESSION(r135863): GtkLauncher --help no longer displays all help options 2012-12-10 05:52:19 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned vjaquez webkit.review.bot oldest_to_newest 785977 0 pnormand 2012-12-07 10:50:40 -0800 Before: Help Options: -h, --help Show help options --help-all Show all help options --help-gtk Show GTK+ Options --help-websettings WebKitWebSettings properties Application Options: --display=DISPLAY X display to use -------------- Currently: Help Options: -h, --help Show help options --help-all Show all help options --help-gst Show GStreamer Options -------------- I think the gst_init() call is the culprit. If I remove it I still see the gst options group in the help, along with the other options, like help-websettings. But it'd be good to check this is really the issue. 787195 1 178515 vjaquez 2012-12-10 04:26:45 -0800 Created attachment 178515 Patch 787230 2 178515 webkit.review.bot 2012-12-10 05:52:16 -0800 Comment on attachment 178515 Patch Clearing flags on attachment: 178515 Committed r137141: <http://trac.webkit.org/changeset/137141> 787231 3 webkit.review.bot 2012-12-10 05:52:19 -0800 All reviewed patches have been landed. Closing bug. 178515 2012-12-10 04:26:45 -0800 2012-12-10 05:52:16 -0800 Patch bug-104382-20121210122406.patch text/plain 1289 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MTE5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDg1YmYxZjViMDI3ZDc0ZjVhMzQxZDY4ZGY1NTRiNmVj NDcxOGZlZi4uOGM5OTg2YmM5NzQxZDI4NTkwMmI1NTZlZGVhNTMyNWE5YzljZDRmZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTEyLTEwICBWw61jdG9yIE1hbnVlbCBKw6FxdWV6IExlYWwgIDx2amFxdWV6QGln YWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTM1ODYzKTogR3RrTGF1bmNoZXIgLS1o ZWxwIG5vIGxvbmdlciBkaXNwbGF5cyBhbGwgaGVscCBvcHRpb25zCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQzODIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgZ3N0X2luaXQoKSBiZWNhdXNl IGl0IHN0ZWFscyB0aGUgR09wdGlvbkNvbnRleHQuCisgICAgICAgIGdzdF9pbml0X2dldF9vcHRp b25fZ3JvdXAoKSBhbHJlYWR5IGRvZXMgdGhlIGluaXRpYWxpemF0aW9uIGpvYi4KKworICAgICAg ICAqIEd0a0xhdW5jaGVyL21haW4uYzoKKyAgICAgICAgKG1haW4pOgorCiAyMDEyLTEyLTEwICBN aWhuZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQu IEFkZGluZyBNaWhhaSBNYWVyZWFuIHRvIHRoZSBsaXN0IG9mIGNvbnRyaWJ1dG9ycywgd29ya2lu ZyBvbiBDU1NSZWdpb25zLgpkaWZmIC0tZ2l0IGEvVG9vbHMvR3RrTGF1bmNoZXIvbWFpbi5jIGIv VG9vbHMvR3RrTGF1bmNoZXIvbWFpbi5jCmluZGV4IDc0NzBlMTcxNGM0OTQ5YjI0ZWU1Nzc5Yjg5 NDkyODFkOGYwNzZlZDAuLmNiOGI2YjI2YWY4MjVlYTU3ZTZjNjg5YjhkMzAzNzQxZjQzNmYyMzcg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0d0a0xhdW5jaGVyL21haW4uYworKysgYi9Ub29scy9HdGtMYXVu Y2hlci9tYWluLmMKQEAgLTQ4NCw3ICs0ODQsNiBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciog YXJndltdKQogICAgIH07CiAKICAgICBndGtfaW5pdCgmYXJnYywgJmFyZ3YpOwotICAgIGdzdF9p bml0KCZhcmdjLCAmYXJndik7CiAKICAgICBHT3B0aW9uQ29udGV4dCAqY29udGV4dCA9IGdfb3B0 aW9uX2NvbnRleHRfbmV3KDApOwogICAgIGdfb3B0aW9uX2NvbnRleHRfYWRkX21haW5fZW50cmll cyhjb250ZXh0LCBjb21tYW5kTGluZU9wdGlvbnMsIDApOwo=