104380 2012-12-07 10:32:31 -0800 Improve r136754 by hardening checks of expected values for background-position. 2012-12-07 11:24:53 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 menard menard cmarcelo koivisto macpherson ojan.autocc webkit.review.bot oldest_to_newest 785968 0 menard 2012-12-07 10:32:31 -0800 Improve r136754 by hardening checks of expected values for background-position. 785974 1 178238 menard 2012-12-07 10:43:13 -0800 Created attachment 178238 Patch 786005 2 178238 webkit.review.bot 2012-12-07 11:24:49 -0800 Comment on attachment 178238 Patch Clearing flags on attachment: 178238 Committed r136966: <http://trac.webkit.org/changeset/136966> 786006 3 webkit.review.bot 2012-12-07 11:24:53 -0800 All reviewed patches have been landed. Closing bug. 178238 2012-12-07 10:43:13 -0800 2012-12-07 11:24:49 -0800 Patch bug-104380-20121207154036.patch text/plain 5663 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWFhZmI0NTRjMTdmNmVj Zjk0NzkyNDMyNTJmOWU2ZTUxNGYyODc2Ny4uNzkzNTlkODViOTljZDA3N2QyNjk1ZDVkNTk3MDNm NTIzMjg2ZjUxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTEyLTA3ICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgSW1wcm92ZSByMTM2NzU0 IGJ5IGhhcmRlbmluZyBjaGVja3Mgb2YgZXhwZWN0ZWQgdmFsdWVzIGZvciBiYWNrZ3JvdW5kLXBv c2l0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA0MzgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg cjEzNjc1NCB3YXMgbGFuZGVkIHRvIGZpeCB0aGUgcHJvYmxlbSBvZiBjaGVja2luZyBzdWNjZXNz aXZlbHkgdHdvIGNhbGMKKyAgICAgICAgdmFsdWVzIHdpdGggdmFsaWRVbml0LiBJdCB3YXMgYXNz ZXJ0aW5nIGFzIHZhbGlkVW5pdCBleHBlY3QgeW91IHRvIHVzZQorICAgICAgICB0aGUgcGFyc2Vk IHZhbHVlIG9mIHRoZSBjYWxjIGFmdGVyIHRoZSBjYWxsLiBJbiB0aGlzIGNhc2Ugd2UgcHJlLWNo ZWNrIHRoZQorICAgICAgICBiYWNrZ3JvdW5kLXBvc2l0aW9uIGxvbmdoYW5kIHRvIGNvdW50IGhv dyBtYW55IHZhbHVlcyBpdCBoYXMgdG8gdGhlbgorICAgICAgICBjYWxsIHRoZSByaWdodCBwYXJz aW5nIGZ1bmN0aW9ucyBhY2NvcmRpbmdseS4gV2hpbGUgcjEzNjc1NCBpcyBub3QKKyAgICAgICAg d3JvbmcgaXQgaXMgYmV0dGVyIHRvIGhhcmRlbiBpc1BvdGVudGlhbFBvc2l0aW9uVmFsdWUgd2l0 aCB0aGUgcmVhbAorICAgICAgICBleHBlY3RlZCB1bml0cyBhbmQga2V5d29yZHMuIEZvciB0aGlz IG1hdHRlciB3ZSBjYW4gcmV1c2UgdGhlCisgICAgICAgIFJlbGVhc2VQYXJzZWRDYWxjVmFsdWVD b25kaXRpb24gZW51bSB3aGljaCB3YXMgY3JlYXRlZCB3aXRoIHRoZSBzYW1lCisgICAgICAgIGlk ZWEgYXMgdGhpcyBwYXRjaC4gSWYgeW91IGFyZSBub3QgaW50ZXJlc3RlZCBvZiB0aGUgY2FsYyBw YXJzZWQKKyAgICAgICAgdmFsdWUgd2hlbiBjYWxsaW5nIHZhbGlkVW5pdCgpIHlvdSBjYW4gbm93 IHNwZWNpZnkgaXQsIEkgYmVsaWV2ZSBpdCBpcworICAgICAgICBnb29kIHRvIGhhdmUgaXQgZXhw bGljaXQgdG8gYXZvaWQgbWlzdGFrZSBpbiB0aGUgZnV0dXJlLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyA6IHRoaXMgaXMgY292ZXJlZCBieSBjc3MzLyosIGZhc3QvYmFja2dyb3VuZHMvKi4KKwor ICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2Vy Ojp2YWxpZENhbGN1bGF0aW9uVW5pdCk6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnZh bGlkVW5pdCk6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OmlzUG90ZW50aWFsUG9zaXRp b25WYWx1ZSk6CisgICAgICAgICogY3NzL0NTU1BhcnNlci5oOgorICAgICAgICAoV2ViQ29yZTo6 Q1NTUGFyc2VyOjp2YWxpZFVuaXQpOgorICAgICAgICAoQ1NTUGFyc2VyKToKKwogMjAxMi0xMi0w NyAgS29uZGFwYWxseSBLYWx5YW4gIDxrYWx5YW4ua29uZGFwYWxseUBpbnRlbC5jb20+CiAKICAg ICAgICAgW0VGTF0gW0FDXSBJbXBsZW1lbnQgSW1hZ2VFeHRyYWN0b3I6OmV4dHJhY3RJbWFnZSBp biBHcmFwaGljc0NvbnRleHQzREVmbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggNzU2 ZjE5NTMyN2QzYWYzYmM3YjQxMTk4ZDljNDM2NGNkNzg2MDZjNC4uYWZkNzNiNzM1YjQxNWZkNmUx ZjQ3YzgzMGZmNjdiOGY3N2E1ZDlhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NT U1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTE0 ODcsNyArMTQ4Nyw3IEBAIEtVUkwgQ1NTUGFyc2VyOjpjb21wbGV0ZVVSTChjb25zdCBTdHJpbmcm IHVybCkgY29uc3QKICAgICByZXR1cm4gY29tcGxldGVVUkwobV9jb250ZXh0LCB1cmwpOwogfQog Ci1ib29sIENTU1BhcnNlcjo6dmFsaWRDYWxjdWxhdGlvblVuaXQoQ1NTUGFyc2VyVmFsdWUqIHZh bHVlLCBVbml0cyB1bml0ZmxhZ3MpCitib29sIENTU1BhcnNlcjo6dmFsaWRDYWxjdWxhdGlvblVu aXQoQ1NTUGFyc2VyVmFsdWUqIHZhbHVlLCBVbml0cyB1bml0ZmxhZ3MsIFJlbGVhc2VQYXJzZWRD YWxjVmFsdWVDb25kaXRpb24gcmVsZWFzZUNhbGMpCiB7CiAgICAgYm9vbCBtdXN0QmVOb25OZWdh dGl2ZSA9IHVuaXRmbGFncyAmIEZOb25OZWc7CiAKQEAgLTE1MjUsNyArMTUyNSw3IEBAIGJvb2wg Q1NTUGFyc2VyOjp2YWxpZENhbGN1bGF0aW9uVW5pdChDU1NQYXJzZXJWYWx1ZSogdmFsdWUsIFVu aXRzIHVuaXRmbGFncykKICAgICBjYXNlIENhbGNPdGhlcjoKICAgICAgICAgYnJlYWs7CiAgICAg fQotICAgIGlmICghYikKKyAgICBpZiAoIWIgfHwgcmVsZWFzZUNhbGMgPT0gUmVsZWFzZVBhcnNl ZENhbGNWYWx1ZSkKICAgICAgICAgbV9wYXJzZWRDYWxjdWxhdGlvbi5yZWxlYXNlKCk7CiAgICAg cmV0dXJuIGI7ICAgIAogfQpAQCAtMTUzNiwxMCArMTUzNiwxMCBAQCBpbmxpbmUgYm9vbCBDU1NQ YXJzZXI6OnNob3VsZEFjY2VwdFVuaXRMZXNzVmFsdWVzKENTU1BhcnNlclZhbHVlKiB2YWx1ZSwg VW5pdHMgdQogICAgIHJldHVybiAodW5pdGZsYWdzICYgKEZMZW5ndGggfCBGQW5nbGUgfCBGVGlt ZSkpICYmICghdmFsdWUtPmZWYWx1ZSB8fCBjc3NQYXJzZXJNb2RlID09IENTU1F1aXJrc01vZGUg fHwgY3NzUGFyc2VyTW9kZSA9PSBTVkdBdHRyaWJ1dGVNb2RlKTsKIH0KIAotYm9vbCBDU1NQYXJz ZXI6OnZhbGlkVW5pdChDU1NQYXJzZXJWYWx1ZSogdmFsdWUsIFVuaXRzIHVuaXRmbGFncywgQ1NT UGFyc2VyTW9kZSBjc3NQYXJzZXJNb2RlKQorYm9vbCBDU1NQYXJzZXI6OnZhbGlkVW5pdChDU1NQ YXJzZXJWYWx1ZSogdmFsdWUsIFVuaXRzIHVuaXRmbGFncywgQ1NTUGFyc2VyTW9kZSBjc3NQYXJz ZXJNb2RlLCBSZWxlYXNlUGFyc2VkQ2FsY1ZhbHVlQ29uZGl0aW9uIHJlbGVhc2VDYWxjKQogewog ICAgIGlmIChpc0NhbGN1bGF0aW9uKHZhbHVlKSkKLSAgICAgICAgcmV0dXJuIHZhbGlkQ2FsY3Vs YXRpb25Vbml0KHZhbHVlLCB1bml0ZmxhZ3MpOworICAgICAgICByZXR1cm4gdmFsaWRDYWxjdWxh dGlvblVuaXQodmFsdWUsIHVuaXRmbGFncywgcmVsZWFzZUNhbGMpOwogICAgICAgICAKICAgICBi b29sIGIgPSBmYWxzZTsKICAgICBzd2l0Y2ggKHZhbHVlLT51bml0KSB7CkBAIC0zODc1LDcgKzM4 NzUsNyBAQCB2b2lkIENTU1BhcnNlcjo6cGFyc2UzVmFsdWVzQmFja2dyb3VuZFBvc2l0aW9uKENT U1BhcnNlclZhbHVlTGlzdCogdmFsdWVMaXN0LCBSZQogCiBpbmxpbmUgYm9vbCBDU1NQYXJzZXI6 OmlzUG90ZW50aWFsUG9zaXRpb25WYWx1ZShDU1NQYXJzZXJWYWx1ZSogdmFsdWUpCiB7Ci0gICAg cmV0dXJuICF2YWx1ZS0+aWQgfHwgaXNCYWNrZ3JvdW5kUG9zaXRpb25LZXl3b3JkKHZhbHVlLT5p ZCk7CisgICAgcmV0dXJuIGlzQmFja2dyb3VuZFBvc2l0aW9uS2V5d29yZCh2YWx1ZS0+aWQpIHx8 IHZhbGlkVW5pdCh2YWx1ZSwgRlBlcmNlbnQgfCBGTGVuZ3RoLCBSZWxlYXNlUGFyc2VkQ2FsY1Zh bHVlKTsKIH0KIAogdm9pZCBDU1NQYXJzZXI6OnBhcnNlRmlsbEJhY2tncm91bmRQb3NpdGlvbihD U1NQYXJzZXJWYWx1ZUxpc3QqIHZhbHVlTGlzdCwgUmVmUHRyPENTU1ZhbHVlPiYgdmFsdWUxLCBS ZWZQdHI8Q1NTVmFsdWU+JiB2YWx1ZTIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUGFyc2VyLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmgKaW5kZXggNGM2Zjhj NTliZGZkN2I2MGY4NTdlNzllNTc4MjY3YTg1MWNjMDU0OC4uMTMxMTg3NWZiNzliMTUwZDZmNzEz ZDdlYmRjNDNjZjEyOGJiOWE4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Bh cnNlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuaApAQCAtNTg5LDIwICs1 ODksMjAgQEAgcHJpdmF0ZToKICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PFVuaXRzPihzdGF0 aWNfY2FzdDx1bnNpZ25lZD4oYSkgfCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oYikpOwogICAgIH0K IAotICAgIGJvb2wgdmFsaWRDYWxjdWxhdGlvblVuaXQoQ1NTUGFyc2VyVmFsdWUqLCBVbml0cyk7 CisgICAgZW51bSBSZWxlYXNlUGFyc2VkQ2FsY1ZhbHVlQ29uZGl0aW9uIHsKKyAgICAgICAgUmVs ZWFzZVBhcnNlZENhbGNWYWx1ZSwKKyAgICAgICAgRG9Ob3RSZWxlYXNlUGFyc2VkQ2FsY1ZhbHVl CisgICAgfTsKKworICAgIGJvb2wgdmFsaWRDYWxjdWxhdGlvblVuaXQoQ1NTUGFyc2VyVmFsdWUq LCBVbml0cywgUmVsZWFzZVBhcnNlZENhbGNWYWx1ZUNvbmRpdGlvbiByZWxlYXNlQ2FsYyA9IERv Tm90UmVsZWFzZVBhcnNlZENhbGNWYWx1ZSk7CiAKICAgICBib29sIHNob3VsZEFjY2VwdFVuaXRM ZXNzVmFsdWVzKENTU1BhcnNlclZhbHVlKiwgVW5pdHMsIENTU1BhcnNlck1vZGUpOwogCi0gICAg aW5saW5lIGJvb2wgdmFsaWRVbml0KENTU1BhcnNlclZhbHVlKiB2YWx1ZSwgVW5pdHMgdW5pdGZs YWdzKSB7IHJldHVybiB2YWxpZFVuaXQodmFsdWUsIHVuaXRmbGFncywgbV9jb250ZXh0Lm1vZGUp OyB9Ci0gICAgYm9vbCB2YWxpZFVuaXQoQ1NTUGFyc2VyVmFsdWUqLCBVbml0cywgQ1NTUGFyc2Vy TW9kZSk7CisgICAgaW5saW5lIGJvb2wgdmFsaWRVbml0KENTU1BhcnNlclZhbHVlKiB2YWx1ZSwg VW5pdHMgdW5pdGZsYWdzLCBSZWxlYXNlUGFyc2VkQ2FsY1ZhbHVlQ29uZGl0aW9uIHJlbGVhc2VD YWxjID0gRG9Ob3RSZWxlYXNlUGFyc2VkQ2FsY1ZhbHVlKSB7IHJldHVybiB2YWxpZFVuaXQodmFs dWUsIHVuaXRmbGFncywgbV9jb250ZXh0Lm1vZGUsIHJlbGVhc2VDYWxjKTsgfQorICAgIGJvb2wg dmFsaWRVbml0KENTU1BhcnNlclZhbHVlKiwgVW5pdHMsIENTU1BhcnNlck1vZGUsIFJlbGVhc2VQ YXJzZWRDYWxjVmFsdWVDb25kaXRpb24gcmVsZWFzZUNhbGMgPSBEb05vdFJlbGVhc2VQYXJzZWRD YWxjVmFsdWUpOwogCiAgICAgYm9vbCBwYXJzZUJvcmRlckltYWdlUXVhZChVbml0cywgUmVmUHRy PENTU1ByaW1pdGl2ZVZhbHVlPiYpOwogICAgIGludCBjb2xvckludEZyb21WYWx1ZShDU1NQYXJz ZXJWYWx1ZSopOwotCi0gICAgZW51bSBSZWxlYXNlUGFyc2VkQ2FsY1ZhbHVlQ29uZGl0aW9uIHsK LSAgICAgICAgUmVsZWFzZVBhcnNlZENhbGNWYWx1ZSwKLSAgICAgICAgRG9Ob3RSZWxlYXNlUGFy c2VkQ2FsY1ZhbHVlCi0gICAgfTsgICAgCiAgICAgZG91YmxlIHBhcnNlZERvdWJsZShDU1NQYXJz ZXJWYWx1ZSosIFJlbGVhc2VQYXJzZWRDYWxjVmFsdWVDb25kaXRpb24gcmVsZWFzZUNhbGMgPSBE b05vdFJlbGVhc2VQYXJzZWRDYWxjVmFsdWUpOwogICAgIGJvb2wgaXNDYWxjdWxhdGlvbihDU1NQ YXJzZXJWYWx1ZSopOwogICAgIAo=