104358 2012-12-07 02:58:06 -0800 base64DecodeInternal() is not conforming to HTML5(window.atob) spec. 2015-05-11 02:11:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 118898 P2 Normal --- 1 sh919.park webkit-unassigned ap benjamin dw.im glenn gyuyoung.kim kihong.kwon laszlo.gombos ojan.autocc ossy webkit.review.bot oldest_to_newest 785778 0 sh919.park 2012-12-07 02:58:06 -0800 base64DecodeInternal() is not conforming to HTML5(window.atob) spec. Window.atob has not been implemented in accordance with base64 spec(http://www.w3.org/TR/html5/webappapis.html#atob). 4. If the length of input divides by 4 leaving no remainder, then: if input ends with one or two "=" (U+003D) characters, remove them from input. (in spec) 6. If input contains a character that is not in the following list of characters and character ranges, throw an InvalidCharacterError exception and abort these steps (in spec) - Currently in WebKit, if input invalid charater, did not throw an InvalidCharacterError exception and abort. This issue is reproducible at w3c approved test site (http://w3c-test.org/html/tests/approved/base64.html). So, I will upload the patch as soon as possible. 785866 1 glenn 2012-12-07 07:20:39 -0800 how does the HTML5 specified behavior compare with other implementations? FF, IE, etc? 787319 2 sh919.park 2012-12-10 07:32:23 -0800 (In reply to comment #1) > how does the HTML5 specified behavior compare with other implementations? FF, IE, etc? In case of WebKit, result of w3c approved test site is "350 pass/18 fail". On the other hand, firefox result is 366 pass / 2 fail. - 2 fails are TC error, so firefox supports the spec, perfectly. Opera is also better than WebKit.(Result : 363 pass / 5 fail). 787323 3 glenn 2012-12-10 07:37:35 -0800 in the case of tests where one or more other browsers also fail, then care should be given to the validity of the test in question; some evaluation/discussion may be needed before implementing changes to pass the test; in other words, don't simply assume that the w3c tests are always valid 787377 4 sh919.park 2012-12-10 08:53:09 -0800 Thanks for your kind concern. I have tried double-checking to make sure about mismatching between TC and Spec. Failed 14 test cases which are proper. However, 2 failed TCs have below bugs. Let atob("ab="). (- this test is contained the "http://w3c-test.org/html/tests/approved/base64.htm") According to No. 4 of aboved spec, Because length of "ab=" is not divisible by 4, cannot remove the "=". According to No. 6 of aboved spec, "=" is not in the following list of characters and character ranges("+" (U+002B), "/" (U+002F), ASCII digits, uppercase ASCII letters and lowercase ASCII letters). So,should throw an InvalidCharacterError exception and abort. but in Webkit, do not following No. 4 spec and always remove ends with "=" characters, so do not throw an error. 818663 5 185186 sh919.park 2013-01-29 00:34:47 -0800 Created attachment 185186 Initial patch! 818670 6 benjamin 2013-01-29 00:43:17 -0800 (In reply to comment #3) > in the case of tests where one or more other browsers also fail, then care should be given to the validity of the test in question; some evaluation/discussion may be needed before implementing changes to pass the test; in other words, don't simply assume that the w3c tests are always valid This is an important point. Thanks for pointing that out. 1093699 7 ossy 2015-05-11 02:11:25 -0700 *** This bug has been marked as a duplicate of bug 118898 *** 185186 2013-01-29 00:34:47 -0800 2015-05-11 02:11:43 -0700 Initial patch! [sh919.park@samsung.com]-[base64DecodeInternal() is not conforming to HTML5(window.atob) spec].patch text/plain 5843 sh919.park ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4ZTcwNmYwLi45OWFjOTUyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDEt MjkgIFNhbmdoeXVuIFBhcmsgIDxzaDkxOS5wYXJrQHNhbXN1bmcuY29tPgorCisgICAgICAgIGJh c2U2NERlY29kZUludGVybmFsKCkgaXMgbm90IGNvbmZvcm1pbmcgdG8gSFRNTDUod2luZG93LmF0 b2IpIHNwZWMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDQzNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXaW5kb3cuYXRvYiBoYXMgbm90IGJlZW4gaW1wbGVtZW50ZWQgaW4gYWNjb3JkYW5jZSB3aXRo IGJhc2U2NCBzcGVjKGh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw1L3dlYmFwcGFwaXMuaHRtbCNh dG9iKS4KKyAgICAgICAgLSBJZiB0aGUgbGVuZ3RoIG9mIGlucHV0IGRpdmlkZXMgYnkgNCBsZWF2 aW5nIG5vIHJlbWFpbmRlciwgdGhlbjogaWYgaW5wdXQgZW5kcyB3aXRoIG9uZSBvciB0d28gIj0i IChVKzAwM0QpIGNoYXJhY3RlcnMsIHJlbW92ZSB0aGVtIGZyb20gaW5wdXQuIChpbiBzcGVjKQor ICAgICAgICAtIElmIGlucHV0IGNvbnRhaW5zIGEgY2hhcmFjdGVyIHRoYXQgaXMgbm90IGluIHRo ZSBmb2xsb3dpbmcgbGlzdCBvZiBjaGFyYWN0ZXJzIGFuZCBjaGFyYWN0ZXIgcmFuZ2VzLCB0aHJv dyBhbiBJbnZhbGlkQ2hhcmFjdGVyRXJyb3IgZXhjZXB0aW9uIGFuZCBhYm9ydCB0aGVzZSBzdGVw cyAoaW4gc3BlYykKKworICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy9hdG9iLWJ0b2EtZXhwZWN0 ZWQudHh0OgorICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy9hdG9iLWJ0b2EuaHRtbDoKKwogMjAx My0wMS0yOCAgIFZpbmVldCBDaGF1ZGhhcnkgIDxyZ2Y3NDhAbW90b3JvbGEuY29tPgogCiAgICAg ICAgIEhUTUxPdXRwdXRFbGVtZW50OjpodG1sRm9yIHNob3VsZCBiZSByZWFkb25seQpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L2F0b2ItYnRvYS1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvYXRvYi1idG9hLWV4cGVjdGVkLnR4dAppbmRl eCAzZTBiNjA2Li4xYWNjODM0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5k b3cvYXRvYi1idG9hLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5k b3cvYXRvYi1idG9hLWV4cGVjdGVkLnR4dApAQCAtMzYsOSArMzYsOSBAQCBQQVNTIHdpbmRvdy5h dG9iKCJ6IikgdGhyZXcgZXhjZXB0aW9uIEVycm9yOiBJbnZhbGlkQ2hhcmFjdGVyRXJyb3I6IERP TSBFeGNlcHRpbwogUEFTUyB3aW5kb3cuYXRvYigienoiKSBpcyAiw48iCiBQQVNTIHdpbmRvdy5h dG9iKCJ6enoiKSBpcyAiw488IgogUEFTUyB3aW5kb3cuYXRvYigienp6PSIpIGlzICLDjzwiCi1Q QVNTIHdpbmRvdy5hdG9iKCJ6eno9PSIpIGlzICLDjzwiCi1QQVNTIHdpbmRvdy5hdG9iKCJ6eno9 PT0iKSBpcyAiw488IgotUEFTUyB3aW5kb3cuYXRvYigienp6PT09PSIpIGlzICLDjzwiCitQQVNT IHdpbmRvdy5hdG9iKCJ6eno9PSIpIHRocmV3IGV4Y2VwdGlvbiBFcnJvcjogSW52YWxpZENoYXJh Y3RlckVycm9yOiBET00gRXhjZXB0aW9uIDUuCitQQVNTIHdpbmRvdy5hdG9iKCJ6eno9PT0iKSB0 aHJldyBleGNlcHRpb24gRXJyb3I6IEludmFsaWRDaGFyYWN0ZXJFcnJvcjogRE9NIEV4Y2VwdGlv biA1LgorUEFTUyB3aW5kb3cuYXRvYigienp6PT09PSIpIHRocmV3IGV4Y2VwdGlvbiBFcnJvcjog SW52YWxpZENoYXJhY3RlckVycm9yOiBET00gRXhjZXB0aW9uIDUuCiBQQVNTIHdpbmRvdy5hdG9i KCJ6enp6IikgaXMgIsOPPMOzIgogUEFTUyB3aW5kb3cuYXRvYigienp6enoiKSB0aHJldyBleGNl cHRpb24gRXJyb3I6IEludmFsaWRDaGFyYWN0ZXJFcnJvcjogRE9NIEV4Y2VwdGlvbiA1LgogUEFT UyB3aW5kb3cuYXRvYigiej16eiIpIHRocmV3IGV4Y2VwdGlvbiBFcnJvcjogSW52YWxpZENoYXJh Y3RlckVycm9yOiBET00gRXhjZXB0aW9uIDUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2RvbS9XaW5kb3cvYXRvYi1idG9hLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cv YXRvYi1idG9hLmh0bWwKaW5kZXggNTBlODFkNC4uOTIzY2VlMiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvZmFzdC9kb20vV2luZG93L2F0b2ItYnRvYS5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvZG9tL1dpbmRvdy9hdG9iLWJ0b2EuaHRtbApAQCAtNDYsOSArNDYsOSBAQCBzaG91bGRUaHJv dygnd2luZG93LmF0b2IoInoiKScpOwogc2hvdWxkQmUoJ3dpbmRvdy5hdG9iKCJ6eiIpJywgJyLD jyInKTsKIHNob3VsZEJlKCd3aW5kb3cuYXRvYigienp6IiknLCAnIsOPXHUwMDNDIicpOwogc2hv dWxkQmUoJ3dpbmRvdy5hdG9iKCJ6eno9IiknLCAnIsOPXHUwMDNDIicpOwotc2hvdWxkQmUoJ3dp bmRvdy5hdG9iKCJ6eno9PSIpJywgJyLDj1x1MDAzQyInKTsKLXNob3VsZEJlKCd3aW5kb3cuYXRv Yigienp6PT09IiknLCAnIsOPXHUwMDNDIicpOwotc2hvdWxkQmUoJ3dpbmRvdy5hdG9iKCJ6eno9 PT09IiknLCAnIsOPXHUwMDNDIicpOworc2hvdWxkVGhyb3coJ3dpbmRvdy5hdG9iKCJ6eno9PSIp Jyk7CitzaG91bGRUaHJvdygnd2luZG93LmF0b2IoInp6ej09PSIpJyk7CitzaG91bGRUaHJvdygn d2luZG93LmF0b2IoInp6ej09PT0iKScpOwogc2hvdWxkQmUoJ3dpbmRvdy5hdG9iKCJ6enp6Iikn LCAnIsOPXHUwMDNDw7MiJyk7CiBzaG91bGRUaHJvdygnd2luZG93LmF0b2IoInp6enp6IiknKTsK IHNob3VsZFRocm93KCd3aW5kb3cuYXRvYigiej16eiIpJyk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGZjYzYwOTguLjY1NGQ1 ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMDEtMjkgIFNhbmdoeXVuIFBhcmsgIDxzaDkx OS5wYXJrQHNhbXN1bmcuY29tPgorCisgICAgICAgIGJhc2U2NERlY29kZUludGVybmFsKCkgaXMg bm90IGNvbmZvcm1pbmcgdG8gSFRNTDUod2luZG93LmF0b2IpIHNwZWMuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQzNTgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaW5kb3cuYXRvYiBoYXMgbm90IGJl ZW4gaW1wbGVtZW50ZWQgaW4gYWNjb3JkYW5jZSB3aXRoIGJhc2U2NCBzcGVjKGh0dHA6Ly93d3cu dzMub3JnL1RSL2h0bWw1L3dlYmFwcGFwaXMuaHRtbCNhdG9iKQorICAgICAgICAtIElmIHRoZSBs ZW5ndGggb2YgaW5wdXQgZGl2aWRlcyBieSA0IGxlYXZpbmcgbm8gcmVtYWluZGVyLCB0aGVuOiBp ZiBpbnB1dCBlbmRzIHdpdGggb25lIG9yIHR3byAiPSIgKFUrMDAzRCkgY2hhcmFjdGVycywgcmVt b3ZlIHRoZW0gZnJvbSBpbnB1dC4gKGluIHNwZWMpCisgICAgICAgIC0gSWYgaW5wdXQgY29udGFp bnMgYSBjaGFyYWN0ZXIgdGhhdCBpcyBub3QgaW4gdGhlIGZvbGxvd2luZyBsaXN0IG9mIGNoYXJh Y3RlcnMgYW5kIGNoYXJhY3RlciByYW5nZXMsIHRocm93IGFuIEludmFsaWRDaGFyYWN0ZXJFcnJv ciBleGNlcHRpb24gYW5kIGFib3J0IHRoZXNlIHN0ZXBzIChpbiBzcGVjKQorICAgICAgICBUaGlz IGlzc3VlIGlzIHJlcHJvZHVjaWJsZSBhdCB3M2MgYXBwcm92ZWQgdGVzdCBzaXRlIChodHRwOi8v dzNjLXRlc3Qub3JnL2h0bWwvdGVzdHMvYXBwcm92ZWQvYmFzZTY0Lmh0bWwpCisKKyAgICAgICAg KiB3dGYvdGV4dC9CYXNlNjQuY3BwOgorICAgICAgICAoV1RGOjpiYXNlNjREZWNvZGVJbnRlcm5h bCk6CisKIDIwMTMtMDEtMjggIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3Jn PgogCiAgICAgICAgIFN0cmluZyBjb25zdHJ1Y3RlZCBmcm9tIExpdGVyYWxzIHNob3VsZCBiZSBu b24tZW1wdHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvQmFzZTY0LmNwcCBiL1Nv dXJjZS9XVEYvd3RmL3RleHQvQmFzZTY0LmNwcAppbmRleCA3YTA0NjdhLi41NDE1NWRmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0Jhc2U2NC5jcHAKKysrIGIvU291cmNlL1dURi93 dGYvdGV4dC9CYXNlNjQuY3BwCkBAIC0xMTEsNyArMTExLDcgQEAgdm9pZCBiYXNlNjRFbmNvZGUo Y29uc3QgY2hhciogZGF0YSwgdW5zaWduZWQgbGVuLCBWZWN0b3I8Y2hhcj4mIG91dCwgQmFzZTY0 RW5jb2QKIAogICAgIGlmIChzaWR4IDwgbGVuKSB7CiAgICAgICAgIGlmIChpbnNlcnRMRnMgJiYg KGNvdW50ID4gMCkgJiYgIShjb3VudCAlIDc2KSkKLSAgICAgICAgICAgb3V0W2RpZHgrK10gPSAn XG4nOworICAgICAgICAgICAgb3V0W2RpZHgrK10gPSAnXG4nOwogCiAgICAgICAgIG91dFtkaWR4 KytdID0gYmFzZTY0RW5jTWFwWyhkYXRhW3NpZHhdID4+IDIpICYgMDc3XTsKICAgICAgICAgaWYg KHNpZHggPCBsZW4gLSAxKSB7CkBAIC0xNDgsMTIgKzE0OCwxMiBAQCBzdGF0aWMgaW5saW5lIGJv b2wgYmFzZTY0RGVjb2RlSW50ZXJuYWwoY29uc3QgVCogZGF0YSwgdW5zaWduZWQgbGVuLCBWZWN0 b3I8Y2hhcgogCiAgICAgb3V0Lmdyb3cobGVuKTsKIAotICAgIGJvb2wgc2F3RXF1YWxzU2lnbiA9 IGZhbHNlOworICAgIHVuc2lnbmVkIHNhd0VxdWFsc1NpZ24gPSAwOwogICAgIHVuc2lnbmVkIG91 dExlbmd0aCA9IDA7CiAgICAgZm9yICh1bnNpZ25lZCBpZHggPSAwOyBpZHggPCBsZW47ICsraWR4 KSB7CiAgICAgICAgIHVuc2lnbmVkIGNoID0gZGF0YVtpZHhdOwogICAgICAgICBpZiAoY2ggPT0g Jz0nKQotICAgICAgICAgICAgc2F3RXF1YWxzU2lnbiA9IHRydWU7CisgICAgICAgICAgICBzYXdF cXVhbHNTaWduKys7CiAgICAgICAgIGVsc2UgaWYgKCgnMCcgPD0gY2ggJiYgY2ggPD0gJzknKSB8 fCAoJ0EnIDw9IGNoICYmIGNoIDw9ICdaJykgfHwgKCdhJyA8PSBjaCAmJiBjaCA8PSAneicpIHx8 IGNoID09ICcrJyB8fCBjaCA9PSAnLycpIHsKICAgICAgICAgICAgIGlmIChzYXdFcXVhbHNTaWdu KQogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTE2Niw2ICsxNjYsMTUgQEAgc3Rh dGljIGlubGluZSBib29sIGJhc2U2NERlY29kZUludGVybmFsKGNvbnN0IFQqIGRhdGEsIHVuc2ln bmVkIGxlbiwgVmVjdG9yPGNoYXIKICAgICBpZiAoIW91dExlbmd0aCkKICAgICAgICAgcmV0dXJu ICFzYXdFcXVhbHNTaWduOwogCisgICAgaWYgKHBvbGljeSA9PSBCYXNlNjRGYWlsT25JbnZhbGlk Q2hhcmFjdGVyKSB7CisgICAgICAgIC8vIElmIHRoZSBsZW5ndGggb2YgaW5wdXQgaXMgZGl2aXNp YmxlIGJ5IDQsIGFuZCBpbnB1dCBlbmRzIHdpdGggb25lIG9yIHR3byA9IGNoYXJhY3RlcnMsIHJl bW92ZSB0aGUgdHJhaWxpbmcgPSBjaGFyYWN0ZXJzLgorICAgICAgICBpZiAoc2F3RXF1YWxzU2ln biA8PSAyICYmICEoKG91dExlbmd0aCtzYXdFcXVhbHNTaWduKSAlIDQpKQorICAgICAgICAgICAg c2F3RXF1YWxzU2lnbiA9IDA7CisKKyAgICAgICAgaWYgKHNhd0VxdWFsc1NpZ24gPiAwKQorICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKwogICAgIC8vIFZhbGlkIGRhdGEgaXMgKG4g KiA0ICsgWzAsMiwzXSkgY2hhcmFjdGVycyBsb25nLgogICAgIGlmICgob3V0TGVuZ3RoICUgNCkg PT0gMSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwo=