104355 2012-12-07 02:21:41 -0800 Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers 2012-12-07 10:27:01 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen abarth dpranke tony webkit.review.bot oldest_to_newest 785758 0 jochen 2012-12-07 02:21:41 -0800 Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers 785761 1 178186 jochen 2012-12-07 02:23:23 -0800 Created attachment 178186 Patch 785917 2 178186 dpranke 2012-12-07 09:07:40 -0800 Comment on attachment 178186 Patch is there a particular reason to do this with an env variable rather than a DRT command line flag? 785952 3 jochen 2012-12-07 10:09:08 -0800 Mainly because that's the way chromium development was setup: https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment (so all the buildbots set that variable etc..) An alternative would be to teach our tools to translate the env variable to a command line flag, and content_shell to translate it back, but that seems a bit over complicated 785956 4 178186 dpranke 2012-12-07 10:14:38 -0800 Comment on attachment 178186 Patch OK. 785962 5 178186 webkit.review.bot 2012-12-07 10:26:58 -0800 Comment on attachment 178186 Patch Clearing flags on attachment: 178186 Committed r136962: <http://trac.webkit.org/changeset/136962> 785963 6 webkit.review.bot 2012-12-07 10:27:01 -0800 All reviewed patches have been landed. Closing bug. 178186 2012-12-07 02:23:23 -0800 2012-12-07 10:26:58 -0800 Patch bug-104355-20121207112046.patch text/plain 1441 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjIyYTc2NDI2MDNkY2I0MGNkMDk3NmQ5ZWRmZjM5ZDU4 NTRkMDkwOC4uYTYyZjZjZTUwOGNjNzI0M2Q2NDIzMDg1NjY2OTg3MGZmYzc0NmJjZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTEyLTA3ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIEFkZCAnQ0hST01JVU1fREVWRUxfU0FOREJPWCcgdG8gdGhlIGVudmlyb25tZW50 IHZhcmlhYmxlcyB0byBjb3B5IGZvciBsYXlvdXQgdGVzdCBkcml2ZXJzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQzNTUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGVuYWJsZXMgY2hyb21pdW0n cyBjb250ZW50X3NoZWxsIGRyaXZlciB0byBydW4gd2l0aCB0aGUgZnVsbCBTVUlECisgICAgICAg IHNhbmRib3guCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2Jhc2UucHk6CisgICAgICAgIChQb3J0LnRvLnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcik6CisK IDIwMTItMTItMDYgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzY3ODQgYW5kIHIxMzY4MDIuCmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2Uu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKaW5k ZXggOTZhZjQ2YWU0NzgzMWMxZTgxNWI4N2Q5YTk1YTMwNGYyZDg3NzNiMy4uYWY3NDJjOWUyYTk4 OTYxNmUwYTFmZDJjNjQxZTkwMzI5OGQ3ZGUxMSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQpAQCAtODk4LDYgKzg5OCw5IEBAIGNsYXNz IFBvcnQob2JqZWN0KToKICAgICAgICAgICAgICMgTW9zdCBwb3J0cyAoPyk6CiAgICAgICAgICAg ICAnV0VCS0lUX1RFU1RGT05UUycsCiAgICAgICAgICAgICAnV0VCS0lUT1VUUFVURElSJywKKwor ICAgICAgICAgICAgIyBDaHJvbWl1bToKKyAgICAgICAgICAgICdDSFJPTUVfREVWRUxfU0FOREJP WCcsCiAgICAgICAgIF0KICAgICAgICAgZm9yIHZhcmlhYmxlIGluIHZhcmlhYmxlc190b19jb3B5 OgogICAgICAgICAgICAgc2VsZi5fY29weV92YWx1ZV9mcm9tX2Vudmlyb25faWZfc2V0KGNsZWFu X2VudiwgdmFyaWFibGUpCg==