104353 2012-12-07 01:03:23 -0800 Improve confusing code in BaseMultipleFieldsDateAndTimeInputType 2012-12-07 01:54:43 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tkent tkent haraken mifenton ojan.autocc webkit.review.bot oldest_to_newest 785722 0 tkent 2012-12-07 01:03:23 -0800 Improve confusing code in BaseMultipleFieldsDateAndTimeInputType 785731 1 178178 tkent 2012-12-07 01:17:59 -0800 Created attachment 178178 Patch 785734 2 178178 tkent 2012-12-07 01:19:38 -0800 Comment on attachment 178178 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178178&action=review > Source/WebCore/ChangeLog:9 > + isEditControlOwnerDisabled adn isEditControlOwnerReadOnly treat them adn -> and 785736 3 178179 tkent 2012-12-07 01:20:21 -0800 Created attachment 178179 Patch 2 typo 785737 4 178179 haraken 2012-12-07 01:21:00 -0800 Comment on attachment 178179 Patch 2 ok 785754 5 178179 webkit.review.bot 2012-12-07 01:54:39 -0800 Comment on attachment 178179 Patch 2 Clearing flags on attachment: 178179 Committed r136937: <http://trac.webkit.org/changeset/136937> 785755 6 webkit.review.bot 2012-12-07 01:54:43 -0800 All reviewed patches have been landed. Closing bug. 178178 2012-12-07 01:17:59 -0800 2012-12-07 01:20:18 -0800 Patch bug-104353-20121207181523.patch text/plain 1966 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzkyZTBmOTQyNmYwMjJi ZjU5M2EyOGIxYTVmY2EzZDc3NmM5MDVhMi4uNTYwZGRlMGNlMWNlMmE1ZTZiYjM1ZjQ5MTg1ZWM2 NzVjMzQzZGVmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEyLTA3ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBJbXByb3ZlIGNvbmZ1c2lu ZyBjb2RlIGluIEJhc2VNdWx0aXBsZUZpZWxkc0RhdGVBbmRUaW1lSW5wdXRUeXBlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQzNTMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGRvZXNuJ3QgY2hh bmdlIGFueSBiZWhhdmlvciBiZWNhdXNlIGNhbGwgc2l0ZXMgb2YKKyAgICAgICAgaXNFZGl0Q29u dHJvbE93bmVyRGlzYWJsZWQgYWRuIGlzRWRpdENvbnRyb2xPd25lclJlYWRPbmx5IHRyZWF0IHRo ZW0KKyAgICAgICAgc2ltaWxhcmx5LgorCisgICAgICAgICogaHRtbC9CYXNlTXVsdGlwbGVGaWVs ZHNEYXRlQW5kVGltZUlucHV0VHlwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCYXNlTXVsdGlw bGVGaWVsZHNEYXRlQW5kVGltZUlucHV0VHlwZTo6aXNFZGl0Q29udHJvbE93bmVyRGlzYWJsZWQp OgorICAgICAgICBDaGVja3MgZWxlbWVudCgpLT5kaXNhYmxlZCwgbm90IHJlYWRPbmx5LgorICAg ICAgICAoV2ViQ29yZTo6QmFzZU11bHRpcGxlRmllbGRzRGF0ZUFuZFRpbWVJbnB1dFR5cGU6Omlz RWRpdENvbnRyb2xPd25lclJlYWRPbmx5KToKKyAgICAgICAgQ2hlY2tzIGVsZW1lbnQoKS0+cmVh ZE9ubHksIG5vdCBkaXNhYmxlZC4KKwogMjAxMi0xMi0wNiAgS2VudCBUYW11cmEgIDx0a2VudEBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVmYWN0b3Jpbmc6IENsZWFuIHVwIHBsYWNlaG9sZGVy IGF0dHJpYnV0ZSB1c2FnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9CYXNlTXVs dGlwbGVGaWVsZHNEYXRlQW5kVGltZUlucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0Jhc2VNdWx0aXBsZUZpZWxkc0RhdGVBbmRUaW1lSW5wdXRUeXBlLmNwcAppbmRleCBiNTVlOWE1 YTc3MTZjNDNmYmJkYTJkM2E3MjU3YTRlYjNiYzBlMjk0Li4xZjgyYjFkMmMxMTc2M2I5ZWMxYjc4 NzI3NTNlOTkyZjU5MmRjMjU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0Jhc2VN dWx0aXBsZUZpZWxkc0RhdGVBbmRUaW1lSW5wdXRUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0Jhc2VNdWx0aXBsZUZpZWxkc0RhdGVBbmRUaW1lSW5wdXRUeXBlLmNwcApAQCAtODYs MTIgKzg2LDEyIEBAIGJvb2wgQmFzZU11bHRpcGxlRmllbGRzRGF0ZUFuZFRpbWVJbnB1dFR5cGU6 Omhhc0N1c3RvbUZvY3VzTG9naWMoKSBjb25zdAogCiBib29sIEJhc2VNdWx0aXBsZUZpZWxkc0Rh dGVBbmRUaW1lSW5wdXRUeXBlOjppc0VkaXRDb250cm9sT3duZXJEaXNhYmxlZCgpIGNvbnN0CiB7 Ci0gICAgcmV0dXJuIGVsZW1lbnQoKS0+cmVhZE9ubHkoKTsKKyAgICByZXR1cm4gZWxlbWVudCgp LT5kaXNhYmxlZCgpOwogfQogCiBib29sIEJhc2VNdWx0aXBsZUZpZWxkc0RhdGVBbmRUaW1lSW5w dXRUeXBlOjppc0VkaXRDb250cm9sT3duZXJSZWFkT25seSgpIGNvbnN0CiB7Ci0gICAgcmV0dXJu IGVsZW1lbnQoKS0+ZGlzYWJsZWQoKTsKKyAgICByZXR1cm4gZWxlbWVudCgpLT5yZWFkT25seSgp OwogfQogCiB2b2lkIEJhc2VNdWx0aXBsZUZpZWxkc0RhdGVBbmRUaW1lSW5wdXRUeXBlOjpmb2N1 c0FuZFNlbGVjdFNwaW5CdXR0b25Pd25lcigpCg== 178179 2012-12-07 01:20:21 -0800 2012-12-07 01:54:39 -0800 Patch 2 bug-104353-20121207181745.patch text/plain 1966 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzkyZTBmOTQyNmYwMjJi ZjU5M2EyOGIxYTVmY2EzZDc3NmM5MDVhMi4uZWQ5ODg3NWY2NTYwZDAzNDhmNTM0ZWJkYzhmOGIz NDZiYTE5ZGMyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEyLTA3ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBJbXByb3ZlIGNvbmZ1c2lu ZyBjb2RlIGluIEJhc2VNdWx0aXBsZUZpZWxkc0RhdGVBbmRUaW1lSW5wdXRUeXBlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQzNTMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGRvZXNuJ3QgY2hh bmdlIGFueSBiZWhhdmlvciBiZWNhdXNlIGNhbGwgc2l0ZXMgb2YKKyAgICAgICAgaXNFZGl0Q29u dHJvbE93bmVyRGlzYWJsZWQgYW5kIGlzRWRpdENvbnRyb2xPd25lclJlYWRPbmx5IHRyZWF0IHRo ZW0KKyAgICAgICAgc2ltaWxhcmx5LgorCisgICAgICAgICogaHRtbC9CYXNlTXVsdGlwbGVGaWVs ZHNEYXRlQW5kVGltZUlucHV0VHlwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCYXNlTXVsdGlw bGVGaWVsZHNEYXRlQW5kVGltZUlucHV0VHlwZTo6aXNFZGl0Q29udHJvbE93bmVyRGlzYWJsZWQp OgorICAgICAgICBDaGVja3MgZWxlbWVudCgpLT5kaXNhYmxlZCwgbm90IHJlYWRPbmx5LgorICAg ICAgICAoV2ViQ29yZTo6QmFzZU11bHRpcGxlRmllbGRzRGF0ZUFuZFRpbWVJbnB1dFR5cGU6Omlz RWRpdENvbnRyb2xPd25lclJlYWRPbmx5KToKKyAgICAgICAgQ2hlY2tzIGVsZW1lbnQoKS0+cmVh ZE9ubHksIG5vdCBkaXNhYmxlZC4KKwogMjAxMi0xMi0wNiAgS2VudCBUYW11cmEgIDx0a2VudEBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVmYWN0b3Jpbmc6IENsZWFuIHVwIHBsYWNlaG9sZGVy IGF0dHJpYnV0ZSB1c2FnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9CYXNlTXVs dGlwbGVGaWVsZHNEYXRlQW5kVGltZUlucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0Jhc2VNdWx0aXBsZUZpZWxkc0RhdGVBbmRUaW1lSW5wdXRUeXBlLmNwcAppbmRleCBiNTVlOWE1 YTc3MTZjNDNmYmJkYTJkM2E3MjU3YTRlYjNiYzBlMjk0Li4xZjgyYjFkMmMxMTc2M2I5ZWMxYjc4 NzI3NTNlOTkyZjU5MmRjMjU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0Jhc2VN dWx0aXBsZUZpZWxkc0RhdGVBbmRUaW1lSW5wdXRUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0Jhc2VNdWx0aXBsZUZpZWxkc0RhdGVBbmRUaW1lSW5wdXRUeXBlLmNwcApAQCAtODYs MTIgKzg2LDEyIEBAIGJvb2wgQmFzZU11bHRpcGxlRmllbGRzRGF0ZUFuZFRpbWVJbnB1dFR5cGU6 Omhhc0N1c3RvbUZvY3VzTG9naWMoKSBjb25zdAogCiBib29sIEJhc2VNdWx0aXBsZUZpZWxkc0Rh dGVBbmRUaW1lSW5wdXRUeXBlOjppc0VkaXRDb250cm9sT3duZXJEaXNhYmxlZCgpIGNvbnN0CiB7 Ci0gICAgcmV0dXJuIGVsZW1lbnQoKS0+cmVhZE9ubHkoKTsKKyAgICByZXR1cm4gZWxlbWVudCgp LT5kaXNhYmxlZCgpOwogfQogCiBib29sIEJhc2VNdWx0aXBsZUZpZWxkc0RhdGVBbmRUaW1lSW5w dXRUeXBlOjppc0VkaXRDb250cm9sT3duZXJSZWFkT25seSgpIGNvbnN0CiB7Ci0gICAgcmV0dXJu IGVsZW1lbnQoKS0+ZGlzYWJsZWQoKTsKKyAgICByZXR1cm4gZWxlbWVudCgpLT5yZWFkT25seSgp OwogfQogCiB2b2lkIEJhc2VNdWx0aXBsZUZpZWxkc0RhdGVBbmRUaW1lSW5wdXRUeXBlOjpmb2N1 c0FuZFNlbGVjdFNwaW5CdXR0b25Pd25lcigpCg==