104348 2012-12-07 00:20:09 -0800 [Qt] Adjust library name in layout_tests/port/qt.py after Qt5-r40 2012-12-07 00:57:44 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yoon webkit-unassigned abarth dbates dpranke hausmann ossy vestbo webkit.review.bot oldest_to_newest 785695 0 yoon 2012-12-07 00:20:09 -0800 After Qt-5.0.0-r40, the library was renamed from QtWebKitWidgets to Qt5WebKitWidgets. run-launcher and run-webkit-tests were still looking for QtWebKitWidgets 785697 1 178171 yoon 2012-12-07 00:25:02 -0800 Created attachment 178171 Patch 785709 2 178171 dbates 2012-12-07 00:44:00 -0800 Comment on attachment 178171 Patch This patch needs to be rebased following <http://trac.webkit.org/changeset/136931>, which renames the library from QtWebKitWidgets to Qt5WebKitWidgets in webkitdirs::builtDylibPathForName(). 785712 3 178171 ossy 2012-12-07 00:46:51 -0800 Comment on attachment 178171 Patch Thanks for the fix, I'll land the rebased patch. 785715 4 yoon 2012-12-07 00:50:13 -0800 (In reply to comment #3) > (From update of attachment 178171 [details]) > Thanks for the fix, I'll land the rebased patch. Thanks. So, should I upload the rebase patch? 785716 5 ossy 2012-12-07 00:51:56 -0800 Committed r136934: <http://trac.webkit.org/changeset/136934> 785717 6 ossy 2012-12-07 00:53:07 -0800 (In reply to comment #4) > Thanks. > So, should I upload the rebase patch? Not necessary, I already landed the rebased fix. ;) 785718 7 yoon 2012-12-07 00:54:55 -0800 Reopening to attach new patch. 785719 8 178175 yoon 2012-12-07 00:54:58 -0800 Created attachment 178175 Patch 785720 9 yoon 2012-12-07 00:57:44 -0800 (In reply to comment #6) > (In reply to comment #4) > > Thanks. > > So, should I upload the rebase patch? > > Not necessary, I already landed the rebased fix. ;) Sorry for noise. I was little bit confused. :) 178171 2012-12-07 00:25:02 -0800 2012-12-07 00:54:49 -0800 Patch bug-104348-20121207172226.patch text/plain 2437 yoon U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWIxYjlkYjY5MTY1ZGFlODRkMjAzMjhhM2U4MGE1MGVi NjYwMjBkMS4uOGZhYzk0NDIzYjc2NTAxYjQ0MzQyMWE5NTMxODkxZGQ1Y2Y5MDgyMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTEyLTA3ICBHd2FuZyBZb29uIEh3YW5nICA8cnl1bWllbEBjb21wYW55MTAwLm5l dD4KKworICAgICAgICBbUVRdIEFkanVzdCBsaWJyYXJ5IG5hbWUgaW4gd2Via2l0ZGlycy5wbSBh bmQgbGF5b3V0X3Rlc3RzL3BvcnQvcXQucHkgYWZ0ZXIgUXQ1LXI0MAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0MzQ4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWZ0ZXIgUXQtNS4wLjAtcjQwLCB0aGUg bGlicmFyeSB3YXMgcmVuYW1lZCBmcm9tIFF0V2ViS2l0V2lkZ2V0cyB0bworICAgICAgICBRdDVX ZWJLaXRXaWRnZXRzLiBydW4tbGF1bmNoZXIgYW5kIHJ1bi13ZWJraXQtdGVzdHMgd2VyZSBzdGls bCBsb29raW5nCisgICAgICAgIGZvciBRdFdlYktpdFdpZGdldHMKKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGJ1aWx0RHlsaWJQYXRoRm9yTmFtZSk6CisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weToKKyAgICAgICAg KFF0UG9ydC5fcGF0aF90b193ZWJjb3JlX2xpYnJhcnkpOgorCiAyMDEyLTEyLTA2ICBDc2FiYSBP c3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBmaXgg YWZ0ZXIgcjEzNjg5NiwgdW5icmVhayAtLWRlYnVnLXJ3dCB0byBtYWtlIGJvdHMgcmVzdWx0IHZl cmJvc2UgYWdhaW4uCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9U b29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggYTU1NDViMzhlYWQzYWMzOTVhYThkNWQ3 NjFiZTExMmEwNDU0NzVhMS4uNzA5MmNlYjgwNmM1MjUwM2FjNzU0Njk5NDc1ZWY0YmNhNTYxNGIy YSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtNzIzLDcgKzcyMyw3IEBAIHN1YiBidWlsdER5bGliUGF0 aEZvck5hbWUKICAgICB9CiAgICAgaWYgKGlzUXQoKSkgewogICAgICAgICBteSAkaXNTZWFyY2hp bmdGb3JXZWJDb3JlID0gJGxpYnJhcnlOYW1lID1+ICJXZWJDb3JlIjsKLSAgICAgICAgJGxpYnJh cnlOYW1lID0gIlF0V2ViS2l0V2lkZ2V0cyI7CisgICAgICAgICRsaWJyYXJ5TmFtZSA9ICJRdDVX ZWJLaXRXaWRnZXRzIjsKICAgICAgICAgbXkgJHJlc3VsdDsKICAgICAgICAgaWYgKGlzRGFyd2lu KCkgYW5kIC1kICIkY29uZmlndXJhdGlvblByb2R1Y3REaXIvbGliLyRsaWJyYXJ5TmFtZS5mcmFt ZXdvcmsiKSB7CiAgICAgICAgICAgICAkcmVzdWx0ID0gIiRjb25maWd1cmF0aW9uUHJvZHVjdERp ci9saWIvJGxpYnJhcnlOYW1lLmZyYW1ld29yay8kbGlicmFyeU5hbWUiOwpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXQucHkKaW5kZXggNTVmMTNlZThjZTMw NTNlYWMxZjhhNDIyZjkwMjVmZjU1MjhjNmNmZi4uYzlhM2JiNGY1OTE5ZmZlNjVjZmIxNTM2ODg2 ZTM0MjY4NDYyZmU2NSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9xdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L3F0LnB5CkBAIC05MCw3ICs5MCw3IEBAIGNsYXNzIFF0UG9ydChQb3J0KToKICAgICAg ICAgaWYgc2VsZi5vcGVyYXRpbmdfc3lzdGVtKCkgPT0gJ21hYyc6CiAgICAgICAgICAgICByZXR1 cm4gc2VsZi5fYnVpbGRfcGF0aCgnbGliL1F0V2ViS2l0V2lkZ2V0cy5mcmFtZXdvcmsvUXRXZWJL aXRXaWRnZXRzJykKICAgICAgICAgZWxzZToKLSAgICAgICAgICAgIHJldHVybiBzZWxmLl9idWls ZF9wYXRoKCdsaWIvbGliUXRXZWJLaXRXaWRnZXRzLnNvJykKKyAgICAgICAgICAgIHJldHVybiBz ZWxmLl9idWlsZF9wYXRoKCdsaWIvbGliUXQ1V2ViS2l0V2lkZ2V0cy5zbycpCiAKICAgICBkZWYg X21vZHVsZXNfdG9fc2VhcmNoX2Zvcl9zeW1ib2xzKHNlbGYpOgogICAgICAgICAjIFdlIHNlYXJj aCBpbiBldmVyeSBsaWJyYXJ5IHRvIGJlIHJlbGlhYmxlIGluIHRoZSBjYXNlIG9mIGJ1aWxkaW5n IHdpdGggQ09ORklHKz1mb3JjZV9zdGF0aWNfbGlic19hc19zaGFyZWQuCg== 178175 2012-12-07 00:54:58 -0800 2012-12-07 00:56:25 -0800 Patch bug-104348-20121207175222.patch text/plain 1642 yoon U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGFjOWZkMTdiNDJjYWI4ZTc2YTk2Y2M2OWRkZGIwMGY4 Y2NhZTlmYi4uYWU4MjdiZWFiZjdjZmU0YzQ2NDBhNTFlYzQ4YTgyMTU0Y2QxMTI2NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTEyLTA3ICBHd2FuZyBZb29uIEh3YW5nICA8cnl1bWllbEBjb21wYW55MTAwLm5l dD4KKworICAgICAgICBbUXRdIEFkanVzdCBsaWJyYXJ5IG5hbWUgaW4gbGF5b3V0X3Rlc3RzL3Bv cnQvcXQucHkgYWZ0ZXIgUXQ1LXI0MAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA0MzQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWZ0ZXIgUXQtNS4wLjAtcjQwLCB0aGUgbGlicmFyeSB3YXMgcmVuYW1l ZCBmcm9tIFF0V2ViS2l0V2lkZ2V0cyB0bworICAgICAgICBRdDVXZWJLaXRXaWRnZXRzLiBydW4t d2Via2l0LXRlc3RzIHdhcyBzdGlsbCBsb29raW5nIGZvciBRdFdlYktpdFdpZGdldHMKKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXQucHk6CisgICAgICAg IChRdFBvcnQuX3BhdGhfdG9fd2ViY29yZV9saWJyYXJ5KToKKwogMjAxMi0xMi0wNyAgQ3NhYmEg T3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgZml4 LCB1bmJyZWFrIHJ1bi1sYXVuY2hlciBhZnRlciBsaWJyYXJ5IHJlbmFtaW5nLgpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXQucHkKaW5kZXggNTVmMTNlZThj ZTMwNTNlYWMxZjhhNDIyZjkwMjVmZjU1MjhjNmNmZi4uYzlhM2JiNGY1OTE5ZmZlNjVjZmIxNTM2 ODg2ZTM0MjY4NDYyZmU2NSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9xdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L3F0LnB5CkBAIC05MCw3ICs5MCw3IEBAIGNsYXNzIFF0UG9ydChQb3J0KToKICAg ICAgICAgaWYgc2VsZi5vcGVyYXRpbmdfc3lzdGVtKCkgPT0gJ21hYyc6CiAgICAgICAgICAgICBy ZXR1cm4gc2VsZi5fYnVpbGRfcGF0aCgnbGliL1F0V2ViS2l0V2lkZ2V0cy5mcmFtZXdvcmsvUXRX ZWJLaXRXaWRnZXRzJykKICAgICAgICAgZWxzZToKLSAgICAgICAgICAgIHJldHVybiBzZWxmLl9i dWlsZF9wYXRoKCdsaWIvbGliUXRXZWJLaXRXaWRnZXRzLnNvJykKKyAgICAgICAgICAgIHJldHVy biBzZWxmLl9idWlsZF9wYXRoKCdsaWIvbGliUXQ1V2ViS2l0V2lkZ2V0cy5zbycpCiAKICAgICBk ZWYgX21vZHVsZXNfdG9fc2VhcmNoX2Zvcl9zeW1ib2xzKHNlbGYpOgogICAgICAgICAjIFdlIHNl YXJjaCBpbiBldmVyeSBsaWJyYXJ5IHRvIGJlIHJlbGlhYmxlIGluIHRoZSBjYXNlIG9mIGJ1aWxk aW5nIHdpdGggQ09ORklHKz1mb3JjZV9zdGF0aWNfbGlic19hc19zaGFyZWQuCg==