104338 2012-12-06 20:31:33 -0800 IndexedDB: Replace int64 with int64_t 2012-12-07 09:53:15 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 michael webkit-unassigned alecflett haraken jsbell webkit.review.bot oldest_to_newest 785581 0 michael 2012-12-06 20:31:33 -0800 With r136714, one use of the non-standard type int64 was introduced into IDBFactory.cpp. This type should be changed to the C99/C++11 int64_t type. The int64 type is defined in Chromium's basictypes.h but is not defined for other platforms. 785582 1 178147 michael 2012-12-06 20:32:34 -0800 Created attachment 178147 Patch 785584 2 webkit.review.bot 2012-12-06 20:35:56 -0800 Attachment 178147 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 785585 3 178148 michael 2012-12-06 20:38:06 -0800 Created attachment 178148 Patch 785635 4 178148 haraken 2012-12-06 22:04:25 -0800 Comment on attachment 178148 Patch ok 785664 5 178148 webkit.review.bot 2012-12-06 23:03:28 -0800 Comment on attachment 178148 Patch Clearing flags on attachment: 178148 Committed r136923: <http://trac.webkit.org/changeset/136923> 785665 6 webkit.review.bot 2012-12-06 23:03:32 -0800 All reviewed patches have been landed. Closing bug. 785941 7 alecflett 2012-12-07 09:53:15 -0800 sorry about that.. 178147 2012-12-06 20:32:34 -0800 2012-12-06 20:38:06 -0800 Patch idb-int64.patch text/plain 1927 michael RnJvbTogTWljaGFlbCBQcnVldHQgPG1pY2hhZWxANjhrLm9yZz4KRGF0ZTogVGh1LCA2IERlYyAy MDEyIDIwOjE1OjM3IC0wODAwClN1YmplY3Q6IEluZGV4ZWREQjogUmVwbGFjZSBpbnQ2NCB3aXRo IGludDY0X3QKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4 ZWRkYi9JREJGYWN0b3J5LmNwcCB8ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjNWU1MDJkLi5kYTg4YmMzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTItMDYgIE1pY2hhZWwgUHJ1ZXR0ICA8 bWljaGFlbEA2OGsub3JnPgorCisgICAgICAgIEluZGV4ZWREQjogUmVwbGFjZSBpbnQ2NCB3aXRo IGludDY0X3QKKyAgICAgICAgTmVlZCB0aGUgYnVnIFVSTCAoT09QUyEpLgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENsZWFuaW5nIHVwIGNvZGluZyBp bmNvbnNpc3RlbmNpZXMsIG5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICBUZXN0czog c3RvcmFnZS9pbmRleGVkZGIvKgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCRmFj dG9yeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJGYWN0b3J5OjpvcGVuSW50ZXJuYWwpOgor CiAyMDEyLTEyLTA1ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBbVjhdIEltcGxlbWVudCBkZXByZWNhdGVkVjhTdHJpbmcoKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRmFjdG9yeS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJGYWN0b3J5LmNwcAppbmRleCAxMzQ2MTk0Li4zYmNi YzQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJGYWN0 b3J5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJGYWN0b3J5 LmNwcApAQCAtMTI3LDcgKzEyNyw3IEBAIFBhc3NSZWZQdHI8SURCT3BlbkRCUmVxdWVzdD4gSURC RmFjdG9yeTo6b3BlbkludGVybmFsKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvCiAgICAgICAg IHJldHVybiAwOwogCiAgICAgUmVmUHRyPElEQkRhdGFiYXNlQ2FsbGJhY2tzSW1wbD4gZGF0YWJh c2VDYWxsYmFja3MgPSBJREJEYXRhYmFzZUNhbGxiYWNrc0ltcGw6OmNyZWF0ZSgpOwotICAgIGlu dDY0IHRyYW5zYWN0aW9uSWQgPSBJREJEYXRhYmFzZTo6bmV4dFRyYW5zYWN0aW9uSWQoKTsKKyAg ICBpbnQ2NF90IHRyYW5zYWN0aW9uSWQgPSBJREJEYXRhYmFzZTo6bmV4dFRyYW5zYWN0aW9uSWQo KTsKICAgICBSZWZQdHI8SURCT3BlbkRCUmVxdWVzdD4gcmVxdWVzdCA9IElEQk9wZW5EQlJlcXVl c3Q6OmNyZWF0ZShjb250ZXh0LCBJREJBbnk6OmNyZWF0ZU51bGwoKSwgZGF0YWJhc2VDYWxsYmFj a3MsIHRyYW5zYWN0aW9uSWQsIHZlcnNpb24pOwogICAgIC8vIEZJWE1FOiBwYXNzIHRoZSB0cmFu c2FjdGlvbklkIGluIGhlcmUgaW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMzkyMgogICAgIG1fYmFja2VuZC0+b3BlbihuYW1lLCB2ZXJzaW9uLCByZXF1ZXN0LCBk YXRhYmFzZUNhbGxiYWNrcywgY29udGV4dC0+c2VjdXJpdHlPcmlnaW4oKSwgY29udGV4dCwgZ2V0 SW5kZXhlZERCRGF0YWJhc2VQYXRoKGNvbnRleHQpKTsKLS0gCjEuNy45LjUKCg== 178148 2012-12-06 20:38:06 -0800 2012-12-06 23:03:28 -0800 Patch idb-int64.patch text/plain 1948 michael RnJvbTogTWljaGFlbCBQcnVldHQgPG1pY2hhZWxANjhrLm9yZz4KRGF0ZTogVGh1LCA2IERlYyAy MDEyIDIwOjE1OjM3IC0wODAwClN1YmplY3Q6IEluZGV4ZWREQjogUmVwbGFjZSBpbnQ2NCB3aXRo IGludDY0X3QKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4 ZWRkYi9JREJGYWN0b3J5LmNwcCB8ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjNWU1MDJkLi4xMmI2MDdhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTItMDYgIE1pY2hhZWwgUHJ1ZXR0ICA8 bWljaGFlbEA2OGsub3JnPgorCisgICAgICAgIEluZGV4ZWREQjogUmVwbGFjZSBpbnQ2NCB3aXRo IGludDY0X3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwNDMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IENsZWFuaW5nIHVwIGNvZGluZyBpbmNvbnNpc3RlbmNpZXMsIG5vIGNoYW5nZSBpbiBiZWhhdmlv ci4KKworICAgICAgICBUZXN0czogc3RvcmFnZS9pbmRleGVkZGIvKgorCisgICAgICAgICogTW9k dWxlcy9pbmRleGVkZGIvSURCRmFjdG9yeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJGYWN0 b3J5OjpvcGVuSW50ZXJuYWwpOgorCiAyMDEyLTEyLTA1ICBLZW50YXJvIEhhcmEgIDxoYXJha2Vu QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbVjhdIEltcGxlbWVudCBkZXByZWNhdGVkVjhTdHJp bmcoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRmFj dG9yeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJGYWN0b3J5LmNw cAppbmRleCAxMzQ2MTk0Li4zYmNiYzQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL2luZGV4ZWRkYi9JREJGYWN0b3J5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2luZGV4ZWRkYi9JREJGYWN0b3J5LmNwcApAQCAtMTI3LDcgKzEyNyw3IEBAIFBhc3NSZWZQdHI8 SURCT3BlbkRCUmVxdWVzdD4gSURCRmFjdG9yeTo6b3BlbkludGVybmFsKFNjcmlwdEV4ZWN1dGlv bkNvbnRleHQqIGNvCiAgICAgICAgIHJldHVybiAwOwogCiAgICAgUmVmUHRyPElEQkRhdGFiYXNl Q2FsbGJhY2tzSW1wbD4gZGF0YWJhc2VDYWxsYmFja3MgPSBJREJEYXRhYmFzZUNhbGxiYWNrc0lt cGw6OmNyZWF0ZSgpOwotICAgIGludDY0IHRyYW5zYWN0aW9uSWQgPSBJREJEYXRhYmFzZTo6bmV4 dFRyYW5zYWN0aW9uSWQoKTsKKyAgICBpbnQ2NF90IHRyYW5zYWN0aW9uSWQgPSBJREJEYXRhYmFz ZTo6bmV4dFRyYW5zYWN0aW9uSWQoKTsKICAgICBSZWZQdHI8SURCT3BlbkRCUmVxdWVzdD4gcmVx dWVzdCA9IElEQk9wZW5EQlJlcXVlc3Q6OmNyZWF0ZShjb250ZXh0LCBJREJBbnk6OmNyZWF0ZU51 bGwoKSwgZGF0YWJhc2VDYWxsYmFja3MsIHRyYW5zYWN0aW9uSWQsIHZlcnNpb24pOwogICAgIC8v IEZJWE1FOiBwYXNzIHRoZSB0cmFuc2FjdGlvbklkIGluIGhlcmUgaW4gaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzkyMgogICAgIG1fYmFja2VuZC0+b3BlbihuYW1l LCB2ZXJzaW9uLCByZXF1ZXN0LCBkYXRhYmFzZUNhbGxiYWNrcywgY29udGV4dC0+c2VjdXJpdHlP cmlnaW4oKSwgY29udGV4dCwgZ2V0SW5kZXhlZERCRGF0YWJhc2VQYXRoKGNvbnRleHQpKTsKLS0g CjEuNy45LjUKCg==