104337 2012-12-06 20:25:01 -0800 Refactoring: Clean up placeholder attribute usage 2012-12-06 23:47:57 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tkent tkent haraken mifenton morrita ojan.autocc webkit.review.bot oldest_to_newest 785578 0 tkent 2012-12-06 20:25:01 -0800 Refactoring: Clean up placeholder attribute usage 785580 1 178146 tkent 2012-12-06 20:27:48 -0800 Created attachment 178146 Patch 785612 2 178146 haraken 2012-12-06 21:27:34 -0800 Comment on attachment 178146 Patch Looks ok 785680 3 178146 webkit.review.bot 2012-12-06 23:47:54 -0800 Comment on attachment 178146 Patch Clearing flags on attachment: 178146 Committed r136928: <http://trac.webkit.org/changeset/136928> 785681 4 webkit.review.bot 2012-12-06 23:47:57 -0800 All reviewed patches have been landed. Closing bug. 178146 2012-12-06 20:27:48 -0800 2012-12-06 23:47:53 -0800 Patch bug-104337-20121207132511.patch text/plain 5259 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzc3NTdiMjEzZTk2YTdm YzY0N2M2ZGZmYTRjNjA0MWQxZmM2NGVhZi4uYWZjOWJlODk4MzQ1Nzg3NGFmNGQ0Y2MzNTg3NjEx ZmQzMTI1NzVkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEyLTA2ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZWZhY3RvcmluZzogQ2xl YW4gdXAgcGxhY2Vob2xkZXIgYXR0cmlidXRlIHVzYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQzMzcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgZG9lc24ndCBjaGFu Z2UgYW55IGJlaGF2aW9yLgorCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDog UmVtb3ZlIHBsYWNlaG9sZGVyIGFuZCBzZXRQbGFjZWhvZGxlci4KKyAgICAgICAgKiBodG1sL0hU TUxJbnB1dEVsZW1lbnQuaDogRGl0dG8uCisgICAgICAgICogaHRtbC9IVE1MVGV4dEZvcm1Db250 cm9sRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVGV4dEZvcm1Db250cm9sRWxl bWVudDo6c3RyaXBwZWRQbGFjZWhvbGRlcik6CisgICAgICAgIFdlIGNhbiB1c2UgZmFzdEdldEF0 dHJpYnV0ZSBmb3IgcGxhY2Vob2xkZXIuCisgICAgICAgIChXZWJDb3JlOjpIVE1MVGV4dEZvcm1D b250cm9sRWxlbWVudDo6aXNQbGFjZWhvbGRlckVtcHR5KToKKyAgICAgICAgRGl0dG8uCisKIDIw MTItMTItMDYgIFJpY2sgQnllcnMgIDxyYnllcnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENT UyBjdXJzb3IgcHJvcGVydHkgc2hvdWxkIHN1cHBvcnQgd2Via2l0LWltYWdlLXNldApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwppbmRleCBjOWVjYWY1OTIyNTgxZDdjZWNlNTljNTI3NDgzZTQ0ZDU4 MjgxMWY3Li5iMjFkYjhmMGVlZTBjMTljYmQxYTI3YTZkODFjZjg1ZTAyNGU4MjQ1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTA2ICBLZW50IFRh bXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZWZhY3RvcmluZzogQ2xlYW4g dXAgcGxhY2Vob2xkZXIgYXR0cmlidXRlIHVzYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQzMzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9XZWJJbnB1dEVsZW1lbnQuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJJbnB1dEVsZW1lbnQ6OnNldFBsYWNlaG9sZGVyKToKKyAgICAgICAgVXNl IHNldEF0dHJpYnV0ZS4KKyAgICAgICAgKFdlYktpdDo6V2ViSW5wdXRFbGVtZW50OjpwbGFjZWhv bGRlcik6CisgICAgICAgIFVzZSBmYXN0R2V0QXR0cmlidXRlLgorCiAyMDEyLTEyLTA2ICBSaWNr IEJ5ZXJzICA8cmJ5ZXJzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDU1MgY3Vyc29yIHByb3Bl cnR5IHNob3VsZCBzdXBwb3J0IHdlYmtpdC1pbWFnZS1zZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IDVmM2I2ZmZmNzgxZjAxMzY5ZDFkNDU4MjZmN2IwMjNl NzVhOWE0OWMuLjBmZmRhYWIyNGNkYzQ4NGQzYTgyZTc0YzQ0MDYyMjliY2NiNDc0ZDAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcApAQCAtMTA1MSwxNiArMTA1MSw2 IEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6c2V0VmFsdWVBc051bWJlcihkb3VibGUgbmV3VmFs dWUsIEV4Y2VwdGlvbkNvZGUmIGVjLCBUZXh0CiAgICAgbV9pbnB1dFR5cGUtPnNldFZhbHVlQXNE b3VibGUobmV3VmFsdWUsIGV2ZW50QmVoYXZpb3IsIGVjKTsKIH0KIAotU3RyaW5nIEhUTUxJbnB1 dEVsZW1lbnQ6OnBsYWNlaG9sZGVyKCkgY29uc3QKLXsKLSAgICByZXR1cm4gZmFzdEdldEF0dHJp YnV0ZShwbGFjZWhvbGRlckF0dHIpLnN0cmluZygpOwotfQotCi12b2lkIEhUTUxJbnB1dEVsZW1l bnQ6OnNldFBsYWNlaG9sZGVyKGNvbnN0IFN0cmluZyYgdmFsdWUpCi17Ci0gICAgc2V0QXR0cmli dXRlKHBsYWNlaG9sZGVyQXR0ciwgdmFsdWUpOwotfQotCiB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6 OnNldFZhbHVlRnJvbVJlbmRlcmVyKGNvbnN0IFN0cmluZyYgdmFsdWUpCiB7CiAgICAgLy8gRmls ZSB1cGxvYWQgY29udHJvbHMgd2lsbCBuZXZlciB1c2UgdGhpcy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MSW5wdXRFbGVtZW50LmgKaW5kZXggZjk4YjAxOWY2YmUxYTI1NzNhZDMyYzg2MTQ5NDA4OTRm NTYxMGQwZC4uODIxNDUzYTFiMGFiNTAzMDc5ODEzMGJhOTE1MTdjY2NkZTc5ZDQ4NSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKKysrIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKQEAgLTE3Niw5ICsxNzYsNiBAQCBwdWJs aWM6CiAgICAgZG91YmxlIHZhbHVlQXNOdW1iZXIoKSBjb25zdDsKICAgICB2b2lkIHNldFZhbHVl QXNOdW1iZXIoZG91YmxlLCBFeGNlcHRpb25Db2RlJiwgVGV4dEZpZWxkRXZlbnRCZWhhdmlvciA9 IERpc3BhdGNoTm9FdmVudCk7CiAKLSAgICB2aXJ0dWFsIFN0cmluZyBwbGFjZWhvbGRlcigpIGNv bnN0OwotICAgIHZpcnR1YWwgdm9pZCBzZXRQbGFjZWhvbGRlcihjb25zdCBTdHJpbmcmKTsKLQog ICAgIFN0cmluZyB2YWx1ZVdpdGhEZWZhdWx0KCkgY29uc3Q7CiAKICAgICB2b2lkIHNldFZhbHVl RnJvbVJlbmRlcmVyKGNvbnN0IFN0cmluZyYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcAppbmRleCAwYzkyNWJhMGY4ZDRjNTk1MmRk YjgxY2JmOWU2ODgxNmExODQwYWRlLi43OGJjNmU5NDg2N2VmZjQzODkzMDdiYjFlMjM5NjM1ZDA3 MTk5NTg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRy b2xFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRy b2xFbGVtZW50LmNwcApAQCAtMTE2LDcgKzExNiw3IEBAIFN0cmluZyBIVE1MVGV4dEZvcm1Db250 cm9sRWxlbWVudDo6c3RyaXBwZWRQbGFjZWhvbGRlcigpIGNvbnN0CiB7CiAgICAgLy8gQWNjb3Jk aW5nIHRvIHRoZSBIVE1MNSBzcGVjaWZpY2F0aW9uLCB3ZSBuZWVkIHRvIHJlbW92ZSBDUiBhbmQg TEYgZnJvbQogICAgIC8vIHRoZSBhdHRyaWJ1dGUgdmFsdWUuCi0gICAgY29uc3QgQXRvbWljU3Ry aW5nJiBhdHRyaWJ1dGVWYWx1ZSA9IGdldEF0dHJpYnV0ZShwbGFjZWhvbGRlckF0dHIpOworICAg IGNvbnN0IEF0b21pY1N0cmluZyYgYXR0cmlidXRlVmFsdWUgPSBmYXN0R2V0QXR0cmlidXRlKHBs YWNlaG9sZGVyQXR0cik7CiAgICAgaWYgKCFhdHRyaWJ1dGVWYWx1ZS5jb250YWlucyhuZXdsaW5l Q2hhcmFjdGVyKSAmJiAhYXR0cmlidXRlVmFsdWUuY29udGFpbnMoY2FycmlhZ2VSZXR1cm4pKQog ICAgICAgICByZXR1cm4gYXR0cmlidXRlVmFsdWU7CiAKQEAgLTEzNiw3ICsxMzYsNyBAQCBzdGF0 aWMgYm9vbCBpc05vdExpbmVCcmVhayhVQ2hhciBjaCkgeyByZXR1cm4gY2ggIT0gbmV3bGluZUNo YXJhY3RlciAmJiBjaCAhPSBjYQogCiBib29sIEhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50Ojpp c1BsYWNlaG9sZGVyRW1wdHkoKSBjb25zdAogewotICAgIGNvbnN0IEF0b21pY1N0cmluZyYgYXR0 cmlidXRlVmFsdWUgPSBnZXRBdHRyaWJ1dGUocGxhY2Vob2xkZXJBdHRyKTsKKyAgICBjb25zdCBB dG9taWNTdHJpbmcmIGF0dHJpYnV0ZVZhbHVlID0gZmFzdEdldEF0dHJpYnV0ZShwbGFjZWhvbGRl ckF0dHIpOwogICAgIHJldHVybiBhdHRyaWJ1dGVWYWx1ZS5zdHJpbmcoKS5maW5kKGlzTm90TGlu ZUJyZWFrKSA9PSBub3RGb3VuZDsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYklucHV0RWxlbWVudC5jcHAKaW5kZXggYmZjMGMyMzZiZDk2ZWVjM2NkNWJiYjk5NWNhN2Nl ZTZkMWNlNTgxZi4uMWY0YjViYWMyZDg0NTZlMmIwZWI2M2Y1YmYxZjViMmFmM2E5ZjRhMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwCkBAIC0x MjUsMTIgKzEyNSwxMiBAQCBXZWJTdHJpbmcgV2ViSW5wdXRFbGVtZW50OjpzdWdnZXN0ZWRWYWx1 ZSgpIGNvbnN0CiAKIHZvaWQgV2ViSW5wdXRFbGVtZW50OjpzZXRQbGFjZWhvbGRlcihjb25zdCBX ZWJTdHJpbmcmIHZhbHVlKQogewotICAgIHVud3JhcDxIVE1MSW5wdXRFbGVtZW50PigpLT5zZXRQ bGFjZWhvbGRlcih2YWx1ZSk7CisgICAgdW53cmFwPEhUTUxJbnB1dEVsZW1lbnQ+KCktPnNldEF0 dHJpYnV0ZShIVE1MTmFtZXM6OnBsYWNlaG9sZGVyQXR0ciwgdmFsdWUpOwogfQogCiBXZWJTdHJp bmcgV2ViSW5wdXRFbGVtZW50OjpwbGFjZWhvbGRlcigpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIGNv bnN0VW53cmFwPEhUTUxJbnB1dEVsZW1lbnQ+KCktPnBsYWNlaG9sZGVyKCk7CisgICAgcmV0dXJu IGNvbnN0VW53cmFwPEhUTUxJbnB1dEVsZW1lbnQ+KCktPmZhc3RHZXRBdHRyaWJ1dGUoSFRNTE5h bWVzOjpwbGFjZWhvbGRlckF0dHIpOwogfQogCiBib29sIFdlYklucHV0RWxlbWVudDo6aXNBdXRv ZmlsbGVkKCkgY29uc3QK