104334 2012-12-06 19:19:07 -0800 [BlackBerry] make "isVideo" information available to platform media player 2012-12-07 11:56:46 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified CLOSED FIXED P2 Normal --- 1 mfeil mfeil eric.carlson feature-media-reviews mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 785551 0 mfeil 2012-12-06 19:19:07 -0800 The platform player needs to know whether the element is <video> or <audio>, so it can make certain decisions before metadata is ready. Basically it will use "isVideo" sometimes instead of "hasVideo". This is part of a performance optimization refactor which does not change functionality so no new tests are required. The bulk of the code changes are covered under PR234726 in the platform repository. 785555 1 178138 mfeil 2012-12-06 19:34:04 -0800 Created attachment 178138 Patch 785808 2 178138 rwlbuis 2012-12-07 04:54:59 -0800 Comment on attachment 178138 Patch LGTM 785809 3 178138 webkit.review.bot 2012-12-07 04:58:47 -0800 Comment on attachment 178138 Patch Clearing flags on attachment: 178138 Committed r136946: <http://trac.webkit.org/changeset/136946> 785810 4 webkit.review.bot 2012-12-07 04:58:52 -0800 All reviewed patches have been landed. Closing bug. 786026 5 mfeil 2012-12-07 11:56:46 -0800 Thanks Rob. Closing. 178138 2012-12-06 19:34:04 -0800 2012-12-07 04:58:47 -0800 Patch bug-104334-20121206223128.patch text/plain 2347 mfeil U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzc3NTdiMjEzZTk2YTdm YzY0N2M2ZGZmYTRjNjA0MWQxZmM2NGVhZi4uZTk0OGE3YzViODg2N2JhNjAxMWViM2ZmYWUxZTA3 YWE5ZDRmNTk2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTA2ICBNYXgg RmVpbCAgPG1mZWlsQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIG1ha2UgImlzVmlk ZW8iIGluZm9ybWF0aW9uIGF2YWlsYWJsZSB0byBwbGF0Zm9ybSBtZWRpYSBwbGF5ZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDMzNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwbGF0Zm9ybSBw bGF5ZXIgbmVlZHMgdG8ga25vdyB3aGV0aGVyIHRoZSBlbGVtZW50IGlzIDx2aWRlbz4KKyAgICAg ICAgb3IgPGF1ZGlvPiwgc28gaXQgY2FuIG1ha2UgY2VydGFpbiBkZWNpc2lvbnMgYmVmb3JlIG1l dGFkYXRhCisgICAgICAgIGlzIHJlYWR5LiBUaGlzIGlzIHBhcnQgb2YgYSBwZXJmb3JtYW5jZSBv cHRpbWl6YXRpb24gcmVmYWN0b3IKKyAgICAgICAgd2hpY2ggZG9lcyBub3QgY2hhbmdlIGZ1bmN0 aW9uYWxpdHkgc28gbm8gbmV3IHRlc3RzIGFyZSByZXF1aXJlZC4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6OmxvYWQpOgorCiAyMDEyLTEy LTA2ICBSaWNrIEJ5ZXJzICA8cmJ5ZXJzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDU1MgY3Vy c29yIHByb3BlcnR5IHNob3VsZCBzdXBwb3J0IHdlYmtpdC1pbWFnZS1zZXQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQ cml2YXRlQmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9i bGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwCmluZGV4IDdlOWE3OWNi MDVkYWFkNWNiMjgzNGRjOWFhNWQ4N2E3YmZjYzI1Y2EuLjI2ZjU3N2I2ZjA1NjU0MzY1ZmZmZTgx NjliYWM3M2IxMTI5MTMwMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclBy aXZhdGVCbGFja0JlcnJ5LmNwcApAQCAtMTYxLDEyICsxNjEsMTMgQEAgdm9pZCBNZWRpYVBsYXll clByaXZhdGU6OmxvYWQoY29uc3QgV1RGOjpTdHJpbmcmIHVybCkKIAogICAgIHZvaWQqIHRhYklk ID0gbV93ZWJDb3JlUGxheWVyLT5tZWRpYVBsYXllckNsaWVudCgpLT5tZWRpYVBsYXllckhvc3RX aW5kb3coKS0+cGxhdGZvcm1QYWdlQ2xpZW50KCk7CiAgICAgaW50IHBsYXllcklEID0gbV93ZWJD b3JlUGxheWVyLT5tZWRpYVBsYXllckNsaWVudCgpLT5tZWRpYVBsYXllckhvc3RXaW5kb3coKS0+ cGxhdGZvcm1QYWdlQ2xpZW50KCktPnBsYXllcklEKCk7CisgICAgYm9vbCBpc1ZpZGVvID0gbV93 ZWJDb3JlUGxheWVyLT5tZWRpYVBsYXllckNsaWVudCgpLT5tZWRpYVBsYXllcklzVmlkZW8oKTsK IAogICAgIGRlbGV0ZUd1YXJkZWRPYmplY3QobV9wbGF0Zm9ybVBsYXllcik7CiAjaWYgVVNFKEFD Q0VMRVJBVEVEX0NPTVBPU0lUSU5HKQotICAgIG1fcGxhdGZvcm1QbGF5ZXIgPSBQbGF0Zm9ybVBs YXllcjo6Y3JlYXRlKHRoaXMsIHRhYklkLCB0cnVlLCBtb2RpZmllZFVybC51dGY4KCkuZGF0YSgp KTsKKyAgICBtX3BsYXRmb3JtUGxheWVyID0gUGxhdGZvcm1QbGF5ZXI6OmNyZWF0ZSh0aGlzLCB0 YWJJZCwgaXNWaWRlbywgdHJ1ZSwgbW9kaWZpZWRVcmwudXRmOCgpLmRhdGEoKSk7CiAjZWxzZQot ICAgIG1fcGxhdGZvcm1QbGF5ZXIgPSBQbGF0Zm9ybVBsYXllcjo6Y3JlYXRlKHRoaXMsIHRhYklk LCBmYWxzZSwgbW9kaWZpZWRVcmwudXRmOCgpLmRhdGEoKSk7CisgICAgbV9wbGF0Zm9ybVBsYXll ciA9IFBsYXRmb3JtUGxheWVyOjpjcmVhdGUodGhpcywgdGFiSWQsIGlzVmlkZW8sIGZhbHNlLCBt b2RpZmllZFVybC51dGY4KCkuZGF0YSgpKTsKICNlbmRpZgogCiAgICAgV1RGOjpTdHJpbmcgY29v a2llUGFpcnM7Cg==