104327 2012-12-06 17:22:53 -0800 [CoordGfx] Variable name starts with upper case character 2012-12-07 14:14:18 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 helder.correia webkit-unassigned gtk-ews noam webkit.review.bot xan.lopez zeno oldest_to_newest 785448 0 helder.correia 2012-12-06 17:22:53 -0800 In CoordinatedGraphicsLayer::setMaskLayer(GraphicsLayer*): CoordinatedGraphicsLayer* CoordinatedGraphicsLayer = toCoordinatedGraphicsLayer(layer); CoordinatedGraphicsLayer->didChangeLayerState(); 785450 1 178117 helder.correia 2012-12-06 17:24:51 -0800 Created attachment 178117 Patch 785463 2 178117 gtk-ews 2012-12-06 17:36:29 -0800 Comment on attachment 178117 Patch Attachment 178117 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15159915 786140 3 178117 webkit.review.bot 2012-12-07 14:14:15 -0800 Comment on attachment 178117 Patch Clearing flags on attachment: 178117 Committed r136983: <http://trac.webkit.org/changeset/136983> 786141 4 webkit.review.bot 2012-12-07 14:14:18 -0800 All reviewed patches have been landed. Closing bug. 178117 2012-12-06 17:24:51 -0800 2012-12-07 14:14:15 -0800 Patch bug-104327-20121206172223.patch text/plain 1690 helder.correia U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTAxNGZiMDdjMWNlY2Vk ZmFlMmNhZmJkYzUxOTE1M2EyYzRjMTMzNS4uOWRjZjY1MTA5MGQ2ZmQ0MjQxYjU3NGI1MDU5Y2Ey NDk1MWZjODVmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTA2ICBIZWxk ZXIgQ29ycmVpYSAgPGhlbGRlci5jb3JyZWlhQG5va2lhLmNvbT4KKworICAgICAgICBbQ29vcmRH ZnhdIFZhcmlhYmxlIG5hbWUgc3RhcnRzIHdpdGggdXBwZXIgY2FzZSBjaGFyYWN0ZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDMyNworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEp1c3QgZml4aW5nIGEg dHlwby4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNz L0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb29yZGlu YXRlZEdyYXBoaWNzTGF5ZXI6OnNldE1hc2tMYXllcik6CisKIDIwMTItMTItMDYgIEpvbiBMZWUg IDxqb25sZWVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldHJ5IHNuYXBzaG90cyBpZiB0aGV5IGFy ZSB0b28gZW1wdHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGlu YXRlZEdyYXBoaWNzTGF5ZXIuY3BwCmluZGV4IDk4NTZmNTFmNDUwNTYwY2FhNDE2ZGQ4MWY5OGY5 MWMyMmNlNzY0N2UuLjY4MzhhZTc1YzBiMzM0ZWFhZWY5NmVjNTJiMjk5NDZkMDYyYWEyOTUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdy YXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGlj c0xheWVyLmNwcApAQCAtNDAyLDggKzQwMiw4IEBAIHZvaWQgQ29vcmRpbmF0ZWRHcmFwaGljc0xh eWVyOjpzZXRNYXNrTGF5ZXIoR3JhcGhpY3NMYXllciogbGF5ZXIpCiAKICAgICBsYXllci0+c2V0 U2l6ZShzaXplKCkpOwogICAgIGxheWVyLT5zZXRDb250ZW50c1Zpc2libGUoY29udGVudHNBcmVW aXNpYmxlKCkpOwotICAgIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllciogQ29vcmRpbmF0ZWRHcmFw aGljc0xheWVyID0gdG9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIobGF5ZXIpOwotICAgIENvb3Jk aW5hdGVkR3JhcGhpY3NMYXllci0+ZGlkQ2hhbmdlTGF5ZXJTdGF0ZSgpOworICAgIENvb3JkaW5h dGVkR3JhcGhpY3NMYXllciogY29vcmRpbmF0ZWRMYXllciA9IHRvQ29vcmRpbmF0ZWRHcmFwaGlj c0xheWVyKGxheWVyKTsKKyAgICBjb29yZGluYXRlZExheWVyLT5kaWRDaGFuZ2VMYXllclN0YXRl KCk7CiAgICAgZGlkQ2hhbmdlTGF5ZXJTdGF0ZSgpOwogCiB9Cg==