104316 2012-12-06 16:31:58 -0800 [chromium] Rename non-standard discard/ensureFramebufferCHROMIUM extensions so we can use real GL_EXT_discard_framebuffer 2012-12-06 18:58:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth backer dglazkov fishd kbr piman sievers tkent+wkapi webkit.review.bot oldest_to_newest 785400 0 jamesr 2012-12-06 16:31:58 -0800 [chromium] Rename non-standard discard/ensureFramebufferCHROMIUM extensions so we can use real GL_EXT_discard_framebuffer 785401 1 178105 jamesr 2012-12-06 16:34:30 -0800 Created attachment 178105 Patch 785409 2 webkit.review.bot 2012-12-06 16:40:23 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 785485 3 piman 2012-12-06 17:53:40 -0800 LGTM 785531 4 178105 kbr 2012-12-06 18:44:09 -0800 Comment on attachment 178105 Patch Looks fine. r=me 785538 5 178105 webkit.review.bot 2012-12-06 18:58:16 -0800 Comment on attachment 178105 Patch Clearing flags on attachment: 178105 Committed r136917: <http://trac.webkit.org/changeset/136917> 785539 6 webkit.review.bot 2012-12-06 18:58:20 -0800 All reviewed patches have been landed. Closing bug. 178105 2012-12-06 16:34:30 -0800 2012-12-06 18:58:16 -0800 Patch bug-104316-20121206163154.patch text/plain 3068 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBkMDZjMzMxZGQ2YmM2 OTE2MDMyNDk0ODcwMjM3ODMwYWU0MDRlODY0Li4wZWVjZWY3ZjJlMDY5MjA3NDEzM2JhMTRlMWM4 NGIzZDNlYjQxZTJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0xMi0wNiAg SmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1 bV0gUmVuYW1lIG5vbi1zdGFuZGFyZCBkaXNjYXJkL2Vuc3VyZUZyYW1lYnVmZmVyQ0hST01JVU0g ZXh0ZW5zaW9ucyBzbyB3ZSBjYW4gdXNlIHJlYWwgR0xfRVhUX2Rpc2NhcmRfZnJhbWVidWZmZXIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDMxNgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdMX0VYVF9k aXNjYXJkX2ZyYW1lYnVmZmVyIGlzIGEgR0wgZXh0ZW5zaW9uIHRoYXQgZW5hYmxlcyBvcHRpbWl6 YXRpb25zIGZvciBHUFVzIHRoYXQgYWdncmVzc2l2ZWx5IGRlZmVyCisgICAgICAgIG9wZXJhdGlv bnMuIFdlJ3ZlICdib3Jyb3dlZCcgdGhlIGV4dGVuc2lvbiBuYW1lc3BhY2UgdG8gZW5hYmxlIGJh Y2tidWZmZXIgbWFuYWdlbWVudCwgYnV0IHRoaXMgbWFrZXMgaXQKKyAgICAgICAgaW1wb3NzaWJs ZSB0byB1c2UgdGhlIGFjdHVhbCBleHRlbnNpb24uICBUaGlzIGFkZHMgbmV3IGVudHJ5IHBvaW50 cyBmb3IgYmFja2J1ZmZlciBtYW5hZ2VtZW50LiBBZnRlciBjYWxsZXJzCisgICAgICAgICh3aGlj aCBhcmVuJ3QgaW4gdGhlIFdlYktpdCByZXBvKSBhcmUgdXBkYXRlZCwgd2UgY2FuIHJlbW92ZSB0 aGUgb3ZlcmxhcHBpbmcgZW50cnkgcG9pbnRzLgorCisgICAgICAgICogY2hyb21pdW0vcHVibGlj L1dlYkdyYXBoaWNzQ29udGV4dDNELmg6CisgICAgICAgIChXZWJHcmFwaGljc0NvbnRleHQzRCk6 CisgICAgICAgIChXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEOjpkaXNjYXJkRnJhbWVidWZm ZXJDSFJPTUlVTSk6CisgICAgICAgIChXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEOjpkaXNj YXJkQmFja2J1ZmZlckNIUk9NSVVNKToKKyAgICAgICAgKFdlYktpdDo6V2ViR3JhcGhpY3NDb250 ZXh0M0Q6OmVuc3VyZUJhY2tidWZmZXJDSFJPTUlVTSk6CisKIDIwMTItMTItMDQgIEdsZW5uIEhh cnRtYW5uICA8aGFydG1hbm5nQGNocm9taXVtLm9yZz4KIAogICAgICAgICBHdXQgV2ViUmVuZGVy aW5nU3RhdHMgc2luY2Ugd2Ugbm8gbG9uZ2VyIHVzZSBpdHMgbWVtYmVyIHZhcmlhYmxlcy4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViR3JhcGhpY3NDb250 ZXh0M0QuaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViR3JhcGhpY3NDb250 ZXh0M0QuaAppbmRleCA4ZjMxMWNjMmVhOWQyN2FmMWE1OTdhNDZlMmNkNTk3MTIzODY3NDg0Li5l ZDk3MjNlM2ZiZWI5M2U4MDg0Zjg2ZmVjNTg5MDViZTdhMmVkNDAzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmgKKysrIGIv U291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCkBA IC0xNjUsMTAgKzE2NSwxNiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNldE1lbW9yeUFs bG9jYXRpb25DaGFuZ2VkQ2FsbGJhY2tDSFJPTUlVTShXZWJHcmFwaGljc01lbW9yeUFsbG9jYXRp b25DaGFuZ2VkQ2FsbGJhY2tDSFJPTUlVTSogY2FsbGJhY2spIHsgfQogICAgIHZpcnR1YWwgdm9p ZCBzZW5kTWFuYWdlZE1lbW9yeVN0YXRzQ0hST01JVU0oY29uc3QgV2ViR3JhcGhpY3NNYW5hZ2Vk TWVtb3J5U3RhdHMqIHN0YXRzKSB7IH0KIAotICAgIC8vIEdMX0VYVF9kaXNjYXJkX2ZyYW1lYnVm ZmVyIC0gZGlzY2FyZC9lbnN1cmUgZXhpc3RhbmNlIG9mIHN1cmZhY2UgYmFja2J1ZmZlci4KLSAg ICAvLyBGSVhNRTogbWFrZSB0aGVzZSBwdXJlIHZpcnR1YWwgb25jZSB0aGV5IGFyZSBpbXBsZW1l bnRlZCBieSBjbGllbnRzLgorICAgIC8vIEdMX0VYVF9kaXNjYXJkX2ZyYW1lYnVmZmVyIC0gbWFr ZXMgc3BlY2lmaWVkIGF0dGFjaG1lbnRzIG9mIGN1cnJlbnRseSBib3VuZCBmcmFtZWJ1ZmZlciB1 bmRlZmluZWQuCiAgICAgdmlydHVhbCB2b2lkIGRpc2NhcmRGcmFtZWJ1ZmZlckVYVChXR0MzRGVu dW0gdGFyZ2V0LCBXR0MzRHNpemVpIG51bUF0dGFjaG1lbnRzLCBjb25zdCBXR0MzRGVudW0qIGF0 dGFjaG1lbnRzKSB7IH0KKworICAgIC8vIEdMX0NIUk9NSVVNX2Rpc2NhcmRfYmFja2J1ZmZlciAt IGNvbnRyb2xzIGFsbG9jYXRpb24vZGVhbGxvY2F0aW9uIG9mIHRoZSBiYWNrIGJ1ZmZlci4KKyAg ICAvLyBGSVhNRTogUGFyYW1ldGVycyB0byBkaXNjYXJkRnJhbWVidWZmZXJDSFJPTUlVTSBhcmVu J3QgdXNlZCwgcmVtb3ZlIHdoZW4gY2FsbGluZyBjb2RlIGlzIGdvbmUuCisgICAgLy8gRklYTUU6 IFJlbW92ZSB4eHhGcmFtZWJ1ZmZlckNIUk9NSVVNIHZlcnNpb25zIHdoZW4gY2FsbGVycyBzd2l0 Y2ggdG8geHh4QmFja2J1ZmZlckNIUk9NSVVNKCkKKyAgICB2aXJ0dWFsIHZvaWQgZGlzY2FyZEZy YW1lYnVmZmVyQ0hST01JVU0oV0dDM0RlbnVtLCBXR0MzRHNpemVpLCBjb25zdCBXR0MzRGVudW0q KSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgZW5zdXJlRnJhbWVidWZmZXJDSFJPTUlVTSgpIHsgfQor ICAgIHZpcnR1YWwgdm9pZCBkaXNjYXJkQmFja2J1ZmZlckNIUk9NSVVNKCkgeyB9CisgICAgdmly dHVhbCB2b2lkIGVuc3VyZUJhY2tidWZmZXJDSFJPTUlVTSgpIHsgfQogCiAgICAgLy8gUXVlcnkg d2hldGhlciBpdCBpcyBidWlsdCBvbiB0b3Agb2YgY29tcGxpYW50IEdMRVMyIGltcGxlbWVudGF0 aW9uLgogICAgIHZpcnR1YWwgYm9vbCBpc0dMRVMyQ29tcGxpYW50KCkgPSAwOwo=