104301 2012-12-06 14:15:21 -0800 nrwt: remove deprecated ORWT compatibility command line flags 2012-12-12 14:41:03 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104298 104299 1 dpranke dpranke abarth dglazkov eric ojan ossy webkit.review.bot oldest_to_newest 785256 0 dpranke 2012-12-06 14:15:21 -0800 nrwt: remove deprecated ORWT compatibility command line flags 785263 1 178081 dpranke 2012-12-06 14:17:37 -0800 Created attachment 178081 Patch 785330 2 eric 2012-12-06 15:23:14 -0800 I really appreciate you cleaning all this up. 785331 3 178081 webkit.review.bot 2012-12-06 15:25:10 -0800 Comment on attachment 178081 Patch Attachment 178081 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15187046 789719 4 dpranke 2012-12-12 11:09:30 -0800 Ossy, can you let me know when it's safe to land this w/o breaking the http://build.webkit.sed.hu/ waterfall? I'd update the config if I had any idea how to do that :). 789777 5 ossy 2012-12-12 12:07:28 -0800 (In reply to comment #4) > Ossy, can you let me know when it's safe to land this w/o breaking the http://build.webkit.sed.hu/ waterfall? I'd update the config if I had any idea how to do that :). I removed the obsolete --no-launch-safari and --use-remote-links-to-tests from the master.cfg of build.webkit.sed.hu. Now the test command is: command = ["perl", "./Tools/Scripts/run-webkit-tests", "--no-new-test-results", "--debug-rwt-logging", "--no-sample-on-timeout", "--results-directory", "layout-test-results", "--builder-name", WithProperties("%(buildername)s"), WithProperties("--%(configuration)s")] Is there anything else I should remove? 789788 6 dpranke 2012-12-12 12:13:10 -0800 (In reply to comment #5) > (In reply to comment #4) > > Ossy, can you let me know when it's safe to land this w/o breaking the http://build.webkit.sed.hu/ waterfall? I'd update the config if I had any idea how to do that :). > > I removed the obsolete --no-launch-safari and --use-remote-links-to-tests > from the master.cfg of build.webkit.sed.hu. Now the test command is: > command = ["perl", "./Tools/Scripts/run-webkit-tests", "--no-new-test-results", "--debug-rwt-logging", "--no-sample-on-timeout", "--results-directory", "layout-test-results", "--builder-name", WithProperties("%(buildername)s"), WithProperties("--%(configuration)s")] > > Is there anything else I should remove? You probably want to add --no-show-results back in to replace --no-launch-safari. Otherwise, this should be all you need. 789790 7 ossy 2012-12-12 12:15:15 -0800 yes, I noticed I missed to add --no-show-results first. But I managed to do it for the second update. :) 789935 8 dpranke 2012-12-12 14:41:03 -0800 Committed r137517: <http://trac.webkit.org/changeset/137517> 178081 2012-12-06 14:17:37 -0800 2012-12-06 15:25:10 -0800 Patch bug-104301-20121206141507.patch text/plain 3660 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjVjZTQ3OWVkMGFlMGQ4MzU5OGY3NDRlYmEyZGMxYmRl N2FlYzZiOC4uMzA3Y2VmMDgxMmZkYWZlZTI0ZDJiZDIwYTY5MDRhYzhlNzc5M2FkMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIy IEBACiAyMDEyLTEyLTA2ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG5yd3Q6IHJlbW92ZSBkZXByZWNhdGVkIE9SV1QgY29tcGF0aWJpbGl0eSBjb21tYW5k IGxpbmUgZmxhZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNDMwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSBjb21tYW5kIGxpbmUgZmxhZ3MgZm9yIC0tbm9zaG93LXJlc3VsdHMsIC0tW25vLV1s YXVuY2gtc2FmYXJpLAorICAgICAgICBhbmQgLS11c2UtcmVtb3RlLWxpbmtzLXRvLXRlc3RzIHdl cmUgZm9yIGNvbXBhdGliaWxpdHkgd2l0aAorICAgICAgICBvbGQtcnVuLXdlYmtpdC10ZXN0cywg YnV0IHRoZSBjb21wYXRpYmlsaXR5IGlzIG5vdCBuZWVkZWQgYW55IG1vcmUKKyAgICAgICAgc2lu Y2UgTlJXVCBpcyBiYXNpY2FsbHkgZGVmYXVsdCBhbmQgdGhlIHNjcmlwdHMgdGhhdCBwYXNzZWQg dGhlCisgICAgICAgIG9sZCBmbGFncyBoYXZlIGJlZW4gdXBkYXRlZC4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisgICAgICAg IChfc2V0X3VwX2Rlcml2ZWRfb3B0aW9ucyk6CisgICAgICAgIChwYXJzZV9hcmdzKToKKworMjAx Mi0xMi0wNiAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAgICAgICBi dWlsZGJvdDogY2hhbmdlIHJ1bi13ZWJraXQtdGVzdHMgLS1uby1sYXVuY2gtc2FmYXJpIHRvIC0t bm8tc2hvdy1yZXN1bHRzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDQyOTkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKaW5kZXggMzlmNmYyYTIxMWFjNTI0Yzk5ODk5 MDJmMDJjYjBkNTc2NmJjYzdjZS4uYjY4MTIzMGYyOWI0ZGY3MzkyNGU1MTM3ZDc3Zjg1YjQ5MmU0 MmI2YiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVu X3dlYmtpdF90ZXN0cy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9ydW5fd2Via2l0X3Rlc3RzLnB5CkBAIC0xNTksMjEgKzE1OSw3IEBAIGRlZiBfc2V0X3VwX2Rl cml2ZWRfb3B0aW9ucyhwb3J0LCBvcHRpb25zKToKICAgICAgICAgb3B0aW9ucy52ZXJib3NlID0g VHJ1ZQogCiAKLWRlZiBfY29tcGF0X3NoaW1fY2FsbGJhY2sob3B0aW9uLCBvcHRfc3RyLCB2YWx1 ZSwgcGFyc2VyKTogICMgaWdub3JlIHVudXNlZCB2YXJpYWJsZSB3YXJuaW5nIC0gcHlsaW50OiBk aXNhYmxlLW1zZz1XMDYxMwotICAgIHByaW50ICJJZ25vcmluZyB1bnN1cHBvcnRlZCBvcHRpb246 ICVzIiAlIG9wdF9zdHIKLQotCi1kZWYgX2NvbXBhdF9zaGltX29wdGlvbihvcHRpb25fbmFtZSwg Kiprd2FyZ3MpOgotICAgIHJldHVybiBvcHRwYXJzZS5tYWtlX29wdGlvbihvcHRpb25fbmFtZSwg YWN0aW9uPSJjYWxsYmFjayIsCi0gICAgICAgIGNhbGxiYWNrPV9jb21wYXRfc2hpbV9jYWxsYmFj aywKLSAgICAgICAgaGVscD0iSWdub3JlZCwgZm9yIG9sZC1ydW4td2Via2l0LXRlc3RzIGNvbXBh dCBvbmx5LiIsICoqa3dhcmdzKQotCi0KIGRlZiBwYXJzZV9hcmdzKGFyZ3M9Tm9uZSk6Ci0gICAg IiIiUHJvdmlkZXMgYSBkZWZhdWx0IHNldCBvZiBjb21tYW5kIGxpbmUgYXJncy4KLQotICAgIFJl dHVybnMgYSB0dXBsZSBvZiBvcHRpb25zLCBhcmdzIGZyb20gb3B0cGFyc2UiIiIKLQogICAgIG9w dGlvbl9ncm91cF9kZWZpbml0aW9ucyA9IFtdCiAKICAgICBvcHRpb25fZ3JvdXBfZGVmaW5pdGlv bnMuYXBwZW5kKCgiUGxhdGZvcm0gb3B0aW9ucyIsIHBsYXRmb3JtX29wdGlvbnMoKSkpCkBAIC0y MTMsMTIgKzE5OSw2IEBAIGRlZiBwYXJzZV9hcmdzKGFyZ3M9Tm9uZSk6CiAgICAgICAgICAgICBo ZWxwPSJQYXRoIHRvIGEgZGlyZWN0b3J5IGNvbnRhaW5pbmcgdGhlIGV4ZWN1dGFibGVzIG5lZWRl ZCB0byBydW4gdGVzdHMuIiksCiAgICAgXSkpCiAKLSAgICBvcHRpb25fZ3JvdXBfZGVmaW5pdGlv bnMuYXBwZW5kKCgiT1JXVCBDb21wYXRpYmlsaXR5IE9wdGlvbnMiLCBbCi0gICAgICAgICMgRklY TUU6IFJlbW92ZSB0aGlzIG9wdGlvbiBvbmNlIHRoZSBib3RzIGRvbid0IHJlZmVyIHRvIGl0Lgot ICAgICAgICAjIHJlc3VsdHMuaHRtbCBpcyBzbWFydCBlbm91Z2ggdG8gZmlndXJlIHRoaXMgb3V0 IGl0c2VsZi4KLSAgICAgICAgX2NvbXBhdF9zaGltX29wdGlvbigiLS11c2UtcmVtb3RlLWxpbmtz LXRvLXRlc3RzIiksCi0gICAgXSkpCi0KICAgICBvcHRpb25fZ3JvdXBfZGVmaW5pdGlvbnMuYXBw ZW5kKCgiUmVzdWx0cyBPcHRpb25zIiwgWwogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigi LXAiLCAiLS1waXhlbC10ZXN0cyIsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsCiAgICAgICAgICAgICBk ZXN0PSJwaXhlbF90ZXN0cyIsIGhlbHA9IkVuYWJsZSBwaXhlbC10by1waXhlbCBQTkcgY29tcGFy aXNvbnMiKSwKQEAgLTI3OCwxMCArMjU4LDYgQEAgZGVmIHBhcnNlX2FyZ3MoYXJncz1Ob25lKToK ICAgICAgICAgICAgIGRlZmF1bHQ9VHJ1ZSwgZGVzdD0ic2hvd19yZXN1bHRzIiwKICAgICAgICAg ICAgIGhlbHA9IkRvbid0IGxhdW5jaCBhIGJyb3dzZXIgd2l0aCByZXN1bHRzIGFmdGVyIHRoZSB0 ZXN0cyAiCiAgICAgICAgICAgICAgICAgICJhcmUgZG9uZSIpLAotICAgICAgICAjIEZJWE1FOiBX ZSBzaG91bGQgaGF2ZSBhIGhlbHBlciBmdW5jdGlvbiB0byBkbyB0aGlzIHNvcnQgb2YKLSAgICAg ICAgIyBkZXByZWN0YXRlZCBtYXBwaW5nIGFuZCBhdXRvbWF0aWNhbGx5IGxvZywgZXRjLgotICAg ICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1ub3Nob3ctcmVzdWx0cyIsIGFjdGlvbj0ic3Rv cmVfZmFsc2UiLCBkZXN0PSJzaG93X3Jlc3VsdHMiLCBoZWxwPSJEZXByZWNhdGVkLCBzYW1lIGFz IC0tbm8tc2hvdy1yZXN1bHRzLiIpLAotICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1u by1sYXVuY2gtc2FmYXJpIiwgYWN0aW9uPSJzdG9yZV9mYWxzZSIsIGRlc3Q9InNob3dfcmVzdWx0 cyIsIGhlbHA9IkRlcHJlY2F0ZWQsIHNhbWUgYXMgLS1uby1zaG93LXJlc3VsdHMuIiksCiAgICAg ICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWZ1bGwtcmVzdWx0cy1odG1sIiwgYWN0aW9uPSJz dG9yZV90cnVlIiwKICAgICAgICAgICAgIGRlZmF1bHQ9RmFsc2UsCiAgICAgICAgICAgICBoZWxw PSJTaG93IGFsbCBmYWlsdXJlcyBpbiByZXN1bHRzLmh0bWwsIHJhdGhlciB0aGFuIG9ubHkgcmVn cmVzc2lvbnMiKSwK