104296 2012-12-06 14:01:12 -0800 new-run-webkit-tests --lint-test-files seems to be broken 2012-12-10 11:31:51 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 senorblanco dpranke abarth dpranke eric ojan ossy rniwa webkit.review.bot oldest_to_newest 785233 0 senorblanco 2012-12-06 14:01:12 -0800 new-run-webkit-tests --lint-test-files is giving this on Linux: No handlers could be found for logger "__main__" It doesn't seem to do the lint check, either. 785290 1 178085 dpranke 2012-12-06 14:39:37 -0800 Created attachment 178085 Patch 785293 2 dpranke 2012-12-06 14:41:35 -0800 landing this unreviewed since the lint build step is borked ... 785298 3 dpranke 2012-12-06 14:46:34 -0800 Committed r136896: <http://trac.webkit.org/changeset/136896> 785690 4 ossy 2012-12-07 00:08:02 -0800 (In reply to comment #3) > Committed r136896: <http://trac.webkit.org/changeset/136896> It broke --debug-rwt option and made the output on the bots non-verbose. :( I put back the removed line - https://trac.webkit.org/changeset/136929 It would be great if you would be more careful in the future if you modify common codes and prefer rolling out buggy changes instead of buggy unreviewed quick fixes and causing more problem. 785915 5 dpranke 2012-12-07 09:05:58 -0800 (In reply to comment #4) > (In reply to comment #3) > > Committed r136896: <http://trac.webkit.org/changeset/136896> > > It broke --debug-rwt option and made the output on the bots non-verbose. :( > I put back the removed line - https://trac.webkit.org/changeset/136929 > > It would be great if you would be more careful in the future if you > modify common codes and prefer rolling out buggy changes instead > of buggy unreviewed quick fixes and causing more problem. Argh, you're right, sorry! The reason I didn't roll out the buggy change was because there was about six changes stacked on top of each other, and figuring out which ones needed to be rolled out, in which order, would have been non-trivial. Still probably not a great excuse, though. I will try to do better in the future. 178085 2012-12-06 14:39:37 -0800 2012-12-10 11:31:51 -0800 Patch bug-104296-20121206143708.patch text/plain 6729 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzZiNTI2N2UyMzJmNWU2NWM2Yzg5OWZjNzM4ZTUxYzFj YWY4YTRmNS4uMzgwOWQ3OTRmMzIxYTMyNThiZmU0ZDdiMThlMGI5ZmNmNjI4OTRiMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEyLTEyLTA2ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3RzIC0tbGludC10ZXN0LWZpbGVzIHNlZW1zIHRvIGJl IGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA0Mjk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TXkgcmVjZW50IHJlZmFjdG9yaW5nIGNhdXNlZCBtZSB0byBub3QgaW5pdGlhbGl6ZSB0aGUgcHJp bnRlcgorICAgICAgICBiZWZvcmUgY2FsbGluZyBsaW50KCk7IHRoaXMgcGF0Y2ggcmVzdHJ1Y3R1 cmVzIHRoZSBjb2RlIHRvIG1ha2UKKyAgICAgICAgdGhlIGxpbnQgcm91dGluZSBzZWxmLWNvbnRh aW5lZCBhbmQgZG8gYWxsIHRoZSB3b3JrIG5lY2Vzc2FyeS4KKyAgICAgICAgVGhpcyB3aWxsIGFs c28gbWFrZSBpdCBlYXNpZXIgdG8gbW92ZSB0aGlzIGNvZGUgb3V0IGludG8gYSBzdGFuZGFsb25l CisgICAgICAgIGZpbGUuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9ydW5fd2Via2l0X3Rlc3RzLnB5OgorICAgICAgICAobGludCk6CisgICAgICAgIChtYWluKToK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3Rz X2ludGVncmF0aW9udGVzdC5weToKKyAgICAgICAgKExpbnRUZXN0LnRlc3RfYWxsX2NvbmZpZ3Vy YXRpb25zKToKKyAgICAgICAgKExpbnRUZXN0LnRlc3RfbGludF90ZXN0X2ZpbGVzKToKKyAgICAg ICAgKExpbnRUZXN0LnRlc3RfbGludF90ZXN0X2ZpbGVzX19lcnJvcnMpOgorCiAyMDEyLTEyLTA2 ICBNYXggVnVqb3ZpYyAgPG12dWpvdmljQGFkb2JlLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk LiBBZGQgbXlzZWxmIHRvIGNvbW1pdHRlcnMucHkuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCAzOWY2ZjJh MjExYWM1MjRjOTk4OTkwMmYwMmNiMGQ1NzY2YmNjN2NlLi4zZThlNWI0MWMwMmU4ODM2YmZjYzg1 NzAyMzE4MDMyMjVhMWFiZjM0IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAgLTU0LDggKzU0LDExIEBAIElO VEVSUlVQVEVEX0VYSVRfU1RBVFVTID0gc2lnbmFsLlNJR0lOVCArIDEyOAogRVhDRVBUSU9OQUxf RVhJVF9TVEFUVVMgPSAyNTQKIAogCi1kZWYgbGludChwb3J0LCBvcHRpb25zKToKK2RlZiBsaW50 KHBvcnQsIG9wdGlvbnMsIGxvZ2dpbmdfc3RyZWFtKToKICAgICBob3N0ID0gcG9ydC5ob3N0Cisg ICAgbG9nZ2luZy5nZXRMb2dnZXIoKS5zZXRMZXZlbChsb2dnaW5nLkRFQlVHIGlmIG9wdGlvbnMu ZGVidWdfcnd0X2xvZ2dpbmcgZWxzZSBsb2dnaW5nLklORk8pCisgICAgcHJpbnRlciA9IHByaW50 aW5nLlByaW50ZXIocG9ydCwgb3B0aW9ucywgbG9nZ2luZ19zdHJlYW0sIGxvZ2dlcj1sb2dnaW5n LmdldExvZ2dlcigpKQorCiAgICAgaWYgb3B0aW9ucy5wbGF0Zm9ybToKICAgICAgICAgcG9ydHNf dG9fbGludCA9IFtwb3J0XQogICAgIGVsc2U6CkBAIC04Miw4ICs4NSwxMCBAQCBkZWYgbGludChw b3J0LCBvcHRpb25zKToKIAogICAgIGlmIGxpbnRfZmFpbGVkOgogICAgICAgICBfbG9nLmVycm9y KCdMaW50IGZhaWxlZC4nKQorICAgICAgICBwcmludGVyLmNsZWFudXAoKQogICAgICAgICByZXR1 cm4gLTEKICAgICBfbG9nLmluZm8oJ0xpbnQgc3VjY2VlZGVkLicpCisgICAgcHJpbnRlci5jbGVh bnVwKCkKICAgICByZXR1cm4gMAogCiAKQEAgLTQxNSwxMSArNDIwLDEwIEBAIGRlZiBtYWluKGFy Z3Y9Tm9uZSwgc3Rkb3V0PXN5cy5zdGRvdXQsIHN0ZGVycj1zeXMuc3RkZXJyKToKICAgICAgICAg cHJpbnQgPj4gc3RkZXJyLCBzdHIoZSkKICAgICAgICAgcmV0dXJuIEVYQ0VQVElPTkFMX0VYSVRf U1RBVFVTCiAKLSAgICBsb2dnaW5nLmdldExvZ2dlcigpLnNldExldmVsKGxvZ2dpbmcuREVCVUcg aWYgb3B0aW9ucy5kZWJ1Z19yd3RfbG9nZ2luZyBlbHNlIGxvZ2dpbmcuSU5GTykKLSAgICB0cnk6 Ci0gICAgICAgIGlmIG9wdGlvbnMubGludF90ZXN0X2ZpbGVzOgotICAgICAgICAgICAgcmV0dXJu IGxpbnQocG9ydCwgb3B0aW9ucykKKyAgICBpZiBvcHRpb25zLmxpbnRfdGVzdF9maWxlczoKKyAg ICAgICAgcmV0dXJuIGxpbnQocG9ydCwgb3B0aW9ucywgc3RkZXJyKQogCisgICAgdHJ5OgogICAg ICAgICBydW5fZGV0YWlscyA9IHJ1bihwb3J0LCBvcHRpb25zLCBhcmdzLCBzdGRlcnIpCiAKICAg ICAgICAgYm90X3ByaW50ZXIgPSBidWlsZGJvdF9yZXN1bHRzLkJ1aWxkQm90UHJpbnRlcihzdGRv dXQsIG9wdGlvbnMuZGVidWdfcnd0X2xvZ2dpbmcpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX2ludGVncmF0aW9udGVzdC5w eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNf aW50ZWdyYXRpb250ZXN0LnB5CmluZGV4IGNkMTZjMzI2ZjQxOGZlMWRkMTBlNTQ3YTcyMTk4OWEy OTA0OWRlNWMuLjJhNDkzZmZlMzY2NDY2NTNhZDVjNmNmZDNhMjZkMWYzMTEwNWQyMTggMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVz dHNfaW50ZWdyYXRpb250ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5CkBAIC0yMjUsNTcgKzIy NSw0MyBAQCBjbGFzcyBMaW50VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSwgU3RyZWFtVGVzdGluZ01p eGluKToKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRmFr ZVBvcnQoaG9zdCwgJ2InLCAncGF0aC10by1iJyksCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIEZha2VQb3J0KGhvc3QsICdiLXdpbicsICdwYXRoLXRvLWIn KSkpCiAKLSAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChydW5fd2Via2l0X3Rlc3RzLmxpbnQoaG9z dC5wb3J0X2ZhY3RvcnkucG9ydHNbJ2EnXSwgTW9ja09wdGlvbnMocGxhdGZvcm09Tm9uZSkpLCAw KQorICAgICAgICBsb2dnaW5nX3N0cmVhbSA9IFN0cmluZ0lPLlN0cmluZ0lPKCkKKyAgICAgICAg c2VsZi5hc3NlcnRFcXVhbChydW5fd2Via2l0X3Rlc3RzLmxpbnQoaG9zdC5wb3J0X2ZhY3Rvcnku cG9ydHNbJ2EnXSwgTW9ja09wdGlvbnMocGxhdGZvcm09Tm9uZSwgZGVidWdfcnd0X2xvZ2dpbmc9 RmFsc2UpLCBsb2dnaW5nX3N0cmVhbSksIDApCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoaG9z dC5wb3J0c19wYXJzZWQsIFsnYScsICdiJywgJ2Itd2luJ10pCiAKICAgICAgICAgaG9zdC5wb3J0 c19wYXJzZWQgPSBbXQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHJ1bl93ZWJraXRfdGVzdHMu bGludChob3N0LnBvcnRfZmFjdG9yeS5wb3J0c1snYSddLCBNb2NrT3B0aW9ucyhwbGF0Zm9ybT0n YScpKSwgMCkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChydW5fd2Via2l0X3Rlc3RzLmxpbnQo aG9zdC5wb3J0X2ZhY3RvcnkucG9ydHNbJ2EnXSwgTW9ja09wdGlvbnMocGxhdGZvcm09J2EnLCBk ZWJ1Z19yd3RfbG9nZ2luZz1GYWxzZSksIGxvZ2dpbmdfc3RyZWFtKSwgMCkKICAgICAgICAgc2Vs Zi5hc3NlcnRFcXVhbChob3N0LnBvcnRzX3BhcnNlZCwgWydhJ10pCiAKICAgICBkZWYgdGVzdF9s aW50X3Rlc3RfZmlsZXMoc2VsZik6Ci0gICAgICAgIG9jID0gb3V0cHV0Y2FwdHVyZS5PdXRwdXRD YXB0dXJlKCkKLSAgICAgICAgb2MuY2FwdHVyZV9vdXRwdXQoKQotICAgICAgICB0cnk6Ci0gICAg ICAgICAgICByZXMgPSBydW5fd2Via2l0X3Rlc3RzLm1haW4oWyctLXBsYXRmb3JtJywgJ3Rlc3Qn LCAnLS1saW50LXRlc3QtZmlsZXMnXSkKLSAgICAgICAgZmluYWxseToKLSAgICAgICAgICAgIG91 dCwgZXJyLCBsb2dzID0gb2MucmVzdG9yZV9vdXRwdXQoKQotCisgICAgICAgIGxvZ2dpbmdfc3Ry ZWFtID0gU3RyaW5nSU8uU3RyaW5nSU8oKQorICAgICAgICBvcHRpb25zLCBfID0gcGFyc2VfYXJn cyhbJy0tcGxhdGZvcm0nLCAndGVzdCcsICctLWxpbnQtdGVzdC1maWxlcyddKQorICAgICAgICBo b3N0ID0gTW9ja0hvc3QoKQorICAgICAgICBwb3J0X29iaiA9IGhvc3QucG9ydF9mYWN0b3J5Lmdl dChvcHRpb25zLnBsYXRmb3JtLCBvcHRpb25zPW9wdGlvbnMpCisgICAgICAgIHJlcyA9IHJ1bl93 ZWJraXRfdGVzdHMubGludChwb3J0X29iaiwgb3B0aW9ucywgbG9nZ2luZ19zdHJlYW0pCiAgICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWwocmVzLCAwKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKG91 dCwgJycpCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoZXJyLCAnJykKLSAgICAgICAgc2VsZi5h c3NlcnRUcnVlKCdMaW50IHN1Y2NlZWRlZCcgaW4gbG9ncykKKyAgICAgICAgc2VsZi5hc3NlcnRU cnVlKCdMaW50IHN1Y2NlZWRlZCcgaW4gbG9nZ2luZ19zdHJlYW0uZ2V0dmFsdWUoKSkKIAogICAg IGRlZiB0ZXN0X2xpbnRfdGVzdF9maWxlc19fZXJyb3JzKHNlbGYpOgotICAgICAgICBvcHRpb25z LCBwYXJzZWRfYXJncyA9IHBhcnNlX2FyZ3MoWyctLXBsYXRmb3JtJywgJ3Rlc3QnLCAnLS1saW50 LXRlc3QtZmlsZXMnXSkKKyAgICAgICAgb3B0aW9ucywgXyA9IHBhcnNlX2FyZ3MoWyctLXBsYXRm b3JtJywgJ3Rlc3QnLCAnLS1saW50LXRlc3QtZmlsZXMnXSkKICAgICAgICAgaG9zdCA9IE1vY2tI b3N0KCkKICAgICAgICAgcG9ydF9vYmogPSBob3N0LnBvcnRfZmFjdG9yeS5nZXQob3B0aW9ucy5w bGF0Zm9ybSwgb3B0aW9ucz1vcHRpb25zKQogICAgICAgICBwb3J0X29iai5leHBlY3RhdGlvbnNf ZGljdCA9IGxhbWJkYTogeycnOiAnLS0gc3ludGF4IGVycm9yJ30KIAotICAgICAgICBvYyA9IG91 dHB1dGNhcHR1cmUuT3V0cHV0Q2FwdHVyZSgpCi0gICAgICAgIG9jLmNhcHR1cmVfb3V0cHV0KCkK LSAgICAgICAgdHJ5OgotICAgICAgICAgICAgcmVzID0gcnVuX3dlYmtpdF90ZXN0cy5saW50KHBv cnRfb2JqLCBvcHRpb25zKQotICAgICAgICBmaW5hbGx5OgotICAgICAgICAgICAgb3V0LCBlcnIs IGxvZ3MgPSBvYy5yZXN0b3JlX291dHB1dCgpCisgICAgICAgIGxvZ2dpbmdfc3RyZWFtID0gU3Ry aW5nSU8uU3RyaW5nSU8oKQorICAgICAgICByZXMgPSBydW5fd2Via2l0X3Rlc3RzLmxpbnQocG9y dF9vYmosIG9wdGlvbnMsIGxvZ2dpbmdfc3RyZWFtKQogCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWwocmVzLCAtMSkKLSAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChvdXQsICcnKQotICAgICAgICBz ZWxmLmFzc2VydEVxdWFsKGVyciwgJycpCi0gICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZSgnTGludCBm YWlsZWQnIGluIGxvZ3MpCisgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZSgnTGludCBmYWlsZWQnIGlu IGxvZ2dpbmdfc3RyZWFtLmdldHZhbHVlKCkpCiAKICAgICAgICAgIyBlbnN1cmUgd2UgbGludCAq YWxsKiBvZiB0aGUgZmlsZXMgaW4gdGhlIGNhc2NhZGUuCiAgICAgICAgIHBvcnRfb2JqLmV4cGVj dGF0aW9uc19kaWN0ID0gbGFtYmRhOiB7J2Zvbyc6ICctLSBzeW50YXggZXJyb3IxJywgJ2Jhcic6 ICctLSBzeW50YXggZXJyb3IyJ30KLSAgICAgICAgb2MuY2FwdHVyZV9vdXRwdXQoKQotICAgICAg ICB0cnk6Ci0gICAgICAgICAgICByZXMgPSBydW5fd2Via2l0X3Rlc3RzLmxpbnQocG9ydF9vYmos IG9wdGlvbnMpCi0gICAgICAgIGZpbmFsbHk6Ci0gICAgICAgICAgICBvdXQsIGVyciwgbG9ncyA9 IG9jLnJlc3RvcmVfb3V0cHV0KCkKKyAgICAgICAgbG9nZ2luZ19zdHJlYW0gPSBTdHJpbmdJTy5T dHJpbmdJTygpCisgICAgICAgIHJlcyA9IHJ1bl93ZWJraXRfdGVzdHMubGludChwb3J0X29iaiwg b3B0aW9ucywgbG9nZ2luZ19zdHJlYW0pCiAKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChyZXMs IC0xKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKG91dCwgJycpCi0gICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWwoZXJyLCAnJykKLSAgICAgICAgc2VsZi5hc3NlcnRUcnVlKCdmb286MScgaW4gbG9n cykKLSAgICAgICAgc2VsZi5hc3NlcnRUcnVlKCdiYXI6MScgaW4gbG9ncykKKyAgICAgICAgc2Vs Zi5hc3NlcnRUcnVlKCdmb286MScgaW4gbG9nZ2luZ19zdHJlYW0uZ2V0dmFsdWUoKSkKKyAgICAg ICAgc2VsZi5hc3NlcnRUcnVlKCdiYXI6MScgaW4gbG9nZ2luZ19zdHJlYW0uZ2V0dmFsdWUoKSkK IAogCiBjbGFzcyBNYWluVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSwgU3RyZWFtVGVzdGluZ01peGlu KToK