104287 2012-12-06 12:29:12 -0800 [CMake] Consolidate list of files to build for JavaScriptCore 2012-12-06 18:18:14 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned gyuyoung.kim mxie paroga rakuco webkit.review.bot oldest_to_newest 785149 0 laszlo.gombos 2012-12-06 12:29:12 -0800 It seems to me that we can consolidate the list of files to build in the CMake build system and move some some of the files from PlatformXXX.cmake to CMakeLists.txt. 785150 1 178060 laszlo.gombos 2012-12-06 12:34:22 -0800 Created attachment 178060 proposed patch My preference would be to move jit/ExecutableAllocatorFixedVMPool.cpp to the common list as well as the cpp file itself is guarded already with the appropriate build flags to enable sharing the list of files in the build system. Any feedback on this would be much appreciated. 785152 2 178060 laszlo.gombos 2012-12-06 12:34:45 -0800 Comment on attachment 178060 proposed patch wrong patch, sorry 785153 3 178061 laszlo.gombos 2012-12-06 12:35:33 -0800 Created attachment 178061 proposed patch 785497 4 178061 gyuyoung.kim 2012-12-06 18:02:14 -0800 Comment on attachment 178061 proposed patch r=me 785509 5 178061 webkit.review.bot 2012-12-06 18:18:10 -0800 Comment on attachment 178061 proposed patch Clearing flags on attachment: 178061 Committed r136914: <http://trac.webkit.org/changeset/136914> 785510 6 webkit.review.bot 2012-12-06 18:18:14 -0800 All reviewed patches have been landed. Closing bug. 178060 2012-12-06 12:34:22 -0800 2012-12-06 12:34:44 -0800 proposed patch 102827.patch text/plain 1541 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzNjg0 MykKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEy LTA2ICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VG TF0gT3B0aW1pemUgYmluYXJ5IHNpemUgYnkgcmVtb3ZpbmcgZGVhZCBzZWN0aW9ucyBvbiB1bml4 L2djYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAy ODI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisK KyAgICAgICAgVHVybiBvbiAtZmZ1bmN0aW9uLXNlY3Rpb25zIC1mZGF0YS1zZWN0aW9ucyAtLWdj LXNlY3Rpb24gZmxhZ3MKKyAgICAgICAgb24gdW5peCBmb3IgdGhlIGdjYyB0b29sY2hhaW4gZm9y IHJlbGVhc2UgYnVpbGRzIHRvIG9wdGltaXplIGJpbmFyeQorICAgICAgICBzaXplIGZvciB0aGUg RWZsIHBvcnQuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZToKKwog MjAxMi0xMi0wNiAgU2Vva2p1IEt3b24gIDxzZW9ranUua3dvbkBnbWFpbC5jb20+CiAKICAgICAg ICAgW0VGTF0gRml4IGRlc3RpbmF0aW9uIHBhdGggaW4gU291cmNlL1BsYXRmb3JtRWZsLmNtYWtl CkluZGV4OiBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQkocmV2aXNpb24gMTM2ODQzKQorKysgU291cmNlL2Nt YWtlL09wdGlvbnNFZmwuY21ha2UJKHdvcmtpbmcgY29weSkKQEAgLTE3Nyw2ICsxNzcsMTMgQEAg ZW5kaWYgKCkKIAogc2V0KENQQUNLX1NPVVJDRV9HRU5FUkFUT1IgVEJaMikKIAorIyBPcHRpbWl6 ZSBiaW5hcnkgc2l6ZSBmb3IgcmVsZWFzZSBidWlsZHMgYnkgcmVtb3ZpbmcgZGVhZCBzZWN0aW9u cyBvbiB1bml4L2djYworaWYgKENNQUtFX0JVSUxEX1RZUEUgU1RSRVFVQUwgUmVsZWFzZSBBTkQg Q01BS0VfQ09NUElMRVJfSVNfR05VQ0MgQU5EIFVOSVggQU5EIE5PVCBBUFBMRSkKKyAgICBzZXQo Q01BS0VfQ19GTEFHUyAiLWZmdW5jdGlvbi1zZWN0aW9ucyAtZmRhdGEtc2VjdGlvbnMgJHtDTUFL RV9DX0ZMQUdTfSIpCisgICAgc2V0KENNQUtFX0NYWF9GTEFHUyAiLWZmdW5jdGlvbi1zZWN0aW9u cyAtZmRhdGEtc2VjdGlvbnMgJHtDTUFLRV9DWFhfRkxBR1N9IikKKyAgICBzZXQoQ01BS0VfU0hB UkVEX0xJTktFUl9GTEFHUyAiLVdsLC0tZ2Mtc2VjdGlvbnMgJHtDTUFLRV9TSEFSRURfTElOS0VS X0ZMQUdTfSIpCitlbmRpZiAoKQorCiBpZiAoV1RGX1VTRV9USUxFRF9CQUNLSU5HX1NUT1JFKQog ICAgIGFkZF9kZWZpbml0aW9ucygtRFdURl9VU0VfQUNDRUxFUkFURURfQ09NUE9TSVRJTkc9MSkK IAo= 178061 2012-12-06 12:35:33 -0800 2012-12-06 18:18:10 -0800 proposed patch 104287.patch text/plain 2738 laszlo.gombos SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM2ODcyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTEyLTA2ICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CisKKyAg ICAgICAgW0NNYWtlXSBDb25zb2xpZGF0ZSBsaXN0IG9mIGZpbGVzIHRvIGJ1aWxkIGZvciBKYXZh U2NyaXB0Q29yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA0Mjg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIE1lbW9yeVN0YXRpc3RpY3MuY3BwIGFuZCBFeGVjdXRhYmxlQWxsb2NhdG9yLmNwcCB0 byB0aGUgY29tbW9uCisgICAgICAgIGxpc3Qgb2YgZmlsZXMgYW5kIHJlbW92ZSB0aGVtIGZyb20g dGhlIHBvcnQgc3BlY2lmaWMgbGlzdHMuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKyAg ICAgICAgKiBQbGF0Zm9ybUJsYWNrQmVycnkuY21ha2U6CisgICAgICAgICogUGxhdGZvcm1FZmwu Y21ha2U6CisgICAgICAgICogUGxhdGZvcm1XaW5DRS5jbWFrZToKKwogMjAxMi0xMi0wNiAgT2xp dmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeCwgbGFzdCBw YXRjaCByb2xsZWQgb3V0IGxvZ2ljIHRoYXQgaXMgbm93IG5lZWRlZCBvbiBUb1QuCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CShyZXZpc2lvbiAxMzY4NDMpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTI1NCw2 ICsyNTQsNyBAQCBzZXQoSmF2YVNjcmlwdENvcmVfU09VUkNFUwogICAgIHJ1bnRpbWUvTGl0ZXJh bFBhcnNlci5jcHAKICAgICBydW50aW1lL0xvb2t1cC5jcHAKICAgICBydW50aW1lL01hdGhPYmpl Y3QuY3BwCisgICAgcnVudGltZS9NZW1vcnlTdGF0aXN0aWNzLmNwcAogICAgIHJ1bnRpbWUvTmFt ZUNvbnN0cnVjdG9yLmNwcAogICAgIHJ1bnRpbWUvTmFtZUNvbnN0cnVjdG9yLmgKICAgICBydW50 aW1lL05hbWVJbnN0YW5jZS5jcHAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9QbGF0Zm9y bUJsYWNrQmVycnkuY21ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL1Bs YXRmb3JtQmxhY2tCZXJyeS5jbWFrZQkocmV2aXNpb24gMTM2ODQzKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL1BsYXRmb3JtQmxhY2tCZXJyeS5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtOCw3 ICs4LDYgQEAgbGlzdChSRU1PVkVfSVRFTSBKYXZhU2NyaXB0Q29yZV9TT1VSQ0VTCiAKIGxpc3Qo QVBQRU5EIEphdmFTY3JpcHRDb3JlX1NPVVJDRVMKICAgICBydW50aW1lL0dDQWN0aXZpdHlDYWxs YmFja0JsYWNrQmVycnkuY3BwCi0gICAgcnVudGltZS9NZW1vcnlTdGF0aXN0aWNzLmNwcAogKQog CiBpbnN0YWxsKEZJTEVTICJ3dGYvRm9yd2FyZC5oIiBERVNUSU5BVElPTiB1c3IvaW5jbHVkZS9i cm93c2VyL3dlYmtpdC93dGYpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1F ZmwuY21ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3JtRWZs LmNtYWtlCShyZXZpc2lvbiAxMzY4NDMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZv cm1FZmwuY21ha2UJKHdvcmtpbmcgY29weSkKQEAgLTEsOCArMSw1IEBACiBsaXN0KEFQUEVORCBK YXZhU2NyaXB0Q29yZV9TT1VSQ0VTCiAgICAgaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZN UG9vbC5jcHAKLSAgICBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5jcHAKLQotICAgIHJ1bnRpbWUv TWVtb3J5U3RhdGlzdGljcy5jcHAKICkKIAogbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfTElC UkFSSUVTCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1XaW5DRS5jbWFrZQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1XaW5DRS5jbWFrZQko cmV2aXNpb24gMTM2ODQzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3JtV2luQ0Uu Y21ha2UJKHdvcmtpbmcgY29weSkKQEAgLTEsNyArMSwzIEBACi1saXN0KEFQUEVORCBKYXZhU2Ny aXB0Q29yZV9TT1VSQ0VTCi0gICAgaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuY3BwCi0pCi0KIGlm IChFTkFCTEVfSklUIEFORCBXVEZfQ1BVX0FSTSkKICAgICBhZGRfY3VzdG9tX2NvbW1hbmQoCiAg ICAgICAgIE9VVFBVVCAke0RFUklWRURfU09VUkNFU19ESVJ9L0dlbmVyYXRlZEpJVFN0dWJzLmFz bQo=