104271 2012-12-06 09:49:57 -0800 [EFL] [AC]Implement ImageExtractor::extractImage in GraphicsContext3DEfl 2012-12-07 02:51:02 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 102991 1 kalyan.kondapally kalyan.kondapally dino kenneth lucas.de.marchi webkit.review.bot oldest_to_newest 784990 0 kalyan.kondapally 2012-12-06 09:49:57 -0800 Each platform must provide an implementation of this method. 785079 1 178042 kalyan.kondapally 2012-12-06 11:27:48 -0800 Created attachment 178042 patch 785151 2 178042 kenneth 2012-12-06 12:34:40 -0800 Comment on attachment 178042 patch View in context: https://bugs.webkit.org/attachment.cgi?id=178042&action=review > Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:248 > + if (m_decoder) > + delete m_decoder; no, just delete m_decoder! this si c++ > Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:253 > + // This implementation is taken from GraphicsContext3DCairo dot at end > Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:311 > + return true; > + > } one newline too much. Also add newline before return 785239 3 178076 kalyan.kondapally 2012-12-06 14:02:50 -0800 Created attachment 178076 review fixes 785414 4 178076 kenneth 2012-12-06 16:48:24 -0800 Comment on attachment 178076 review fixes View in context: https://bugs.webkit.org/attachment.cgi?id=178076&action=review > Source/WebCore/ChangeLog:10 > + Covered by exisiting tests. spelling 785634 5 178159 kalyan.kondapally 2012-12-06 22:00:06 -0800 Created attachment 178159 review fixes 785776 6 178159 webkit.review.bot 2012-12-07 02:50:58 -0800 Comment on attachment 178159 review fixes Clearing flags on attachment: 178159 Committed r136942: <http://trac.webkit.org/changeset/136942> 785777 7 webkit.review.bot 2012-12-07 02:51:02 -0800 All reviewed patches have been landed. Closing bug. 178042 2012-12-06 11:27:48 -0800 2012-12-06 14:02:50 -0800 patch 104271impl.patch text/plain 4028 kalyan.kondapally ZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDdmN2M1OTUuLmQxYjRhZGEgMTAwNjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTEyLTA2ICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4K KworICAgICAgICBbRUZMXSBbQUNdIEltcGxlbWVudCBJbWFnZUV4dHJhY3Rvcjo6ZXh0cmFjdElt YWdlIGluIEdyYXBoaWNzQ29udGV4dDNERWZsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0MjcxLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggaW1wbGVtZW50cyBJbWFnZUV4dHJhY3Rv cjo6ZXh0cmFjdEltYWdlIGluIEdyYXBoaWNzQ29udGV4dDNERWZsLgorCisgICAgICAgIENvdmVy ZWQgYnkgZXhpc2l0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZWZs L0dyYXBoaWNzQ29udGV4dDNERWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29u dGV4dDNEOjpJbWFnZUV4dHJhY3Rvcjo6fkltYWdlRXh0cmFjdG9yKToKKyAgICAgICAgKFdlYkNv cmU6OkdyYXBoaWNzQ29udGV4dDNEOjpJbWFnZUV4dHJhY3Rvcjo6ZXh0cmFjdEltYWdlKToKKwog MjAxMi0xMi0wNSAgS3J6eXN6dG9mIEN6ZWNoICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KIAogICAg ICAgICBbRUZMXVtXSzJdIEludHJvZHVjZSBXZWJLaXQtRUZMIHRvIEFzc2lzdGl2ZSBUZWNobm9s b2dpZXMKZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZmwvR3Jh cGhpY3NDb250ZXh0M0RFZmwuY3BwIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Vm bC9HcmFwaGljc0NvbnRleHQzREVmbC5jcHAKaW5kZXggNDY3OTQ3Ni4uYmU2YjI2OCAxMDA2NDQK LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VmbC9HcmFwaGljc0NvbnRleHQz REVmbC5jcHAKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VmbC9HcmFwaGlj c0NvbnRleHQzREVmbC5jcHAKQEAgLTI0LDcgKzI0LDggQEAKICNpZiBVU0UoM0RfR1JBUEhJQ1Mp IHx8IFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKIAogI2luY2x1ZGUgIkdyYXBoaWNzQ29u dGV4dDNEUHJpdmF0ZS5oIgotI2luY2x1ZGUgIkltYWdlRGF0YS5oIgorI2luY2x1ZGUgIkltYWdl LmgiCisjaW5jbHVkZSAiSW1hZ2VTb3VyY2UuaCIKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5o IgogI2luY2x1ZGUgIk9wZW5HTFNoaW1zLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1Db250ZXh0Q2Fp cm8uaCIKQEAgLTI0MywxMiArMjQ0LDcwIEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OmNyZWF0 ZUdyYXBoaWNzU3VyZmFjZXMoY29uc3QgSW50U2l6ZSYgc2l6ZSkKIAogR3JhcGhpY3NDb250ZXh0 M0Q6OkltYWdlRXh0cmFjdG9yOjp+SW1hZ2VFeHRyYWN0b3IoKQogeworICAgIGlmIChtX2RlY29k ZXIpCisgICAgICAgIGRlbGV0ZSBtX2RlY29kZXI7CiB9CiAKLWJvb2wgR3JhcGhpY3NDb250ZXh0 M0Q6OkltYWdlRXh0cmFjdG9yOjpleHRyYWN0SW1hZ2UoYm9vbCAvKnByZW11bHRpcGx5QWxwaGEq LywgYm9vbCAvKmlnbm9yZUdhbW1hQW5kQ29sb3JQcm9maWxlKi8pCitib29sIEdyYXBoaWNzQ29u dGV4dDNEOjpJbWFnZUV4dHJhY3Rvcjo6ZXh0cmFjdEltYWdlKGJvb2wgcHJlbXVsdGlwbHlBbHBo YSwgYm9vbCBpZ25vcmVHYW1tYUFuZENvbG9yUHJvZmlsZSkKIHsKLSAgICBub3RJbXBsZW1lbnRl ZCgpOwotICAgIHJldHVybiBmYWxzZTsKKyAgICAvLyBUaGlzIGltcGxlbWVudGF0aW9uIGlzIHRh a2VuIGZyb20gR3JhcGhpY3NDb250ZXh0M0RDYWlybworCisgICAgaWYgKCFtX2ltYWdlKQorICAg ICAgICByZXR1cm4gZmFsc2U7CisKKyAgICAvLyBXZSBuZWVkIHRoaXMgdG8gc3RheSBpbiBzY29w ZSBiZWNhdXNlIHRoZSBuYXRpdmUgaW1hZ2UgaXMganVzdCBhIHNoYWxsb3cgY29weSBvZiB0aGUg ZGF0YS4KKyAgICBtX2RlY29kZXIgPSBuZXcgSW1hZ2VTb3VyY2UocHJlbXVsdGlwbHlBbHBoYSA/ IEltYWdlU291cmNlOjpBbHBoYVByZW11bHRpcGxpZWQgOiBJbWFnZVNvdXJjZTo6QWxwaGFOb3RQ cmVtdWx0aXBsaWVkLCBpZ25vcmVHYW1tYUFuZENvbG9yUHJvZmlsZSA/IEltYWdlU291cmNlOjpH YW1tYUFuZENvbG9yUHJvZmlsZUlnbm9yZWQgOiBJbWFnZVNvdXJjZTo6R2FtbWFBbmRDb2xvclBy b2ZpbGVBcHBsaWVkKTsKKworICAgIGlmICghbV9kZWNvZGVyKQorICAgICAgICByZXR1cm4gZmFs c2U7CisKKyAgICBJbWFnZVNvdXJjZSYgZGVjb2RlciA9ICptX2RlY29kZXI7CisgICAgbV9hbHBo YU9wID0gQWxwaGFEb05vdGhpbmc7CisKKyAgICBpZiAobV9pbWFnZS0+ZGF0YSgpKSB7CisgICAg ICAgIGRlY29kZXIuc2V0RGF0YShtX2ltYWdlLT5kYXRhKCksIHRydWUpOworCisgICAgICAgIGlm ICghZGVjb2Rlci5mcmFtZUNvdW50KCkgfHwgIWRlY29kZXIuZnJhbWVJc0NvbXBsZXRlQXRJbmRl eCgwKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgICAgICBPd25QdHI8TmF0aXZl SW1hZ2VDYWlybz4gbmF0aXZlSW1hZ2UgPSBhZG9wdFB0cihkZWNvZGVyLmNyZWF0ZUZyYW1lQXRJ bmRleCgwKSk7CisgICAgICAgIG1faW1hZ2VTdXJmYWNlID0gbmF0aXZlSW1hZ2UtPnN1cmZhY2Uo KTsKKyAgICB9IGVsc2UgeworICAgICAgICBOYXRpdmVJbWFnZUNhaXJvKiBuYXRpdmVJbWFnZSA9 IG1faW1hZ2UtPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7CisgICAgICAgIG1faW1hZ2VT dXJmYWNlID0gKG5hdGl2ZUltYWdlKSA/IG5hdGl2ZUltYWdlLT5zdXJmYWNlKCkgOiAwOworCisg ICAgICAgIGlmICghcHJlbXVsdGlwbHlBbHBoYSkKKyAgICAgICAgICAgIG1fYWxwaGFPcCA9IEFs cGhhRG9Vbm11bHRpcGx5OworICAgIH0KKworICAgIGlmICghbV9pbWFnZVN1cmZhY2UpCisgICAg ICAgIHJldHVybiBmYWxzZTsKKworICAgIG1faW1hZ2VXaWR0aCA9IGNhaXJvX2ltYWdlX3N1cmZh Y2VfZ2V0X3dpZHRoKG1faW1hZ2VTdXJmYWNlLmdldCgpKTsKKyAgICBtX2ltYWdlSGVpZ2h0ID0g Y2Fpcm9faW1hZ2Vfc3VyZmFjZV9nZXRfaGVpZ2h0KG1faW1hZ2VTdXJmYWNlLmdldCgpKTsKKwor ICAgIGlmICghbV9pbWFnZVdpZHRoIHx8ICFtX2ltYWdlSGVpZ2h0KQorICAgICAgICByZXR1cm4g ZmFsc2U7CisKKyAgICBpZiAoY2Fpcm9faW1hZ2Vfc3VyZmFjZV9nZXRfZm9ybWF0KG1faW1hZ2VT dXJmYWNlLmdldCgpKSAhPSBDQUlST19GT1JNQVRfQVJHQjMyKQorICAgICAgICByZXR1cm4gZmFs c2U7CisKKyAgICB1aW50IHNyY1VucGFja0FsaWdubWVudCA9IDE7CisgICAgc2l6ZV90IGJ5dGVz UGVyUm93ID0gY2Fpcm9faW1hZ2Vfc3VyZmFjZV9nZXRfc3RyaWRlKG1faW1hZ2VTdXJmYWNlLmdl dCgpKTsKKyAgICBzaXplX3QgYml0c1BlclBpeGVsID0gMzI7CisgICAgdW5zaWduZWQgcGFkZGlu ZyA9IGJ5dGVzUGVyUm93IC0gYml0c1BlclBpeGVsIC8gOCAqIG1faW1hZ2VXaWR0aDsKKworICAg IGlmIChwYWRkaW5nKSB7CisgICAgICAgIHNyY1VucGFja0FsaWdubWVudCA9IHBhZGRpbmcgKyAx OworICAgICAgICB3aGlsZSAoYnl0ZXNQZXJSb3cgJSBzcmNVbnBhY2tBbGlnbm1lbnQpCisgICAg ICAgICAgICArK3NyY1VucGFja0FsaWdubWVudDsKKyAgICB9CisKKyAgICBtX2ltYWdlUGl4ZWxE YXRhID0gY2Fpcm9faW1hZ2Vfc3VyZmFjZV9nZXRfZGF0YShtX2ltYWdlU3VyZmFjZS5nZXQoKSk7 CisgICAgbV9pbWFnZVNvdXJjZUZvcm1hdCA9IFNvdXJjZUZvcm1hdEJHUkE4OworICAgIG1faW1h Z2VTb3VyY2VVbnBhY2tBbGlnbm1lbnQgPSBzcmNVbnBhY2tBbGlnbm1lbnQ7CisgICAgcmV0dXJu IHRydWU7CisKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 178076 2012-12-06 14:02:50 -0800 2012-12-06 22:00:06 -0800 review fixes 104271review.patch text/plain 4005 kalyan.kondapally ZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDdmN2M1OTUuLmQxYjRhZGEgMTAwNjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTEyLTA2ICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4K KworICAgICAgICBbRUZMXSBbQUNdIEltcGxlbWVudCBJbWFnZUV4dHJhY3Rvcjo6ZXh0cmFjdElt YWdlIGluIEdyYXBoaWNzQ29udGV4dDNERWZsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0MjcxLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggaW1wbGVtZW50cyBJbWFnZUV4dHJhY3Rv cjo6ZXh0cmFjdEltYWdlIGluIEdyYXBoaWNzQ29udGV4dDNERWZsLgorCisgICAgICAgIENvdmVy ZWQgYnkgZXhpc2l0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZWZs L0dyYXBoaWNzQ29udGV4dDNERWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29u dGV4dDNEOjpJbWFnZUV4dHJhY3Rvcjo6fkltYWdlRXh0cmFjdG9yKToKKyAgICAgICAgKFdlYkNv cmU6OkdyYXBoaWNzQ29udGV4dDNEOjpJbWFnZUV4dHJhY3Rvcjo6ZXh0cmFjdEltYWdlKToKKwog MjAxMi0xMi0wNSAgS3J6eXN6dG9mIEN6ZWNoICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KIAogICAg ICAgICBbRUZMXVtXSzJdIEludHJvZHVjZSBXZWJLaXQtRUZMIHRvIEFzc2lzdGl2ZSBUZWNobm9s b2dpZXMKZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZmwvR3Jh cGhpY3NDb250ZXh0M0RFZmwuY3BwIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Vm bC9HcmFwaGljc0NvbnRleHQzREVmbC5jcHAKaW5kZXggNDY3OTQ3Ni4uZGFmZDE1ZiAxMDA2NDQK LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VmbC9HcmFwaGljc0NvbnRleHQz REVmbC5jcHAKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VmbC9HcmFwaGlj c0NvbnRleHQzREVmbC5jcHAKQEAgLTI0LDcgKzI0LDggQEAKICNpZiBVU0UoM0RfR1JBUEhJQ1Mp IHx8IFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKIAogI2luY2x1ZGUgIkdyYXBoaWNzQ29u dGV4dDNEUHJpdmF0ZS5oIgotI2luY2x1ZGUgIkltYWdlRGF0YS5oIgorI2luY2x1ZGUgIkltYWdl LmgiCisjaW5jbHVkZSAiSW1hZ2VTb3VyY2UuaCIKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5o IgogI2luY2x1ZGUgIk9wZW5HTFNoaW1zLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1Db250ZXh0Q2Fp cm8uaCIKQEAgLTI0MywxMiArMjQ0LDY5IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OmNyZWF0 ZUdyYXBoaWNzU3VyZmFjZXMoY29uc3QgSW50U2l6ZSYgc2l6ZSkKIAogR3JhcGhpY3NDb250ZXh0 M0Q6OkltYWdlRXh0cmFjdG9yOjp+SW1hZ2VFeHRyYWN0b3IoKQogeworICAgIGRlbGV0ZSBtX2Rl Y29kZXI7CiB9CiAKLWJvb2wgR3JhcGhpY3NDb250ZXh0M0Q6OkltYWdlRXh0cmFjdG9yOjpleHRy YWN0SW1hZ2UoYm9vbCAvKnByZW11bHRpcGx5QWxwaGEqLywgYm9vbCAvKmlnbm9yZUdhbW1hQW5k Q29sb3JQcm9maWxlKi8pCitib29sIEdyYXBoaWNzQ29udGV4dDNEOjpJbWFnZUV4dHJhY3Rvcjo6 ZXh0cmFjdEltYWdlKGJvb2wgcHJlbXVsdGlwbHlBbHBoYSwgYm9vbCBpZ25vcmVHYW1tYUFuZENv bG9yUHJvZmlsZSkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBmYWxzZTsK KyAgICAvLyBUaGlzIGltcGxlbWVudGF0aW9uIGlzIHRha2VuIGZyb20gR3JhcGhpY3NDb250ZXh0 M0RDYWlyby4KKworICAgIGlmICghbV9pbWFnZSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisg ICAgLy8gV2UgbmVlZCB0aGlzIHRvIHN0YXkgaW4gc2NvcGUgYmVjYXVzZSB0aGUgbmF0aXZlIGlt YWdlIGlzIGp1c3QgYSBzaGFsbG93IGNvcHkgb2YgdGhlIGRhdGEuCisgICAgbV9kZWNvZGVyID0g bmV3IEltYWdlU291cmNlKHByZW11bHRpcGx5QWxwaGEgPyBJbWFnZVNvdXJjZTo6QWxwaGFQcmVt dWx0aXBsaWVkIDogSW1hZ2VTb3VyY2U6OkFscGhhTm90UHJlbXVsdGlwbGllZCwgaWdub3JlR2Ft bWFBbmRDb2xvclByb2ZpbGUgPyBJbWFnZVNvdXJjZTo6R2FtbWFBbmRDb2xvclByb2ZpbGVJZ25v cmVkIDogSW1hZ2VTb3VyY2U6OkdhbW1hQW5kQ29sb3JQcm9maWxlQXBwbGllZCk7CisKKyAgICBp ZiAoIW1fZGVjb2RlcikKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgSW1hZ2VTb3VyY2Um IGRlY29kZXIgPSAqbV9kZWNvZGVyOworICAgIG1fYWxwaGFPcCA9IEFscGhhRG9Ob3RoaW5nOwor CisgICAgaWYgKG1faW1hZ2UtPmRhdGEoKSkgeworICAgICAgICBkZWNvZGVyLnNldERhdGEobV9p bWFnZS0+ZGF0YSgpLCB0cnVlKTsKKworICAgICAgICBpZiAoIWRlY29kZXIuZnJhbWVDb3VudCgp IHx8ICFkZWNvZGVyLmZyYW1lSXNDb21wbGV0ZUF0SW5kZXgoMCkpCisgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CisKKyAgICAgICAgT3duUHRyPE5hdGl2ZUltYWdlQ2Fpcm8+IG5hdGl2ZUltYWdl ID0gYWRvcHRQdHIoZGVjb2Rlci5jcmVhdGVGcmFtZUF0SW5kZXgoMCkpOworICAgICAgICBtX2lt YWdlU3VyZmFjZSA9IG5hdGl2ZUltYWdlLT5zdXJmYWNlKCk7CisgICAgfSBlbHNlIHsKKyAgICAg ICAgTmF0aXZlSW1hZ2VDYWlybyogbmF0aXZlSW1hZ2UgPSBtX2ltYWdlLT5uYXRpdmVJbWFnZUZv ckN1cnJlbnRGcmFtZSgpOworICAgICAgICBtX2ltYWdlU3VyZmFjZSA9IChuYXRpdmVJbWFnZSkg PyBuYXRpdmVJbWFnZS0+c3VyZmFjZSgpIDogMDsKKworICAgICAgICBpZiAoIXByZW11bHRpcGx5 QWxwaGEpCisgICAgICAgICAgICBtX2FscGhhT3AgPSBBbHBoYURvVW5tdWx0aXBseTsKKyAgICB9 CisKKyAgICBpZiAoIW1faW1hZ2VTdXJmYWNlKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAg ICBtX2ltYWdlV2lkdGggPSBjYWlyb19pbWFnZV9zdXJmYWNlX2dldF93aWR0aChtX2ltYWdlU3Vy ZmFjZS5nZXQoKSk7CisgICAgbV9pbWFnZUhlaWdodCA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfZ2V0 X2hlaWdodChtX2ltYWdlU3VyZmFjZS5nZXQoKSk7CisKKyAgICBpZiAoIW1faW1hZ2VXaWR0aCB8 fCAhbV9pbWFnZUhlaWdodCkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKGNhaXJv X2ltYWdlX3N1cmZhY2VfZ2V0X2Zvcm1hdChtX2ltYWdlU3VyZmFjZS5nZXQoKSkgIT0gQ0FJUk9f Rk9STUFUX0FSR0IzMikKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgdWludCBzcmNVbnBh Y2tBbGlnbm1lbnQgPSAxOworICAgIHNpemVfdCBieXRlc1BlclJvdyA9IGNhaXJvX2ltYWdlX3N1 cmZhY2VfZ2V0X3N0cmlkZShtX2ltYWdlU3VyZmFjZS5nZXQoKSk7CisgICAgc2l6ZV90IGJpdHNQ ZXJQaXhlbCA9IDMyOworICAgIHVuc2lnbmVkIHBhZGRpbmcgPSBieXRlc1BlclJvdyAtIGJpdHNQ ZXJQaXhlbCAvIDggKiBtX2ltYWdlV2lkdGg7CisKKyAgICBpZiAocGFkZGluZykgeworICAgICAg ICBzcmNVbnBhY2tBbGlnbm1lbnQgPSBwYWRkaW5nICsgMTsKKyAgICAgICAgd2hpbGUgKGJ5dGVz UGVyUm93ICUgc3JjVW5wYWNrQWxpZ25tZW50KQorICAgICAgICAgICAgKytzcmNVbnBhY2tBbGln bm1lbnQ7CisgICAgfQorCisgICAgbV9pbWFnZVBpeGVsRGF0YSA9IGNhaXJvX2ltYWdlX3N1cmZh Y2VfZ2V0X2RhdGEobV9pbWFnZVN1cmZhY2UuZ2V0KCkpOworICAgIG1faW1hZ2VTb3VyY2VGb3Jt YXQgPSBTb3VyY2VGb3JtYXRCR1JBODsKKyAgICBtX2ltYWdlU291cmNlVW5wYWNrQWxpZ25tZW50 ID0gc3JjVW5wYWNrQWxpZ25tZW50OworCisgICAgcmV0dXJuIHRydWU7CiB9CiAKIH0gLy8gbmFt ZXNwYWNlIFdlYkNvcmUK 178159 2012-12-06 22:00:06 -0800 2012-12-07 02:50:58 -0800 review fixes patchv4.patch text/plain 4016 kalyan.kondapally ZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDdmN2M1OTUuLmQ5Y2E1YzMgMTAwNjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTEyLTA2ICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4K KworICAgICAgICBbRUZMXSBbQUNdIEltcGxlbWVudCBJbWFnZUV4dHJhY3Rvcjo6ZXh0cmFjdElt YWdlIGluIEdyYXBoaWNzQ29udGV4dDNERWZsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0MjcxLgorCisgICAgICAgIFJldmlld2VkIGJ5IEtlbm5l dGggUm9oZGUgQ2hyaXN0aWFuc2VuLgorCisgICAgICAgIFRoaXMgcGF0Y2ggaW1wbGVtZW50cyBJ bWFnZUV4dHJhY3Rvcjo6ZXh0cmFjdEltYWdlIGluIEdyYXBoaWNzQ29udGV4dDNERWZsLgorCisg ICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9lZmwvR3JhcGhpY3NDb250ZXh0M0RFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 R3JhcGhpY3NDb250ZXh0M0Q6OkltYWdlRXh0cmFjdG9yOjp+SW1hZ2VFeHRyYWN0b3IpOgorICAg ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OkltYWdlRXh0cmFjdG9yOjpleHRyYWN0 SW1hZ2UpOgorCiAyMDEyLTEyLTA1ICBLcnp5c3p0b2YgQ3plY2ggIDxrLmN6ZWNoQHNhbXN1bmcu Y29tPgogCiAgICAgICAgIFtFRkxdW1dLMl0gSW50cm9kdWNlIFdlYktpdC1FRkwgdG8gQXNzaXN0 aXZlIFRlY2hub2xvZ2llcwpkaWZmIC0tZ2l0IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2VmbC9HcmFwaGljc0NvbnRleHQzREVmbC5jcHAgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZWZsL0dyYXBoaWNzQ29udGV4dDNERWZsLmNwcAppbmRleCA0Njc5NDc2Li5kYWZk MTVmIDEwMDY0NAotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWZsL0dyYXBo aWNzQ29udGV4dDNERWZsLmNwcAorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv ZWZsL0dyYXBoaWNzQ29udGV4dDNERWZsLmNwcApAQCAtMjQsNyArMjQsOCBAQAogI2lmIFVTRSgz RF9HUkFQSElDUykgfHwgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogCiAjaW5jbHVkZSAi R3JhcGhpY3NDb250ZXh0M0RQcml2YXRlLmgiCi0jaW5jbHVkZSAiSW1hZ2VEYXRhLmgiCisjaW5j bHVkZSAiSW1hZ2UuaCIKKyNpbmNsdWRlICJJbWFnZVNvdXJjZS5oIgogI2luY2x1ZGUgIk5vdElt cGxlbWVudGVkLmgiCiAjaW5jbHVkZSAiT3BlbkdMU2hpbXMuaCIKICNpbmNsdWRlICJQbGF0Zm9y bUNvbnRleHRDYWlyby5oIgpAQCAtMjQzLDEyICsyNDQsNjkgQEAgdm9pZCBHcmFwaGljc0NvbnRl eHQzRDo6Y3JlYXRlR3JhcGhpY3NTdXJmYWNlcyhjb25zdCBJbnRTaXplJiBzaXplKQogCiBHcmFw aGljc0NvbnRleHQzRDo6SW1hZ2VFeHRyYWN0b3I6On5JbWFnZUV4dHJhY3RvcigpCiB7CisgICAg ZGVsZXRlIG1fZGVjb2RlcjsKIH0KIAotYm9vbCBHcmFwaGljc0NvbnRleHQzRDo6SW1hZ2VFeHRy YWN0b3I6OmV4dHJhY3RJbWFnZShib29sIC8qcHJlbXVsdGlwbHlBbHBoYSovLCBib29sIC8qaWdu b3JlR2FtbWFBbmRDb2xvclByb2ZpbGUqLykKK2Jvb2wgR3JhcGhpY3NDb250ZXh0M0Q6OkltYWdl RXh0cmFjdG9yOjpleHRyYWN0SW1hZ2UoYm9vbCBwcmVtdWx0aXBseUFscGhhLCBib29sIGlnbm9y ZUdhbW1hQW5kQ29sb3JQcm9maWxlKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0 dXJuIGZhbHNlOworICAgIC8vIFRoaXMgaW1wbGVtZW50YXRpb24gaXMgdGFrZW4gZnJvbSBHcmFw aGljc0NvbnRleHQzRENhaXJvLgorCisgICAgaWYgKCFtX2ltYWdlKQorICAgICAgICByZXR1cm4g ZmFsc2U7CisKKyAgICAvLyBXZSBuZWVkIHRoaXMgdG8gc3RheSBpbiBzY29wZSBiZWNhdXNlIHRo ZSBuYXRpdmUgaW1hZ2UgaXMganVzdCBhIHNoYWxsb3cgY29weSBvZiB0aGUgZGF0YS4KKyAgICBt X2RlY29kZXIgPSBuZXcgSW1hZ2VTb3VyY2UocHJlbXVsdGlwbHlBbHBoYSA/IEltYWdlU291cmNl OjpBbHBoYVByZW11bHRpcGxpZWQgOiBJbWFnZVNvdXJjZTo6QWxwaGFOb3RQcmVtdWx0aXBsaWVk LCBpZ25vcmVHYW1tYUFuZENvbG9yUHJvZmlsZSA/IEltYWdlU291cmNlOjpHYW1tYUFuZENvbG9y UHJvZmlsZUlnbm9yZWQgOiBJbWFnZVNvdXJjZTo6R2FtbWFBbmRDb2xvclByb2ZpbGVBcHBsaWVk KTsKKworICAgIGlmICghbV9kZWNvZGVyKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBJ bWFnZVNvdXJjZSYgZGVjb2RlciA9ICptX2RlY29kZXI7CisgICAgbV9hbHBoYU9wID0gQWxwaGFE b05vdGhpbmc7CisKKyAgICBpZiAobV9pbWFnZS0+ZGF0YSgpKSB7CisgICAgICAgIGRlY29kZXIu c2V0RGF0YShtX2ltYWdlLT5kYXRhKCksIHRydWUpOworCisgICAgICAgIGlmICghZGVjb2Rlci5m cmFtZUNvdW50KCkgfHwgIWRlY29kZXIuZnJhbWVJc0NvbXBsZXRlQXRJbmRleCgwKSkKKyAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKKworICAgICAgICBPd25QdHI8TmF0aXZlSW1hZ2VDYWlybz4g bmF0aXZlSW1hZ2UgPSBhZG9wdFB0cihkZWNvZGVyLmNyZWF0ZUZyYW1lQXRJbmRleCgwKSk7Cisg ICAgICAgIG1faW1hZ2VTdXJmYWNlID0gbmF0aXZlSW1hZ2UtPnN1cmZhY2UoKTsKKyAgICB9IGVs c2UgeworICAgICAgICBOYXRpdmVJbWFnZUNhaXJvKiBuYXRpdmVJbWFnZSA9IG1faW1hZ2UtPm5h dGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7CisgICAgICAgIG1faW1hZ2VTdXJmYWNlID0gKG5h dGl2ZUltYWdlKSA/IG5hdGl2ZUltYWdlLT5zdXJmYWNlKCkgOiAwOworCisgICAgICAgIGlmICgh cHJlbXVsdGlwbHlBbHBoYSkKKyAgICAgICAgICAgIG1fYWxwaGFPcCA9IEFscGhhRG9Vbm11bHRp cGx5OworICAgIH0KKworICAgIGlmICghbV9pbWFnZVN1cmZhY2UpCisgICAgICAgIHJldHVybiBm YWxzZTsKKworICAgIG1faW1hZ2VXaWR0aCA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfZ2V0X3dpZHRo KG1faW1hZ2VTdXJmYWNlLmdldCgpKTsKKyAgICBtX2ltYWdlSGVpZ2h0ID0gY2Fpcm9faW1hZ2Vf c3VyZmFjZV9nZXRfaGVpZ2h0KG1faW1hZ2VTdXJmYWNlLmdldCgpKTsKKworICAgIGlmICghbV9p bWFnZVdpZHRoIHx8ICFtX2ltYWdlSGVpZ2h0KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAg ICBpZiAoY2Fpcm9faW1hZ2Vfc3VyZmFjZV9nZXRfZm9ybWF0KG1faW1hZ2VTdXJmYWNlLmdldCgp KSAhPSBDQUlST19GT1JNQVRfQVJHQjMyKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICB1 aW50IHNyY1VucGFja0FsaWdubWVudCA9IDE7CisgICAgc2l6ZV90IGJ5dGVzUGVyUm93ID0gY2Fp cm9faW1hZ2Vfc3VyZmFjZV9nZXRfc3RyaWRlKG1faW1hZ2VTdXJmYWNlLmdldCgpKTsKKyAgICBz aXplX3QgYml0c1BlclBpeGVsID0gMzI7CisgICAgdW5zaWduZWQgcGFkZGluZyA9IGJ5dGVzUGVy Um93IC0gYml0c1BlclBpeGVsIC8gOCAqIG1faW1hZ2VXaWR0aDsKKworICAgIGlmIChwYWRkaW5n KSB7CisgICAgICAgIHNyY1VucGFja0FsaWdubWVudCA9IHBhZGRpbmcgKyAxOworICAgICAgICB3 aGlsZSAoYnl0ZXNQZXJSb3cgJSBzcmNVbnBhY2tBbGlnbm1lbnQpCisgICAgICAgICAgICArK3Ny Y1VucGFja0FsaWdubWVudDsKKyAgICB9CisKKyAgICBtX2ltYWdlUGl4ZWxEYXRhID0gY2Fpcm9f aW1hZ2Vfc3VyZmFjZV9nZXRfZGF0YShtX2ltYWdlU3VyZmFjZS5nZXQoKSk7CisgICAgbV9pbWFn ZVNvdXJjZUZvcm1hdCA9IFNvdXJjZUZvcm1hdEJHUkE4OworICAgIG1faW1hZ2VTb3VyY2VVbnBh Y2tBbGlnbm1lbnQgPSBzcmNVbnBhY2tBbGlnbm1lbnQ7CisKKyAgICByZXR1cm4gdHJ1ZTsKIH0K IAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=