104262 2012-12-06 07:05:29 -0800 [EFL] Fix build warning in StyleResolver.cpp using gcc 4.7.2 2012-12-07 06:53:12 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 sujjin.park webkit-unassigned allan.jensen cmarcelo lucas.de.marchi macpherson menard ojan.autocc webkit.review.bot oldest_to_newest 784922 0 sujjin.park 2012-12-06 07:05:29 -0800 When I compile in Ubuntu 12.10(gcc 4.7.2), I got bellow errors Source/WebCore/CMakeFiles/webcore_efl.dir/css/ViewportStyleResolver.cpp.o In file included from /home/sujin/workspace/WebKit/Source/WebCore/rendering/style/RenderStyle.h:39:0, from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.h:30, from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:30: /home/sujin/workspace/WebKit/Source/WebCore/platform/graphics/FontDescription.h: In static member function ‘static WTF::PassRefPtr<WebCore::RenderStyle> WebCore::StyleResolver::styleForDocument(WebCore::Document*, WebCore::CSSFontSelector*)’: /home/sujin/workspace/WebKit/Source/WebCore/platform/graphics/FontDescription.h:165:112: error: ‘glyphOrientation’ may be used uninitialized in this function [-Werror=maybe-uninitialized] /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:1508:28: note: ‘glyphOrientation’ was declared here In file included from /home/sujin/workspace/WebKit/Source/WebCore/rendering/style/RenderStyle.h:39:0, from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.h:30, from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:30: /home/sujin/workspace/WebKit/Source/WebCore/platform/graphics/FontDescription.h:164:83: error: ‘fontOrientation’ may be used uninitialized in this function [-Werror=maybe-uninitialized] /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:1507:21: note: ‘fontOrientation’ was declared here /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp: In member function ‘void WebCore::StyleResolver::_ZN7WebCore13StyleResolver10updateFontEv.part.218()’: /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:2140:5: error: ‘parentGlyphOrientation’ may be used uninitialized in this function [-Werror=maybe-uninitialized] /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:2137:28: note: ‘parentGlyphOrientation’ was declared here /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:2140:5: error: ‘parentFontOrientation’ may be used uninitialized in this function [-Werror=maybe-uninitialized] /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:2136:21: note: ‘parentFontOrientation’ was declared here In file included from /home/sujin/workspace/WebKit/Source/WebCore/rendering/style/RenderStyle.h:39:0, from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.h:30, from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:30: /home/sujin/workspace/WebKit/Source/WebCore/platform/graphics/FontDescription.h:165:112: error: ‘childGlyphOrientation’ may be used uninitialized in this function [-Werror=maybe-uninitialized] /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:2133:28: note: ‘childGlyphOrientation’ was declared here In file included from /home/sujin/workspace/WebKit/Source/WebCore/rendering/style/RenderStyle.h:39:0, from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.h:30, from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:30: /home/sujin/workspace/WebKit/Source/WebCore/platform/graphics/FontDescription.h:164:83: error: ‘childFontOrientation’ may be used uninitialized in this function [-Werror=maybe-uninitialized] /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:2132:21: note: ‘childFontOrientation’ was declared here cc1plus: all warnings being treated as errors make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/css/StyleResolver.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/all] Error 2 make: *** [all] Error 2 784936 1 178011 sujjin.park 2012-12-06 07:33:01 -0800 Created attachment 178011 Patch 785792 2 178193 sujjin.park 2012-12-07 03:53:15 -0800 Created attachment 178193 Patch 785857 3 178193 webkit.review.bot 2012-12-07 06:53:08 -0800 Comment on attachment 178193 Patch Clearing flags on attachment: 178193 Committed r136952: <http://trac.webkit.org/changeset/136952> 785858 4 webkit.review.bot 2012-12-07 06:53:12 -0800 All reviewed patches have been landed. Closing bug. 178011 2012-12-06 07:33:01 -0800 2012-12-07 03:53:08 -0800 Patch bug-104262-20121207003024.patch text/plain 1598 sujjin.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThmMjBlMDBiMmFlYjA0 ODNhMjAxY2Q4OGEwMmMxNGNmYTdlZWRjYy4uYmE1MjI4ZGM4ZmYzNzI4NjZiM2FlMjAyZDVkMzgy ZjAwYzM2ODE1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTA2ICBTdWpp biBQYXJrICA8c3VqamluLnBhcmtAZ29vZ2xlLmNvbT4KKworICAgICAgICBbRUZMXSBGaXggYnVp bGQgd2FybmluZyBpbiBTdHlsZVJlc29sdmVyLmNwcCB1c2luZyBnY2MgNC43LjIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDI2MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJlY2F1c2UgZ2V0Rm9udEFu ZEdseXBoT3JpZW50YXRpb24gZnVuY3Rpb24gZG9lcyBub3QgaGF2ZSBhIGRlZmF1bHQgc3RhdGVt ZW50IGZvciBzd2l0Y2gtY2FzZSwgYWRkIGRlZmF1bHQgY2FzZSB0byByZW1vdmUgJy1XZXJyb3I9 bWF5YmUtdW5pbml0aWFsaXplZCcKKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKwor ICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmdldEZv bnRBbmRHbHlwaE9yaWVudGF0aW9uKToKKwogMjAxMi0xMi0wNiAgS29uZGFwYWxseSBLYWx5YW4g IDxrYWx5YW4ua29uZGFwYWxseUBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gQWN0aXZlIHRl eHR1cmUgc3RhdGUgZ2V0cyBjb3JydXB0ZWQgYWZ0ZXIgdXBkYXRpbmcgZ3JhcGhpY3Mgc3VyZmFj ZSBjb250ZW50cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAppbmRleCA3MjYzMzIz OWUzMmVkNzQ5OTNiMTcwYjI1ZjgzOWQ4MzkyYzI0ODQyLi5hY2IzNmEyMDJlNzYzYTY4ZjRkMTQ1 OGI2NmI5ZjA1YmY5MmEwZjRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVS ZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCkBA IC0xNDIwLDYgKzE0MjAsMTEgQEAgc3RhdGljIHZvaWQgZ2V0Rm9udEFuZEdseXBoT3JpZW50YXRp b24oY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxlLCBGb250T3JpZW50YXRpb24KICAgICAgICAgZm9u dE9yaWVudGF0aW9uID0gSG9yaXpvbnRhbDsKICAgICAgICAgZ2x5cGhPcmllbnRhdGlvbiA9IE5v bkNKS0dseXBoT3JpZW50YXRpb25WZXJ0aWNhbFJpZ2h0OwogICAgICAgICByZXR1cm47CisgICAg ZGVmYXVsdDoKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIGZvbnRPcmll bnRhdGlvbiA9IEhvcml6b250YWw7CisgICAgICAgIGdseXBoT3JpZW50YXRpb24gPSBOb25DSktH bHlwaE9yaWVudGF0aW9uVmVydGljYWxSaWdodDsKKyAgICAgICAgcmV0dXJuOwogICAgIH0KIH0K IAo= 178193 2012-12-07 03:53:15 -0800 2012-12-07 06:53:08 -0800 Patch bug-104262-20121207205038.patch text/plain 1596 sujjin.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThmMjBlMDBiMmFlYjA0 ODNhMjAxY2Q4OGEwMmMxNGNmYTdlZWRjYy4uMjVlYjE1NzQxOTA3YmFkZTU2Y2VkMTZjYWRjNWRj MGQyOWZkNjNiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTA2ICBTdWpp biBQYXJrICA8c3VqamluLnBhcmtAZ21haWwuY29tPgorCisgICAgICAgIFtFRkxdIEZpeCBidWls ZCB3YXJuaW5nIGluIFN0eWxlUmVzb2x2ZXIuY3BwIHVzaW5nIGdjYyA0LjcuMgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0MjYyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRUZMIHBvcnQgdHJlYXRzIGJ1 aWxkIHdhcm5pbmcgYXMgY29tcGlsZSBlcnJvciBhbmQgdGhlcmUgYXJlCisgICAgICAgIG1heWJl LXVuaW5pdGlhbGl6ZWQgd2hlbiBidWlsZGluZyB3aXRoIGdjYyA0LjcuMi4KKyAgICAgICAgVGhp cyBwYXRjaCBhZGRzIGRlZmF1bHQgY2FzZSB0byByZXNvbHZlIGEgYnVpbGQgYnJlYWsuCisKKyAg ICAgICAgKiBjc3MvU3R5bGVSZXNvbHZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpnZXRGb250 QW5kR2x5cGhPcmllbnRhdGlvbik6CisKIDIwMTItMTItMDYgIEtvbmRhcGFsbHkgS2FseWFuICA8 a2FseWFuLmtvbmRhcGFsbHlAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIEFjdGl2ZSB0ZXh0 dXJlIHN0YXRlIGdldHMgY29ycnVwdGVkIGFmdGVyIHVwZGF0aW5nIGdyYXBoaWNzIHN1cmZhY2Ug Y29udGVudHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKaW5kZXggNzI2MzMyMzll MzJlZDc0OTkzYjE3MGIyNWY4MzlkODM5MmMyNDg0Mi4uYWNiMzZhMjAyZTc2M2E2OGY0ZDE0NThi NjZiOWYwNWJmOTJhMGY0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVz b2x2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcApAQCAt MTQyMCw2ICsxNDIwLDExIEBAIHN0YXRpYyB2b2lkIGdldEZvbnRBbmRHbHlwaE9yaWVudGF0aW9u KGNvbnN0IFJlbmRlclN0eWxlKiBzdHlsZSwgRm9udE9yaWVudGF0aW9uCiAgICAgICAgIGZvbnRP cmllbnRhdGlvbiA9IEhvcml6b250YWw7CiAgICAgICAgIGdseXBoT3JpZW50YXRpb24gPSBOb25D SktHbHlwaE9yaWVudGF0aW9uVmVydGljYWxSaWdodDsKICAgICAgICAgcmV0dXJuOworICAgIGRl ZmF1bHQ6CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICBmb250T3JpZW50 YXRpb24gPSBIb3Jpem9udGFsOworICAgICAgICBnbHlwaE9yaWVudGF0aW9uID0gTm9uQ0pLR2x5 cGhPcmllbnRhdGlvblZlcnRpY2FsUmlnaHQ7CisgICAgICAgIHJldHVybjsKICAgICB9CiB9CiAK