104260 2012-12-06 06:52:06 -0800 REGRESSION(r136788): Asserts on EFL WebKit2 Debug bot (Requested by yael on #webkit). 2012-12-07 19:36:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103843 1 webkit.review.bot webkit.review.bot dongseong.hwang noam oldest_to_newest 784913 0 webkit.review.bot 2012-12-06 06:52:06 -0800 http://trac.webkit.org/changeset/136788 broke the build: Asserts on EFL WebKit2 Debug bot (Requested by yael on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 784914 1 178007 webkit.review.bot 2012-12-06 06:52:44 -0800 Created attachment 178007 ROLLOUT of r136788 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 784915 2 178007 webkit.review.bot 2012-12-06 06:57:21 -0800 Comment on attachment 178007 ROLLOUT of r136788 Clearing flags on attachment: 178007 Committed r136841: <http://trac.webkit.org/changeset/136841> 784917 3 webkit.review.bot 2012-12-06 06:57:24 -0800 All reviewed patches have been landed. Closing bug. 786378 4 178007 dongseong.hwang 2012-12-07 19:33:03 -0800 Comment on attachment 178007 ROLLOUT of r136788 View in context: https://bugs.webkit.org/attachment.cgi?id=178007&action=review > Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:-331 > - ASSERT(m_rootLayerID != InvalidWebLayerID); This bug rolled out wrong bug. The bug that failed debug build is Bug 103983. Bug 103983 renamed from InvalidWebLayerID to CoordinatedLayerID except for this line. However, it's ok. I'll roll back this bug as well as Bug 104260. 786380 5 dongseong.hwang 2012-12-07 19:36:42 -0800 (In reply to comment #4) > (From update of attachment 178007 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178007&action=review > > > Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:-331 > > - ASSERT(m_rootLayerID != InvalidWebLayerID); > > This bug rolled out wrong bug. > The bug that failed debug build is Bug 103983. > Bug 103983 renamed from InvalidWebLayerID to CoordinatedLayerID except for this line. > However, it's ok. I'll roll back this bug as well as Bug 104260. I think I made a mistake after rethinking. rolling out was good to me. thank you. I'll investigate more. 178007 2012-12-06 06:52:44 -0800 2012-12-07 19:33:03 -0800 ROLLOUT of r136788 bug-104260-20121206145859.patch text/plain 5824 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDUyNjNlYmExNDhiYTA2 NWZjNzViZDMyNTY2ZDVhYzE5YzliZmY5Mi4uZGI2MDMyOTdhZGUyNGM1OGVjYjljYWNhZjdjY2Vk NjU5MjUzYzVjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTEyLTA2ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAorICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTM2Nzg4LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMzY3ODgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNDI2MAorCisgICAgICAgIEFzc2VydHMgb24gRUZMIFdlYktpdDIgRGVidWcg Ym90IChSZXF1ZXN0ZWQgYnkgeWFlbCBvbgorICAgICAgICAjd2Via2l0KS4KKworICAgICAgICAq IFVJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZVJlbmRlcmVyLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6TGF5ZXJUcmVlUmVuZGVyZXI6OnNldExheWVyU3RhdGUpOgorICAgICAg ICAoV2ViS2l0OjpMYXllclRyZWVSZW5kZXJlcjo6c2V0Um9vdExheWVySUQpOgorICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZUNvb3JkaW5h dG9yLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TGF5ZXJUcmVlQ29vcmRpbmF0b3I6OkxheWVyVHJl ZUNvb3JkaW5hdG9yKToKKyAgICAgICAgKFdlYktpdDo6TGF5ZXJUcmVlQ29vcmRpbmF0b3I6OmZs dXNoUGVuZGluZ0xheWVyQ2hhbmdlcyk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0Nv b3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlQ29vcmRpbmF0b3IuaDoKKyAgICAgICAgKExheWVy VHJlZUNvb3JkaW5hdG9yKToKKworMjAxMi0xMi0wNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2 aWV3LmJvdEBnbWFpbC5jb20+CisKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEz Njc5NS4KICAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTM2Nzk1CiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQyNTcKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xh eWVyVHJlZVJlbmRlcmVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRl ZEdyYXBoaWNzL0xheWVyVHJlZVJlbmRlcmVyLmNwcAppbmRleCBmM2Q3MjliOTNhNzkyMWMxZTRj OGQwMTMwY2ZmOTMyMjRhNDUzNDYzLi5jNjcyODIyZGIyMDM0ZmQ5ZTA0YTg0MDk4YWEzODczNWZl NWRlZjE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRH cmFwaGljcy9MYXllclRyZWVSZW5kZXJlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlUmVuZGVyZXIuY3BwCkBAIC0zMjgsNyAr MzI4LDYgQEAgdm9pZCBMYXllclRyZWVSZW5kZXJlcjo6cmVtb3ZlQ3VzdG9tRmlsdGVyUHJvZ3Jh bShpbnQgaWQpCiAKIHZvaWQgTGF5ZXJUcmVlUmVuZGVyZXI6OnNldExheWVyU3RhdGUoV2ViTGF5 ZXJJRCBpZCwgY29uc3QgV2ViTGF5ZXJJbmZvJiBsYXllckluZm8pCiB7Ci0gICAgQVNTRVJUKG1f cm9vdExheWVySUQgIT0gSW52YWxpZFdlYkxheWVySUQpOwogICAgIEdyYXBoaWNzTGF5ZXIqIGxh eWVyID0gZW5zdXJlTGF5ZXIoaWQpOwogCiAgICAgbGF5ZXItPnNldFJlcGxpY2F0ZWRCeUxheWVy KGxheWVyQnlJRChsYXllckluZm8ucmVwbGljYSkpOwpAQCAtMzU5LDYgKzM1OCw4IEBAIHZvaWQg TGF5ZXJUcmVlUmVuZGVyZXI6OnNldExheWVyU3RhdGUoV2ViTGF5ZXJJRCBpZCwgY29uc3QgV2Vi TGF5ZXJJbmZvJiBsYXllckluCiAgICAgbGF5ZXItPnNldE1hc2tzVG9Cb3VuZHMobGF5ZXJJbmZv LmlzUm9vdExheWVyID8gZmFsc2UgOiBsYXllckluZm8ubWFza3NUb0JvdW5kcyk7CiAgICAgbGF5 ZXItPnNldE9wYWNpdHkobGF5ZXJJbmZvLm9wYWNpdHkpOwogICAgIGxheWVyLT5zZXRQcmVzZXJ2 ZXMzRChsYXllckluZm8ucHJlc2VydmVzM0QpOworICAgIGlmIChsYXllckluZm8uaXNSb290TGF5 ZXIgJiYgbV9yb290TGF5ZXJJRCAhPSBpZCkKKyAgICAgICAgc2V0Um9vdExheWVySUQoaWQpOwog fQogCiB2b2lkIExheWVyVHJlZVJlbmRlcmVyOjpkZWxldGVMYXllcihXZWJMYXllcklEIGxheWVy SUQpCkBAIC00MDEsNyArNDAyLDEwIEBAIHZvaWQgTGF5ZXJUcmVlUmVuZGVyZXI6OnNldFJvb3RM YXllcklEKFdlYkxheWVySUQgbGF5ZXJJRCkKICAgICBpZiAoIWxheWVySUQpCiAgICAgICAgIHJl dHVybjsKIAotICAgIEdyYXBoaWNzTGF5ZXIqIGxheWVyID0gZW5zdXJlTGF5ZXIobGF5ZXJJRCk7 CisgICAgR3JhcGhpY3NMYXllciogbGF5ZXIgPSBsYXllckJ5SUQobGF5ZXJJRCk7CisgICAgaWYg KCFsYXllcikKKyAgICAgICAgcmV0dXJuOworCiAgICAgbV9yb290TGF5ZXItPmFkZENoaWxkKGxh eWVyKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlQ29vcmRpbmF0b3IuY3BwIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlQ29v cmRpbmF0b3IuY3BwCmluZGV4IDUwM2ZkMDE2MjE5YjZiNjA3NzkwNTdiM2YyOTZiNzljOWUzOTNk YTIuLmFiYzJjMGYxM2Y0ZTNkNTJhNzRlYzI3NWY2M2ZhNjBmNWUwNTIwMzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0xh eWVyVHJlZUNvb3JkaW5hdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVDb29yZGluYXRvci5jcHAKQEAgLTkw LDYgKzkwLDcgQEAgTGF5ZXJUcmVlQ29vcmRpbmF0b3I6OkxheWVyVHJlZUNvb3JkaW5hdG9yKFdl YlBhZ2UqIHdlYlBhZ2UpCiAgICAgLCBtX2NvbnRlbnRzU2NhbGUoMSkKICAgICAsIG1fc2hvdWxk U2VuZFNjcm9sbFBvc2l0aW9uVXBkYXRlKHRydWUpCiAgICAgLCBtX3Nob3VsZFN5bmNGcmFtZShm YWxzZSkKKyAgICAsIG1fc2hvdWxkU3luY1Jvb3RMYXllcih0cnVlKQogICAgICwgbV9sYXllckZs dXNoVGltZXIodGhpcywgJkxheWVyVHJlZUNvb3JkaW5hdG9yOjpsYXllckZsdXNoVGltZXJGaXJl ZCkKICAgICAsIG1fcmVsZWFzZUluYWN0aXZlQXRsYXNlc1RpbWVyKHRoaXMsICZMYXllclRyZWVD b29yZGluYXRvcjo6cmVsZWFzZUluYWN0aXZlQXRsYXNlc1RpbWVyRmlyZWQpCiAgICAgLCBtX2xh eWVyRmx1c2hTY2hlZHVsaW5nRW5hYmxlZCh0cnVlKQpAQCAtMTE5LDE2ICsxMjAsOSBAQCBMYXll clRyZWVDb29yZGluYXRvcjo6TGF5ZXJUcmVlQ29vcmRpbmF0b3IoV2ViUGFnZSogd2ViUGFnZSkK ICAgICBpZiAobV93ZWJQYWdlLT5oYXNQYWdlT3ZlcmxheSgpKQogICAgICAgICBjcmVhdGVQYWdl T3ZlcmxheUxheWVyKCk7CiAKLSAgICBpbml0aWFsaXplUm9vdENvbXBvc2l0aW5nTGF5ZXIoKTsK ICAgICBzY2hlZHVsZUxheWVyRmx1c2goKTsKIH0KIAotdm9pZCBMYXllclRyZWVDb29yZGluYXRv cjo6aW5pdGlhbGl6ZVJvb3RDb21wb3NpdGluZ0xheWVyKCkKLXsKLSAgICBtX3dlYlBhZ2UtPnNl bmQoTWVzc2FnZXM6OkxheWVyVHJlZUNvb3JkaW5hdG9yUHJveHk6OlNldFJvb3RDb21wb3NpdGlu Z0xheWVyKHRvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyKG1fcm9vdExheWVyLmdldCgpKS0+aWQo KSkpOwotICAgIG1fc2hvdWxkU3luY0ZyYW1lID0gdHJ1ZTsKLX0KLQogdm9pZCBMYXllclRyZWVD b29yZGluYXRvcjo6c2V0TGF5ZXJGbHVzaFNjaGVkdWxpbmdFbmFibGVkKGJvb2wgbGF5ZXJGbHVz aGluZ0VuYWJsZWQpCiB7CiAgICAgaWYgKG1fbGF5ZXJGbHVzaFNjaGVkdWxpbmdFbmFibGVkID09 IGxheWVyRmx1c2hpbmdFbmFibGVkKQpAQCAtMjgzLDYgKzI3NywxMiBAQCBib29sIExheWVyVHJl ZUNvb3JkaW5hdG9yOjpmbHVzaFBlbmRpbmdMYXllckNoYW5nZXMoKQogCiAgICAgZmx1c2hQZW5k aW5nSW1hZ2VCYWNraW5nQ2hhbmdlcygpOwogCisgICAgaWYgKG1fc2hvdWxkU3luY1Jvb3RMYXll cikgeworICAgICAgICBtX3dlYlBhZ2UtPnNlbmQoTWVzc2FnZXM6OkxheWVyVHJlZUNvb3JkaW5h dG9yUHJveHk6OlNldFJvb3RDb21wb3NpdGluZ0xheWVyKHRvQ29vcmRpbmF0ZWRHcmFwaGljc0xh eWVyKG1fcm9vdExheWVyLmdldCgpKS0+aWQoKSkpOworICAgICAgICBtX3Nob3VsZFN5bmNSb290 TGF5ZXIgPSBmYWxzZTsKKyAgICAgICAgbV9zaG91bGRTeW5jRnJhbWUgPSB0cnVlOworICAgIH0K KwogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbV9kZXRhY2hlZExheWVycy5zaXplKCk7ICsr aSkKICAgICAgICAgbV93ZWJQYWdlLT5zZW5kKE1lc3NhZ2VzOjpMYXllclRyZWVDb29yZGluYXRv clByb3h5OjpEZWxldGVDb21wb3NpdGluZ0xheWVyKG1fZGV0YWNoZWRMYXllcnNbaV0pKTsKICAg ICBtX2RldGFjaGVkTGF5ZXJzLmNsZWFyKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVDb29yZGluYXRv ci5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvTGF5ZXJUcmVlQ29vcmRpbmF0b3IuaAppbmRleCBlMDlmZTNhYmE3YWZlZTA2NTY2NDUxYzRm NDk4ODY2NTJhZWNkODE0Li40ZDI5NTIzOWI3ZDM4MTJmMTk4YjQ0YzE2NzA1NzAxOWJlNjFiMTQ2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0 ZWRHcmFwaGljcy9MYXllclRyZWVDb29yZGluYXRvci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZUNvb3JkaW5hdG9y LmgKQEAgLTEzNSw3ICsxMzUsNiBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgUGFzc093blB0cjxX ZWJDb3JlOjpHcmFwaGljc0xheWVyPiBjcmVhdGVHcmFwaGljc0xheWVyKFdlYkNvcmU6OkdyYXBo aWNzTGF5ZXJDbGllbnQqKSBPVkVSUklERTsKIAogICAgIC8vIExheWVyVHJlZUNvb3JkaW5hdG9y Ci0gICAgdm9pZCBpbml0aWFsaXplUm9vdENvbXBvc2l0aW5nTGF5ZXIoKTsKICAgICB2b2lkIGNy ZWF0ZVBhZ2VPdmVybGF5TGF5ZXIoKTsKICAgICB2b2lkIGRlc3Ryb3lQYWdlT3ZlcmxheUxheWVy KCk7CiAgICAgYm9vbCBmbHVzaFBlbmRpbmdMYXllckNoYW5nZXMoKTsKQEAgLTE5NCw2ICsxOTMs NyBAQCBwcml2YXRlOgogCiAgICAgTGF5ZXJUcmVlQ29udGV4dCBtX2xheWVyVHJlZUNvbnRleHQ7 CiAgICAgYm9vbCBtX3Nob3VsZFN5bmNGcmFtZTsKKyAgICBib29sIG1fc2hvdWxkU3luY1Jvb3RM YXllcjsKICAgICBXZWJDb3JlOjpUaW1lcjxMYXllclRyZWVDb29yZGluYXRvcj4gbV9sYXllckZs dXNoVGltZXI7CiAgICAgV2ViQ29yZTo6VGltZXI8TGF5ZXJUcmVlQ29vcmRpbmF0b3I+IG1fcmVs ZWFzZUluYWN0aXZlQXRsYXNlc1RpbWVyOwogICAgIGJvb2wgbV9sYXllckZsdXNoU2NoZWR1bGlu Z0VuYWJsZWQ7Cg==