104259 2012-12-06 06:51:57 -0800 Fix webgl-depth-texture.html to match the test expectation 2012-12-07 15:07:55 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 102991 1 kalyan.kondapally kalyan.kondapally dino gman kbr kenneth lucas.de.marchi webkit.review.bot yael zmo oldest_to_newest 784911 0 kalyan.kondapally 2012-12-06 06:51:57 -0800 The text expectation for this testcase expects to check for FrameBuffer status after creating the framebuffer. 784931 1 178010 kalyan.kondapally 2012-12-06 07:22:32 -0800 Created attachment 178010 patch 784934 2 webkit.review.bot 2012-12-06 07:24:07 -0800 Attachment 178010 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 LayoutTests/ChangeLog:13: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 784942 3 178010 kalyan.kondapally 2012-12-06 07:45:28 -0800 Comment on attachment 178010 patch will update a new patch 784954 4 178015 kalyan.kondapally 2012-12-06 08:09:58 -0800 Created attachment 178015 patch 786207 5 178015 kbr 2012-12-07 15:03:06 -0800 Comment on attachment 178015 patch The basic problem seems to be that Intel's driver reports the framebuffer as complete after adding only the depth or depth/stencil texture, and the test only asserts that the FBO is complete if it was incomplete with just that attachment. The change to the test matches the current expectations for all the ports, so it seems OK. I will take care of upstreaming this change to the Khronos WebGL repo. r=me 786211 6 178015 webkit.review.bot 2012-12-07 15:07:50 -0800 Comment on attachment 178015 patch Clearing flags on attachment: 178015 Committed r136990: <http://trac.webkit.org/changeset/136990> 786212 7 webkit.review.bot 2012-12-07 15:07:55 -0800 All reviewed patches have been landed. Closing bug. 178010 2012-12-06 07:22:32 -0800 2012-12-06 07:45:28 -0800 patch webgldepthtexturecase.patch text/plain 1846 kalyan.kondapally ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0YWZhMWMzLi5kNjE5MzA3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTIt MDYgIEtvbmRhcGFsbHkgS2FseWFuICA8a2FseWFuLmtvbmRhcGFsbHlAaW50ZWwuY29tPgorCisg ICAgICAgIEZpeCB3ZWJnbC1kZXB0aC10ZXh0dXJlLmh0bWwgdG8gbWF0Y2ggdGhlIHRlc3QgZXhw ZWN0YXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDQyNTkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIHRleHQgZXhwZWN0YXRpb24gb2YgdGhpcyB0ZXN0Y2FzZSBleHBlY3RzIHRvIGNoZWNr IGZvciBGcmFtZUJ1ZmZlciBzdGF0dXMgYW5kIGNvbXBhcmUgdGhlIHZhbHVlCisgICAgICAgIHVz aW5nIFNob3VsZEJlIGFmdGVyIGNyZWF0aW5nIHRoZSBmcmFtZWJ1ZmZlci4KKyAgICAgICAgQ3Vy cmVudGx5LCB3ZSBkbyBpdCBvbmx5IGluIGNhc2Ugb2YgYWRkaW5nIGEgY29sb3IgYnVmZmVyLiBU aGlzIHBhdGNoIGVuc3VyZXMgdGhhdCB0aGUgRnJhbWVidWZmZXIKKyAgICAgICAgU3RhdHVzIGNo ZWNrIHVzaW5nIFNob3VsZEJlIGlzIGRvbmUgaW4gYWxsIGNhc2VzLgorCisgICAgICAgICogZmFz dC9jYW52YXMvd2ViZ2wvd2ViZ2wtZGVwdGgtdGV4dHVyZS5odG1sCisKIDIwMTItMTItMDUgIFph biBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KIAogICAgICAgICBUdXJuIHBpeGVs IHRlc3RzIGluIGZhc3QvbWVkaWEgaW50byByZWZ0ZXN0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9jYW52YXMvd2ViZ2wvd2ViZ2wtZGVwdGgtdGV4dHVyZS5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9jYW52YXMvd2ViZ2wvd2ViZ2wtZGVwdGgtdGV4dHVyZS5odG1sCmluZGV4IDc4Yzkz YjAuLjA3ZTJhNTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL3dl YmdsLWRlcHRoLXRleHR1cmUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJn bC93ZWJnbC1kZXB0aC10ZXh0dXJlLmh0bWwKQEAgLTIyMCw4ICsyMjAsOSBAQCBmdW5jdGlvbiBy dW5UZXN0RXh0ZW5zaW9uKCkgewogICAgICAgICAgICAgZ2wudGV4UGFyYW1ldGVyaShnbC5URVhU VVJFXzJELCBnbC5URVhUVVJFX01BR19GSUxURVIsIGdsLkxJTkVBUik7CiAgICAgICAgICAgICBn bC50ZXhJbWFnZTJEKGdsLlRFWFRVUkVfMkQsIDAsIGdsLlJHQkEsIHJlcywgcmVzLCAwLCBnbC5S R0JBLCBnbC5VTlNJR05FRF9CWVRFLCBudWxsKTsKICAgICAgICAgICAgIGdsLmZyYW1lYnVmZmVy VGV4dHVyZTJEKGdsLkZSQU1FQlVGRkVSLCBnbC5DT0xPUl9BVFRBQ0hNRU5UMCwgZ2wuVEVYVFVS RV8yRCwgY29sb3JUZXgsIDApOwotICAgICAgICAgICAgc2hvdWxkQmUoJ2dsLmNoZWNrRnJhbWVi dWZmZXJTdGF0dXMoZ2wuRlJBTUVCVUZGRVIpJywgJ2dsLkZSQU1FQlVGRkVSX0NPTVBMRVRFJyk7 CiAgICAgICAgIH0KKyAgICAgICAgCisgICAgICAgIHNob3VsZEJlKCdnbC5jaGVja0ZyYW1lYnVm ZmVyU3RhdHVzKGdsLkZSQU1FQlVGRkVSKScsICdnbC5GUkFNRUJVRkZFUl9DT01QTEVURScpOwog CiAgICAgICAgIC8vIHVzZSB0aGUgZGVmYXVsdCB0ZXh0dXJlIHRvIHJlbmRlciB3aXRoIHdoaWxl IHdlIHJldHVybiB0byB0aGUgZGVwdGggdGV4dHVyZS4KICAgICAgICAgZ2wuYmluZFRleHR1cmUo Z2wuVEVYVFVSRV8yRCwgbnVsbCk7Cg== 178015 2012-12-06 08:09:58 -0800 2012-12-07 15:07:50 -0800 patch webgldepthtexturecase.patch text/plain 1847 kalyan.kondapally ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0YWZhMWMzLi4zMmZkOWIxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTIt MDYgIEtvbmRhcGFsbHkgS2FseWFuICA8a2FseWFuLmtvbmRhcGFsbHlAaW50ZWwuY29tPgorCisg ICAgICAgIEZpeCB3ZWJnbC1kZXB0aC10ZXh0dXJlLmh0bWwgdG8gbWF0Y2ggdGhlIHRlc3QgZXhw ZWN0YXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDQyNTkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIHRleHQgZXhwZWN0YXRpb24gb2YgdGhpcyB0ZXN0Y2FzZSBleHBlY3RzIHRvIGNoZWNr IGZvciBGcmFtZUJ1ZmZlciBzdGF0dXMgYW5kIGNvbXBhcmUgdGhlIHZhbHVlCisgICAgICAgIHVz aW5nIFNob3VsZEJlIGFmdGVyIGNyZWF0aW5nIHRoZSBmcmFtZWJ1ZmZlci4KKyAgICAgICAgQ3Vy cmVudGx5LCB3ZSBkbyBpdCBvbmx5IGluIGNhc2Ugb2YgYWRkaW5nIGEgY29sb3IgYnVmZmVyLiBU aGlzIHBhdGNoIGVuc3VyZXMgdGhhdCB0aGUgRnJhbWVidWZmZXIKKyAgICAgICAgU3RhdHVzIGNo ZWNrIHVzaW5nIFNob3VsZEJlIGlzIGRvbmUgaW4gYWxsIGNhc2VzLgorCisgICAgICAgICogZmFz dC9jYW52YXMvd2ViZ2wvd2ViZ2wtZGVwdGgtdGV4dHVyZS5odG1sOgorCiAyMDEyLTEyLTA1ICBa YW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgVHVybiBwaXhl bCB0ZXN0cyBpbiBmYXN0L21lZGlhIGludG8gcmVmdGVzdHMKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvY2FudmFzL3dlYmdsL3dlYmdsLWRlcHRoLXRleHR1cmUuaHRtbCBiL0xheW91dFRl c3RzL2Zhc3QvY2FudmFzL3dlYmdsL3dlYmdsLWRlcHRoLXRleHR1cmUuaHRtbAppbmRleCA3OGM5 M2IwLi4wN2UyYTU0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC93 ZWJnbC1kZXB0aC10ZXh0dXJlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2Vi Z2wvd2ViZ2wtZGVwdGgtdGV4dHVyZS5odG1sCkBAIC0yMjAsOCArMjIwLDkgQEAgZnVuY3Rpb24g cnVuVGVzdEV4dGVuc2lvbigpIHsKICAgICAgICAgICAgIGdsLnRleFBhcmFtZXRlcmkoZ2wuVEVY VFVSRV8yRCwgZ2wuVEVYVFVSRV9NQUdfRklMVEVSLCBnbC5MSU5FQVIpOwogICAgICAgICAgICAg Z2wudGV4SW1hZ2UyRChnbC5URVhUVVJFXzJELCAwLCBnbC5SR0JBLCByZXMsIHJlcywgMCwgZ2wu UkdCQSwgZ2wuVU5TSUdORURfQllURSwgbnVsbCk7CiAgICAgICAgICAgICBnbC5mcmFtZWJ1ZmZl clRleHR1cmUyRChnbC5GUkFNRUJVRkZFUiwgZ2wuQ09MT1JfQVRUQUNITUVOVDAsIGdsLlRFWFRV UkVfMkQsIGNvbG9yVGV4LCAwKTsKLSAgICAgICAgICAgIHNob3VsZEJlKCdnbC5jaGVja0ZyYW1l YnVmZmVyU3RhdHVzKGdsLkZSQU1FQlVGRkVSKScsICdnbC5GUkFNRUJVRkZFUl9DT01QTEVURScp OwogICAgICAgICB9CisgICAgICAgIAorICAgICAgICBzaG91bGRCZSgnZ2wuY2hlY2tGcmFtZWJ1 ZmZlclN0YXR1cyhnbC5GUkFNRUJVRkZFUiknLCAnZ2wuRlJBTUVCVUZGRVJfQ09NUExFVEUnKTsK IAogICAgICAgICAvLyB1c2UgdGhlIGRlZmF1bHQgdGV4dHVyZSB0byByZW5kZXIgd2l0aCB3aGls ZSB3ZSByZXR1cm4gdG8gdGhlIGRlcHRoIHRleHR1cmUuCiAgICAgICAgIGdsLmJpbmRUZXh0dXJl KGdsLlRFWFRVUkVfMkQsIG51bGwpOwo=