104253 2012-12-06 04:59:22 -0800 [Chromium] Enable CSS3 background-position offset by default. 2012-12-07 12:35:55 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED WebExposed P2 Normal --- 37514 1 menard menard abarth dglazkov fishd ojan syoichi tony webkit.review.bot oldest_to_newest 784859 0 menard 2012-12-06 04:59:22 -0800 [Chromium] Enable CSS3 background-position offset by default. 784860 1 177995 menard 2012-12-06 05:01:42 -0800 Created attachment 177995 Patch 784863 2 177996 menard 2012-12-06 05:06:28 -0800 Created attachment 177996 Patch 784864 3 menard 2012-12-06 05:09:37 -0800 (In reply to comment #2) > Created an attachment (id=177996) [details] > Patch For the record it is enabled on other ports for some days : Mac, Qt, EFL and GTK. Also as per discussion http://lists.webkit.org/pipermail/webkit-dev/2012-December/023064.html where we decided that when it's ready we'll remove the feature flag (as it is not a major feature). I believe that it's time for it to run on Chromium as well so I can look the bots and remove the feature flag if no problems show up. It is tracked by https://bugs.webkit.org/show_bug.cgi?id=37514 784967 4 abarth 2012-12-06 08:51:31 -0800 I'll defer to Ojan and/or Tony on this one. They likely have more context here. 784975 5 menard 2012-12-06 09:09:21 -0800 (In reply to comment #4) > I'll defer to Ojan and/or Tony on this one. They likely have more context here. I would also need to rebase a few files on Chromium expected files just as http://trac.webkit.org/changeset/136844 and http://trac.webkit.org/changeset/136847. There were broken expected result anyway. Any pointers on how I can do that on all supported Chromium platforms? 784977 6 abarth 2012-12-06 09:13:02 -0800 > Any pointers on how I can do that on all supported Chromium platforms? Practically speaking, you'll need to land your patch first and then use garden-o-matic. 785114 7 177996 webkit.review.bot 2012-12-06 11:54:45 -0800 Comment on attachment 177996 Patch Attachment 177996 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15174364 New failing tests: ietestcenter/css3/bordersbackgrounds/background_position_three_four_values.htm svg/hixie/intrinsic/003.html css2.1/20110323/replaced-intrinsic-003.htm 786059 8 177996 menard 2012-12-07 12:35:49 -0800 Comment on attachment 177996 Patch Clearing flags on attachment: 177996 Committed r136970: <http://trac.webkit.org/changeset/136970> 786060 9 menard 2012-12-07 12:35:55 -0800 All reviewed patches have been landed. Closing bug. 177995 2012-12-06 05:01:42 -0800 2012-12-06 05:06:22 -0800 Patch bug-104253-20121206095905.patch text/plain 1270 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDAzZjk4ZjY5MGE3M2YzZTEzODI5YWUwNTYxMDc5ZjE5ZWU1NzkxNzYuLmNlN2U2YjA3ZDBjNDYy MmU3M2ZlNWE1MTU3ZmE4ZDk5N2M4NDJiNGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMTItMDYgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXNAd2Via2l0 Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEVuYWJsZSBDU1MzIGJhY2tncm91bmQtcG9zaXRp b24gb2Zmc2V0IGJ5IGRlZmF1bHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDQyNTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUdXJuIG9uIHRoZSBmZWF0dXJlIGJ5IGRlZmF1bHQuCisKKyAgICAgICAg KiBmZWF0dXJlcy5neXBpOgorCiAyMDEyLTEyLTA2ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZp ZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTM2 Nzg0IGFuZCByMTM2ODAyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0 dXJlcy5neXBpIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCmluZGV4IDIw ZmI4ZDExN2Y4YzUzZjA5OGZjNmNiNTVkNDNkZmZiZDQzMDBhMjcuLmM1MmQ0NGQ4ZjQ1YWQyZWRi M2JmMmM5NGZjODk0NjlhNzIyYmQyZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vZmVhdHVyZXMuZ3lwaQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5 cGkKQEAgLTM4LDcgKzM4LDcgQEAKICAgICAgICdFTkFCTEVfQkxPQl9TTElDRT0xJywKICAgICAg ICdFTkFCTEVfQ0hBTk5FTF9NRVNTQUdJTkc9MScsCiAgICAgICAnRU5BQkxFX0NTUF9ORVhUPTEn LAotICAgICAgJ0VOQUJMRV9DU1MzX0JBQ0tHUk9VTkQ9MCcsCisgICAgICAnRU5BQkxFX0NTUzNf QkFDS0dST1VORD0xJywKICAgICAgICdFTkFCTEVfQ1NTM19DT05ESVRJT05BTF9SVUxFUz0wJywK ICAgICAgICdFTkFCTEVfQ1NTM19URVhUPTAnLAogICAgICAgJ0VOQUJMRV9DU1NfQk9YX0RFQ09S QVRJT05fQlJFQUs9MScsCg== 177996 2012-12-06 05:06:28 -0800 2012-12-07 12:35:49 -0800 Patch bug-104253-20121206100352.patch text/plain 2845 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDAzZjk4ZjY5MGE3M2YzZTEzODI5YWUwNTYxMDc5ZjE5ZWU1NzkxNzYuLmNlN2U2YjA3ZDBjNDYy MmU3M2ZlNWE1MTU3ZmE4ZDk5N2M4NDJiNGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMTItMDYgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXNAd2Via2l0 Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEVuYWJsZSBDU1MzIGJhY2tncm91bmQtcG9zaXRp b24gb2Zmc2V0IGJ5IGRlZmF1bHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDQyNTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUdXJuIG9uIHRoZSBmZWF0dXJlIGJ5IGRlZmF1bHQuCisKKyAgICAgICAg KiBmZWF0dXJlcy5neXBpOgorCiAyMDEyLTEyLTA2ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZp ZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTM2 Nzg0IGFuZCByMTM2ODAyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0 dXJlcy5neXBpIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCmluZGV4IDIw ZmI4ZDExN2Y4YzUzZjA5OGZjNmNiNTVkNDNkZmZiZDQzMDBhMjcuLmM1MmQ0NGQ4ZjQ1YWQyZWRi M2JmMmM5NGZjODk0NjlhNzIyYmQyZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vZmVhdHVyZXMuZ3lwaQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5 cGkKQEAgLTM4LDcgKzM4LDcgQEAKICAgICAgICdFTkFCTEVfQkxPQl9TTElDRT0xJywKICAgICAg ICdFTkFCTEVfQ0hBTk5FTF9NRVNTQUdJTkc9MScsCiAgICAgICAnRU5BQkxFX0NTUF9ORVhUPTEn LAotICAgICAgJ0VOQUJMRV9DU1MzX0JBQ0tHUk9VTkQ9MCcsCisgICAgICAnRU5BQkxFX0NTUzNf QkFDS0dST1VORD0xJywKICAgICAgICdFTkFCTEVfQ1NTM19DT05ESVRJT05BTF9SVUxFUz0wJywK ICAgICAgICdFTkFCTEVfQ1NTM19URVhUPTAnLAogICAgICAgJ0VOQUJMRV9DU1NfQk9YX0RFQ09S QVRJT05fQlJFQUs9MScsCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTEwNmZmZDRlOWZjMzI1Y2QxZDBlMDA1ZThmOGJjNGI3 Njg5ZWExNi4uZDgyNzIzNjM3NTgxMzZjNWUxNTdiZjYyNDEwOTY2ZWQzNWNmODk4YiAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTA2ICBBbGV4aXMgTWVuYXJkICA8YWxleGlzQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBFbmFibGUgQ1NTMyBiYWNrZ3JvdW5kLXBvc2l0 aW9uIG9mZnNldCBieSBkZWZhdWx0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA0MjUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRW5hYmxlIGJ5IGRlZmF1bHQgdGhlIG5ldyBDU1MzIGJhY2tncm91bmQg cG9zaXRpb24gb2Zmc2V0cyB0aGVyZWZvcmUgd2UKKyAgICAgICAgY2FuIHVuc2tpcCB0aGUgdGVz dHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zOgorCiAy MDEyLTEyLTA2ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTM2ODE4LgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZjhiYjAyYjk3MTRiM2Zm OGIxOTUzMDFmMjMzYzMzZTdlZDE4ZWJkYS4uNDEyZWMxYmQ3ODQxNDMwNjk5NTRlOGM1Njc5MGQ2 YmRiOWJmZWExNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVz dEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhw ZWN0YXRpb25zCkBAIC0yMTUsMTAgKzIxNSw2IEBAIHdlYmtpdC5vcmcvYi84OTA1MiBmYXN0L2Nz cy9pbWFnZS1vcmllbnRhdGlvbgogd2Via2l0Lm9yZy9iLzU4NDkxIGZhc3QvY3NzMy10ZXh0L2Nz czMtdGV4dC1kZWNvcmF0aW9uCiB3ZWJraXQub3JnL2IvNzYxNzMgZmFzdC9jc3MzLXRleHQvY3Nz My10ZXh0LWFsaWduLWxhc3QKIAotIyBDU1MzIEJhY2tncm91bmQgaXMgbm90IHlldCBlbmFibGVk IChuZWVkcyBFTkFCTEVfQ1NTM19CQUNLR1JPVU5EKS4KLXdlYmtpdC5vcmcvYi8zNzUxNCBmYXN0 L2JhY2tncm91bmRzL2JhY2tncm91bmQtcG9zaXRpb24tcGFyc2luZy0yLmh0bWwgWyBUZXh0IF0K LXdlYmtpdC5vcmcvYi8zNzUxNCBmYXN0L2JhY2tncm91bmRzL2JhY2tncm91bmQtcG9zaXRpb24t cmVuZGVyaW5nLmh0bWwgWyBJbWFnZSBdCi0KICMgQ2hyb21pdW0gZG9lcyBub3Qgc3VwcG9ydCBz bWFydCBwYXN0aW5nIGluIHRleHQgY29udHJvbHMgeWV0Lgogd2Via2l0Lm9yZy9iLzYwODMwIGVk aXRpbmcvcGFzdGVib2FyZC9zbWFydC1wYXN0ZS1pbi10ZXh0LWNvbnRyb2wuaHRtbAogCg==