104248 2012-12-06 03:19:40 -0800 [EFL] Active texture state gets corrupted after updating graphics surface contents 2012-12-06 04:33:02 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 102991 1 kalyan.kondapally kalyan.kondapally kenneth lucas.de.marchi webkit.review.bot oldest_to_newest 784816 0 kalyan.kondapally 2012-12-06 03:19:40 -0800 GraphicsContext3DPrivate::copyToGraphicsSurface() doesn't restore the previously bound texture after copying m_texture contents. This corrupts the texture state. Running fast/canvas/webgl/webgl-texture-binding-preserved.html test, highlights this issue. 784831 1 177990 kalyan.kondapally 2012-12-06 04:01:14 -0800 Created attachment 177990 TextureStateFix 784848 2 177990 webkit.review.bot 2012-12-06 04:32:58 -0800 Comment on attachment 177990 TextureStateFix Clearing flags on attachment: 177990 Committed r136832: <http://trac.webkit.org/changeset/136832> 784849 3 webkit.review.bot 2012-12-06 04:33:02 -0800 All reviewed patches have been landed. Closing bug. 177990 2012-12-06 04:01:14 -0800 2012-12-06 04:32:58 -0800 TextureStateFix textureissue.patch text/plain 4180 kalyan.kondapally ZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDdmN2M1OTUuLjRjZjBiYzEgMTAwNjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEy LTEyLTA2ICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4K KworICAgICAgICBbRUZMXSBBY3RpdmUgdGV4dHVyZSBzdGF0ZSBnZXRzIGNvcnJ1cHRlZCBhZnRl ciB1cGRhdGluZyBncmFwaGljcyBzdXJmYWNlIGNvbnRlbnRzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0MjQ4LgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6 Y29weVRvR3JhcGhpY3NTdXJmYWNlKCkgZG9lc24ndCByZXN0b3JlIHRoZSBwcmV2aW91c2x5IGJv dW5kIHRleHR1cmUKKyAgICAgICAgYWZ0ZXIgY29weWluZyB0ZXh0dXJlIGNvbnRlbnRzLiBUaGlz IGNvcnJ1cHRzIHRoZSB0ZXh0dXJlIHN0YXRlLgorCisgICAgICAgIEV4aXN0aW5nIFRlc3RzIHNo b3VsZCBjb3ZlciB0aGlzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZWZsL0dyYXBo aWNzQ29udGV4dDNEUHJpdmF0ZS5jcHA6CisgICAgICAgIChHcmFwaGljc0NvbnRleHQzRFByaXZh dGU6OmNvcHlUb0dyYXBoaWNzU3VyZmFjZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv b3BlbmdsL0dMUGxhdGZvcm1TdXJmYWNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdMUGxhdGZv cm1TdXJmYWNlOjp1cGRhdGVDb250ZW50cyk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv b3BlbmdsL0dMUGxhdGZvcm1TdXJmYWNlLmg6CisgICAgICAgIChHTFBsYXRmb3JtU3VyZmFjZSk6 CisKIDIwMTItMTItMDUgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CiAK ICAgICAgICAgW0VGTF1bV0syXSBJbnRyb2R1Y2UgV2ViS2l0LUVGTCB0byBBc3Npc3RpdmUgVGVj aG5vbG9naWVzCmRpZmYgLS1naXQgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWZs L0dyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZS5jcHAgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZWZsL0dyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZS5jcHAKaW5kZXggYzlmYzRhMC4uMThl MTZiMSAxMDA2NDQKLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VmbC9HcmFw aGljc0NvbnRleHQzRFByaXZhdGUuY3BwCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9lZmwvR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlLmNwcApAQCAtMTU0LDcgKzE1NCw3IEBA IHVpbnQzMl90IEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6Y29weVRvR3JhcGhpY3NTdXJmYWNl KCkKICNlbmRpZgogICAgIH0KIAotICAgIG1fcGxhdGZvcm1TdXJmYWNlLT51cGRhdGVDb250ZW50 cyhtX2NvbnRleHQtPm1fdGV4dHVyZSwgSW50UmVjdCgwLCAwLCBtX2NvbnRleHQtPm1fY3VycmVu dFdpZHRoLCBtX2NvbnRleHQtPm1fY3VycmVudEhlaWdodCksIG1fY29udGV4dC0+bV9ib3VuZEZC Tyk7CisgICAgbV9wbGF0Zm9ybVN1cmZhY2UtPnVwZGF0ZUNvbnRlbnRzKG1fY29udGV4dC0+bV90 ZXh0dXJlLCBJbnRSZWN0KDAsIDAsIG1fY29udGV4dC0+bV9jdXJyZW50V2lkdGgsIG1fY29udGV4 dC0+bV9jdXJyZW50SGVpZ2h0KSwgbV9jb250ZXh0LT5tX2JvdW5kRkJPLCBtX2NvbnRleHQtPm1f Ym91bmRUZXh0dXJlMCk7CiAgICAgcmV0dXJuIDA7CiB9CiAKZGlmZiAtLWdpdCBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQbGF0Zm9ybVN1cmZhY2UuY3BwIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HTFBsYXRmb3JtU3VyZmFjZS5jcHAK aW5kZXggZGVjYjE2Ny4uNzZlODAxOSAxMDA2NDQKLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL29wZW5nbC9HTFBsYXRmb3JtU3VyZmFjZS5jcHAKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HTFBsYXRmb3JtU3VyZmFjZS5jcHAKQEAgLTEyOSw3 ICsxMjksNyBAQCB2b2lkIEdMUGxhdGZvcm1TdXJmYWNlOjpjb3B5VGV4dHVyZSh1aW50MzJfdCB0 ZXh0dXJlLCBjb25zdCBJbnRSZWN0JiBzb3VyY2VSZWN0KQogICAgIGdsUG9wQXR0cmliKCk7CiB9 CiAKLXZvaWQgR0xQbGF0Zm9ybVN1cmZhY2U6OnVwZGF0ZUNvbnRlbnRzKHVpbnQzMl90IHRleHR1 cmUsIGNvbnN0IEludFJlY3QmIHNvdXJjZVJlY3QsIGNvbnN0IEdMdWludCBiaW5kRmJvSWQpCit2 b2lkIEdMUGxhdGZvcm1TdXJmYWNlOjp1cGRhdGVDb250ZW50cyhjb25zdCB1aW50MzJfdCB0ZXh0 dXJlLCBjb25zdCBJbnRSZWN0JiBzb3VyY2VSZWN0LCBjb25zdCBHTHVpbnQgYmluZEZib0lkLCBj b25zdCB1aW50MzJfdCBiaW5kVGV4dHVyZSkKIHsKICAgICBtX3Jlc3RvcmVOZWVkZWQgPSBmYWxz ZTsKIApAQCAtMTQ4LDcgKzE0OCw3IEBAIHZvaWQgR0xQbGF0Zm9ybVN1cmZhY2U6OnVwZGF0ZUNv bnRlbnRzKHVpbnQzMl90IHRleHR1cmUsIGNvbnN0IEludFJlY3QmIHNvdXJjZVJlCiAgICAgZ2xC bGl0RnJhbWVidWZmZXIoeCwgeSwgd2lkdGgsIGhlaWdodCwgeCwgeSwgd2lkdGgsIGhlaWdodCwg R0xfQ09MT1JfQlVGRkVSX0JJVCwgR0xfTElORUFSKTsKICAgICBzd2FwQnVmZmVycygpOwogICAg IGdsRnJhbWVidWZmZXJUZXh0dXJlMkQoR0xfUkVBRF9GUkFNRUJVRkZFUiwgR0xfQ09MT1JfQVRU QUNITUVOVDAsIEdMX1RFWFRVUkVfMkQsIDAsIDApOwotICAgIGdsQmluZFRleHR1cmUoR0xfVEVY VFVSRV8yRCwgMCk7CisgICAgZ2xCaW5kVGV4dHVyZShHTF9URVhUVVJFXzJELCBiaW5kVGV4dHVy ZSk7CiAgICAgZ2xCaW5kRnJhbWVidWZmZXIoR0xfRlJBTUVCVUZGRVIsIGJpbmRGYm9JZCk7CiB9 CiAKZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQ bGF0Zm9ybVN1cmZhY2UuaCBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wv R0xQbGF0Zm9ybVN1cmZhY2UuaAppbmRleCBmMTA2NmI3Li5iNDExMTMyIDEwMDY0NAotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dMUGxhdGZvcm1TdXJmYWNlLmgK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HTFBsYXRmb3JtU3Vy ZmFjZS5oCkBAIC02MCwxMiArNjAsMTIgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCB2b2lkIGNv cHlUZXh0dXJlKHVpbnQzMl90IHRleHR1cmUsIGNvbnN0IEludFJlY3QmIHNvdXJjZVJlY3QpOwog Ci0gICAgLy8gQ29udmVuaWVuY2UgRnVuY3Rpb24gdG8gdXBkYXRlIHN1cmZhY2UgYmFja2J1ZmZl ciB3aXRoIHRleHR1cmUgY29udGVudHMgYW5kIHJlc3RvcmUgY3VycmVudCBGQk8uCisgICAgLy8g Q29udmVuaWVuY2UgRnVuY3Rpb24gdG8gdXBkYXRlIHN1cmZhY2UgYmFja2J1ZmZlciB3aXRoIHRl eHR1cmUgY29udGVudHMsIHJlc3RvcmUgY3VycmVudCBGQk8gYW5kIFRleHR1cmUuCiAgICAgLy8g RnVuY3Rpb24gZG9lcyB0aGUgZm9sbG93aW5nKGluIG9yZGVyKToKICAgICAvLyBhKUJsaXRzIHRl eHR1cmUgY29udGVudHMgdG8gYmFjayBidWZmZXIuCiAgICAgLy8gYilDYWxscyBTd2FwIEJ1ZmZl cnMuCi0gICAgLy8gYylTZXRzIGN1cnJlbnQgRkJPIGFzIGJpbmRGYm9JZC4KLSAgICB2aXJ0dWFs IHZvaWQgdXBkYXRlQ29udGVudHModWludDMyX3QgdGV4dHVyZSwgY29uc3QgSW50UmVjdCYgc291 cmNlUmVjdCwgY29uc3QgR0x1aW50IGJpbmRGYm9JZCk7CisgICAgLy8gYylTZXRzIGN1cnJlbnQg RkJPIGFzIGJpbmRGYm9JZCBhbmQgYmluZHMgdGV4dHVyZSB0byBiaW5kVGV4dHVyZS4KKyAgICB2 aXJ0dWFsIHZvaWQgdXBkYXRlQ29udGVudHMoY29uc3QgdWludDMyX3QgdGV4dHVyZSwgY29uc3Qg SW50UmVjdCYgc291cmNlUmVjdCwgY29uc3QgR0x1aW50IGJpbmRGYm9JZCwgY29uc3QgdWludDMy X3QgYmluZFRleHR1cmUpOwogCiAgICAgdmlydHVhbCB2b2lkIHNldEdlb21ldHJ5KGNvbnN0IElu dFJlY3QmIG5ld1JlY3QpOwogCg==