104239 2012-12-06 01:46:52 -0800 [V8] Make an Isolate mandatory in v8String() 2013-01-23 05:17:31 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 107540 P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 784761 0 haraken 2012-12-06 01:46:52 -0800 This will slightly speed up v8String(). 784768 1 177973 haraken 2012-12-06 01:51:26 -0800 Created attachment 177973 Patch 784962 2 177973 abarth 2012-12-06 08:42:14 -0800 Comment on attachment 177973 Patch LGTM, but this looks to be causing IDB crashes. 785407 3 haraken 2012-12-06 16:36:47 -0800 SerializedScriptValue has methods like xxx(Isolate* isolate = 0), and the methods can pass 0 to v8Integer() or v8String(). We need to kill an optional isolate parameter first and guarantee that an isolate is not 0. 814123 4 haraken 2013-01-23 05:17:31 -0800 *** This bug has been marked as a duplicate of bug 107540 *** 177973 2012-12-06 01:51:26 -0800 2012-12-06 08:42:14 -0800 Patch bug-104239-20121206184851.patch text/plain 4546 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjAxNTg5YmY3MGQ4NzM0 ZDU1NWZjZTgzNWU5NTc0NzhlOWI3NjEwZS4uNTNmOWVjZmE4OTgxMDY3MjE5NDBlOWE0OTU3YjQ0 MTE2YWNiZDhiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTEyLTA2ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIE1ha2UgYW4g SXNvbGF0ZSBtYW5kYXRvcnkgaW4gdjhTdHJpbmcoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0MjM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSSBjb3VsZG4ndCBjb25maXJtIGFueSBwZXJmb3JtYW5j ZSBpbXByb3ZlbWVudC4KKyAgICAgICAgVGhpcyB3b3VsZCBiZSBiZWNhdXNlIElzV2VhaygpIGFu ZCBMb2NhbDxUPjo6TmV3KCkgaW5zaWRlIHY4U3RyaW5nKCkKKyAgICAgICAgc3RpbGwgbmVlZCB0 byBsb29rIHVwIGFuIElzb2xhdGUuIFRoaXMgd2lsbCBiZSBmaXhlZCBzb29uLgorCisgICAgICAg ICogYmluZGluZ3MvdjgvVjhCaW5kaW5nLmg6CisgICAgICAgIChXZWJDb3JlOjp2OFN0cmluZyk6 CisgICAgICAgICogYmluZGluZ3MvdjgvVjhXaW5kb3dFcnJvckhhbmRsZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6VjhXaW5kb3dFcnJvckhhbmRsZXI6OmNhbGxMaXN0ZW5lckZ1bmN0aW9uKToK KyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFdvcmtlckNvbnRleHRFcnJvckhhbmRsZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6VjhXb3JrZXJDb250ZXh0RXJyb3JIYW5kbGVyOjpjYWxsTGlzdGVu ZXJGdW5jdGlvbik6CisKKzIwMTItMTItMDYgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21p dW0ub3JnPgorCiAgICAgICAgIFVucmV2aWV3ZWQuIEZpeGVkIGEgd3JvbmcgY29tbWVudCBsYW5k ZWQgaW4gcjEzNjgyMi4KIAogICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5oOgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmggYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaAppbmRleCA2OWQwZTY0MWYwZDEwY2MyZjEx NjI3ZTVlMGY2NzY4MTBiMTFjMjkwLi4zYjgwZWRhZDFhYjE0NjA3YjMwYzk4MzQxZGU4ODA3NTY0 MWY4M2JjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaApAQCAtMTQ1LDEw ICsxNDUsOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgLy8gUmV0dXJuIGEgVjggZXh0ZXJu YWwgc3RyaW5nIHRoYXQgc2hhcmVzIHRoZSB1bmRlcmx5aW5nIGJ1ZmZlciB3aXRoIHRoZSBnaXZl bgogICAgIC8vIFdlYkNvcmUgc3RyaW5nLiBUaGUgcmVmZXJlbmNlIGNvdW50aW5nIG1lY2hhbmlz bSBpcyB1c2VkIHRvIGtlZXAgdGhlCiAgICAgLy8gdW5kZXJseWluZyBidWZmZXIgYWxpdmUgd2hp bGUgdGhlIHN0cmluZyBpcyBzdGlsbCBsaXZlIGluIHRoZSBWOCBlbmdpbmUuCi0gICAgaW5saW5l IHY4OjpIYW5kbGU8djg6OlN0cmluZz4gdjhTdHJpbmcoY29uc3QgU3RyaW5nJiBzdHJpbmcsIHY4 OjpJc29sYXRlKiBpc29sYXRlID0gMCkKKyAgICBpbmxpbmUgdjg6OkhhbmRsZTx2ODo6U3RyaW5n PiB2OFN0cmluZyhjb25zdCBTdHJpbmcmIHN0cmluZywgdjg6Oklzb2xhdGUqIGlzb2xhdGUpCiAg ICAgewotICAgICAgICBpZiAoVU5MSUtFTFkoIWlzb2xhdGUpKQotICAgICAgICAgICAgaXNvbGF0 ZSA9IHY4OjpJc29sYXRlOjpHZXRDdXJyZW50KCk7CisgICAgICAgIEFTU0VSVChpc29sYXRlKTsK ICAgICAgICAgaWYgKHN0cmluZy5pc051bGwoKSkKICAgICAgICAgICAgIHJldHVybiB2ODo6U3Ry aW5nOjpFbXB0eShpc29sYXRlKTsKICAgICAgICAgcmV0dXJuIFY4UGVySXNvbGF0ZURhdGE6OmZy b20oaXNvbGF0ZSktPnN0cmluZ0NhY2hlKCktPnY4RXh0ZXJuYWxTdHJpbmcoc3RyaW5nLmltcGwo KSwgaXNvbGF0ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFdp bmRvd0Vycm9ySGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFdpbmRv d0Vycm9ySGFuZGxlci5jcHAKaW5kZXggZTY1YTlmMjIwZjAxYjQyYTU5NTFhMTExYjQ1Y2FjNjUy YTYxYTRkNi4uMGY4ZjhlOGE1Zjc4YWEzYTJhZmVlMzQyNDc5NWYyZjg0MmViODY4OCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhXaW5kb3dFcnJvckhhbmRsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4V2luZG93RXJyb3JIYW5kbGVyLmNw cApAQCAtNTUsNyArNTUsNyBAQCB2ODo6TG9jYWw8djg6OlZhbHVlPiBWOFdpbmRvd0Vycm9ySGFu ZGxlcjo6Y2FsbExpc3RlbmVyRnVuY3Rpb24oU2NyaXB0RXhlY3V0aW9uQwogICAgIGlmICghbGlz dGVuZXIuSXNFbXB0eSgpICYmIGxpc3RlbmVyLT5Jc0Z1bmN0aW9uKCkpIHsKICAgICAgICAgdjg6 OkxvY2FsPHY4OjpGdW5jdGlvbj4gY2FsbEZ1bmN0aW9uID0gdjg6OkxvY2FsPHY4OjpGdW5jdGlv bj46OkNhc3QobGlzdGVuZXIpOwogICAgICAgICB2ODo6TG9jYWw8djg6Ok9iamVjdD4gdGhpc1Zh bHVlID0gdjg6OkNvbnRleHQ6OkdldEN1cnJlbnQoKS0+R2xvYmFsKCk7Ci0gICAgICAgIHY4OjpI YW5kbGU8djg6OlZhbHVlPiBwYXJhbWV0ZXJzWzNdID0geyB2OFN0cmluZyhlcnJvckV2ZW50LT5t ZXNzYWdlKCkpLCBkZXByZWNhdGVkVjhTdHJpbmcoZXJyb3JFdmVudC0+ZmlsZW5hbWUoKSksIGRl cHJlY2F0ZWRWOEludGVnZXIoZXJyb3JFdmVudC0+bGluZW5vKCkpIH07CisgICAgICAgIHY4OjpI YW5kbGU8djg6OlZhbHVlPiBwYXJhbWV0ZXJzWzNdID0geyBkZXByZWNhdGVkVjhTdHJpbmcoZXJy b3JFdmVudC0+bWVzc2FnZSgpKSwgZGVwcmVjYXRlZFY4U3RyaW5nKGVycm9yRXZlbnQtPmZpbGVu YW1lKCkpLCBkZXByZWNhdGVkVjhJbnRlZ2VyKGVycm9yRXZlbnQtPmxpbmVubygpKSB9OwogICAg ICAgICB2ODo6VHJ5Q2F0Y2ggdHJ5Q2F0Y2g7CiAgICAgICAgIHRyeUNhdGNoLlNldFZlcmJvc2Uo dHJ1ZSk7CiAgICAgICAgIHJldHVyblZhbHVlID0gU2NyaXB0Q29udHJvbGxlcjo6Y2FsbEZ1bmN0 aW9uV2l0aEluc3RydW1lbnRhdGlvbigwLCBjYWxsRnVuY3Rpb24sIHRoaXNWYWx1ZSwgMywgcGFy YW1ldGVycyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFdvcmtl ckNvbnRleHRFcnJvckhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhX b3JrZXJDb250ZXh0RXJyb3JIYW5kbGVyLmNwcAppbmRleCA2OTNiMmJhMDA1ODU4YzBmNmUwNGVi ZmM3ZjY0ZjE3NTFkZTFlZjM2Li43NDdlYjRhMzc3OWU2YTI2MTBjMDY2NTQ0NGRhNDJlYTE1ZjJm OTJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFdvcmtlckNvbnRl eHRFcnJvckhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4V29y a2VyQ29udGV4dEVycm9ySGFuZGxlci5jcHAKQEAgLTU1LDcgKzU1LDcgQEAgdjg6OkxvY2FsPHY4 OjpWYWx1ZT4gVjhXb3JrZXJDb250ZXh0RXJyb3JIYW5kbGVyOjpjYWxsTGlzdGVuZXJGdW5jdGlv bihTY3JpcHRFeGUKICAgICAgICAgRXJyb3JFdmVudCogZXJyb3JFdmVudCA9IHN0YXRpY19jYXN0 PEVycm9yRXZlbnQqPihldmVudCk7CiAgICAgICAgIHY4OjpMb2NhbDx2ODo6RnVuY3Rpb24+IGNh bGxGdW5jdGlvbiA9IHY4OjpMb2NhbDx2ODo6RnVuY3Rpb24+OjpDYXN0KGxpc3RlbmVyKTsKICAg ICAgICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IHRoaXNWYWx1ZSA9IHY4OjpDb250ZXh0OjpHZXRD dXJyZW50KCktPkdsb2JhbCgpOwotICAgICAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gcGFyYW1l dGVyc1szXSA9IHsgdjhTdHJpbmcoZXJyb3JFdmVudC0+bWVzc2FnZSgpKSwgZGVwcmVjYXRlZFY4 U3RyaW5nKGVycm9yRXZlbnQtPmZpbGVuYW1lKCkpLCBkZXByZWNhdGVkVjhJbnRlZ2VyKGVycm9y RXZlbnQtPmxpbmVubygpKSB9OworICAgICAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gcGFyYW1l dGVyc1szXSA9IHsgZGVwcmVjYXRlZFY4U3RyaW5nKGVycm9yRXZlbnQtPm1lc3NhZ2UoKSksIGRl cHJlY2F0ZWRWOFN0cmluZyhlcnJvckV2ZW50LT5maWxlbmFtZSgpKSwgZGVwcmVjYXRlZFY4SW50 ZWdlcihlcnJvckV2ZW50LT5saW5lbm8oKSkgfTsKICAgICAgICAgVjhSZWN1cnNpb25TY29wZSBy ZWN1cnNpb25TY29wZShjb250ZXh0KTsKICAgICAgICAgcmV0dXJuVmFsdWUgPSBjYWxsRnVuY3Rp b24tPkNhbGwodGhpc1ZhbHVlLCAzLCBwYXJhbWV0ZXJzKTsKICAgICB9Cg==