104236 2012-12-06 01:33:22 -0800 [V8] Make an Isolate mandatory in v8Integer() 2013-01-23 05:17:42 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 107540 P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 784751 0 haraken 2012-12-06 01:33:22 -0800 This will slightly speed up v8Integer(). 784754 1 177971 haraken 2012-12-06 01:36:19 -0800 Created attachment 177971 Patch 784963 2 177971 abarth 2012-12-06 08:42:56 -0800 Comment on attachment 177971 Patch LGTM but this appears to be causing IDB crashes. Maybe those are in the tree already? 785405 3 haraken 2012-12-06 16:36:23 -0800 (In reply to comment #2) > (From update of attachment 177971 [details]) > LGTM but this appears to be causing IDB crashes. Maybe those are in the tree already? Ah, SerializedScriptValue has methods like xxx(Isolate* isolate = 0), and the methods can pass 0 to v8Integer() or v8String(). We need to kill an optional isolate parameter first and guarantee that an isolate is not 0. 814125 4 haraken 2013-01-23 05:17:42 -0800 *** This bug has been marked as a duplicate of bug 107540 *** 177971 2012-12-06 01:36:19 -0800 2012-12-06 08:42:56 -0800 Patch bug-104236-20121206183343.patch text/plain 2396 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzVlNTAyZDZlNDU0OWZi MTcxOTBiMDFkYTU4Njk0N2U2MjFkNjhmNi4uN2IwZWQ0MjFjYTY5MmZmYTY5N2Y0ZjZkMWE4N2Yy ZDkyODY4MzQxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTA2ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1ha2UgYW4g SXNvbGF0ZSBtYW5kYXRvcnkgaW4gdjhJbnRlZ2VyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDIzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtkaXYubm9kZVR5cGVdCisgICAgICAgIEJlZm9yZSB0 aGlzIHBhdGNoOiAxMC4yNiBucworICAgICAgICBBZnRlciB0aGlzIHBhdGNoOiAgIDkuNjIgbnMK KworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICog YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisgICAgICAgIChOYXRpdmVUb0pT VmFsdWUpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5oOgorICAgICAgICAoV2Vi Q29yZTo6djhJbnRlZ2VyKToKKwogMjAxMi0xMi0wNSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XSBJbXBsZW1lbnQgZGVwcmVjYXRlZFY4U3RyaW5n KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvclY4LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y VjgucG0KaW5kZXggNzc3MDRhNjZkZTA0NWFmOWE3ZGIzZmY5NjY3ZWM3NGYyYzc1OWRiZC4uOWI1 ZjlmYjE1MzgyZmI1MWVhZjA5YzgwMmYyYWE3ZmNjMzVkNmRkYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTQwNjIsNyAr NDA2Miw2IEBAIHN1YiBOYXRpdmVUb0pTVmFsdWUKICAgICB9CiAKICAgICAjIEZvciBhbGwgdGhl IHR5cGVzIHdoZXJlIHdlIHVzZSAnaW50JyBhcyB0aGUgcmVwcmVzZW50YXRpb24gdHlwZSwKLSAg ICAjIHdlIHVzZSB2OEludGVnZXIoKSB3aGljaCBoYXMgYSBmYXN0IHNtYWxsIGludGVnZXIgY29u dmVyc2lvbiBjaGVjay4KICAgICBteSAkbmF0aXZlVHlwZSA9IEdldE5hdGl2ZVR5cGUoJHR5cGUp OwogICAgIHJldHVybiAidjhJbnRlZ2VyKCR2YWx1ZSRnZXRJc29sYXRlQXJnKSIgaWYgJG5hdGl2 ZVR5cGUgZXEgImludCI7CiAgICAgcmV0dXJuICJ2OFVuc2lnbmVkSW50ZWdlcigkdmFsdWUkZ2V0 SXNvbGF0ZUFyZykiIGlmICRuYXRpdmVUeXBlIGVxICJ1bnNpZ25lZCI7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaCBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4QmluZGluZy5oCmluZGV4IDI5MzYxMGUzMWRhZWZiMTU1Y2IyNjE3OGIwZWNh MmZlYTI0YWFhOTMuLjg0OThmNDNmMDVlZmQ5ZWMxZGNjYzA0NDdlYmFhMzNkYWEwZjhiNDcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCkBAIC0xNzYsMTAgKzE3Niw5IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgcmV0dXJuIFY4UGVySXNvbGF0ZURhdGE6OmZy b20oaXNvbGF0ZSktPnN0cmluZ0NhY2hlKCktPnY4RXh0ZXJuYWxTdHJpbmcoc3RyaW5nLmltcGwo KSwgaXNvbGF0ZSk7CiAgICAgfQogCi0gICAgaW5saW5lIHY4OjpIYW5kbGU8djg6OkludGVnZXI+ IHY4SW50ZWdlcihpbnQgdmFsdWUsIHY4OjpJc29sYXRlKiBpc29sYXRlID0gMCkKKyAgICBpbmxp bmUgdjg6OkhhbmRsZTx2ODo6SW50ZWdlcj4gdjhJbnRlZ2VyKGludCB2YWx1ZSwgdjg6Oklzb2xh dGUqIGlzb2xhdGUpCiAgICAgewotICAgICAgICBpZiAoVU5MSUtFTFkoIWlzb2xhdGUpKQotICAg ICAgICAgICAgaXNvbGF0ZSA9IHY4OjpJc29sYXRlOjpHZXRDdXJyZW50KCk7CisgICAgICAgIEFT U0VSVChpc29sYXRlKTsKICAgICAgICAgcmV0dXJuIFY4UGVySXNvbGF0ZURhdGE6OmZyb20oaXNv bGF0ZSktPmludGVnZXJDYWNoZSgpLT52OEludGVnZXIodmFsdWUsIGlzb2xhdGUpOwogICAgIH0K IAo=