104235 2012-12-06 01:27:02 -0800 [V8] Make an Isolate mandatory in v8UnsignedInteger() 2012-12-06 14:11:09 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 784748 0 haraken 2012-12-06 01:27:02 -0800 [V8] Make an Isolate mandatory in v8UnsignedInteger() 784749 1 177968 haraken 2012-12-06 01:28:58 -0800 Created attachment 177968 Patch 785251 2 177968 webkit.review.bot 2012-12-06 14:11:06 -0800 Comment on attachment 177968 Patch Clearing flags on attachment: 177968 Committed r136887: <http://trac.webkit.org/changeset/136887> 785252 3 webkit.review.bot 2012-12-06 14:11:09 -0800 All reviewed patches have been landed. Closing bug. 177968 2012-12-06 01:28:58 -0800 2012-12-06 14:11:06 -0800 Patch bug-104235-20121206182623.patch text/plain 3687 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzVlNTAyZDZlNDU0OWZi MTcxOTBiMDFkYTU4Njk0N2U2MjFkNjhmNi4uY2IyN2EwZWRiYjA3Zjg1MTQ1YzA5NTgzMTgyMzIz NGQxNWQyMGU0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTA2ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1ha2UgYW4g SXNvbGF0ZSBtYW5kYXRvcnkgaW4gdjhVbnNpZ25lZEludGVnZXIoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0MjM1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBi ZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L0FycmF5VmFsdWUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6QXJyYXlWYWx1ZTo6Z2V0KToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEJp bmRpbmcuaDoKKyAgICAgICAgKFdlYkNvcmU6OnY4VW5zaWduZWRJbnRlZ2VyKToKKyAgICAgICAg KiBiaW5kaW5ncy92OC9WOExhenlFdmVudExpc3RlbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlY4TGF6eUV2ZW50TGlzdGVuZXI6OnByZXBhcmVMaXN0ZW5lck9iamVjdCk6CisKIDIwMTItMTIt MDUgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtWOF0g SW1wbGVtZW50IGRlcHJlY2F0ZWRWOFN0cmluZygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9BcnJheVZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L0FycmF5VmFsdWUuY3BwCmluZGV4IDU0MGY1ZTFhZWE3Njk4M2E4Yjk3NTEzZWM5MTEwYTQyZGU1 MmQ5YzguLjdlM2MxNGNmZDg3MmExNDdmOTI1N2Q3Y2IxMTJiNjUwNmRmYzk5MGEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0FycmF5VmFsdWUuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0FycmF5VmFsdWUuY3BwCkBAIC02MCwxMiArNjAsMTIgQEAg Ym9vbCBBcnJheVZhbHVlOjpnZXQoc2l6ZV90IGluZGV4LCBEaWN0aW9uYXJ5JiB2YWx1ZSkgY29u c3QKICAgICBpZiAoaW5kZXggPj0gbV9hcnJheS0+TGVuZ3RoKCkpCiAgICAgICAgIHJldHVybiBm YWxzZTsKIAotICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+IGluZGV4ZWRWYWx1ZSA9IG1fYXJyYXkt PkdldCh2OFVuc2lnbmVkSW50ZWdlcihpbmRleCkpOworICAgIEFTU0VSVChtX2lzb2xhdGUpOwor ICAgIEFTU0VSVChtX2lzb2xhdGUgPT0gdjg6Oklzb2xhdGU6OkdldEN1cnJlbnQoKSk7CisgICAg djg6OkxvY2FsPHY4OjpWYWx1ZT4gaW5kZXhlZFZhbHVlID0gbV9hcnJheS0+R2V0KHY4VW5zaWdu ZWRJbnRlZ2VyKGluZGV4LCBtX2lzb2xhdGUpKTsKICAgICBpZiAoaW5kZXhlZFZhbHVlLklzRW1w dHkoKSB8fCAhaW5kZXhlZFZhbHVlLT5Jc09iamVjdCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7 CiAKLSAgICBBU1NFUlQobV9pc29sYXRlKTsKLSAgICBBU1NFUlQobV9pc29sYXRlID09IHY4OjpJ c29sYXRlOjpHZXRDdXJyZW50KCkpOwogICAgIHZhbHVlID0gRGljdGlvbmFyeShpbmRleGVkVmFs dWUsIG1faXNvbGF0ZSk7CiAgICAgcmV0dXJuIHRydWU7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4QmluZGluZy5oCmluZGV4IDI5MzYxMGUzMWRhZWZiMTU1Y2IyNjE3OGIwZWNhMmZlYTI0 YWFhOTMuLjc0MmZiM2JjMmM4Y2M2MWNhYzE2NDlmMzM0NTM5ZGNkZGQzMDZkMjIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCkBAIC0xODksMTAgKzE4OSw5IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKICAgICAgICAgcmV0dXJuIHY4SW50ZWdlcih2YWx1ZSwgdjg6Oklzb2xh dGU6OkdldEN1cnJlbnQoKSk7CiAgICAgfQogCi0gICAgaW5saW5lIHY4OjpIYW5kbGU8djg6Oklu dGVnZXI+IHY4VW5zaWduZWRJbnRlZ2VyKHVuc2lnbmVkIHZhbHVlLCB2ODo6SXNvbGF0ZSogaXNv bGF0ZSA9IDApCisgICAgaW5saW5lIHY4OjpIYW5kbGU8djg6OkludGVnZXI+IHY4VW5zaWduZWRJ bnRlZ2VyKHVuc2lnbmVkIHZhbHVlLCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKICAgICB7Ci0gICAg ICAgIGlmIChVTkxJS0VMWSghaXNvbGF0ZSkpCi0gICAgICAgICAgICBpc29sYXRlID0gdjg6Oklz b2xhdGU6OkdldEN1cnJlbnQoKTsKKyAgICAgICAgQVNTRVJUKGlzb2xhdGUpOwogICAgICAgICBy ZXR1cm4gVjhQZXJJc29sYXRlRGF0YTo6ZnJvbShpc29sYXRlKS0+aW50ZWdlckNhY2hlKCktPnY4 VW5zaWduZWRJbnRlZ2VyKHZhbHVlLCBpc29sYXRlKTsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4TGF6eUV2ZW50TGlzdGVuZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAKaW5kZXggMjlhYWNk NTE4MzY1YzAwYzg1ZGE4N2VlZjM1NDY4MWNiOWVlY2RlOC4uOTM4YjEwOTgwM2ZmMGFkOGUzZGE3 YTE2N2ZlOWMxN2JiOTVjNTE1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAKQEAgLTE4NSwxMSArMTg1LDExIEBAIHZvaWQgVjhM YXp5RXZlbnRMaXN0ZW5lcjo6cHJlcGFyZUxpc3RlbmVyT2JqZWN0KFNjcmlwdEV4ZWN1dGlvbkNv bnRleHQqIGNvbnRleHQpCiAgICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IHRoaXNPYmplY3QgPSB2 ODo6T2JqZWN0OjpOZXcoKTsKICAgICBpZiAodGhpc09iamVjdC5Jc0VtcHR5KCkpCiAgICAgICAg IHJldHVybjsKLSAgICBpZiAoIXRoaXNPYmplY3QtPkZvcmNlU2V0KHY4VW5zaWduZWRJbnRlZ2Vy KDApLCBub2RlV3JhcHBlcikpCisgICAgaWYgKCF0aGlzT2JqZWN0LT5Gb3JjZVNldChkZXByZWNh dGVkVjhJbnRlZ2VyKDApLCBub2RlV3JhcHBlcikpCiAgICAgICAgIHJldHVybjsKLSAgICBpZiAo IXRoaXNPYmplY3QtPkZvcmNlU2V0KHY4VW5zaWduZWRJbnRlZ2VyKDEpLCBmb3JtV3JhcHBlcikp CisgICAgaWYgKCF0aGlzT2JqZWN0LT5Gb3JjZVNldChkZXByZWNhdGVkVjhJbnRlZ2VyKDEpLCBm b3JtV3JhcHBlcikpCiAgICAgICAgIHJldHVybjsKLSAgICBpZiAoIXRoaXNPYmplY3QtPkZvcmNl U2V0KHY4VW5zaWduZWRJbnRlZ2VyKDIpLCBkb2N1bWVudFdyYXBwZXIpKQorICAgIGlmICghdGhp c09iamVjdC0+Rm9yY2VTZXQoZGVwcmVjYXRlZFY4SW50ZWdlcigyKSwgZG9jdW1lbnRXcmFwcGVy KSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIGNvZGUgd2hl biB3ZSBzdG9wIGRvaW5nIHRoZSAnd2l0aCcgaGFjayBhYm92ZS4K