104228 2012-12-05 23:28:14 -0800 Add win8/* to Chromium DEPS (r171376) 2012-12-07 03:50:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tasak tasak eae morrita noel.gordon robertshield tony oldest_to_newest 784667 0 tasak 2012-12-05 23:28:14 -0800 Current chromium/src/printing/printing.gyp requires win8: ['OS=="win"', { 'dependencies': [ '../win8/win8.gyp:win8_util', ], So need to checkout win8/* to roll Chromium DEPS to r171376. 784672 1 177952 tasak 2012-12-05 23:36:16 -0800 Created attachment 177952 Patch 784673 2 177952 morrita 2012-12-05 23:38:41 -0800 Comment on attachment 177952 Patch rs=me 784677 3 177952 tasak 2012-12-05 23:47:42 -0800 Comment on attachment 177952 Patch Clearing flags on attachment: 177952 Committed r136811: <http://trac.webkit.org/changeset/136811> 784678 4 tasak 2012-12-05 23:47:46 -0800 All reviewed patches have been landed. Closing bug. 785230 5 eae 2012-12-06 14:00:30 -0800 This seems to have casued the win release bot fail, http://build.webkit.org/builders/Chromium%20Win%20Release/builds/51312 785267 6 tony 2012-12-06 14:22:22 -0800 src/printing depends on src/win8, which depends on src/chrome/tools/build/win/check_sdk_patch.py. That's wrong. We need to break this dependency. Looking at win8.gyp, I would probably move the python script into win8. I'm not sure why it's in the chrome directory. 785552 7 noel.gordon 2012-12-06 19:22:45 -0800 https://src.chromium.org/viewvc/chrome?view=rev&revision=171652 785790 8 noel.gordon 2012-12-07 03:50:08 -0800 http://trac.webkit.org/changeset/136939 DEPS rolled to 171707, win release build bot went green \o/ 177952 2012-12-05 23:36:16 -0800 2012-12-05 23:47:41 -0800 Patch bug-104228-20121206163340.patch text/plain 1261 tasak U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDljNmMwODZlNmQ2ZDAwNzBjYzk3ZDk4Njk0ZDhiYTc4NTEwMGFkYjAuLmYzOThmMWY1Y2Y0OTE3 NDQzMjJiMmE4NTZhMWZlZDcyNmMzMjU4MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTcgQEAKIDIwMTItMTItMDUgIFRha2FzaGkgU2FrYW1vdG8gIDx0YXNha0Bnb29n bGUuY29tPgogCisgICAgICAgIEFkZCB3aW44LyogdG8gQ2hyb21pdW0gREVQUyAocjE3MTM3NikK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDIyOAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHVw ZGF0ZWQgY2hyb21pdW0gREVQUyB0byByMTcxMzc2LCBub3cgcHJpbnRpbmcvcHJpbnRpbmcuZ3lw CisgICAgICAgIHJlcXVpcmVzIHdpbjgvKiBmb3Igd2luZG93cyBidWlsZC4KKworICAgICAgICAq IERFUFM6CisKKzIwMTItMTItMDUgIFRha2FzaGkgU2FrYW1vdG8gIDx0YXNha0Bnb29nbGUuY29t PgorCiAgICAgICAgIFVucmV2aWV3ZWQsIFdlYktpdCBnYXJkZW5pbmcuCiAKICAgICAgICAgKiBX ZWJLaXQuZ3lwOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTCmluZGV4IGM3MWNmYWM1Njg5N2JhNzA5NDIxYTQwZGY1 OTc5MzdjMDgzMDY1MjIuLjkyZmE4YjEzZGVjZGRhNDYxN2U3ZjY4YWY5MjJiZWE5ZjljNTIwZDMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUworKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL0RFUFMKQEAgLTEyNSw2ICsxMjUsOCBAQCBkZXBzID0gewogICAgIFZhcign Y2hyb21pdW1fc3ZuJykrJy90b29scy93aW5AJytWYXIoJ2Nocm9taXVtX3JldicpLAogICAndWkn OgogICAgIFZhcignY2hyb21pdW1fc3ZuJykrJy91aUAnK1ZhcignY2hyb21pdW1fcmV2JyksCisg ICd3aW44JzoKKyAgICBWYXIoJ2Nocm9taXVtX3N2bicpKycvd2luOEAnK1ZhcignY2hyb21pdW1f cmV2JyksCiAKICAgIyBvdGhlciB0aGlyZCBwYXJ0eQogICAndGhpcmRfcGFydHkvcHlmdHBkbGli L3NyYyc6Cg==