104226 2012-12-05 23:00:44 -0800 Disabled file input box stops a certain other div from being rendered 2012-12-06 18:19:03 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified All RESOLVED FIXED P2 Normal --- 0 ksakamoto webkit-unassigned dglazkov eric mifenton morrita ojan tkent webkit.review.bot oldest_to_newest 784652 0 ksakamoto 2012-12-05 23:00:44 -0800 Imported from http://crbug.com/120194 Sample: http://jsfiddle.net/ECEtY/1/ Text "OK!" should be shown below the file input, but isn't. 784675 1 177953 ksakamoto 2012-12-05 23:41:49 -0800 Created attachment 177953 Patch 784940 2 177953 dglazkov 2012-12-06 07:43:42 -0800 Comment on attachment 177953 Patch I <3 this change. More please. Kill that RenderFileUploadControl. 785502 3 177953 ksakamoto 2012-12-06 18:07:33 -0800 Comment on attachment 177953 Patch Thank you for the review. I'll file a separate bug for further refactoring. 785512 4 177953 webkit.review.bot 2012-12-06 18:18:59 -0800 Comment on attachment 177953 Patch Clearing flags on attachment: 177953 Committed r136915: <http://trac.webkit.org/changeset/136915> 785513 5 webkit.review.bot 2012-12-06 18:19:03 -0800 All reviewed patches have been landed. Closing bug. 177953 2012-12-05 23:41:49 -0800 2012-12-06 18:18:59 -0800 Patch bug-104226-20121206163914.patch text/plain 7087 ksakamoto U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzI1NDlkODMzYmZkOTRj MTRjOGZhYjgzYzEwYTJkNWJkN2IyZGVhOS4uNWRhYTE3ZTQxMTgxNzI3MDY1MmQ5OWQzYTI0ZDcz MGJhYjA1MTlkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEyLTEyLTA2ICBLdW5p aGlrbyBTYWthbW90byAgPGtzYWthbW90b0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGlzYWJs ZWQgZmlsZSBpbnB1dCBib3ggc3RvcHMgYSBjZXJ0YWluIG90aGVyIGRpdiBmcm9tIGJlaW5nIHJl bmRlcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDQyMjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgYnVnIHdhcyBjYXVzZWQgYnkgc2V0TmVlZHNTdHlsZVJlY2FsYygpIGNhbGwgZHVyaW5nIHN0 eWxlIHJlY2FsY3VsYXRpb24sCisgICAgICAgIHdoaWNoIHJlc3VsdGVkIGluIGluY29uc2lzdGVu dCBDaGlsZE5lZWRzU3R5bGVSZWNhbGMgZmxhZ3MgaW4gRE9NIHRyZWUuCisKKyAgICAgICAgV2hl biByZWF0dGFjaCBvZiBmaWxlIGlucHV0IGhhcHBlbnMgZHVyaW5nIHN0eWxlIHJlY2FsY3VsYXRp b24sCisgICAgICAgIFJlbmRlckZpbGVVcGxvYWRDb250cm9sOjp1cGRhdGVGcm9tRWxlbWVudCgp IGlzIGNhbGxlZCBmcm9tIGF0dGFjaCgpLgorICAgICAgICBJdCBtYXkgY2hhbmdlIHRoZSBkaXNh YmxlZCBzdGF0ZSBvZiB0aGUgdXBsb2FkIGJ1dHRvbiBpbiBpdHMgc2hhZG93IHRyZWUsCisgICAg ICAgIGJ1dCBpdCB0cmlnZ2VycyBzdHlsZSByZWNhbGN1bGF0aW9uLgorCisgICAgICAgIFRoaXMg cGF0Y2ggc29sdmVzIHRoaXMgaXNzdWUgYnkgc2V0dGluZyBkaXNhYmxlZCBzdGF0ZSBvZiB0aGUg dXBsb2FkIGJ1dHRvbiBpbgorICAgICAgICBGaWxlSW5wdXRUeXBlOjpkaXNhYmxlZEF0dHJpYnV0 ZUNoYW5nZWQgaW5zdGVhZCBvZiBSZW5kZXJGaWxlVXBsb2FkQ29udHJvbC4KKworICAgICAgICBU ZXN0OiBmYXN0L2Zvcm1zL2ZpbGUvc2libGluZy1vZi1kaXNhYmxlZC1maWxlLWlucHV0Lmh0bWwK KworICAgICAgICAqIGh0bWwvRmlsZUlucHV0VHlwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpG aWxlSW5wdXRUeXBlOjpkaXNhYmxlZEF0dHJpYnV0ZUNoYW5nZWQpOiBBZGRlZC4KKyAgICAgICAg KiBodG1sL0ZpbGVJbnB1dFR5cGUuaDoKKyAgICAgICAgKEZpbGVJbnB1dFR5cGUpOiBEZWNsYXJl IGRpc2FibGVkQXR0cmlidXRlQ2hhbmdlZC4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRmls ZVVwbG9hZENvbnRyb2wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmlsZVVwbG9hZENv bnRyb2w6OnVwZGF0ZUZyb21FbGVtZW50KTogUmVtb3ZlIGNhbGwgdG8gYnV0dG9uLT5zZXREaXNh YmxlZCgpLgorCiAyMDEyLTEyLTA1ICBKdXN0aW4gTm92b3NhZCAgPGp1bm92QGdvb2dsZS5jb20+ CiAKICAgICAgICAgW3NraWFdIEltcHJvdmUgcGVyZm9ybWFuY2Ugb2YgR3JhcGhpY3NDb250ZXh0 OjpjcmVhdGVDb21wYXRpYmxlQnVmZmVyIGJ5IHVzaW5nIFNrRGV2aWNlOmNyZWF0ZUNvbXBhdGli bGVEZXZpY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRmlsZUlucHV0VHlwZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ZpbGVJbnB1dFR5cGUuY3BwCmluZGV4IGY2MTA1Y2E5 NDZmMGE5OWU1MGQwNTIyYzVhMjlkNWUxZjNmM2IzODguLjFlZGQ2NWFhZTJjZTZmYTU0OTIwOTk3 Yzc3NTdmMTkyMTc2NTc3M2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRmlsZUlu cHV0VHlwZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9GaWxlSW5wdXRUeXBlLmNwcApA QCAtMzA2LDYgKzMwNiwxNCBAQCB2b2lkIEZpbGVJbnB1dFR5cGU6OmNyZWF0ZVNoYWRvd1N1YnRy ZWUoKQogICAgIGVsZW1lbnQoKS0+dXNlckFnZW50U2hhZG93Um9vdCgpLT5hcHBlbmRDaGlsZChl bGVtZW50KCktPm11bHRpcGxlKCkgPyBVcGxvYWRCdXR0b25FbGVtZW50OjpjcmVhdGVGb3JNdWx0 aXBsZShlbGVtZW50KCktPmRvY3VtZW50KCkpOiBVcGxvYWRCdXR0b25FbGVtZW50OjpjcmVhdGUo ZWxlbWVudCgpLT5kb2N1bWVudCgpKSwgZWMpOwogfQogCit2b2lkIEZpbGVJbnB1dFR5cGU6OmRp c2FibGVkQXR0cmlidXRlQ2hhbmdlZCgpCit7CisgICAgQVNTRVJUKGVsZW1lbnQoKS0+c2hhZG93 KCkpOworICAgIFVwbG9hZEJ1dHRvbkVsZW1lbnQqIGJ1dHRvbiA9IHN0YXRpY19jYXN0PFVwbG9h ZEJ1dHRvbkVsZW1lbnQqPihlbGVtZW50KCktPnVzZXJBZ2VudFNoYWRvd1Jvb3QoKS0+Zmlyc3RD aGlsZCgpKTsKKyAgICBpZiAoYnV0dG9uKQorICAgICAgICBidXR0b24tPnNldERpc2FibGVkKGVs ZW1lbnQoKS0+ZGlzYWJsZWQoKSk7Cit9CisKIHZvaWQgRmlsZUlucHV0VHlwZTo6bXVsdGlwbGVB dHRyaWJ1dGVDaGFuZ2VkKCkKIHsKICAgICBBU1NFUlQoZWxlbWVudCgpLT5zaGFkb3coKSk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0ZpbGVJbnB1dFR5cGUuaCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvRmlsZUlucHV0VHlwZS5oCmluZGV4IDEwYWNkZTcwMmQ4MThkODYxZGZhOWYy YjQ1ZTVjM2FiM2ZkMDU2NTYuLmEwZjQyOTI2NzZiNWJiNDZjYmFlOTllMzI4NzRlMzAwZjg2NjVh ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRmlsZUlucHV0VHlwZS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvRmlsZUlucHV0VHlwZS5oCkBAIC03MSw2ICs3MSw3IEBAIHBy aXZhdGU6CiAgICAgdmlydHVhbCBJY29uKiBpY29uKCkgY29uc3QgT1ZFUlJJREU7CiAgICAgdmly dHVhbCBib29sIGlzRmlsZVVwbG9hZCgpIGNvbnN0IE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9p ZCBjcmVhdGVTaGFkb3dTdWJ0cmVlKCkgT1ZFUlJJREU7CisgICAgdmlydHVhbCB2b2lkIGRpc2Fi bGVkQXR0cmlidXRlQ2hhbmdlZCgpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBtdWx0aXBs ZUF0dHJpYnV0ZUNoYW5nZWQoKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIFN0cmluZyBkZWZhdWx0 VG9vbFRpcCgpIGNvbnN0IE9WRVJSSURFOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckZpbGVVcGxvYWRDb250cm9sLmNwcAppbmRleCBjZTZmMjc4YjUyNTljNmY0 YzhmZmNiM2Q0YjVlNmI0MmMzMDA3MjA0Li4xODhkODU1OTRkY2RlNzliMGQyMzFjZGE5YjE1ZTg3 ZDI3NmVlNGRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmls ZVVwbG9hZENvbnRyb2wuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJG aWxlVXBsb2FkQ29udHJvbC5jcHAKQEAgLTcyLDE0ICs3Miw2IEBAIHZvaWQgUmVuZGVyRmlsZVVw bG9hZENvbnRyb2w6OnVwZGF0ZUZyb21FbGVtZW50KCkKICAgICBBU1NFUlQoaW5wdXQtPmlzRmls ZVVwbG9hZCgpKTsKIAogICAgIGlmIChIVE1MSW5wdXRFbGVtZW50KiBidXR0b24gPSB1cGxvYWRC dXR0b24oKSkgewotICAgICAgICBib29sIG5ld0Rpc2FibGVkID0gIXRoZW1lKCktPmlzRW5hYmxl ZCh0aGlzKTsKLSAgICAgICAgLy8gV2Ugc2hvdWxkIGF2b2lkIHRvIGNhbGwgSFRNTEZvcm1Db250 cm9sRWxlbWVudDo6c2V0RGlzYWJsZWQoKSBhcwotICAgICAgICAvLyBwb3NzaWJsZSBiZWNhdXNl IHNldEF0dHJpYnV0ZSgpIGluIHNldERpc2FibGVkKCkgY2FuIGNhdXNlIHN0eWxlCi0gICAgICAg IC8vIHJlY2FsY3VsYXRpb24sIGFuZCBIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpyZWNhbGNTdHls ZSgpIGNhbGxzCi0gICAgICAgIC8vIHVwZGF0ZUZyb21FbGVtZW50KCkgZXZlbnR1YWxseS4KLSAg ICAgICAgaWYgKGJ1dHRvbi0+ZGlzYWJsZWQoKSAhPSBuZXdEaXNhYmxlZCkKLSAgICAgICAgICAg IGJ1dHRvbi0+c2V0RGlzYWJsZWQobmV3RGlzYWJsZWQpOwotCiAgICAgICAgIGJvb2wgbmV3Q2Fu UmVjZWl2ZURyb3BwZWRGaWxlc1N0YXRlID0gaW5wdXQtPmNhblJlY2VpdmVEcm9wcGVkRmlsZXMo KTsKICAgICAgICAgaWYgKG1fY2FuUmVjZWl2ZURyb3BwZWRGaWxlcyAhPSBuZXdDYW5SZWNlaXZl RHJvcHBlZEZpbGVzU3RhdGUpIHsKICAgICAgICAgICAgIG1fY2FuUmVjZWl2ZURyb3BwZWRGaWxl cyA9IG5ld0NhblJlY2VpdmVEcm9wcGVkRmlsZXNTdGF0ZTsKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyZTJmOTcyNDA3NWU1 MzYxNDFjM2Q1Yzk1NTIyZjJmOTA1M2JkMzlkLi4wNDhiMmFiYjI2YTlkNjAzOTYyYmM5NjZjMTg5 YjAxZTdlZTJhMmRjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMTItMDYgIEt1bmloaWtv IFNha2Ftb3RvICA8a3Nha2Ftb3RvQGNocm9taXVtLm9yZz4KKworICAgICAgICBEaXNhYmxlZCBm aWxlIGlucHV0IGJveCBzdG9wcyBhIGNlcnRhaW4gb3RoZXIgZGl2IGZyb20gYmVpbmcgcmVuZGVy ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDIy NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBh IHRlc3QgdG8gZW5zdXJlIHRoYXQgc2libGluZyBvZiBkaXNhYmxlZCBmaWxlIGlucHV0IGlzIGNv cnJlY3RseSByZW5kZXJlZC4KKworICAgICAgICAqIGZhc3QvZm9ybXMvZmlsZS9zaWJsaW5nLW9m LWRpc2FibGVkLWZpbGUtaW5wdXQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L2Zvcm1zL2ZpbGUvc2libGluZy1vZi1kaXNhYmxlZC1maWxlLWlucHV0Lmh0bWw6IEFkZGVkLgor CiAyMDEyLTEyLTA1ICBMZW8gWWFuZyAgPGxlb3lhbmdAcmltLmNvbT4KIAogICAgICAgICBFeHRy YSBzcGFjZSBpbiBmYXN0L2Nzcy9pbWFnZS1yZXNvbHV0aW9uL2ltYWdlLXJlc29sdXRpb24uaHRt bApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9maWxlL3NpYmxpbmctb2YtZGlz YWJsZWQtZmlsZS1pbnB1dC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2Zp bGUvc2libGluZy1vZi1kaXNhYmxlZC1maWxlLWlucHV0LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li44YWUzYTVlNjU3YmUwOGU2ZjVlNWI1YWQ3NjA2YTZlNjI0OWQ0OTg5Ci0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9maWxlL3NpYmxpbmctb2YtZGlzYWJsZWQtZmls ZS1pbnB1dC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw0IEBACitUZXN0IGZvciBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0MjI2IERpc2FibGVkIGZpbGUgaW5wdXQg Ym94IHN0b3BzIGEgY2VydGFpbiBvdGhlciBkaXYgZnJvbSBiZWluZyByZW5kZXJlZC4KKworCitQ QVNTIGlmIHRoaXMgdGV4dCBpcyB2aXNpYmxlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9maWxlL3NpYmxpbmctb2YtZGlzYWJsZWQtZmlsZS1pbnB1dC5odG1sIGIvTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9maWxlL3NpYmxpbmctb2YtZGlzYWJsZWQtZmlsZS1pbnB1dC5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjZhNTQxODJhMGRjYTNmNzYyZjFlNDc1MjJkYWRjMDIxOTk5YjZjMGYKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ZpbGUvc2libGluZy1vZi1k aXNhYmxlZC1maWxlLWlucHV0Lmh0bWwKQEAgLTAsMCArMSwzNyBAQAorPCFkb2N0eXBlIGh0bWw+ Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAg IHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgp OworfQorZnVuY3Rpb24gb25Mb2FkKCkgeworICAgIGRpdjEgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCdkaXYnKTsKKyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRpdjEpOworCisgICAg ZGl2MiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOworICAgIGRpdjEuYXBwZW5kQ2hp bGQoZGl2Mik7CisKKyAgICBmaWxlSW5wdXQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdpbnB1 dCcpOworICAgIGZpbGVJbnB1dC50eXBlID0gJ2ZpbGUnOworICAgIGZpbGVJbnB1dC5kaXNhYmxl ZCA9IHRydWU7CisgICAgZGl2Mi5hcHBlbmRDaGlsZChmaWxlSW5wdXQpOworCisgICAgZGl2VHh0 ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7CisgICAgZGl2Mi5hcHBlbmRDaGlsZChk aXZUeHQpOworCisgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgZGl2VHh0LmFw cGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCdQQVNTIGlmIHRoaXMgdGV4dCBpcyB2 aXNpYmxlLicpKTsKKyAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICAgICAg dGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgfSwgMSk7Cit9Cis8L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5IG9ubG9hZD0ib25Mb2FkKCk7Ij4KKzxwPlRlc3QgZm9yIDxhIGhyZWY9Imh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQyMjYiPmh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQyMjY8L2E+CitEaXNhYmxlZCBmaWxlIGlucHV0 IGJveCBzdG9wcyBhIGNlcnRhaW4gb3RoZXIgZGl2IGZyb20gYmVpbmcgcmVuZGVyZWQuCis8L3A+ Cis8L2JvZHk+Cis8L2h0bWw+Cg==