104224 2012-12-05 22:54:40 -0800 [V8] Pass Isolate to toDOMStringList() 2012-12-06 01:22:12 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 784648 0 haraken 2012-12-05 22:54:40 -0800 After this patch is landed, I think we can make an Isolate mandatory for v8Integer(). 784650 1 177944 haraken 2012-12-05 22:56:51 -0800 Created attachment 177944 Patch 784715 2 177944 webkit.review.bot 2012-12-06 00:44:10 -0800 Comment on attachment 177944 Patch Rejecting attachment 177944 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13133 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 52>At revision 13133. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/15144871 784718 3 haraken 2012-12-06 00:48:20 -0800 Committed r136816: <http://trac.webkit.org/changeset/136816> 177944 2012-12-05 22:56:51 -0800 2012-12-06 01:22:12 -0800 Patch bug-104224-20121206155416.patch text/plain 6781 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2Nzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQ1OGU5NjliMjEzODgw ZjI2ODQ2Njc5Y2ZkNmU1NWZiNzZlZTkyYy4uOGUwYWY2MDkzYzUwZGRjNmUzMDU1NDQwMDY2ZGQ2 NmYxOTZmNTcyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTEyLTA1ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFBhc3MgSXNv bGF0ZSB0byB0b0RPTVN0cmluZ0xpc3QoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA0MjI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAg ICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgorICAgICAgICAoSlNW YWx1ZVRvTmF0aXZlKToKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0 T2JqLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRlc3RPYmpWOEludGVybmFsOjpvdmVybG9hZGVk TWV0aG9kNkNhbGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OlRlc3RPYmpWOEludGVybmFsOjpv dmVybG9hZGVkTWV0aG9kN0NhbGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OlRlc3RPYmpWOElu dGVybmFsOjpvdmVybG9hZGVkTWV0aG9kOUNhbGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OlRl c3RPYmpWOEludGVybmFsOjpzdHJpbmdBcnJheUZ1bmN0aW9uQ2FsbGJhY2spOgorICAgICAgICAq IGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b0RPTVN0cmlu Z0xpc3QpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5oOgorICAgICAgICAoV2Vi Q29yZSk6CisKKzIwMTItMTItMDUgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3Jn PgorCiAgICAgICAgIFtWOF0gT3B0aW1pemUgdjhTdHJpbmdPck51bGwoKSBhbmQgdjhTdHJpbmdP clVuZGVmaW5lZCgpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDQyMDYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9yVjgucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JWOC5wbQppbmRleCBmM2JiNGI3OWVhZTBkMjA3NGQxNThlYjA1Nzk3MDMyNDQ4 MzJiMzFjLi44MTBjNzViYjAyYjEyZGY2YTdmOGVhMDAxOTRmZTUxMWZlYjUwNmNmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQor KysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpA QCAtMzc4Myw5ICszNzgzLDkgQEAgc3ViIEpTVmFsdWVUb05hdGl2ZQogICAgIHJldHVybiAidG9J bnQ2NCgkdmFsdWUpIiBpZiAkdHlwZSBlcSAidW5zaWduZWQgbG9uZyBsb25nIiBvciAkdHlwZSBl cSAibG9uZyBsb25nIjsKICAgICByZXR1cm4gInN0YXRpY19jYXN0PFJhbmdlOjpDb21wYXJlSG93 PigkdmFsdWUtPkludDMyVmFsdWUoKSkiIGlmICR0eXBlIGVxICJDb21wYXJlSG93IjsKICAgICBy ZXR1cm4gInRvV2ViQ29yZURhdGUoJHZhbHVlKSIgaWYgJHR5cGUgZXEgIkRhdGUiOwotICAgIHJl dHVybiAidG9ET01TdHJpbmdMaXN0KCR2YWx1ZSkiIGlmICR0eXBlIGVxICJET01TdHJpbmdMaXN0 IjsKKyAgICByZXR1cm4gInRvRE9NU3RyaW5nTGlzdCgkdmFsdWUsICRnZXRJc29sYXRlKSIgaWYg JHR5cGUgZXEgIkRPTVN0cmluZ0xpc3QiOwogICAgICMgRklYTUU6IENvbnNpZGVyIHJlcGxhY2lu ZyBET01TdHJpbmdMaXN0IHdpdGggRE9NU3RyaW5nW10gb3Igc2VxdWVuY2U8RE9NU3RyaW5nPi4K LSAgICByZXR1cm4gInRvRE9NU3RyaW5nTGlzdCgkdmFsdWUpIiBpZiAkdHlwZSBlcSAiRE9NU3Ry aW5nW10iOworICAgIHJldHVybiAidG9ET01TdHJpbmdMaXN0KCR2YWx1ZSwgJGdldElzb2xhdGUp IiBpZiAkdHlwZSBlcSAiRE9NU3RyaW5nW10iOwogCiAgICAgaWYgKCR0eXBlIGVxICJET01TdHJp bmciKSB7CiAgICAgICAgIHJldHVybiAkdmFsdWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0T2JqLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RPYmouY3BwCmluZGV4IDFjYTI2MzhhYzVi ZDhlNzUwYzg4MmUyNTE4ZjcxNGJkZDI4MjBiMmIuLjBiMzI4OGRlNDQxN2EyZmE1NDNiN2Y0OGE2 NTE4YmVmN2U1NDkwZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvdGVzdC9WOC9WOFRlc3RPYmouY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj cmlwdHMvdGVzdC9WOC9WOFRlc3RPYmouY3BwCkBAIC0xNjA5LDcgKzE2MDksNyBAQCBzdGF0aWMg djg6OkhhbmRsZTx2ODo6VmFsdWU+IG92ZXJsb2FkZWRNZXRob2Q2Q2FsbGJhY2soY29uc3Qgdjg6 OkFyZ3VtZW50cyYgYXJncwogICAgIGlmIChhcmdzLkxlbmd0aCgpIDwgMSkKICAgICAgICAgcmV0 dXJuIHRocm93Tm90RW5vdWdoQXJndW1lbnRzRXJyb3IoYXJncy5HZXRJc29sYXRlKCkpOwogICAg IFRlc3RPYmoqIGltcCA9IFY4VGVzdE9iajo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSk7Ci0gICAg VjhUUllDQVRDSChSZWZQdHI8RE9NU3RyaW5nTGlzdD4sIGxpc3RBcmcsIHRvRE9NU3RyaW5nTGlz dChNQVlCRV9NSVNTSU5HX1BBUkFNRVRFUihhcmdzLCAwLCBEZWZhdWx0SXNVbmRlZmluZWQpKSk7 CisgICAgVjhUUllDQVRDSChSZWZQdHI8RE9NU3RyaW5nTGlzdD4sIGxpc3RBcmcsIHRvRE9NU3Ry aW5nTGlzdChNQVlCRV9NSVNTSU5HX1BBUkFNRVRFUihhcmdzLCAwLCBEZWZhdWx0SXNVbmRlZmlu ZWQpLCBhcmdzLkdldElzb2xhdGUoKSkpOwogICAgIGltcC0+b3ZlcmxvYWRlZE1ldGhvZChsaXN0 QXJnKTsKICAgICByZXR1cm4gdjhVbmRlZmluZWQoKTsKIH0KQEAgLTE2MjAsNyArMTYyMCw3IEBA IHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gb3ZlcmxvYWRlZE1ldGhvZDdDYWxsYmFjayhj b25zdCB2ODo6QXJndW1lbnRzJiBhcmdzCiAgICAgaWYgKGFyZ3MuTGVuZ3RoKCkgPCAxKQogICAg ICAgICByZXR1cm4gdGhyb3dOb3RFbm91Z2hBcmd1bWVudHNFcnJvcihhcmdzLkdldElzb2xhdGUo KSk7CiAgICAgVGVzdE9iaiogaW1wID0gVjhUZXN0T2JqOjp0b05hdGl2ZShhcmdzLkhvbGRlcigp KTsKLSAgICBWOFRSWUNBVENIKFJlZlB0cjxET01TdHJpbmdMaXN0PiwgYXJyYXlBcmcsIHRvRE9N U3RyaW5nTGlzdChNQVlCRV9NSVNTSU5HX1BBUkFNRVRFUihhcmdzLCAwLCBEZWZhdWx0SXNVbmRl ZmluZWQpKSk7CisgICAgVjhUUllDQVRDSChSZWZQdHI8RE9NU3RyaW5nTGlzdD4sIGFycmF5QXJn LCB0b0RPTVN0cmluZ0xpc3QoTUFZQkVfTUlTU0lOR19QQVJBTUVURVIoYXJncywgMCwgRGVmYXVs dElzVW5kZWZpbmVkKSwgYXJncy5HZXRJc29sYXRlKCkpKTsKICAgICBpbXAtPm92ZXJsb2FkZWRN ZXRob2QoYXJyYXlBcmcpOwogICAgIHJldHVybiB2OFVuZGVmaW5lZCgpOwogfQpAQCAtMTY0Miw3 ICsxNjQyLDcgQEAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBvdmVybG9hZGVkTWV0aG9k OUNhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MKICAgICBpZiAoYXJncy5MZW5ndGgo KSA8IDEpCiAgICAgICAgIHJldHVybiB0aHJvd05vdEVub3VnaEFyZ3VtZW50c0Vycm9yKGFyZ3Mu R2V0SXNvbGF0ZSgpKTsKICAgICBUZXN0T2JqKiBpbXAgPSBWOFRlc3RPYmo6OnRvTmF0aXZlKGFy Z3MuSG9sZGVyKCkpOwotICAgIFY4VFJZQ0FUQ0goUmVmUHRyPERPTVN0cmluZ0xpc3Q+LCBhcnJh eUFyZywgdG9ET01TdHJpbmdMaXN0KE1BWUJFX01JU1NJTkdfUEFSQU1FVEVSKGFyZ3MsIDAsIERl ZmF1bHRJc1VuZGVmaW5lZCkpKTsKKyAgICBWOFRSWUNBVENIKFJlZlB0cjxET01TdHJpbmdMaXN0 PiwgYXJyYXlBcmcsIHRvRE9NU3RyaW5nTGlzdChNQVlCRV9NSVNTSU5HX1BBUkFNRVRFUihhcmdz LCAwLCBEZWZhdWx0SXNVbmRlZmluZWQpLCBhcmdzLkdldElzb2xhdGUoKSkpOwogICAgIGltcC0+ b3ZlcmxvYWRlZE1ldGhvZChhcnJheUFyZyk7CiAgICAgcmV0dXJuIHY4VW5kZWZpbmVkKCk7CiB9 CkBAIC0xODMwLDcgKzE4MzAsNyBAQCBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHN0cmlu Z0FycmF5RnVuY3Rpb25DYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcgogICAgIFRlc3RP YmoqIGltcCA9IFY4VGVzdE9iajo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSk7CiAgICAgRXhjZXB0 aW9uQ29kZSBlYyA9IDA7CiAgICAgewotICAgIFY4VFJZQ0FUQ0goUmVmUHRyPERPTVN0cmluZ0xp c3Q+LCB2YWx1ZXMsIHRvRE9NU3RyaW5nTGlzdChNQVlCRV9NSVNTSU5HX1BBUkFNRVRFUihhcmdz LCAwLCBEZWZhdWx0SXNVbmRlZmluZWQpKSk7CisgICAgVjhUUllDQVRDSChSZWZQdHI8RE9NU3Ry aW5nTGlzdD4sIHZhbHVlcywgdG9ET01TdHJpbmdMaXN0KE1BWUJFX01JU1NJTkdfUEFSQU1FVEVS KGFyZ3MsIDAsIERlZmF1bHRJc1VuZGVmaW5lZCksIGFyZ3MuR2V0SXNvbGF0ZSgpKSk7CiAgICAg UmVmUHRyPERPTVN0cmluZ0xpc3Q+IHJlc3VsdCA9IGltcC0+c3RyaW5nQXJyYXlGdW5jdGlvbih2 YWx1ZXMsIGVjKTsKICAgICBpZiAoVU5MSUtFTFkoZWMpKQogICAgICAgICBnb3RvIGZhaWw7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcAppbmRleCBkNDE0NzJlYjk0MjM2 MDk2N2E2MGRlZDMzMzhiYWY2MjNjNjUwMjlmLi4yYjVmNzQzNWVkNTVlY2NjZmI4NzY5MjA4YzI3 OWZiZjkwY2FlYTc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJp bmRpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAK QEAgLTE5Niw3ICsxOTYsNyBAQCB2b2lkIFN0cmluZ0NhY2hlOjpyZXBvcnRNZW1vcnlVc2FnZShN ZW1vcnlPYmplY3RJbmZvKiBtZW1vcnlPYmplY3RJbmZvKSBjb25zdAogICAgIGluZm8uYWRkTWVt YmVyKG1fc3RyaW5nQ2FjaGUpOwogfQogICAgIAotUGFzc1JlZlB0cjxET01TdHJpbmdMaXN0PiB0 b0RPTVN0cmluZ0xpc3Qodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVlKQorUGFzc1JlZlB0cjxE T01TdHJpbmdMaXN0PiB0b0RPTVN0cmluZ0xpc3Qodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVl LCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsKICAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiB2OFZh bHVlKHY4OjpMb2NhbDx2ODo6VmFsdWU+OjpOZXcodmFsdWUpKTsKIApAQCAtMjExLDcgKzIxMSw3 IEBAIFBhc3NSZWZQdHI8RE9NU3RyaW5nTGlzdD4gdG9ET01TdHJpbmdMaXN0KHY4OjpIYW5kbGU8 djg6OlZhbHVlPiB2YWx1ZSkKICAgICBSZWZQdHI8RE9NU3RyaW5nTGlzdD4gcmV0ID0gRE9NU3Ry aW5nTGlzdDo6Y3JlYXRlKCk7CiAgICAgdjg6OkxvY2FsPHY4OjpBcnJheT4gdjhBcnJheSA9IHY4 OjpMb2NhbDx2ODo6QXJyYXk+OjpDYXN0KHY4VmFsdWUpOwogICAgIGZvciAoc2l6ZV90IGkgPSAw OyBpIDwgdjhBcnJheS0+TGVuZ3RoKCk7ICsraSkgewotICAgICAgICB2ODo6TG9jYWw8djg6OlZh bHVlPiBpbmRleGVkVmFsdWUgPSB2OEFycmF5LT5HZXQodjhJbnRlZ2VyKGkpKTsKKyAgICAgICAg djg6OkxvY2FsPHY4OjpWYWx1ZT4gaW5kZXhlZFZhbHVlID0gdjhBcnJheS0+R2V0KHY4SW50ZWdl cihpLCBpc29sYXRlKSk7CiAgICAgICAgIHJldC0+YXBwZW5kKHRvV2ViQ29yZVN0cmluZyhpbmRl eGVkVmFsdWUpKTsKICAgICB9CiAgICAgcmV0dXJuIHJldC5yZWxlYXNlKCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaCBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCmluZGV4IDVkZTZlZWNhNDljNDhjMDgzMzYwMmE3ZDg1 MDhiZjQwNGVjYjZkMmUuLjk1ZjkwZGEwOTk2Y2QyMDQwNGJkZTQ5OGQ5MTcyNzQ5Y2E5ZDk3Y2Qg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCkBAIC00MjksNyArNDI5LDcg QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgdjg6OlBlcnNpc3RlbnQ8djg6OkZ1bmN0aW9u VGVtcGxhdGU+IGNyZWF0ZVJhd1RlbXBsYXRlKCk7CiAKLSAgICBQYXNzUmVmUHRyPERPTVN0cmlu Z0xpc3Q+IHRvRE9NU3RyaW5nTGlzdCh2ODo6SGFuZGxlPHY4OjpWYWx1ZT4pOworICAgIFBhc3NS ZWZQdHI8RE9NU3RyaW5nTGlzdD4gdG9ET01TdHJpbmdMaXN0KHY4OjpIYW5kbGU8djg6OlZhbHVl Piwgdjg6Oklzb2xhdGUqKTsKICAgICBQYXNzUmVmUHRyPFhQYXRoTlNSZXNvbHZlcj4gdG9YUGF0 aE5TUmVzb2x2ZXIodjg6OkhhbmRsZTx2ODo6VmFsdWU+KTsKIAogICAgIHY4OjpIYW5kbGU8djg6 Ok9iamVjdD4gdG9Jbm5lckdsb2JhbE9iamVjdCh2ODo6SGFuZGxlPHY4OjpDb250ZXh0Pik7Cg==