104222 2012-12-05 22:48:50 -0800 Profiler should print a helpful message if you pass the wrong arguments 2012-12-06 13:21:41 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 784645 0 fpizlo 2012-12-05 22:48:50 -0800 Currently it prints something like: [pizlo@wartooth OpenSource] Tools/Scripts/display-profiler-output Tools/Scripts/display-profiler-output:279:in `read': can't convert nil into String (TypeError) from Tools/Scripts/display-profiler-output:279 That's not helpful. 784647 1 177943 fpizlo 2012-12-05 22:49:47 -0800 Created attachment 177943 the patch 785185 2 fpizlo 2012-12-06 13:21:41 -0800 Landed in http://trac.webkit.org/changeset/136879 177943 2012-12-05 22:49:47 -0800 2012-12-06 10:31:07 -0800 the patch pbp.patch text/plain 1312 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzNjgwNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDEyLTEyLTA1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgUHJvZmlsZXIgc2hvdWxkIHByaW50IGEgaGVscGZ1bCBtZXNzYWdlIGlmIHlvdSBw YXNzIHRoZSB3cm9uZyBhcmd1bWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNDIyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2NyaXB0cy9kaXNwbGF5LXByb2ZpbGVyLW91dHB1dDoKKwogMjAx Mi0xMi0wNSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQg bXlzZWxmIHRvIHdhdGNoIGNoYW5nZXMgaW4gUGVyZm9ybWFuY2VUZXN0cy8qLgpJbmRleDogVG9v bHMvU2NyaXB0cy9kaXNwbGF5LXByb2ZpbGVyLW91dHB1dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9T Y3JpcHRzL2Rpc3BsYXktcHJvZmlsZXItb3V0cHV0CShyZXZpc2lvbiAxMzY4MDMpCisrKyBUb29s cy9TY3JpcHRzL2Rpc3BsYXktcHJvZmlsZXItb3V0cHV0CSh3b3JraW5nIGNvcHkpCkBAIC0yNTgs NiArMjU4LDE2IEBAIGNsYXNzIENvbXBpbGF0aW9uCiAgICAgZW5kCiBlbmQKIAoraWYgQVJHVi5s ZW5ndGggIT0gMQorICAgICRzdGRlcnIucHV0cyAiVXNhZ2U6IGRpc3BsYXktcHJvZmlsZXItb3V0 cHV0IDxwYXRoIHRvIHByb2ZpbGVyIG91dHB1dCBmaWxlPiIKKyAgICAkc3RkZXJyLnB1dHMKKyAg ICAkc3RkZXJyLnB1dHMgIlRoZSB0eXBpY2FsIHVzYWdlIHBhdHRlcm4gZm9yIHRoZSBwcm9maWxl ciBjdXJyZW50bHkgbG9va3Mgc29tZXRoaW5nIGxpa2U6IgorICAgICRzdGRlcnIucHV0cworICAg ICRzdGRlcnIucHV0cyAiUGF0aC9Uby9qc2MgLXAgcHJvZmlsZS5qc29uIG15cHJvZ3JhbS5qcyIK KyAgICAkc3RkZXJyLnB1dHMgImRpc3BsYXktcHJvZmlsZXItb3V0cHV0IHByb2ZpbGUuanNvbiIK KyAgICBleGl0IDEKK2VuZAorCiAkanNvbiA9IEpTT046OnBhcnNlKElPOjpyZWFkKEFSR1ZbMF0p KQogJGJ5dGVjb2RlcyA9ICRqc29uWyJieXRlY29kZXMiXS5tYXAgewogICAgIHwgc3ViSnNvbiB8 Cg==