104219 2012-12-05 22:34:26 -0800 Page popup should align to the right when the anchor element is rtl 2012-12-06 01:04:28 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keishi keishi tkent webkit.review.bot oldest_to_newest 784634 0 keishi 2012-12-05 22:34:26 -0800 Page popup should align to the right when the anchor element is rtl 784658 1 177948 keishi 2012-12-05 23:13:06 -0800 Created attachment 177948 Patch 784661 2 177948 tkent 2012-12-05 23:17:53 -0800 Comment on attachment 177948 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177948&action=review > Source/WebCore/Resources/pagepopups/pickerCommon.js:173 > - resizeWindow(1, 1); > + setWindowRect(new Rectangle(window.screen.left, window.screen.top, 1, 1)); I don't understand this. window.screen is a Screen object, and it has not left and top properties. 784679 3 177954 keishi 2012-12-05 23:50:15 -0800 Created attachment 177954 Patch 784680 4 keishi 2012-12-05 23:53:27 -0800 (In reply to comment #2) > (From update of attachment 177948 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177948&action=review > > > Source/WebCore/Resources/pagepopups/pickerCommon.js:173 > > - resizeWindow(1, 1); > > + setWindowRect(new Rectangle(window.screen.left, window.screen.top, 1, 1)); > > I don't understand this. window.screen is a Screen object, and it has not left and top properties. I made a mistake. 784682 5 177954 tkent 2012-12-06 00:01:51 -0800 Comment on attachment 177954 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177954&action=review > Source/WebCore/ChangeLog:15 > + (setWindowRect): If the window is hidden we want to move first then resize so the popup doesn't flicker. > + (isWindowHidden): Returns true if the window is hidden using hideWindow(). nit: These changes look unrelated to the RTL issue. > Source/WebCore/Resources/pagepopups/pickerCommon.js:172 > + var isHidden = isWindowHidden(); > + if (!isHidden) > + window.resizeTo(rect.width, rect.height); > window.moveTo(rect.x - window.screen.availLeft, rect.y - window.screen.availTop); > - window.resizeTo(rect.width, rect.height); > + if (isHidden) > + window.resizeTo(rect.width, rect.height); nit: it's ok to write duplicated line to improve readability. if (isWindowHidden()) { window.moveTo(...); window.resizeTo(...); } else { window.resizeTo(...); window.moveTo(...); } 784685 6 keishi 2012-12-06 00:06:25 -0800 (In reply to comment #5) > (From update of attachment 177954 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177954&action=review > > > Source/WebCore/ChangeLog:15 > > + (setWindowRect): If the window is hidden we want to move first then resize so the popup doesn't flicker. > > + (isWindowHidden): Returns true if the window is hidden using hideWindow(). > > nit: These changes look unrelated to the RTL issue. When the element is rtl and we call hideWindow, I see the popup move to the right edge first and then shrink to 1x1. 784689 7 177959 keishi 2012-12-06 00:15:31 -0800 Created attachment 177959 Patch 784693 8 177959 webkit.review.bot 2012-12-06 00:18:45 -0800 Comment on attachment 177959 Patch Rejecting attachment 177959 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15158631 784706 9 177962 keishi 2012-12-06 00:34:21 -0800 Created attachment 177962 Patch 784733 10 177962 webkit.review.bot 2012-12-06 01:04:23 -0800 Comment on attachment 177962 Patch Clearing flags on attachment: 177962 Committed r136821: <http://trac.webkit.org/changeset/136821> 784734 11 webkit.review.bot 2012-12-06 01:04:28 -0800 All reviewed patches have been landed. Closing bug. 177948 2012-12-05 23:13:06 -0800 2012-12-05 23:50:12 -0800 Patch bug-104219-20121206161030.patch text/plain 2343 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2Nzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDMzZjE2YTNjODEzZjM1 M2Q0MTRjNjNiZmI3NTJlNWYwOTIxMDczNy4uYjEwNWQ4MjE0YWRmYmY4MGQ5MjY2NmY5ZDhkMGRi OGFkNzkzYzE0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTA1ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIFBhZ2UgcG9wdXAgc2hv dWxkIGFsaWduIHRvIHRoZSByaWdodCB3aGVuIHRoZSBhbmNob3IgZWxlbWVudCBpcyBydGwKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDIxOQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhZ2UgcG9wdXAg c2hvdWxkIGFsaWduIHRvIHRoZSByaWdodCBlZGdlIG9mIHRoZSBhbmNob3IgZWxlbWVudCB3aGVu IHRoZSBhbmNob3IgZWxlbWVudCBpcyBydGwuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBNb2Nr IHBhZ2UgcG9wdXAgY2FuJ3QgdGVzdCBwb3B1cCB3aW5kb3cgcG9zaXRpb24uCisKKyAgICAgICAg KiBSZXNvdXJjZXMvcGFnZXBvcHVwcy9waWNrZXJDb21tb24uanM6CisgICAgICAgIChfYWRqdXN0 V2luZG93UmVjdEhvcml6b250YWxseSk6IEFsaWduIHRvIHRoZSByaWdodCBlZGdlIHdoZW4gYW5j aG9yIGVsZW1lbnQgaXMgcnRsLiBSZW1vdmVkIHNvbWUgcmVkdW5kYW50IGxpbmVzLgorICAgICAg ICAoaGlkZVdpbmRvdyk6IHNldFdpbmRvd1JlY3QgbW92ZXMgdGhlIHdpbmRvdyBiZWZvcmUgcmVz aXppbmcgc28gd2UgZG9uJ3Qgd2FudCB0byBtb3ZlIHRoZSB3aW5kb3cgd2hlbiBoaWRpbmcuCisK IDIwMTItMTItMDUgIFNjb3R0IFZpb2xldCAgPHNreUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg W2Nocm9taXVtXSBSZW1vdmUgbGludXggdGhlbWUgcmVsYXRlZCBmaWxlcyBhbmQgc3dpdGNoIHRv IGRlZmF1bHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9wYWdlcG9wdXBz L3BpY2tlckNvbW1vbi5qcyBiL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9wYWdlcG9wdXBzL3Bp Y2tlckNvbW1vbi5qcwppbmRleCBjZmI2MWI0NmEzYWZhMjczMWUzZjNjMDc1ZDQyZThlY2ZlMGI0 MzYzLi41MTZiMmQ5ZmQ5YWFhM2M4MzRjN2I1NDczNjhmNDc4YWZkMzRkMDg0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9SZXNvdXJjZXMvcGFnZXBvcHVwcy9waWNrZXJDb21tb24uanMKKysr IGIvU291cmNlL1dlYkNvcmUvUmVzb3VyY2VzL3BhZ2Vwb3B1cHMvcGlja2VyQ29tbW9uLmpzCkBA IC0xNTAsOSArMTUwLDggQEAgZnVuY3Rpb24gX2FkanVzdFdpbmRvd1JlY3RIb3Jpem9udGFsbHko d2luZG93UmVjdCwgYXZhaWxSZWN0LCBhbmNob3JSZWN0LCBtaW5XaWQKICAgICB3aW5kb3dSZWN0 LndpZHRoID0gTWF0aC5taW4od2luZG93UmVjdC53aWR0aCwgYXZhaWxSZWN0LndpZHRoKTsKICAg ICB3aW5kb3dSZWN0LndpZHRoID0gTWF0aC5tYXgod2luZG93UmVjdC53aWR0aCwgbWluV2lkdGgp OwogICAgIHdpbmRvd1JlY3QueCA9IGFuY2hvclJlY3QueDsKLSAgICB2YXIgYXZhaWxhYmxlU3Bh Y2VUb1JpZ2h0ID0gYXZhaWxSZWN0Lm1heFggLSBhbmNob3JSZWN0Lng7Ci0gICAgaWYgKHdpbmRv d1JlY3Qud2lkdGggPiBhdmFpbGFibGVTcGFjZVRvUmlnaHQpCi0gICAgICAgIHdpbmRvd1JlY3Qu eCAtPSAod2luZG93UmVjdC53aWR0aCAtIGF2YWlsYWJsZVNwYWNlVG9SaWdodCk7CisgICAgaWYg KGdsb2JhbC5wYXJhbXMuaXNSVEwpCisgICAgICAgIHdpbmRvd1JlY3QueCArPSBhbmNob3JSZWN0 LndpZHRoIC0gd2luZG93UmVjdC53aWR0aDsKICAgICB3aW5kb3dSZWN0LnggPSBNYXRoLm1pbih3 aW5kb3dSZWN0LngsIGF2YWlsUmVjdC5tYXhYIC0gd2luZG93UmVjdC53aWR0aCk7CiAgICAgd2lu ZG93UmVjdC54ID0gTWF0aC5tYXgod2luZG93UmVjdC54LCBhdmFpbFJlY3QueCk7CiB9CkBAIC0x NzEsNyArMTcwLDcgQEAgZnVuY3Rpb24gc2V0V2luZG93UmVjdChyZWN0KSB7CiB9CiAKIGZ1bmN0 aW9uIGhpZGVXaW5kb3coKSB7Ci0gICAgcmVzaXplV2luZG93KDEsIDEpOworICAgIHNldFdpbmRv d1JlY3QobmV3IFJlY3RhbmdsZSh3aW5kb3cuc2NyZWVuLmxlZnQsIHdpbmRvdy5zY3JlZW4udG9w LCAxLCAxKSk7CiB9CiAKIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJyZXNpemUiLCBmdW5jdGlv bigpIHsK 177954 2012-12-05 23:50:15 -0800 2012-12-06 00:15:27 -0800 Patch bug-104219-20121206164739.patch text/plain 3206 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2Nzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDMzZjE2YTNjODEzZjM1 M2Q0MTRjNjNiZmI3NTJlNWYwOTIxMDczNy4uMDBmZDc4ODQ0ZDkxMzAwZTc0M2UyMTEzOTVkNGI3 ZjY3M2ViOWU2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTA1ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIFBhZ2UgcG9wdXAgc2hv dWxkIGFsaWduIHRvIHRoZSByaWdodCB3aGVuIHRoZSBhbmNob3IgZWxlbWVudCBpcyBydGwKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDIxOQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhZ2UgcG9wdXAg c2hvdWxkIGFsaWduIHRvIHRoZSByaWdodCBlZGdlIG9mIHRoZSBhbmNob3IgZWxlbWVudCB3aGVu IHRoZSBhbmNob3IgZWxlbWVudCBpcyBydGwuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBNb2Nr IHBhZ2UgcG9wdXAgY2FuJ3QgdGVzdCBwb3B1cCB3aW5kb3cgcG9zaXRpb24uCisKKyAgICAgICAg KiBSZXNvdXJjZXMvcGFnZXBvcHVwcy9waWNrZXJDb21tb24uanM6CisgICAgICAgIChfYWRqdXN0 V2luZG93UmVjdEhvcml6b250YWxseSk6IEFsaWduIHRvIHRoZSByaWdodCBlZGdlIHdoZW4gYW5j aG9yIGVsZW1lbnQgaXMgcnRsLiBSZW1vdmVkIHNvbWUgcmVkdW5kYW50IGxpbmVzLgorICAgICAg ICAoc2V0V2luZG93UmVjdCk6IElmIHRoZSB3aW5kb3cgaXMgaGlkZGVuIHdlIHdhbnQgdG8gbW92 ZSBmaXJzdCB0aGVuIHJlc2l6ZSBzbyB0aGUgcG9wdXAgZG9lc24ndCBmbGlja2VyLgorICAgICAg ICAoaXNXaW5kb3dIaWRkZW4pOiBSZXR1cm5zIHRydWUgaWYgdGhlIHdpbmRvdyBpcyBoaWRkZW4g dXNpbmcgaGlkZVdpbmRvdygpLgorCiAyMDEyLTEyLTA1ICBTY290dCBWaW9sZXQgIDxza3lAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIGxpbnV4IHRoZW1lIHJlbGF0 ZWQgZmlsZXMgYW5kIHN3aXRjaCB0byBkZWZhdWx0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9SZXNvdXJjZXMvcGFnZXBvcHVwcy9waWNrZXJDb21tb24uanMgYi9Tb3VyY2UvV2ViQ29yZS9S ZXNvdXJjZXMvcGFnZXBvcHVwcy9waWNrZXJDb21tb24uanMKaW5kZXggY2ZiNjFiNDZhM2FmYTI3 MzFlM2YzYzA3NWQ0MmU4ZWNmZTBiNDM2My4uYjFkODEyNDlhNDMzZmNlM2IxMDI3NzFkNmIwNWU0 YzQwOGE5YTkyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUmVzb3VyY2VzL3BhZ2Vwb3B1 cHMvcGlja2VyQ29tbW9uLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9wYWdlcG9w dXBzL3BpY2tlckNvbW1vbi5qcwpAQCAtMTUwLDkgKzE1MCw4IEBAIGZ1bmN0aW9uIF9hZGp1c3RX aW5kb3dSZWN0SG9yaXpvbnRhbGx5KHdpbmRvd1JlY3QsIGF2YWlsUmVjdCwgYW5jaG9yUmVjdCwg bWluV2lkCiAgICAgd2luZG93UmVjdC53aWR0aCA9IE1hdGgubWluKHdpbmRvd1JlY3Qud2lkdGgs IGF2YWlsUmVjdC53aWR0aCk7CiAgICAgd2luZG93UmVjdC53aWR0aCA9IE1hdGgubWF4KHdpbmRv d1JlY3Qud2lkdGgsIG1pbldpZHRoKTsKICAgICB3aW5kb3dSZWN0LnggPSBhbmNob3JSZWN0Lng7 Ci0gICAgdmFyIGF2YWlsYWJsZVNwYWNlVG9SaWdodCA9IGF2YWlsUmVjdC5tYXhYIC0gYW5jaG9y UmVjdC54OwotICAgIGlmICh3aW5kb3dSZWN0LndpZHRoID4gYXZhaWxhYmxlU3BhY2VUb1JpZ2h0 KQotICAgICAgICB3aW5kb3dSZWN0LnggLT0gKHdpbmRvd1JlY3Qud2lkdGggLSBhdmFpbGFibGVT cGFjZVRvUmlnaHQpOworICAgIGlmIChnbG9iYWwucGFyYW1zLmlzUlRMKQorICAgICAgICB3aW5k b3dSZWN0LnggKz0gYW5jaG9yUmVjdC53aWR0aCAtIHdpbmRvd1JlY3Qud2lkdGg7CiAgICAgd2lu ZG93UmVjdC54ID0gTWF0aC5taW4od2luZG93UmVjdC54LCBhdmFpbFJlY3QubWF4WCAtIHdpbmRv d1JlY3Qud2lkdGgpOwogICAgIHdpbmRvd1JlY3QueCA9IE1hdGgubWF4KHdpbmRvd1JlY3QueCwg YXZhaWxSZWN0LngpOwogfQpAQCAtMTY1LDggKzE2NCwxMiBAQCBmdW5jdGlvbiBzZXRXaW5kb3dS ZWN0KHJlY3QpIHsKICAgICAgICAgd2luZG93LmZyYW1lRWxlbWVudC5zdHlsZS53aWR0aCA9IHJl Y3Qud2lkdGggKyAicHgiOwogICAgICAgICB3aW5kb3cuZnJhbWVFbGVtZW50LnN0eWxlLmhlaWdo dCA9IHJlY3QuaGVpZ2h0ICsgInB4IjsKICAgICB9IGVsc2UgeworICAgICAgICB2YXIgaXNIaWRk ZW4gPSBpc1dpbmRvd0hpZGRlbigpOworICAgICAgICBpZiAoIWlzSGlkZGVuKQorICAgICAgICAg ICAgd2luZG93LnJlc2l6ZVRvKHJlY3Qud2lkdGgsIHJlY3QuaGVpZ2h0KTsKICAgICAgICAgd2lu ZG93Lm1vdmVUbyhyZWN0LnggLSB3aW5kb3cuc2NyZWVuLmF2YWlsTGVmdCwgcmVjdC55IC0gd2lu ZG93LnNjcmVlbi5hdmFpbFRvcCk7Ci0gICAgICAgIHdpbmRvdy5yZXNpemVUbyhyZWN0LndpZHRo LCByZWN0LmhlaWdodCk7CisgICAgICAgIGlmIChpc0hpZGRlbikKKyAgICAgICAgICAgIHdpbmRv dy5yZXNpemVUbyhyZWN0LndpZHRoLCByZWN0LmhlaWdodCk7CiAgICAgfQogfQogCkBAIC0xNzQs OCArMTc3LDE1IEBAIGZ1bmN0aW9uIGhpZGVXaW5kb3coKSB7CiAgICAgcmVzaXplV2luZG93KDEs IDEpOwogfQogCisvKioKKyAqIEByZXR1cm4geyFib29sZWFufQorICovCitmdW5jdGlvbiBpc1dp bmRvd0hpZGRlbigpIHsKKyAgICByZXR1cm4gd2luZG93LmlubmVyV2lkdGggPT09IDEgJiYgd2lu ZG93LmlubmVySGVpZ2h0ID09PSAxOworfQorCiB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigicmVz aXplIiwgZnVuY3Rpb24oKSB7Ci0gICAgaWYgKHdpbmRvdy5pbm5lcldpZHRoID09PSAxICYmIHdp bmRvdy5pbm5lckhlaWdodCA9PT0gMSkKKyAgICBpZiAoaXNXaW5kb3dIaWRkZW4oKSkKICAgICAg ICAgd2luZG93LmRpc3BhdGNoRXZlbnQobmV3IEN1c3RvbUV2ZW50KCJkaWRIaWRlIikpOwogICAg IGVsc2UKICAgICAgICAgd2luZG93LmRpc3BhdGNoRXZlbnQobmV3IEN1c3RvbUV2ZW50KCJkaWRP cGVuUGlja2VyIikpOwo= 177959 2012-12-06 00:15:31 -0800 2012-12-06 00:34:18 -0800 Patch bug-104219-20121206171255.patch text/plain 3369 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2Nzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDMzZjE2YTNjODEzZjM1 M2Q0MTRjNjNiZmI3NTJlNWYwOTIxMDczNy4uMDBmZDc4ODQ0ZDkxMzAwZTc0M2UyMTEzOTVkNGI3 ZjY3M2ViOWU2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTA1ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIFBhZ2UgcG9wdXAgc2hv dWxkIGFsaWduIHRvIHRoZSByaWdodCB3aGVuIHRoZSBhbmNob3IgZWxlbWVudCBpcyBydGwKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDIxOQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhZ2UgcG9wdXAg c2hvdWxkIGFsaWduIHRvIHRoZSByaWdodCBlZGdlIG9mIHRoZSBhbmNob3IgZWxlbWVudCB3aGVu IHRoZSBhbmNob3IgZWxlbWVudCBpcyBydGwuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBNb2Nr IHBhZ2UgcG9wdXAgY2FuJ3QgdGVzdCBwb3B1cCB3aW5kb3cgcG9zaXRpb24uCisKKyAgICAgICAg KiBSZXNvdXJjZXMvcGFnZXBvcHVwcy9waWNrZXJDb21tb24uanM6CisgICAgICAgIChfYWRqdXN0 V2luZG93UmVjdEhvcml6b250YWxseSk6IEFsaWduIHRvIHRoZSByaWdodCBlZGdlIHdoZW4gYW5j aG9yIGVsZW1lbnQgaXMgcnRsLiBSZW1vdmVkIHNvbWUgcmVkdW5kYW50IGxpbmVzLgorICAgICAg ICAoc2V0V2luZG93UmVjdCk6IElmIHRoZSB3aW5kb3cgaXMgaGlkZGVuIHdlIHdhbnQgdG8gbW92 ZSBmaXJzdCB0aGVuIHJlc2l6ZSBzbyB0aGUgcG9wdXAgZG9lc24ndCBmbGlja2VyLgorICAgICAg ICAoaXNXaW5kb3dIaWRkZW4pOiBSZXR1cm5zIHRydWUgaWYgdGhlIHdpbmRvdyBpcyBoaWRkZW4g dXNpbmcgaGlkZVdpbmRvdygpLgorCiAyMDEyLTEyLTA1ICBTY290dCBWaW9sZXQgIDxza3lAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIGxpbnV4IHRoZW1lIHJlbGF0 ZWQgZmlsZXMgYW5kIHN3aXRjaCB0byBkZWZhdWx0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9SZXNvdXJjZXMvcGFnZXBvcHVwcy9waWNrZXJDb21tb24uanMgYi9Tb3VyY2UvV2ViQ29yZS9S ZXNvdXJjZXMvcGFnZXBvcHVwcy9waWNrZXJDb21tb24uanMKaW5kZXggY2ZiNjFiNDZhM2FmYTI3 MzFlM2YzYzA3NWQ0MmU4ZWNmZTBiNDM2My4uODQwMGU2YWY1M2U5NTEyMTcwODQ2ZjRiZTAzZTUw NmZlMzM3ZTNiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUmVzb3VyY2VzL3BhZ2Vwb3B1 cHMvcGlja2VyQ29tbW9uLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9wYWdlcG9w dXBzL3BpY2tlckNvbW1vbi5qcwpAQCAtMTUwLDkgKzE1MCw4IEBAIGZ1bmN0aW9uIF9hZGp1c3RX aW5kb3dSZWN0SG9yaXpvbnRhbGx5KHdpbmRvd1JlY3QsIGF2YWlsUmVjdCwgYW5jaG9yUmVjdCwg bWluV2lkCiAgICAgd2luZG93UmVjdC53aWR0aCA9IE1hdGgubWluKHdpbmRvd1JlY3Qud2lkdGgs IGF2YWlsUmVjdC53aWR0aCk7CiAgICAgd2luZG93UmVjdC53aWR0aCA9IE1hdGgubWF4KHdpbmRv d1JlY3Qud2lkdGgsIG1pbldpZHRoKTsKICAgICB3aW5kb3dSZWN0LnggPSBhbmNob3JSZWN0Lng7 Ci0gICAgdmFyIGF2YWlsYWJsZVNwYWNlVG9SaWdodCA9IGF2YWlsUmVjdC5tYXhYIC0gYW5jaG9y UmVjdC54OwotICAgIGlmICh3aW5kb3dSZWN0LndpZHRoID4gYXZhaWxhYmxlU3BhY2VUb1JpZ2h0 KQotICAgICAgICB3aW5kb3dSZWN0LnggLT0gKHdpbmRvd1JlY3Qud2lkdGggLSBhdmFpbGFibGVT cGFjZVRvUmlnaHQpOworICAgIGlmIChnbG9iYWwucGFyYW1zLmlzUlRMKQorICAgICAgICB3aW5k b3dSZWN0LnggKz0gYW5jaG9yUmVjdC53aWR0aCAtIHdpbmRvd1JlY3Qud2lkdGg7CiAgICAgd2lu ZG93UmVjdC54ID0gTWF0aC5taW4od2luZG93UmVjdC54LCBhdmFpbFJlY3QubWF4WCAtIHdpbmRv d1JlY3Qud2lkdGgpOwogICAgIHdpbmRvd1JlY3QueCA9IE1hdGgubWF4KHdpbmRvd1JlY3QueCwg YXZhaWxSZWN0LngpOwogfQpAQCAtMTY1LDggKzE2NCwxMyBAQCBmdW5jdGlvbiBzZXRXaW5kb3dS ZWN0KHJlY3QpIHsKICAgICAgICAgd2luZG93LmZyYW1lRWxlbWVudC5zdHlsZS53aWR0aCA9IHJl Y3Qud2lkdGggKyAicHgiOwogICAgICAgICB3aW5kb3cuZnJhbWVFbGVtZW50LnN0eWxlLmhlaWdo dCA9IHJlY3QuaGVpZ2h0ICsgInB4IjsKICAgICB9IGVsc2UgewotICAgICAgICB3aW5kb3cubW92 ZVRvKHJlY3QueCAtIHdpbmRvdy5zY3JlZW4uYXZhaWxMZWZ0LCByZWN0LnkgLSB3aW5kb3cuc2Ny ZWVuLmF2YWlsVG9wKTsKLSAgICAgICAgd2luZG93LnJlc2l6ZVRvKHJlY3Qud2lkdGgsIHJlY3Qu aGVpZ2h0KTsKKyAgICAgICAgaWYgKGlzV2luZG93SGlkZGVuKCkpIHsKKyAgICAgICAgICAgIHdp bmRvdy5tb3ZlVG8ocmVjdC54IC0gd2luZG93LnNjcmVlbi5hdmFpbExlZnQsIHJlY3QueSAtIHdp bmRvdy5zY3JlZW4uYXZhaWxUb3ApOworICAgICAgICAgICAgd2luZG93LnJlc2l6ZVRvKHJlY3Qu d2lkdGgsIHJlY3QuaGVpZ2h0KTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHdpbmRv dy5yZXNpemVUbyhyZWN0LndpZHRoLCByZWN0LmhlaWdodCk7CisgICAgICAgICAgICB3aW5kb3cu bW92ZVRvKHJlY3QueCAtIHdpbmRvdy5zY3JlZW4uYXZhaWxMZWZ0LCByZWN0LnkgLSB3aW5kb3cu c2NyZWVuLmF2YWlsVG9wKTsKKyAgICAgICAgfQogICAgIH0KIH0KIApAQCAtMTc0LDggKzE3OCwx NSBAQCBmdW5jdGlvbiBoaWRlV2luZG93KCkgewogICAgIHJlc2l6ZVdpbmRvdygxLCAxKTsKIH0K IAorLyoqCisgKiBAcmV0dXJuIHshYm9vbGVhbn0KKyAqLworZnVuY3Rpb24gaXNXaW5kb3dIaWRk ZW4oKSB7CisgICAgcmV0dXJuIHdpbmRvdy5pbm5lcldpZHRoID09PSAxICYmIHdpbmRvdy5pbm5l ckhlaWdodCA9PT0gMTsKK30KKwogd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoInJlc2l6ZSIsIGZ1 bmN0aW9uKCkgewotICAgIGlmICh3aW5kb3cuaW5uZXJXaWR0aCA9PT0gMSAmJiB3aW5kb3cuaW5u ZXJIZWlnaHQgPT09IDEpCisgICAgaWYgKGlzV2luZG93SGlkZGVuKCkpCiAgICAgICAgIHdpbmRv dy5kaXNwYXRjaEV2ZW50KG5ldyBDdXN0b21FdmVudCgiZGlkSGlkZSIpKTsKICAgICBlbHNlCiAg ICAgICAgIHdpbmRvdy5kaXNwYXRjaEV2ZW50KG5ldyBDdXN0b21FdmVudCgiZGlkT3BlblBpY2tl ciIpKTsK 177962 2012-12-06 00:34:21 -0800 2012-12-06 01:04:23 -0800 Patch bug-104219-20121206173145.patch text/plain 3366 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2Nzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDMzZjE2YTNjODEzZjM1 M2Q0MTRjNjNiZmI3NTJlNWYwOTIxMDczNy4uZjVjZDBlOGExN2Y4M2QyNzhlOGMyNjUxNGUxNmFh YWI2MjVlNmYzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTA1ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIFBhZ2UgcG9wdXAgc2hv dWxkIGFsaWduIHRvIHRoZSByaWdodCB3aGVuIHRoZSBhbmNob3IgZWxlbWVudCBpcyBydGwKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDIxOQorCisg ICAgICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgorCisgICAgICAgIFBhZ2UgcG9wdXAgc2hv dWxkIGFsaWduIHRvIHRoZSByaWdodCBlZGdlIG9mIHRoZSBhbmNob3IgZWxlbWVudCB3aGVuIHRo ZSBhbmNob3IgZWxlbWVudCBpcyBydGwuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBNb2NrIHBh Z2UgcG9wdXAgY2FuJ3QgdGVzdCBwb3B1cCB3aW5kb3cgcG9zaXRpb24uCisKKyAgICAgICAgKiBS ZXNvdXJjZXMvcGFnZXBvcHVwcy9waWNrZXJDb21tb24uanM6CisgICAgICAgIChfYWRqdXN0V2lu ZG93UmVjdEhvcml6b250YWxseSk6IEFsaWduIHRvIHRoZSByaWdodCBlZGdlIHdoZW4gYW5jaG9y IGVsZW1lbnQgaXMgcnRsLiBSZW1vdmVkIHNvbWUgcmVkdW5kYW50IGxpbmVzLgorICAgICAgICAo c2V0V2luZG93UmVjdCk6IElmIHRoZSB3aW5kb3cgaXMgaGlkZGVuIHdlIHdhbnQgdG8gbW92ZSBm aXJzdCB0aGVuIHJlc2l6ZSBzbyB0aGUgcG9wdXAgZG9lc24ndCBmbGlja2VyLgorICAgICAgICAo aXNXaW5kb3dIaWRkZW4pOiBSZXR1cm5zIHRydWUgaWYgdGhlIHdpbmRvdyBpcyBoaWRkZW4gdXNp bmcgaGlkZVdpbmRvdygpLgorCiAyMDEyLTEyLTA1ICBTY290dCBWaW9sZXQgIDxza3lAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIGxpbnV4IHRoZW1lIHJlbGF0ZWQg ZmlsZXMgYW5kIHN3aXRjaCB0byBkZWZhdWx0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9S ZXNvdXJjZXMvcGFnZXBvcHVwcy9waWNrZXJDb21tb24uanMgYi9Tb3VyY2UvV2ViQ29yZS9SZXNv dXJjZXMvcGFnZXBvcHVwcy9waWNrZXJDb21tb24uanMKaW5kZXggY2ZiNjFiNDZhM2FmYTI3MzFl M2YzYzA3NWQ0MmU4ZWNmZTBiNDM2My4uODQwMGU2YWY1M2U5NTEyMTcwODQ2ZjRiZTAzZTUwNmZl MzM3ZTNiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUmVzb3VyY2VzL3BhZ2Vwb3B1cHMv cGlja2VyQ29tbW9uLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9wYWdlcG9wdXBz L3BpY2tlckNvbW1vbi5qcwpAQCAtMTUwLDkgKzE1MCw4IEBAIGZ1bmN0aW9uIF9hZGp1c3RXaW5k b3dSZWN0SG9yaXpvbnRhbGx5KHdpbmRvd1JlY3QsIGF2YWlsUmVjdCwgYW5jaG9yUmVjdCwgbWlu V2lkCiAgICAgd2luZG93UmVjdC53aWR0aCA9IE1hdGgubWluKHdpbmRvd1JlY3Qud2lkdGgsIGF2 YWlsUmVjdC53aWR0aCk7CiAgICAgd2luZG93UmVjdC53aWR0aCA9IE1hdGgubWF4KHdpbmRvd1Jl Y3Qud2lkdGgsIG1pbldpZHRoKTsKICAgICB3aW5kb3dSZWN0LnggPSBhbmNob3JSZWN0Lng7Ci0g ICAgdmFyIGF2YWlsYWJsZVNwYWNlVG9SaWdodCA9IGF2YWlsUmVjdC5tYXhYIC0gYW5jaG9yUmVj dC54OwotICAgIGlmICh3aW5kb3dSZWN0LndpZHRoID4gYXZhaWxhYmxlU3BhY2VUb1JpZ2h0KQot ICAgICAgICB3aW5kb3dSZWN0LnggLT0gKHdpbmRvd1JlY3Qud2lkdGggLSBhdmFpbGFibGVTcGFj ZVRvUmlnaHQpOworICAgIGlmIChnbG9iYWwucGFyYW1zLmlzUlRMKQorICAgICAgICB3aW5kb3dS ZWN0LnggKz0gYW5jaG9yUmVjdC53aWR0aCAtIHdpbmRvd1JlY3Qud2lkdGg7CiAgICAgd2luZG93 UmVjdC54ID0gTWF0aC5taW4od2luZG93UmVjdC54LCBhdmFpbFJlY3QubWF4WCAtIHdpbmRvd1Jl Y3Qud2lkdGgpOwogICAgIHdpbmRvd1JlY3QueCA9IE1hdGgubWF4KHdpbmRvd1JlY3QueCwgYXZh aWxSZWN0LngpOwogfQpAQCAtMTY1LDggKzE2NCwxMyBAQCBmdW5jdGlvbiBzZXRXaW5kb3dSZWN0 KHJlY3QpIHsKICAgICAgICAgd2luZG93LmZyYW1lRWxlbWVudC5zdHlsZS53aWR0aCA9IHJlY3Qu d2lkdGggKyAicHgiOwogICAgICAgICB3aW5kb3cuZnJhbWVFbGVtZW50LnN0eWxlLmhlaWdodCA9 IHJlY3QuaGVpZ2h0ICsgInB4IjsKICAgICB9IGVsc2UgewotICAgICAgICB3aW5kb3cubW92ZVRv KHJlY3QueCAtIHdpbmRvdy5zY3JlZW4uYXZhaWxMZWZ0LCByZWN0LnkgLSB3aW5kb3cuc2NyZWVu LmF2YWlsVG9wKTsKLSAgICAgICAgd2luZG93LnJlc2l6ZVRvKHJlY3Qud2lkdGgsIHJlY3QuaGVp Z2h0KTsKKyAgICAgICAgaWYgKGlzV2luZG93SGlkZGVuKCkpIHsKKyAgICAgICAgICAgIHdpbmRv dy5tb3ZlVG8ocmVjdC54IC0gd2luZG93LnNjcmVlbi5hdmFpbExlZnQsIHJlY3QueSAtIHdpbmRv dy5zY3JlZW4uYXZhaWxUb3ApOworICAgICAgICAgICAgd2luZG93LnJlc2l6ZVRvKHJlY3Qud2lk dGgsIHJlY3QuaGVpZ2h0KTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHdpbmRvdy5y ZXNpemVUbyhyZWN0LndpZHRoLCByZWN0LmhlaWdodCk7CisgICAgICAgICAgICB3aW5kb3cubW92 ZVRvKHJlY3QueCAtIHdpbmRvdy5zY3JlZW4uYXZhaWxMZWZ0LCByZWN0LnkgLSB3aW5kb3cuc2Ny ZWVuLmF2YWlsVG9wKTsKKyAgICAgICAgfQogICAgIH0KIH0KIApAQCAtMTc0LDggKzE3OCwxNSBA QCBmdW5jdGlvbiBoaWRlV2luZG93KCkgewogICAgIHJlc2l6ZVdpbmRvdygxLCAxKTsKIH0KIAor LyoqCisgKiBAcmV0dXJuIHshYm9vbGVhbn0KKyAqLworZnVuY3Rpb24gaXNXaW5kb3dIaWRkZW4o KSB7CisgICAgcmV0dXJuIHdpbmRvdy5pbm5lcldpZHRoID09PSAxICYmIHdpbmRvdy5pbm5lckhl aWdodCA9PT0gMTsKK30KKwogd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoInJlc2l6ZSIsIGZ1bmN0 aW9uKCkgewotICAgIGlmICh3aW5kb3cuaW5uZXJXaWR0aCA9PT0gMSAmJiB3aW5kb3cuaW5uZXJI ZWlnaHQgPT09IDEpCisgICAgaWYgKGlzV2luZG93SGlkZGVuKCkpCiAgICAgICAgIHdpbmRvdy5k aXNwYXRjaEV2ZW50KG5ldyBDdXN0b21FdmVudCgiZGlkSGlkZSIpKTsKICAgICBlbHNlCiAgICAg ICAgIHdpbmRvdy5kaXNwYXRjaEV2ZW50KG5ldyBDdXN0b21FdmVudCgiZGlkT3BlblBpY2tlciIp KTsK