104215 2012-12-05 22:13:39 -0800 [WK2][EFL] Modify a zoom level setting on MiniBrowser 2017-03-11 10:36:07 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 ktf.kim ktf.kim gyuyoung.kim kenneth lucas.de.marchi mcatanzaro ryuan.choi oldest_to_newest 784613 0 ktf.kim 2012-12-05 22:13:39 -0800 The scale setting of MiniBrowser from bug 99285 doesn't work properly now: 1) It need just increase/decrease current scale with a fixed value. (and need to check boundaries) - I fixed it. I suggest 2 alternatives - "increase/decrease by 10%" and "increase/decrease to nearest zoom level" 2) It works properly only on "legacy behavior mode". - On default behavior mode, when zoomed in, it fits back to viewport on PageViewportController by decreased m_effectiveScale - I try to use ewk_view_device_pixel_ratio_set instead of ewk_view_scale_set on that, but it's not work properly, too. 3) It doesn't work properly for scrolled contents. - I think ewk_view_scale_set need to calculate the scrolled position (like Tizen), but make APIs to get the scrolled position is another big job. (I think we can get it from PageViewportController) 4) It try to zoom like "pinch zoom", not "page zoom" like PC browser. - If page zoom API like suggested on bug 90548 can be introduced, I think I can use it. - If not, I think changing short key could solve the confusing. (like ctrl + wheel) 784651 1 177945 ktf.kim 2012-12-05 22:59:36 -0800 Created attachment 177945 Patch 784737 2 177945 kenneth 2012-12-06 01:06:56 -0800 Comment on attachment 177945 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177945&action=review > Tools/MiniBrowser/efl/main.c:67 > +#if USE_ZOOM_LEVEL > #define DEFAULT_ZOOM_LEVEL 5 // Set default zoom level to 1.0 (index 5 on zoomLevels). > // The zoom values are chosen to be like in Mozilla Firefox 3. > const static float zoomLevels[] = {0.3, 0.5, 0.67, 0.8, 0.9, 1.0, 1.1, 1.2, 1.33, 1.5, 1.7, 2.0, 2.4, 3.0}; > > +static float > +get_scale_factor_from_zoom_levels(float currentScaleFactor, Zoom_Set_Mode mode) > +{ > + int i = 0; Why not just use percentage increase/decrease. What is the point of using those firefox values? I don't get it > Tools/MiniBrowser/efl/main.c:98 > + else > + currentScaleFactor = ewk_view_device_pixel_ratio_get(webview); This is wrong. You need the current scale. If the ewk_view_scale_set is setting effective scale and not css scale, it should include the pixel ratio. > Tools/MiniBrowser/efl/main.c:102 > +#if USE_ZOOM_LEVEL // Use pre-defined zoom level list > + scaleFactor = get_scale_factor_from_zoom_levels(currentScaleFactor, mode); > +#else // Just calculate from current scale factor Why have this at all? > Tools/MiniBrowser/efl/main.c:114 > + // Adjust scaleFactor to boundary. > + if (scaleFactor < 0.25) > + scaleFactor = 0.25; > + else if (scaleFactor > 4.0) > + scaleFactor = 4.0; What if the viewport meta tag says that you cannot scale at all? This code needs to cooperate with the PageViewportController. Maybe the set_scale method should take care of this internally and return bool if it succeeded or not > Tools/MiniBrowser/efl/main.c:120 > + if (legacy_behavior_enabled) { > + Evas_Coord ox, oy, mx, my, cx, cy; > + evas_pointer_canvas_xy_get(evas_object_evas_get(webview), &mx, &my); // Get current mouse position on window. > + evas_object_geometry_get(webview, &ox, &oy, NULL, NULL); // Get webview's position on window. Such code is ugly and that is why we can separate it out in functions > Tools/MiniBrowser/efl/main.c:122 > + cy = my - oy; // current y position = mouse y position - webview y position7 7 ? 1286295 3 mcatanzaro 2017-03-11 10:36:07 -0800 Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. 177945 2012-12-05 22:59:36 -0800 2012-12-06 01:06:56 -0800 Patch bug-104215-20121206155700.patch text/plain 7199 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWZmN2FjNWIzMTMyOWJkZDgzYjM0YTZjZjI1MzJmYzkw YjUxNTY4ZC4uYzhhMzk4MTAyYzFjOGIzMWQ2OWNjZjdkY2M0NDA1NTg3NjQyZjNiMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTEyLTA1ICBLeXVuZ1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFtXSzJdW0VGTF0gTW9kaWZ5IGEgem9vbSBsZXZlbCBzZXR0aW5nIG9uIE1pbmlCcm93 c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQy MTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb2Rp ZnkgbG9naWNzIG9mIHpvb20gbGV2ZWwgc2V0dGluZyBjb2RlIG9uIE1pbmlCcm93c2VyLgorCisg ICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKHpvb21fc2V0KToKKyAg ICAgICAgKF9Ccm93c2VyX1dpbmRvdyk6CisgICAgICAgIChvbl9rZXlfZG93bik6CisgICAgICAg ICh3aW5kb3dfY3JlYXRlKToKKwogMjAxMi0xMi0wNSAgSGFsdG9uIEh1byAgPGhhbHRvbi5odW9A aW50ZWwuY29tPgogCiAgICAgICAgIFtDTWFrZV0gVW5pZnkgY29kaW5nIHN0eWxlIGZvciBDTWFr ZSBmaWxlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xz L01pbmlCcm93c2VyL2VmbC9tYWluLmMKaW5kZXggMmFlMjVmMjgxMWYyYzMxYjEyZDMwYjYxNGMz ODg0ZGYxMGNlOTAwMi4uZTMwNDM2YzZmN2Y1NDhjNjVlODg1MTIzY2IwNTBiNzNhMTJhYTJiNCAx MDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYworKysgYi9Ub29scy9NaW5p QnJvd3Nlci9lZmwvbWFpbi5jCkBAIC00OSwyMyArNDksODkgQEAgc3RhdGljIGludCB3aW5kb3df aGVpZ2h0ID0gNjAwOwogc3RhdGljIGRvdWJsZSBkZXZpY2VfcGl4ZWxfcmF0aW8gPSAwOwogc3Rh dGljIEVpbmFfQm9vbCBsZWdhY3lfYmVoYXZpb3JfZW5hYmxlZCA9IEVJTkFfRkFMU0U7CiAKKwor dHlwZWRlZiBlbnVtIHsKKyAgICBaT09NX1NFVF9UT19ERUZBVUxULAorICAgIFpPT01fU0VUX1pP T01fSU4sCisgICAgWk9PTV9TRVRfWk9PTV9PVVQKK30gWm9vbV9TZXRfTW9kZTsKKyNkZWZpbmUg VVNFX1pPT01fTEVWRUwgMAorI2lmIFVTRV9aT09NX0xFVkVMCiAjZGVmaW5lIERFRkFVTFRfWk9P TV9MRVZFTCA1IC8vIFNldCBkZWZhdWx0IHpvb20gbGV2ZWwgdG8gMS4wIChpbmRleCA1IG9uIHpv b21MZXZlbHMpLgogLy8gVGhlIHpvb20gdmFsdWVzIGFyZSBjaG9zZW4gdG8gYmUgbGlrZSBpbiBN b3ppbGxhIEZpcmVmb3ggMy4KIGNvbnN0IHN0YXRpYyBmbG9hdCB6b29tTGV2ZWxzW10gPSB7MC4z LCAwLjUsIDAuNjcsIDAuOCwgMC45LCAxLjAsIDEuMSwgMS4yLCAxLjMzLCAxLjUsIDEuNywgMi4w LCAyLjQsIDMuMH07CiAKK3N0YXRpYyBmbG9hdAorZ2V0X3NjYWxlX2ZhY3Rvcl9mcm9tX3pvb21f bGV2ZWxzKGZsb2F0IGN1cnJlbnRTY2FsZUZhY3RvciwgWm9vbV9TZXRfTW9kZSBtb2RlKQorewor ICAgIGludCBpID0gMDsKKyAgICBpbnQgbmVhcmVzdF96b29tX2xldmVsID0gMDsKKyAgICBpbnQg bWF4X3pvb21fbGV2ZWwgPSBzaXplb2Yoem9vbUxldmVscykgLyBzaXplb2YoZmxvYXQpIC0gMTsK KworICAgIGZvciAoaSA9IDA7IHpvb21MZXZlbHNbaV0gPD0gY3VycmVudFNjYWxlRmFjdG9yICYm IGkgPD0gbWF4X3pvb21fbGV2ZWwgOyBpKyspIHsgfQorICAgIGlmIChjdXJyZW50U2NhbGVGYWN0 b3IgLSB6b29tTGV2ZWxzW2ktMV0gPCB6b29tTGV2ZWxzW2ldIC0gY3VycmVudFNjYWxlRmFjdG9y KQorICAgICAgICBuZWFyZXN0X3pvb21fbGV2ZWwgPSBpIC0gMTsKKyAgICBlbHNlCisgICAgICAg IG5lYXJlc3Rfem9vbV9sZXZlbCA9IGk7ICAKKyAgICAgICAgCisgICAgaWYgKG1vZGUgPT0gWk9P TV9TRVRfWk9PTV9JTiAmJiBuZWFyZXN0X3pvb21fbGV2ZWwgPCBtYXhfem9vbV9sZXZlbCkKKyAg ICAgICAgbmVhcmVzdF96b29tX2xldmVsKys7CisgICAgZWxzZSBpZiAobW9kZSA9PSBaT09NX1NF VF9aT09NX09VVCAmJiBuZWFyZXN0X3pvb21fbGV2ZWwgPiAwKQorICAgICAgICBuZWFyZXN0X3pv b21fbGV2ZWwtLTsKKyAgICBlbHNlIGlmIChtb2RlID09IFpPT01fU0VUX1RPX0RFRkFVTFQpCisg ICAgICAgIG5lYXJlc3Rfem9vbV9sZXZlbCA9IERFRkFVTFRfWk9PTV9MRVZFTDsKKworICAgIHJl dHVybiB6b29tTGV2ZWxzW25lYXJlc3Rfem9vbV9sZXZlbF07Cit9CisjZW5kaWYKKwogc3RhdGlj IEVpbmFfQm9vbAotem9vbV9sZXZlbF9zZXQoRXZhc19PYmplY3QgKndlYnZpZXcsIGludCBsZXZl bCkKK3pvb21fc2V0KEV2YXNfT2JqZWN0ICp3ZWJ2aWV3LCBab29tX1NldF9Nb2RlIG1vZGUpCiB7 Ci0gICAgaWYgKGxldmVsIDwgMCAgfHwgbGV2ZWwgPj0gc2l6ZW9mKHpvb21MZXZlbHMpIC8gc2l6 ZW9mKGZsb2F0KSkKLSAgICAgICAgcmV0dXJuIEVJTkFfRkFMU0U7CisgICAgRWluYV9Cb29sIHJl c3VsdDsKKyAgICBmbG9hdCBzY2FsZUZhY3RvciA9IDEuMCwgY3VycmVudFNjYWxlRmFjdG9yID0g MS4wOworCisgICAgLy8gVXNlIHRoZSBwYWdlU2NhbGVGYWN0b3IgaW4gbGVnYWN5IG1vZGUsIGFu ZCB1c2UgdGhlIEN1c3RvbURldmljZVNjYWxlRmFjdG9yIGluIGRlZmF1bHQgbW9kZS4KKyAgICBp ZiAobGVnYWN5X2JlaGF2aW9yX2VuYWJsZWQpCisgICAgICAgIGN1cnJlbnRTY2FsZUZhY3RvciA9 IGV3a192aWV3X3NjYWxlX2dldCh3ZWJ2aWV3KTsKKyAgICBlbHNlCisgICAgICAgIGN1cnJlbnRT Y2FsZUZhY3RvciA9IGV3a192aWV3X2RldmljZV9waXhlbF9yYXRpb19nZXQod2Vidmlldyk7CisK KyNpZiBVU0VfWk9PTV9MRVZFTCAvLyBVc2UgcHJlLWRlZmluZWQgem9vbSBsZXZlbCBsaXN0Cisg ICAgc2NhbGVGYWN0b3IgPSBnZXRfc2NhbGVfZmFjdG9yX2Zyb21fem9vbV9sZXZlbHMoY3VycmVu dFNjYWxlRmFjdG9yLCBtb2RlKTsKKyNlbHNlIC8vIEp1c3QgY2FsY3VsYXRlIGZyb20gY3VycmVu dCBzY2FsZSBmYWN0b3IKKyAgICBpZiAobW9kZSAgPT0gWk9PTV9TRVRfWk9PTV9JTikKKyAgICAg ICAgc2NhbGVGYWN0b3IgPSBjdXJyZW50U2NhbGVGYWN0b3IgKiAxLjE7CisgICAgZWxzZSBpZiAo bW9kZSA9PSBaT09NX1NFVF9aT09NX09VVCkKKyAgICAgICAgc2NhbGVGYWN0b3IgPSBjdXJyZW50 U2NhbGVGYWN0b3IgLyAxLjE7CisgICAgZWxzZQorICAgICAgICBzY2FsZUZhY3RvciA9IDE7CiAK LSAgICBFdmFzX0Nvb3JkIG94LCBveSwgbXgsIG15LCBjeCwgY3k7Ci0gICAgZXZhc19wb2ludGVy X2NhbnZhc194eV9nZXQoZXZhc19vYmplY3RfZXZhc19nZXQod2VidmlldyksICZteCwgJm15KTsg Ly8gR2V0IGN1cnJlbnQgbW91c2UgcG9zaXRpb24gb24gd2luZG93LgotICAgIGV2YXNfb2JqZWN0 X2dlb21ldHJ5X2dldCh3ZWJ2aWV3LCAmb3gsICZveSwgTlVMTCwgTlVMTCk7IC8vIEdldCB3ZWJ2 aWV3J3MgcG9zaXRpb24gb24gd2luZG93LgotICAgIGN4ID0gbXggLSBveDsgLy8gY3VycmVudCB4 IHBvc2l0aW9uID0gbW91c2UgeCBwb3NpdGlvbiAtIHdlYnZpZXcgeCBwb3NpdGlvbgotICAgIGN5 ID0gbXkgLSBveTsgLy8gY3VycmVudCB5IHBvc2l0aW9uID0gbW91c2UgeSBwb3NpdGlvbiAtIHdl YnZpZXcgeSBwb3NpdGlvbgorICAgIC8vIEFkanVzdCBzY2FsZUZhY3RvciB0byBib3VuZGFyeS4K KyAgICBpZiAoc2NhbGVGYWN0b3IgPCAwLjI1KQorICAgICAgICBzY2FsZUZhY3RvciA9IDAuMjU7 CisgICAgZWxzZSBpZiAoc2NhbGVGYWN0b3IgPiA0LjApCisgICAgICAgIHNjYWxlRmFjdG9yID0g NC4wOworI2VuZGlmCisKKyAgICBpZiAobGVnYWN5X2JlaGF2aW9yX2VuYWJsZWQpIHsKKyAgICAg ICAgRXZhc19Db29yZCBveCwgb3ksIG14LCBteSwgY3gsIGN5OworICAgICAgICBldmFzX3BvaW50 ZXJfY2FudmFzX3h5X2dldChldmFzX29iamVjdF9ldmFzX2dldCh3ZWJ2aWV3KSwgJm14LCAmbXkp OyAvLyBHZXQgY3VycmVudCBtb3VzZSBwb3NpdGlvbiBvbiB3aW5kb3cuCisgICAgICAgIGV2YXNf b2JqZWN0X2dlb21ldHJ5X2dldCh3ZWJ2aWV3LCAmb3gsICZveSwgTlVMTCwgTlVMTCk7IC8vIEdl dCB3ZWJ2aWV3J3MgcG9zaXRpb24gb24gd2luZG93LgorICAgICAgICBjeCA9IG14IC0gb3g7IC8v IGN1cnJlbnQgeCBwb3NpdGlvbiA9IG1vdXNlIHggcG9zaXRpb24gLSB3ZWJ2aWV3IHggcG9zaXRp b24KKyAgICAgICAgY3kgPSBteSAtIG95OyAvLyBjdXJyZW50IHkgcG9zaXRpb24gPSBtb3VzZSB5 IHBvc2l0aW9uIC0gd2VidmlldyB5IHBvc2l0aW9uNworICAgIAorICAgICAgICByZXN1bHQgPSBl d2tfdmlld19zY2FsZV9zZXQod2Vidmlldywgc2NhbGVGYWN0b3IsIGN4LCBjeSk7CisgICAgfSBl bHNlIHsKKyAgICAgICAgLy8gRklYTUUgOiBWaWV3cG9ydCBpcyBub3QgdXBkYXRlZCBhZnRlciBk ZXZpY2VfcGl4ZWxfcmF0aW9fc2V0IGFsdGhvdWdoIHRoZSBEcmF3aW5nQXJlYVByb3h5SW1wbDo6 c2VuZFVwZGF0ZUJhY2tpbmdTdG9yZVN0YXRlIGNhbGxlZCBpbnNpZGUuCisgICAgICAgIHJlc3Vs dCA9IGV3a192aWV3X2RldmljZV9waXhlbF9yYXRpb19zZXQod2Vidmlldywgc2NhbGVGYWN0b3Ip OworICAgIH0KKworICAgIGlmIChyZXN1bHQpCisgICAgICAgIGluZm8oIlNldCBzY2FsZUZhY3Rv cjogJS4yZiAgLT4gJS4yZlxuICIsIGN1cnJlbnRTY2FsZUZhY3Rvciwgc2NhbGVGYWN0b3IpOwor ICAgIGVsc2UKKyAgICAgICAgaW5mbygiU2V0IHNjYWxlRmFjdG9yOiAlLjJmICAtPiAlLjJmIC0g RkFJTEVEIVxuICIsIGN1cnJlbnRTY2FsZUZhY3Rvciwgc2NhbGVGYWN0b3IpOwogCi0gICAgRWlu YV9Cb29sIHJlc3VsdCA9IGV3a192aWV3X3NjYWxlX3NldCh3ZWJ2aWV3LCB6b29tTGV2ZWxzW2xl dmVsXSwgY3gsIGN5KTsKICAgICByZXR1cm4gcmVzdWx0OwogfQogCkBAIC04MSw3ICsxNDcsNiBA QCB0eXBlZGVmIHN0cnVjdCBfQnJvd3Nlcl9XaW5kb3cgewogICAgIEV2YXNfT2JqZWN0ICp1cmxf YmFyOwogICAgIEV2YXNfT2JqZWN0ICpiYWNrX2J1dHRvbjsKICAgICBFdmFzX09iamVjdCAqZm9y d2FyZF9idXR0b247Ci0gICAgaW50IGN1cnJlbnRfem9vbV9sZXZlbDsgCiB9IEJyb3dzZXJfV2lu ZG93OwogCiB0eXBlZGVmIHN0cnVjdCBfRmlsZV9TZWxlY3Rvcl9EYXRhIHsKQEAgLTIzNCwxNyAr Mjk5LDExIEBAIG9uX2tleV9kb3duKHZvaWQgKnVzZXJfZGF0YSwgRXZhcyAqZSwgRXZhc19PYmpl Y3QgKmV3a192aWV3LCB2b2lkICpldmVudF9pbmZvKQogICAgICAgICBpZiAoZWxtX3dpbl9mdWxs c2NyZWVuX2dldCh3aW5kb3ctPmVsbV93aW5kb3cpKQogICAgICAgICAgICAgZXdrX3ZpZXdfZnVs bHNjcmVlbl9leGl0KGV3a192aWV3KTsKICAgICB9IGVsc2UgaWYgKGN0cmxQcmVzc2VkICYmICgh c3RyY21wKGV2LT5rZXksICJtaW51cyIpIHx8ICFzdHJjbXAoZXYtPmtleSwgIktQX1N1YnRyYWN0 IikpKSB7Ci0gICAgICAgIGlmICh6b29tX2xldmVsX3NldChld2tfdmlldywgd2luZG93LT5jdXJy ZW50X3pvb21fbGV2ZWwgLSAxKSkKLSAgICAgICAgICAgIHdpbmRvdy0+Y3VycmVudF96b29tX2xl dmVsLS07Ci0gICAgICAgIGluZm8oIlpvb20gb3V0IChDdHJsICsgJy0nKSB3YXMgcHJlc3NlZCwg em9vbSBsZXZlbCBiZWNhbWUgJS4yZlxuIiwgem9vbUxldmVsc1t3aW5kb3ctPmN1cnJlbnRfem9v bV9sZXZlbF0pOworICAgICAgICB6b29tX3NldChld2tfdmlldywgWk9PTV9TRVRfWk9PTV9PVVQp OyAvLyBab29tIG91dAogICAgIH0gZWxzZSBpZiAoY3RybFByZXNzZWQgJiYgKCFzdHJjbXAoZXYt PmtleSwgImVxdWFsIikgfHwgIXN0cmNtcChldi0+a2V5LCAiS1BfQWRkIikpKSB7Ci0gICAgICAg IGlmICh6b29tX2xldmVsX3NldChld2tfdmlldywgd2luZG93LT5jdXJyZW50X3pvb21fbGV2ZWwg KyAxKSkKLSAgICAgICAgICAgIHdpbmRvdy0+Y3VycmVudF96b29tX2xldmVsKys7Ci0gICAgICAg IGluZm8oIlpvb20gaW4gKEN0cmwgKyAnKycpIHdhcyBwcmVzc2VkLCB6b29tIGxldmVsIGJlY2Ft ZSAlLjJmXG4iLCB6b29tTGV2ZWxzW3dpbmRvdy0+Y3VycmVudF96b29tX2xldmVsXSk7CisgICAg ICAgIHpvb21fc2V0KGV3a192aWV3LCBaT09NX1NFVF9aT09NX0lOKTsgLy8gWm9vbSBpbgogICAg IH0gZWxzZSBpZiAoY3RybFByZXNzZWQgJiYgIXN0cmNtcChldi0+a2V5LCAiMCIpKSB7Ci0gICAg ICAgIGlmICh6b29tX2xldmVsX3NldChld2tfdmlldywgREVGQVVMVF9aT09NX0xFVkVMKSkKLSAg ICAgICAgICAgIHdpbmRvdy0+Y3VycmVudF96b29tX2xldmVsID0gREVGQVVMVF9aT09NX0xFVkVM OwotICAgICAgICBpbmZvKCJab29tIHRvIGRlZmF1bHQgKEN0cmwgKyAnMCcpIHdhcyBwcmVzc2Vk LCB6b29tIGxldmVsIGJlY2FtZSAlLjJmXG4iLCB6b29tTGV2ZWxzW3dpbmRvdy0+Y3VycmVudF96 b29tX2xldmVsXSk7CisgICAgICAgIHpvb21fc2V0KGV3a192aWV3LCBaT09NX1NFVF9UT19ERUZB VUxUKTsgLy8gWm9vbSB0byBkZWZhdWx0CiAgICAgfQogfQogCkBAIC0xMTAzLDkgKzExNjIsNiBA QCBzdGF0aWMgQnJvd3Nlcl9XaW5kb3cgKndpbmRvd19jcmVhdGUoY29uc3QgY2hhciAqdXJsLCBp bnQgd2lkdGgsIGludCBoZWlnaHQpCiAgICAgaWYgKGRldmljZV9waXhlbF9yYXRpbykKICAgICAg ICAgZXdrX3ZpZXdfZGV2aWNlX3BpeGVsX3JhdGlvX3NldCh3aW5kb3ctPmV3a192aWV3LCAoZmxv YXQpZGV2aWNlX3BpeGVsX3JhdGlvKTsKIAotICAgIC8qIFNldCB0aGUgem9vbSBsZXZlbCB0byBk ZWZhdWx0ICovCi0gICAgd2luZG93LT5jdXJyZW50X3pvb21fbGV2ZWwgPSBERUZBVUxUX1pPT01f TEVWRUw7Ci0KICAgICBFd2tfU2V0dGluZ3MgKnNldHRpbmdzID0gZXdrX3ZpZXdfc2V0dGluZ3Nf Z2V0KHdpbmRvdy0+ZXdrX3ZpZXcpOwogICAgIGV3a19zZXR0aW5nc19maWxlX2FjY2Vzc19mcm9t X2ZpbGVfdXJsc19hbGxvd2VkX3NldChzZXR0aW5ncywgRUlOQV9UUlVFKTsKICAgICBld2tfc2V0 dGluZ3NfZW5jb2RpbmdfZGV0ZWN0b3JfZW5hYmxlZF9zZXQoc2V0dGluZ3MsIGVuY29kaW5nX2Rl dGVjdG9yX2VuYWJsZWQpOwo=