104213 2012-12-05 22:09:07 -0800 [V8] Make an Isolate mandatory for v8StringOrNull() and v8StringOrUndefined() 2012-12-06 01:02:58 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth webkit.review.bot oldest_to_newest 784602 0 haraken 2012-12-05 22:09:07 -0800 All call sites of v8StringOrNull() and v8StringOrUndefined() have an Isolate. 784608 1 177933 haraken 2012-12-05 22:10:48 -0800 Created attachment 177933 Patch 784686 2 177957 haraken 2012-12-06 00:07:48 -0800 Created attachment 177957 Patch 784697 3 177957 abarth 2012-12-06 00:28:55 -0800 Comment on attachment 177957 Patch That's great! 784730 4 177957 webkit.review.bot 2012-12-06 01:02:53 -0800 Comment on attachment 177957 Patch Clearing flags on attachment: 177957 Committed r136820: <http://trac.webkit.org/changeset/136820> 784731 5 webkit.review.bot 2012-12-06 01:02:58 -0800 All reviewed patches have been landed. Closing bug. 177933 2012-12-05 22:10:48 -0800 2012-12-06 00:07:45 -0800 Patch bug-104213-20121206150812.patch text/plain 3243 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2Nzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQ1OGU5NjliMjEzODgw ZjI2ODQ2Njc5Y2ZkNmU1NWZiNzZlZTkyYy4uNDA2NDk1NGE2ZDE4NmI1YjZiODI5YmIzOGJiMTJh YmIzN2RhYTgzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTEyLTA1ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIE1ha2UgYW4g SXNvbGF0ZSBtYW5kYXRvcnkgZm9yIHY4U3RyaW5nT3JOdWxsKCkgYW5kIHY4U3RyaW5nT3JVbmRl ZmluZWQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA0MjEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsIGNhbGwgc2l0ZXMgb2YgdjhTdHJpbmdPck51bGwoKSBhbmQgdjhTdHJpbmdPclVuZGVmaW5l ZCgpIGhhdmUgYW4gSXNvbGF0ZS4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJl aGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06 CisgICAgICAgIChOYXRpdmVUb0pTVmFsdWUpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4Qmlu ZGluZy5oOgorICAgICAgICAoV2ViQ29yZTo6djhTdHJpbmdPck51bGwpOgorICAgICAgICAoV2Vi Q29yZTo6djhTdHJpbmdPclVuZGVmaW5lZCk6CisKKzIwMTItMTItMDUgIEtlbnRhcm8gSGFyYSAg PGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFtWOF0gT3B0aW1pemUgdjhTdHJpbmdP ck51bGwoKSBhbmQgdjhTdHJpbmdPclVuZGVmaW5lZCgpCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQyMDYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0gYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCBmM2JiNGI3OWVhZTBk MjA3NGQxNThlYjA1Nzk3MDMyNDQ4MzJiMzFjLi5jODc3ZTRlNjczMzZlMzA2Y2QxY2FhZWYyNTRk ZDdlYTgwMzdjMTk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtNDA3Niw2ICs0MDc2LDcgQEAgc3ViIE5hdGl2ZVRvSlNW YWx1ZQogICAgIGlmICgkY29kZUdlbmVyYXRvci0+SXNTdHJpbmdUeXBlKCR0eXBlKSkgewogICAg ICAgICBteSAkY29udiA9ICRzaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJUcmVhdFJl dHVybmVkTnVsbFN0cmluZ0FzIn07CiAgICAgICAgIGlmIChkZWZpbmVkICRjb252KSB7CisgICAg ICAgICAgICBkaWUgIkFuIElzb2xhdGUgYXJndW1lbnQgaXMgbWFuZGF0b3J5IGZvciB2OFN0cmlu Z09yTnVsbCgpIGFuZCB2OFN0cmluZ09yVW5kZWZpbmVkKCkiIHVubGVzcyAkZ2V0SXNvbGF0ZTsK ICAgICAgICAgICAgIHJldHVybiAidjhTdHJpbmdPck51bGwoJHZhbHVlJGdldElzb2xhdGVBcmcp IiBpZiAkY29udiBlcSAiTnVsbCI7CiAgICAgICAgICAgICByZXR1cm4gInY4U3RyaW5nT3JVbmRl ZmluZWQoJHZhbHVlJGdldElzb2xhdGVBcmcpIiBpZiAkY29udiBlcSAiVW5kZWZpbmVkIjsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmggYi9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaAppbmRleCA1ZGU2ZWVjYTQ5YzQ4YzA4 MzM2MDJhN2Q4NTA4YmY0MDRlY2I2ZDJlLi5kMWRlZTU3NTY0Mzc4YzZiMDE0YzQyODdhMGY3YWM0 N2Q4NWU3NjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRp bmcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaApAQCAtMTU0 LDE5ICsxNTQsMTcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICByZXR1cm4gVjhQZXJJ c29sYXRlRGF0YTo6ZnJvbShpc29sYXRlKS0+c3RyaW5nQ2FjaGUoKS0+djhFeHRlcm5hbFN0cmlu ZyhzdHJpbmcuaW1wbCgpLCBpc29sYXRlKTsKICAgICB9CiAKLSAgICBpbmxpbmUgdjg6OkhhbmRs ZTx2ODo6VmFsdWU+IHY4U3RyaW5nT3JOdWxsKGNvbnN0IFN0cmluZyYgc3RyaW5nLCB2ODo6SXNv bGF0ZSogaXNvbGF0ZSA9IDApCisgICAgaW5saW5lIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2OFN0 cmluZ09yTnVsbChjb25zdCBTdHJpbmcmIHN0cmluZywgdjg6Oklzb2xhdGUqIGlzb2xhdGUpCiAg ICAgewotICAgICAgICBpZiAoVU5MSUtFTFkoIWlzb2xhdGUpKQotICAgICAgICAgICAgaXNvbGF0 ZSA9IHY4OjpJc29sYXRlOjpHZXRDdXJyZW50KCk7CisgICAgICAgIEFTU0VSVChpc29sYXRlKTsK ICAgICAgICAgaWYgKHN0cmluZy5pc051bGwoKSkKICAgICAgICAgICAgIHJldHVybiB2OE51bGwo aXNvbGF0ZSk7CiAgICAgICAgIHJldHVybiBWOFBlcklzb2xhdGVEYXRhOjpmcm9tKGlzb2xhdGUp LT5zdHJpbmdDYWNoZSgpLT52OEV4dGVybmFsU3RyaW5nKHN0cmluZy5pbXBsKCksIGlzb2xhdGUp OwogICAgIH0KIAotICAgIGlubGluZSB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdjhTdHJpbmdPclVu ZGVmaW5lZChjb25zdCBTdHJpbmcmIHN0cmluZywgdjg6Oklzb2xhdGUqIGlzb2xhdGUgPSAwKQor ICAgIGlubGluZSB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdjhTdHJpbmdPclVuZGVmaW5lZChjb25z dCBTdHJpbmcmIHN0cmluZywgdjg6Oklzb2xhdGUqIGlzb2xhdGUpCiAgICAgewotICAgICAgICBp ZiAoVU5MSUtFTFkoIWlzb2xhdGUpKQotICAgICAgICAgICAgaXNvbGF0ZSA9IHY4OjpJc29sYXRl OjpHZXRDdXJyZW50KCk7CisgICAgICAgIEFTU0VSVChpc29sYXRlKTsKICAgICAgICAgaWYgKHN0 cmluZy5pc051bGwoKSkKICAgICAgICAgICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKGlzb2xhdGUp OwogICAgICAgICByZXR1cm4gVjhQZXJJc29sYXRlRGF0YTo6ZnJvbShpc29sYXRlKS0+c3RyaW5n Q2FjaGUoKS0+djhFeHRlcm5hbFN0cmluZyhzdHJpbmcuaW1wbCgpLCBpc29sYXRlKTsK 177957 2012-12-06 00:07:48 -0800 2012-12-06 01:02:53 -0800 Patch bug-104213-20121206170512.patch text/plain 2348 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2Nzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQ1OGU5NjliMjEzODgw ZjI2ODQ2Njc5Y2ZkNmU1NWZiNzZlZTkyYy4uMWYxZDFhNDMyYzkyMzBmYTMwNWQ5NjNhYmM2MjVj ODk2ZDE5MDU5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTEyLTA1ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIE1ha2UgYW4g SXNvbGF0ZSBtYW5kYXRvcnkgZm9yIHY4U3RyaW5nT3JOdWxsKCkgYW5kIHY4U3RyaW5nT3JVbmRl ZmluZWQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA0MjEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsIGNhbGwgc2l0ZXMgb2YgdjhTdHJpbmdPck51bGwoKSBhbmQgdjhTdHJpbmdPclVuZGVmaW5l ZCgpIGhhdmUgYW4gSXNvbGF0ZS4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJl aGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhCaW5kaW5nLmg6CisgICAgICAgIChX ZWJDb3JlOjp2OFN0cmluZ09yTnVsbCk6CisgICAgICAgIChXZWJDb3JlOjp2OFN0cmluZ09yVW5k ZWZpbmVkKToKKworMjAxMi0xMi0wNSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5v cmc+CisKICAgICAgICAgW1Y4XSBPcHRpbWl6ZSB2OFN0cmluZ09yTnVsbCgpIGFuZCB2OFN0cmlu Z09yVW5kZWZpbmVkKCkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNDIwNgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OEJpbmRpbmcuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCmluZGV4 IDVkZTZlZWNhNDljNDhjMDgzMzYwMmE3ZDg1MDhiZjQwNGVjYjZkMmUuLmQxZGVlNTc1NjQzNzhj NmIwMTRjNDI4N2EwZjdhYzQ3ZDg1ZTc2OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4QmluZGluZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 QmluZGluZy5oCkBAIC0xNTQsMTkgKzE1NCwxNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAg ICAgIHJldHVybiBWOFBlcklzb2xhdGVEYXRhOjpmcm9tKGlzb2xhdGUpLT5zdHJpbmdDYWNoZSgp LT52OEV4dGVybmFsU3RyaW5nKHN0cmluZy5pbXBsKCksIGlzb2xhdGUpOwogICAgIH0KIAotICAg IGlubGluZSB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdjhTdHJpbmdPck51bGwoY29uc3QgU3RyaW5n JiBzdHJpbmcsIHY4OjpJc29sYXRlKiBpc29sYXRlID0gMCkKKyAgICBpbmxpbmUgdjg6OkhhbmRs ZTx2ODo6VmFsdWU+IHY4U3RyaW5nT3JOdWxsKGNvbnN0IFN0cmluZyYgc3RyaW5nLCB2ODo6SXNv bGF0ZSogaXNvbGF0ZSkKICAgICB7Ci0gICAgICAgIGlmIChVTkxJS0VMWSghaXNvbGF0ZSkpCi0g ICAgICAgICAgICBpc29sYXRlID0gdjg6Oklzb2xhdGU6OkdldEN1cnJlbnQoKTsKKyAgICAgICAg QVNTRVJUKGlzb2xhdGUpOwogICAgICAgICBpZiAoc3RyaW5nLmlzTnVsbCgpKQogICAgICAgICAg ICAgcmV0dXJuIHY4TnVsbChpc29sYXRlKTsKICAgICAgICAgcmV0dXJuIFY4UGVySXNvbGF0ZURh dGE6OmZyb20oaXNvbGF0ZSktPnN0cmluZ0NhY2hlKCktPnY4RXh0ZXJuYWxTdHJpbmcoc3RyaW5n LmltcGwoKSwgaXNvbGF0ZSk7CiAgICAgfQogCi0gICAgaW5saW5lIHY4OjpIYW5kbGU8djg6OlZh bHVlPiB2OFN0cmluZ09yVW5kZWZpbmVkKGNvbnN0IFN0cmluZyYgc3RyaW5nLCB2ODo6SXNvbGF0 ZSogaXNvbGF0ZSA9IDApCisgICAgaW5saW5lIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2OFN0cmlu Z09yVW5kZWZpbmVkKGNvbnN0IFN0cmluZyYgc3RyaW5nLCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkK ICAgICB7Ci0gICAgICAgIGlmIChVTkxJS0VMWSghaXNvbGF0ZSkpCi0gICAgICAgICAgICBpc29s YXRlID0gdjg6Oklzb2xhdGU6OkdldEN1cnJlbnQoKTsKKyAgICAgICAgQVNTRVJUKGlzb2xhdGUp OwogICAgICAgICBpZiAoc3RyaW5nLmlzTnVsbCgpKQogICAgICAgICAgICAgcmV0dXJuIHY4OjpV bmRlZmluZWQoaXNvbGF0ZSk7CiAgICAgICAgIHJldHVybiBWOFBlcklzb2xhdGVEYXRhOjpmcm9t KGlzb2xhdGUpLT5zdHJpbmdDYWNoZSgpLT52OEV4dGVybmFsU3RyaW5nKHN0cmluZy5pbXBsKCks IGlzb2xhdGUpOwo=