104201 2012-12-05 18:08:22 -0800 Parameter event need to covert to RefPtr in the DeviceController::dispatchDeviceEvent 2012-12-05 19:38:50 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 97630 1 kihong.kwon kihong.kwon donggwan.kim webkit.review.bot oldest_to_newest 784407 0 kihong.kwon 2012-12-05 18:08:22 -0800 Parameter event need to covert to RefPtr in the DeviceController::dispatchDeviceEvent, but it is used PassRefPtr now. This makes crash if there are more than one listener. 784416 1 177897 kihong.kwon 2012-12-05 18:14:16 -0800 Created attachment 177897 Patch 784462 2 177897 laszlo.gombos 2012-12-05 18:42:18 -0800 Comment on attachment 177897 Patch r=me. Nit: "No new tests. This just a bug fixing." does not make sense to me as bug fixes require tests. 784483 3 177909 kihong.kwon 2012-12-05 19:05:35 -0800 Created attachment 177909 Patch 784484 4 kihong.kwon 2012-12-05 19:07:44 -0800 (In reply to comment #2) > (From update of attachment 177897 [details]) > r=me. > > Nit: "No new tests. This just a bug fixing." does not make sense to me as bug fixes require tests. I got it, it can be tested with existing test cases. I will change statement. Thank you. 784498 5 177909 webkit.review.bot 2012-12-05 19:38:47 -0800 Comment on attachment 177909 Patch Clearing flags on attachment: 177909 Committed r136791: <http://trac.webkit.org/changeset/136791> 784499 6 webkit.review.bot 2012-12-05 19:38:50 -0800 All reviewed patches have been landed. Closing bug. 177897 2012-12-05 18:14:16 -0800 2012-12-05 19:05:30 -0800 Patch bug-104201-20121206111140.patch text/plain 1736 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjI2OGI3NDkzNTdkNWU4 ZDk2NzNlOWViYzk0MWNhNTU0NjkyOTlmMi4uYjY0OWFhN2RjNzNlZTRiYjc2ZmMwYWIzMjZhZjkw OGIxYzBhYmEzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTA1ICBLaWhv bmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFBhcmFtZXRlciBl dmVudCBuZWVkIHRvIGNvdmVydCB0byBSZWZQdHIgaW4gdGhlIERldmljZUNvbnRyb2xsZXI6OmRp c3BhdGNoRGV2aWNlRXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNDIwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFBhcmFtZXRlciBldmVudCBuZWVkIHRvIGNvdmVydCB0byBSZWZQdHIgaW4gdGhl IERldmljZUNvbnRyb2xsZXI6OmRpc3BhdGNoRGV2aWNlRXZlbnQsCisgICAgICAgIGJ1dCBpdCBp cyB1c2VkIFBhc3NSZWZQdHIgbm93LiBUaGlzIG1ha2VzIGNyYXNoIGlmIHRoZXJlIGFyZSBtb3Jl IHRoYW4gb25lIGxpc3RlbmVyLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBqdXN0IGEg YnVnIGZpeGluZy4KKworICAgICAgICAqIHBhZ2UvRGV2aWNlQ29udHJvbGxlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpEZXZpY2VDb250cm9sbGVyOjpkaXNwYXRjaERldmljZUV2ZW50KToKKwog MjAxMi0xMi0wNSAgSm9zaHVhIEJlbGwgIDxqc2JlbGxAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IEluZGV4ZWREQjogQWxsb3cgbXVsdGlwbGUgdHJhbnNhY3Rpb25zIHRvIGludGVybGVhdmUgcmVx dWVzdCBleGVjdXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRGV2aWNlQ29u dHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RldmljZUNvbnRyb2xsZXIuY3BwCmlu ZGV4IGJlMjcwZGI4Nzk3Y2ViZWQzMWU3Yjc1NzY4YjhhNTc0NWI5MzIyY2IuLjAyYTg4MjQ3N2Fl N2QyYzE1NjNmMmY0M2ExNTlmZDc2ZmJmZTMxNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRGV2aWNlQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9EZXZp Y2VDb250cm9sbGVyLmNwcApAQCAtNzEsOCArNzEsOSBAQCB2b2lkIERldmljZUNvbnRyb2xsZXI6 OnJlbW92ZUFsbERldmljZUV2ZW50TGlzdGVuZXJzKERPTVdpbmRvdyogd2luZG93KQogICAgICAg ICBtX2NsaWVudC0+c3RvcFVwZGF0aW5nKCk7CiB9CiAKLXZvaWQgRGV2aWNlQ29udHJvbGxlcjo6 ZGlzcGF0Y2hEZXZpY2VFdmVudChQYXNzUmVmUHRyPEV2ZW50PiBldmVudCkKK3ZvaWQgRGV2aWNl Q29udHJvbGxlcjo6ZGlzcGF0Y2hEZXZpY2VFdmVudChQYXNzUmVmUHRyPEV2ZW50PiBwcnBFdmVu dCkKIHsKKyAgICBSZWZQdHI8RXZlbnQ+IGV2ZW50ID0gcHJwRXZlbnQ7CiAgICAgVmVjdG9yPFJl ZlB0cjxET01XaW5kb3c+ID4gbGlzdGVuZXJWZWN0b3I7CiAgICAgY29weVRvVmVjdG9yKG1fbGlz dGVuZXJzLCBsaXN0ZW5lclZlY3Rvcik7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBsaXN0 ZW5lclZlY3Rvci5zaXplKCk7ICsraSkgewo= 177909 2012-12-05 19:05:35 -0800 2012-12-05 19:38:47 -0800 Patch bug-104201-20121206120259.patch text/plain 1693 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjI2OGI3NDkzNTdkNWU4 ZDk2NzNlOWViYzk0MWNhNTU0NjkyOTlmMi4uYjczMzMyODA1Yjc5NGRkNmQ0NTAxMTg1NDYyMTRh NjM1MjlkZDAzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTA1ICBLaWhv bmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFBhcmFtZXRlciBl dmVudCBuZWVkIHRvIGNvdmVydCB0byBSZWZQdHIgaW4gdGhlIERldmljZUNvbnRyb2xsZXI6OmRp c3BhdGNoRGV2aWNlRXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNDIwMQorCisgICAgICAgIFJldmlld2VkIGJ5IExhc3psbyBHb21ib3MuCisK KyAgICAgICAgUGFyYW1ldGVyICdldmVudCcgbmVlZCB0byBjb3ZlcnQgdG8gUmVmUHRyIGluIHRo ZSBEZXZpY2VDb250cm9sbGVyOjpkaXNwYXRjaERldmljZUV2ZW50LgorICAgICAgICBUaGlzIGNh biBtYWtlIGNyYXNoIHNvbWV0aW1lcy4KKworICAgICAgICBObyBuZXcgdGVzdHMuIENvdmVyZWQg YnkgZXhpc3RpbmcgbGF5b3V0IHRlc3RzLgorCisgICAgICAgICogcGFnZS9EZXZpY2VDb250cm9s bGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRldmljZUNvbnRyb2xsZXI6OmRpc3BhdGNoRGV2 aWNlRXZlbnQpOgorCiAyMDEyLTEyLTA1ICBKb3NodWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBBbGxvdyBtdWx0aXBsZSB0cmFuc2FjdGlvbnMgdG8g aW50ZXJsZWF2ZSByZXF1ZXN0IGV4ZWN1dGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9EZXZpY2VDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRGV2aWNlQ29u dHJvbGxlci5jcHAKaW5kZXggYmUyNzBkYjg3OTdjZWJlZDMxZTdiNzU3NjhiOGE1NzQ1YjkzMjJj Yi4uMDJhODgyNDc3YWU3ZDJjMTU2M2YyZjQzYTE1OWZkNzZmYmZlMzE3MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9EZXZpY2VDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0RldmljZUNvbnRyb2xsZXIuY3BwCkBAIC03MSw4ICs3MSw5IEBAIHZvaWQgRGV2 aWNlQ29udHJvbGxlcjo6cmVtb3ZlQWxsRGV2aWNlRXZlbnRMaXN0ZW5lcnMoRE9NV2luZG93KiB3 aW5kb3cpCiAgICAgICAgIG1fY2xpZW50LT5zdG9wVXBkYXRpbmcoKTsKIH0KIAotdm9pZCBEZXZp Y2VDb250cm9sbGVyOjpkaXNwYXRjaERldmljZUV2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+IGV2ZW50 KQordm9pZCBEZXZpY2VDb250cm9sbGVyOjpkaXNwYXRjaERldmljZUV2ZW50KFBhc3NSZWZQdHI8 RXZlbnQ+IHBycEV2ZW50KQogeworICAgIFJlZlB0cjxFdmVudD4gZXZlbnQgPSBwcnBFdmVudDsK ICAgICBWZWN0b3I8UmVmUHRyPERPTVdpbmRvdz4gPiBsaXN0ZW5lclZlY3RvcjsKICAgICBjb3B5 VG9WZWN0b3IobV9saXN0ZW5lcnMsIGxpc3RlbmVyVmVjdG9yKTsKICAgICBmb3IgKHNpemVfdCBp ID0gMDsgaSA8IGxpc3RlbmVyVmVjdG9yLnNpemUoKTsgKytpKSB7Cg==