104195 2012-12-05 17:37:12 -0800 [WK2][EFL] Gardening. Rebase fast/block/basic/020.html 2012-12-05 18:40:07 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ktf.kim ktf.kim kangil.han lucas.de.marchi ryuan.choi webkit.review.bot oldest_to_newest 784344 0 ktf.kim 2012-12-05 17:37:12 -0800 The layer for "visibility:hidden; position: absolute;" object should be shown in RenderLayer Tree when USE(ACCELERATED_COMPOSITING). It's because the HiddenLayers are included in zOrderList when CompositingMode is on. void RenderLayer::rebuildZOrderLists() { #if USE(ACCELERATED_COMPOSITING) bool includeHiddenLayers = compositor()->inCompositingMode(); // TRUE or FALSE by RenderLayerCompositor::m_compositing #else bool includeHiddenLayers = false; // Always FALSE -> other ports' case #endif for (RenderLayer* child = firstChild(); child; child = child->nextSibling()) if (!m_reflection || reflectionLayer() != child) child->collectLayers(includeHiddenLayers, m_posZOrderList, m_negZOrderList); 784365 1 177890 ktf.kim 2012-12-05 17:50:30 -0800 Created attachment 177890 Patch 784380 2 kangil.han 2012-12-05 17:57:26 -0800 (In reply to comment #0) > The layer for "visibility:hidden; position: absolute;" object should be shown in RenderLayer Tree when USE(ACCELERATED_COMPOSITING). > > It's because the HiddenLayers are included in zOrderList when CompositingMode is on. > > void RenderLayer::rebuildZOrderLists() > { > #if USE(ACCELERATED_COMPOSITING) > bool includeHiddenLayers = compositor()->inCompositingMode(); // TRUE or FALSE by RenderLayerCompositor::m_compositing > #else > bool includeHiddenLayers = false; // Always FALSE -> other ports' case > #endif > for (RenderLayer* child = firstChild(); child; child = child->nextSibling()) > if (!m_reflection || reflectionLayer() != child) > child->collectLayers(includeHiddenLayers, m_posZOrderList, m_negZOrderList); Love to know this! :) 784399 3 177890 ryuan.choi 2012-12-05 18:05:43 -0800 Comment on attachment 177890 Patch I think that this is reasonable. 784449 4 177890 webkit.review.bot 2012-12-05 18:37:18 -0800 Comment on attachment 177890 Patch Clearing flags on attachment: 177890 Committed r136786: <http://trac.webkit.org/changeset/136786> 784450 5 webkit.review.bot 2012-12-05 18:37:22 -0800 All reviewed patches have been landed. Closing bug. 784455 6 ktf.kim 2012-12-05 18:40:07 -0800 (In reply to comment #2) > (In reply to comment #0) Just for reference) That code was originated from the bug 38829, fixing a bug that the first frame of the <video> was displayed even though the video has been set to hidden. 177890 2012-12-05 17:50:30 -0800 2012-12-05 18:37:18 -0800 Patch bug-104195-20121206104755.patch text/plain 3163 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NzczCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWViZjkwMjM0MWQwNzI2MmU2MTY1 NGJjMTdjMTg5NDc4M2M2NWVlMC4uZTkxZTY4ZDM1OGE4NGMwZWM1ZTU0YjE2Yzk3NTQ3ZTI2OTA3 YTg2ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTA1ICBLeXVuZ1RhZSBLaW0gIDxr dGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtXSzJdW0VGTF0gR2FyZGVuaW5nLiBSZWJh c2UgZmFzdC9ibG9jay9iYXNpYy8wMjAuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0MTk1CisKKyAgICAgICAgVW5yZXZpZXdlZCBHYXJkZW5p bmcuCisKKyAgICAgICAgVGhlIGxheWVyIGZvciAidmlzaWJpbGl0eTpoaWRkZW47cG9zaXRpb246 YWJzb2x1dGU7IiBvYmplY3Qgc2hvdWxkIGJlIGluIFJlbmRlclRyZWUgd2hlbiBVU0UoQUNDRUxF UkFURURfQ09NUE9TSVRJTkcpLAorICAgICAgICBiZWNhdXNlIHRoZSBIaWRkZW5MYXllcnMgYXJl IGluY2x1ZGVkIGluIHpPcmRlckxpc3Qgd2hlbiBDb21wb3NpdGluZ01vZGUgaXMgb24uCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9lZmwtd2syL2Zhc3QvYmxvY2svYmFzaWMvMDIwLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIw MTItMTItMDUgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBUZXh0 IGRlY29yYXRpb25zIGFyZSByb3RhdGVkIHdoZW4gdGV4dC1jb21iaW5lIHRha2VzIGVmZmVjdApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9mYXN0L2Jsb2NrL2Jhc2lj LzAyMC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2syL2Zhc3QvYmxv Y2svYmFzaWMvMDIwLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hNTI0YzI4OGNjM2ZkM2FlZDNh ZDA0NjI1MzY1NjJhMGZkMWM5YjgwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZWZsLXdrMi9mYXN0L2Jsb2NrL2Jhc2ljLzAyMC1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSwyNCBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlclZpZXcgYXQgKDAs MCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyQmxv Y2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDYwMAorICAgIFJlbmRlckJvZHkge0JPRFl9IGF0 ICg4LDgpIHNpemUgNzg0eDU3NgorICAgICAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDAsMCkgc2l6 ZSA3ODR4NTIKKyAgICAgICAgUmVuZGVyQmxvY2sgKGFub255bW91cykgYXQgKDAsMCkgc2l6ZSA3 ODR4MTgKKyAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAxMngxOQor ICAgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggMTI6ICJBIgorICAgICAgICAgIFJl bmRlclRleHQgeyN0ZXh0fSBhdCAoMTIsMCkgc2l6ZSAxMXgxOQorICAgICAgICAgICAgdGV4dCBy dW4gYXQgKDEyLDApIHdpZHRoIDExOiAiQyIKKyAgICAgICAgUmVuZGVyQmxvY2sge1B9IGF0ICgw LDM0KSBzaXplIDc4NHgwCisgICAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDM0KSBzaXpl IDc4NHgxOAorICAgICAgICAgIFJlbmRlckJsb2NrIChhbm9ueW1vdXMpIGF0ICgwLDApIHNpemUg Nzg0eDE4CisgICAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDEwMCwwKSBzaXplIDE2 eDE5CisgICAgICAgICAgICAgIHRleHQgcnVuIGF0ICgxMDAsMCkgd2lkdGggMTY6ICJBICIKKyAg ICAgICAgICAgIFJlbmRlckJsb2NrIChmbG9hdGluZykge1NQQU59IGF0ICgwLDApIHNpemUgMTAw eDEwMCBbYmdjb2xvcj0jMDA4MDAwXQorICAgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0 ICgxMTYsMCkgc2l6ZSAxMXgxOQorICAgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMTE2LDApIHdp ZHRoIDExOiAiQiIKKyAgICAgICAgICBSZW5kZXJCbG9jayB7UH0gYXQgKDAsMzQpIHNpemUgNzg0 eDAKK2xheWVyIGF0ICgyMCw4KSBzaXplIDExeDE4CisgIFJlbmRlckJsb2NrIChwb3NpdGlvbmVk KSB7U1BBTn0gYXQgKDIwLDgpIHNpemUgMTF4MTgKKyAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQg KDAsMCkgc2l6ZSAxMXgxOQorICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggMTE6ICJCIgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAyNGY3NzllZTg0 YjkwMTY1NDRmMmJiNWM3ZWNlOTk5OGU2NTlkYzc0Li5mNDYzMjBhZTVkOTAxYWZhZGQ4YTliYTk2 YzIwMzc4NGUzZWY0YzY5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVz dEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0 aW9ucwpAQCAtMTYxMCw3ICsxNjEwLDYgQEAgQnVnKEVGTCkgZWRpdGluZy9zZWxlY3Rpb24vY2Fy ZXQtbHRyLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogQnVnKEVGTCkgZWRpdGluZy9zZWxlY3Rpb24v Y2FyZXQtbHRyLTItbGVmdC5odG1sIFsgRmFpbHVyZSBQYXNzIF0KIEJ1ZyhFRkwpIGVkaXRpbmcv c2VsZWN0aW9uL2NhcmV0LWx0ci0yLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogQnVnKEVGTCkgZWRp dGluZy9zZWxlY3Rpb24vY2FyZXQtcnRsLTIuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCi1CdWcoRUZM KSBmYXN0L2Jsb2NrL2Jhc2ljLzAyMC5odG1sIFsgRmFpbHVyZSBdCiBCdWcoRUZMKSBmYXN0L2Nz cy9ob3Zlci11cGRhdGUuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCiBCdWcoRUZMKSBmYXN0L2R5bmFt aWMvMDEyLmh0bWwgWyBGYWlsdXJlIF0KIEJ1ZyhFRkwpIGZhc3QvZHluYW1pYy9sYXllci1oaXQt dGVzdC1jcmFzaC5odG1sIFsgRmFpbHVyZSBdCg==