104193 2012-12-05 17:31:55 -0800 Remove harmful string->function cache 2012-12-06 14:17:05 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver ap oldest_to_newest 784335 0 oliver 2012-12-05 17:31:55 -0800 Remove harmful string->function cache 784336 1 177884 oliver 2012-12-05 17:32:54 -0800 Created attachment 177884 Patch 785036 2 177884 ap 2012-12-06 10:47:12 -0800 Comment on attachment 177884 Patch Yay to any patch with more red than green ;-) 785077 3 oliver 2012-12-06 11:27:10 -0800 Committed r136860: <http://trac.webkit.org/changeset/136860> 785110 4 177884 darin 2012-12-06 11:50:05 -0800 Comment on attachment 177884 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177884&action=review > Source/JavaScriptCore/ChangeLog:9 > + Remove the string->function code cache that turned out to actually > + be quite harmful. Harmful to what? Performance? Correctness? 785261 5 oliver 2012-12-06 14:17:05 -0800 (In reply to comment #4) > (From update of attachment 177884 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177884&action=review > > > Source/JavaScriptCore/ChangeLog:9 > > + Remove the string->function code cache that turned out to actually > > + be quite harmful. > > Harmful to what? Performance? Correctness? Performance, it was an in browser memory and cpu usage regression in jsbench and membuster. 177884 2012-12-05 17:32:54 -0800 2012-12-06 11:50:05 -0800 Patch bug-104193-20121205173019.patch text/plain 4146 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NzczCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw OGUyNmFjMWRmMjJlNmU0MzE0NWRkYWQwNWJhZWIzMDc4YTYxYTE1Li4xN2JkY2FmNjQwMTJkMWVi MzJhMjljYzcwNmRhNDExYTJmNDBiMDFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMCBAQAogMjAxMi0xMi0wNSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgog CisgICAgICAgIFJlbW92ZSBoYXJtZnVsIHN0cmluZy0+ZnVuY3Rpb24gY2FjaGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDE5MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB0aGUgc3RyaW5n LT5mdW5jdGlvbiBjb2RlIGNhY2hlIHRoYXQgdHVybmVkIG91dCB0byBhY3R1YWxseQorICAgICAg ICBiZSBxdWl0ZSBoYXJtZnVsLgorCisgICAgICAgICogcnVudGltZS9Db2RlQ2FjaGUuY3BwOgor ICAgICAgICAoSlNDOjpDb2RlQ2FjaGU6OmdldEZ1bmN0aW9uQ29kZUJsb2NrKToKKyAgICAgICAg KiBydW50aW1lL0NvZGVDYWNoZS5oOgorICAgICAgICAoSlNDOjpDb2RlQ2FjaGU6OmNsZWFyKToK KworMjAxMi0xMi0wNSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgorCiAgICAgICAg IEVtcHR5IHBhcnNlIGNhY2hlIHdoZW4gcmVjZWl2aW5nIGEgbG93IG1lbW9yeSB3YXJuaW5nCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQxNjEKIApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvZGVDYWNoZS5jcHAKaW5kZXggMTA5ZWMx Y2ZkNTYzZWQ0NTU3YzE5ZDlhNDliNWY5NGJjYWRjNTg1Ny4uZDNkM2UzYzA0YzgwMjdmZWE0ZDM3 OThmZDViOWNjOGM3N2U2Mzk1YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvQ29kZUNhY2hlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9D b2RlQ2FjaGUuY3BwCkBAIC0xMzIsMjMgKzEzMiw3IEBAIFVubGlua2VkRnVuY3Rpb25Db2RlQmxv Y2sqIENvZGVDYWNoZTo6Z2VuZXJhdGVGdW5jdGlvbkNvZGVCbG9jayhKU0dsb2JhbERhdGEmIGds CiAKIFVubGlua2VkRnVuY3Rpb25Db2RlQmxvY2sqIENvZGVDYWNoZTo6Z2V0RnVuY3Rpb25Db2Rl QmxvY2soSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhLCBVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJs ZSogZXhlY3V0YWJsZSwgY29uc3QgU291cmNlQ29kZSYgc291cmNlLCBDb2RlU3BlY2lhbGl6YXRp b25LaW5kIGtpbmQsIERlYnVnZ2VyTW9kZSBkZWJ1Z2dlck1vZGUsIFByb2ZpbGVyTW9kZSBwcm9m aWxlck1vZGUsIFBhcnNlckVycm9yJiBlcnJvcikKIHsKLSAgICBpZiAoZGVidWdnZXJNb2RlID09 IERlYnVnZ2VyT24gfHwgcHJvZmlsZXJNb2RlID09IFByb2ZpbGVyT24pCi0gICAgICAgIHJldHVy biBnZW5lcmF0ZUZ1bmN0aW9uQ29kZUJsb2NrKGdsb2JhbERhdGEsIGV4ZWN1dGFibGUsIHNvdXJj ZSwga2luZCwgZGVidWdnZXJNb2RlLCBwcm9maWxlck1vZGUsIGVycm9yKTsKLQotICAgIFNvdXJj ZUNvZGUgZnVuY3Rpb25Tb3VyY2Uoc291cmNlLnByb3ZpZGVyKCksIGV4ZWN1dGFibGUtPmZ1bmN0 aW9uU3RhcnRPZmZzZXQoKSwgc291cmNlLmVuZE9mZnNldCgpLCBzb3VyY2UuZmlyc3RMaW5lKCkp OwotICAgIENvZGVCbG9ja0tleSBrZXkgPSBtYWtlQ29kZUJsb2NrS2V5KGZ1bmN0aW9uU291cmNl LCBraW5kID09IENvZGVGb3JDYWxsID8gRnVuY3Rpb25DYWxsVHlwZSA6IEZ1bmN0aW9uQ29uc3Ry dWN0VHlwZSwgZXhlY3V0YWJsZS0+aXNJblN0cmljdENvbnRleHQoKSA/IEpTUGFyc2VTdHJpY3Qg OiBKU1BhcnNlTm9ybWFsKTsKLSAgICBpZiAoY29uc3QgU3Ryb25nPFVubGlua2VkRnVuY3Rpb25D b2RlQmxvY2s+KiBjYWNoZUVudHJ5ID0gbV9jYWNoZWRGdW5jdGlvbkV4ZWN1dGFibGVzLmZpbmQo a2V5KSkgewotICAgICAgICBpZiAoY2FjaGVFbnRyeSkgewotICAgICAgICAgICAgVW5saW5rZWRG dW5jdGlvbkNvZGVCbG9jayogdW5saW5rZWRDb2RlID0gY2FjaGVFbnRyeS0+Z2V0KCk7Ci0gICAg ICAgICAgICB1bnNpZ25lZCBmaXJzdExpbmUgPSBzb3VyY2UuZmlyc3RMaW5lKCkgKyB1bmxpbmtl ZENvZGUtPmZpcnN0TGluZSgpOwotICAgICAgICAgICAgZXhlY3V0YWJsZS0+cmVjb3JkUGFyc2Uo dW5saW5rZWRDb2RlLT5jb2RlRmVhdHVyZXMoKSwgdW5saW5rZWRDb2RlLT5oYXNDYXB0dXJlZFZh cmlhYmxlcygpLCBmaXJzdExpbmUsIGZpcnN0TGluZSArIHVubGlua2VkQ29kZS0+bGluZUNvdW50 KCkpOwotICAgICAgICAgICAgbV9yZWNlbnRseVVzZWRGdW5jdGlvbkNvZGUuYWRkKHVubGlua2Vk Q29kZSwgKmNhY2hlRW50cnkpOwotICAgICAgICAgICAgcmV0dXJuIHVubGlua2VkQ29kZTsKLSAg ICAgICAgfQotICAgIH0KLSAgICBVbmxpbmtlZEZ1bmN0aW9uQ29kZUJsb2NrKiByZXN1bHQgPSBn ZW5lcmF0ZUZ1bmN0aW9uQ29kZUJsb2NrKGdsb2JhbERhdGEsIGV4ZWN1dGFibGUsIHNvdXJjZSwg a2luZCwgZGVidWdnZXJNb2RlLCBwcm9maWxlck1vZGUsIGVycm9yKTsKLSAgICBtX2NhY2hlZEZ1 bmN0aW9uRXhlY3V0YWJsZXMuYWRkKGtleSwgU3Ryb25nPFVubGlua2VkRnVuY3Rpb25Db2RlQmxv Y2s+KGdsb2JhbERhdGEsIHJlc3VsdCkpOwotICAgIHJldHVybiByZXN1bHQ7CisgICAgcmV0dXJu IGdlbmVyYXRlRnVuY3Rpb25Db2RlQmxvY2soZ2xvYmFsRGF0YSwgZXhlY3V0YWJsZSwgc291cmNl LCBraW5kLCBkZWJ1Z2dlck1vZGUsIHByb2ZpbGVyTW9kZSwgZXJyb3IpOwogfQogCiBDb2RlQ2Fj aGU6Okdsb2JhbEZ1bmN0aW9uS2V5IENvZGVDYWNoZTo6bWFrZUdsb2JhbEZ1bmN0aW9uS2V5KGNv bnN0IFNvdXJjZUNvZGUmIHNvdXJjZSwgY29uc3QgU3RyaW5nJiBuYW1lKQpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmggYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUuaAppbmRleCBhMWYzODU1YjFhMmIzOTVhYzA4NWE3 OGYxODdiZjQ5Nzg2YmE2NGY1Li4xYTc3ZGE4MjgyOTY1ODM4MDNlODEwZjc2MjFmODdkNGMxN2Zj YTIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUu aAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUuaApAQCAtMTEz LDcgKzExMyw2IEBAIHB1YmxpYzoKICAgICB2b2lkIGNsZWFyKCkKICAgICB7CiAgICAgICAgIG1f Y2FjaGVkQ29kZUJsb2Nrcy5jbGVhcigpOwotICAgICAgICBtX2NhY2hlZEZ1bmN0aW9uRXhlY3V0 YWJsZXMuY2xlYXIoKTsKICAgICAgICAgbV9jYWNoZWRHbG9iYWxGdW5jdGlvbnMuY2xlYXIoKTsK ICAgICAgICAgbV9yZWNlbnRseVVzZWRGdW5jdGlvbkNvZGUuY2xlYXIoKTsKICAgICB9CkBAIC0x MzgsNyArMTM3LDYgQEAgcHJpdmF0ZToKICAgICB9OwogCiAgICAgQ2FjaGVNYXA8Q29kZUJsb2Nr S2V5LCBTdHJvbmc8VW5saW5rZWRDb2RlQmxvY2s+LCBrTWF4Q29kZUJsb2NrRW50cmllcz4gbV9j YWNoZWRDb2RlQmxvY2tzOwotICAgIENhY2hlTWFwPENvZGVCbG9ja0tleSwgU3Ryb25nPFVubGlu a2VkRnVuY3Rpb25Db2RlQmxvY2s+LCBrTWF4RnVuY3Rpb25Db2RlQmxvY2tzPiBtX2NhY2hlZEZ1 bmN0aW9uRXhlY3V0YWJsZXM7CiAgICAgQ2FjaGVNYXA8R2xvYmFsRnVuY3Rpb25LZXksIFN0cm9u ZzxVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZT4sIGtNYXhGdW5jdGlvbkNvZGVCbG9ja3M+IG1f Y2FjaGVkR2xvYmFsRnVuY3Rpb25zOwogICAgIENhY2hlTWFwPFVubGlua2VkRnVuY3Rpb25Db2Rl QmxvY2sqLCBTdHJvbmc8VW5saW5rZWRGdW5jdGlvbkNvZGVCbG9jaz4sIGtNYXhGdW5jdGlvbkNv ZGVCbG9ja3M+IG1fcmVjZW50bHlVc2VkRnVuY3Rpb25Db2RlOwogfTsK